process-util: remove broken support for pid==0

Our functions that query /proc/pid/ support using pid==0 to mean
self. get_process_id also seemed to support that, but it was not implemented
correctly: the result should be in *uid, not returned, and also it gave
completely bogus result when called from get_process_gid(). But afaict,
get_process_{uid,gid} were never called with pid==0, so it's not an actual
bug. Remove the broken code to avoid confusion.

diff --git a/src/basic/process-util.c b/src/basic/process-util.c
index f418b85b922cb02b669197aee1255bcee6b054fc..faadb756cc239c6cc8933680d81134e53d50bc13 100644 (file)
--- a/src/basic/process-util.c
+++ b/src/basic/process-util.c
@@ -321,9 +321,6 @@ static int get_process_id(pid_t pid, const char *field, uid_t *uid) {
         assert(field);
         assert(uid);
 
-        if (pid == 0)
-                return getuid();
-
         p = procfs_file_alloca(pid, "status");
         f = fopen(p, "re");
         if (!f) {