chiark
/
gitweb
/
~ianmdlvl
/
elogind.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(from parent 1:
d725a13
)
core: smack-setup: Actually allow for succesfully loading CIPSO policy
author
Philippe De Swert
<philippedeswert@gmail.com>
Fri, 12 Sep 2014 13:49:48 +0000
(16:49 +0300)
committer
David Herrmann
<dh.herrmann@gmail.com>
Sat, 13 Sep 2014 09:54:09 +0000
(11:54 +0200)
The line under the last switch statement *loaded_policy = true;
would never be executed. As all switch cases return 0. Thus the
policy would never be marked as loaded.
Found with Coverity. Fixes: CID#
1237785
src/core/smack-setup.c
patch
|
blob
|
history
diff --git
a/src/core/smack-setup.c
b/src/core/smack-setup.c
index 5f6dabf82a228fbcacb6194a7b132ba43404ae49..5d8a26c61d910cd932cd1709bceac996ed4e26b1 100644
(file)
--- a/
src/core/smack-setup.c
+++ b/
src/core/smack-setup.c
@@
-158,7
+158,7
@@
int smack_setup(bool *loaded_policy) {
return 0;
case 0:
log_info("Successfully loaded Smack/CIPSO policies.");
-
return 0
;
+
break
;
default:
log_warning("Failed to load Smack/CIPSO access rules: %s, ignoring.",
strerror(abs(r)));