chiark / gitweb /
bus: update name listing logic to current kernel interface
authorLennart Poettering <lennart@poettering.net>
Wed, 11 Dec 2013 23:35:23 +0000 (00:35 +0100)
committerLennart Poettering <lennart@poettering.net>
Wed, 11 Dec 2013 23:35:23 +0000 (00:35 +0100)
src/libsystemd-bus/bus-control.c

index 47e91118a43905db6c36a869dbbc4dde35190e49..b9700068b6acaf20847c94e90e606c00556d8db5 100644 (file)
@@ -203,6 +203,7 @@ static int kernel_get_list(sd_bus *bus, uint64_t flags, char ***x) {
         struct kdbus_cmd_name_list cmd = {};
         struct kdbus_name_list *name_list;
         struct kdbus_cmd_name *name;
+        uint64_t previous_id = 0;
         int r;
 
         /* Caller will free half-constructed list on failure... */
@@ -217,11 +218,7 @@ static int kernel_get_list(sd_bus *bus, uint64_t flags, char ***x) {
 
         KDBUS_ITEM_FOREACH(name, name_list, names) {
 
-                if (name->size > sizeof(*name)) {
-                        r = strv_extend(x, name->name);
-                        if (r < 0)
-                                return -ENOMEM;
-                } else {
+                if ((flags & KDBUS_NAME_LIST_UNIQUE) && name->id != previous_id) {
                         char *n;
 
                         if (asprintf(&n, ":1.%llu", (unsigned long long) name->id) < 0)
@@ -232,8 +229,15 @@ static int kernel_get_list(sd_bus *bus, uint64_t flags, char ***x) {
                                 free(n);
                                 return -ENOMEM;
                         }
+
+                        previous_id = name->id;
                 }
 
+                if (name->size > sizeof(*name)) {
+                        r = strv_extend(x, name->name);
+                        if (r < 0)
+                                return -ENOMEM;
+                }
         }
 
         r = ioctl(sd_bus_get_fd(bus), KDBUS_CMD_FREE, &cmd.offset);