unit: signal explicitly if a condition failed in unit_start()

We shouldn't print a status message on the console if we skipped a unit
due to a condition. Hence make unit_start() return -ENOEXEC in such a
case which is mapped to JOB_SKIPPED which results in no console message.

diff --git a/src/core/job.c b/src/core/job.c
index 781f83e175cf05900b405f59502b699bdb42cd51..f3c76d66b59dd85f1acd7948ca290c8ef7c9d0d3 100644 (file)
--- a/src/core/job.c
+++ b/src/core/job.c
@@ -417,7 +417,8 @@ static void job_print_status_message(Unit *u, JobType t, JobResult result) {
                 switch (result) {
 
                 case JOB_DONE:
                 switch (result) {
 
                 case JOB_DONE:

-                        unit_status_printf(u, ANSI_HIGHLIGHT_GREEN_ON "  OK  " ANSI_HIGHLIGHT_OFF, "Started %s", unit_description(u));
+                        if (u->condition_result)
+                                unit_status_printf(u, ANSI_HIGHLIGHT_GREEN_ON "  OK  " ANSI_HIGHLIGHT_OFF, "Started %s", unit_description(u));

                         break;
 
                 case JOB_FAILED:
                         break;
 
                 case JOB_FAILED: