chiark / gitweb /
mount: make sure m->where is set before unit_add_exec_dependencies()
authorWill Woods <wwoods@redhat.com>
Tue, 16 Oct 2012 21:04:34 +0000 (17:04 -0400)
committerLennart Poettering <lennart@poettering.net>
Mon, 22 Oct 2012 23:53:02 +0000 (01:53 +0200)
commitbcbd5405b1b6d9d219259e3be2c3ec4d92812bcb
treed2e30f3def858fe5b311e5c98cd15ce954781792
parent5411ae4782270e8e82b05e4c7c8135f4eb774dda
mount: make sure m->where is set before unit_add_exec_dependencies()

If you enter unit_add_exec_dependencies with m->where = NULL, you'll
very likely end up aborting somewhere under socket_needs_mount.

(When systemd goes to check to see if the journald socket requires your
mount, it'll do path_startswith(path, m->where)... *kaboom*)

This patch should ensure that:

    a) both branches in mount_add_one() set m->where, and
    b) mount_add_extras() calls unit_add_exec_dependencies() *after*
       setting m->where.
src/core/mount.c