chiark / gitweb /
socket-util: socket_address_parse() should not log errors on its own
authorLennart Poettering <lennart@poettering.net>
Fri, 15 May 2015 18:15:59 +0000 (20:15 +0200)
committerSven Eden <yamakuzure@gmx.net>
Tue, 14 Mar 2017 08:56:11 +0000 (09:56 +0100)
commit24166fdaeee2e0e48cfaf0a3228581c3f11f5627
tree17afa253ea2f00d538ab8c24c73d63fb14bea0c2
parentf734154b8de9da6624d94c08aed86e5716dc631e
socket-util: socket_address_parse() should not log errors on its own

Given that socket_address_parse() is mostly a "library" call it
shouldn't log on its own, but leave that to its caller.

This patch removes logging from the call in case IPv6 is not available
but and IPv6 address shall be parsed. Instead a new call
socket_address_parse_and_warn() is introduced which first invokes
socket_address_parse() and then logs if necessary.

This should fix "make check" on ipv6-less kernels:

http://lists.freedesktop.org/archives/systemd-devel/2015-April/031385.html
src/shared/socket-util.c
src/shared/socket-util.h