chiark / gitweb /
Revert "libsystemd-bus: use assert_return"
authorLennart Poettering <lennart@poettering.net>
Tue, 10 Dec 2013 19:31:10 +0000 (19:31 +0000)
committerLennart Poettering <lennart@poettering.net>
Tue, 10 Dec 2013 19:31:10 +0000 (19:31 +0000)
commit35460afc4896b22b0df743b70003e8768d78111a
tree8491925a6646e175bb0215676bd05cb169e04cbe
parentecad10fe4a4c247da72cafbc7b37f843c7c30c06
Revert "libsystemd-bus: use assert_return"

This reverts commit f7e2bd5a8070ba86cba6bcbf7d1c9a8173d846d4.

Most of these checks are not programming errors, but happen during
normal runtime. For example bus_kernel_pop_memfd() is called all the
time on non-kdbus systems and is supposed to quickly fail if kdbus is
not available. However, assert_return() makes this failure
expensive, and hence has no place here. With the most recent change to
assert_return() it will even log a debug message, which should never
happen here.
src/libsystemd-bus/bus-error.c
src/libsystemd-bus/bus-kernel.c
src/libsystemd-bus/bus-message.c
src/libsystemd-bus/bus-signature.c