chiark / gitweb /
hostnamed: allow more special characters in pretty hostname
authorNathaniel Chen <nathaniel.chen@intel.com>
Tue, 5 Mar 2013 19:46:34 +0000 (11:46 -0800)
committerLennart Poettering <lennart@poettering.net>
Tue, 5 Mar 2013 19:54:05 +0000 (20:54 +0100)
commitebe5d6d0d05d1f17c96315c42f8d9bcf5e13ba9d
treeef828ac5317569996c12d24ed21e8fb1592e02e8
parentd47c78be4a2acbb631a26af11b7ce2ef57f55996
hostnamed: allow more special characters in pretty hostname

this addresses the bug at:
  https://bugs.freedesktop.org/show_bug.cgi?id=59311
  https://bugzilla.redhat.com/show_bug.cgi?id=895299

hostnamectl is supposed to allow a range of special characters for
the 'pretty' hostname:
  $ hostnamectl set-hostname --pretty "Nathaniels Desktop !@#$%"
..however, it rejects apostrophes, double quotes, and backslashes.
The manual for hostnamectl suggests that this should be allowed.

It makes sense to reject \0, \n, etc. pretty_string_is_safe() is
the same as string_is_safe(), but allows more special characters.
src/hostname/hostnamed.c