X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=udevsend.c;h=d3c74dd46a4e9f5b9248759b2a711888585e2222;hp=d3e5378285e8ea7797e1d7d86b97ba3c64abbadb;hb=e047ca9bdfc3d95cccbbcf6d4f2358648c7d0758;hpb=33db4b8da001242b8b3b0ce8a746ef46d4416d6d

diff --git a/udevsend.c b/udevsend.c
index d3e537828..d3c74dd46 100644
--- a/udevsend.c
+++ b/udevsend.c
@@ -23,20 +23,23 @@
  */
 
 #include <sys/types.h>
-#include <sys/ipc.h>
-#include <sys/msg.h>
+#include <sys/socket.h>
+#include <sys/wait.h>
+#include <sys/un.h>
 #include <errno.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 #include <unistd.h>
 #include <time.h>
-#include <wait.h>
 
 #include "udev.h"
+#include "udev_version.h"
 #include "udevd.h"
 #include "logging.h"
 
+unsigned char logname[42];
+
 static inline char *get_action(void)
 {
 	char *action;
@@ -61,26 +64,18 @@ static inline char *get_seqnum(void)
 	return seqnum;
 }
 
-static int build_hotplugmsg(struct hotplug_msg **ppmsg, char *action,
+static int build_hotplugmsg(struct hotplug_msg *msg, char *action,
 			    char *devpath, char *subsystem, int seqnum)
 {
-	struct hotplug_msg *pmsg;
-
-	pmsg = malloc(sizeof(struct hotplug_msg));
-	pmsg->mtype = HOTPLUGMSGTYPE;
-	pmsg->seqnum = seqnum;
-	strncpy(pmsg->action, action, 8);
-	strncpy(pmsg->devpath, devpath, 128);
-	strncpy(pmsg->subsystem, subsystem, 16);
-	*ppmsg = pmsg;
+	memset(msg, 0x00, sizeof(*msg));
+	strfieldcpy(msg->magic, UDEV_MAGIC);
+	msg->seqnum = seqnum;
+	strncpy(msg->action, action, 8);
+	strncpy(msg->devpath, devpath, 128);
+	strncpy(msg->subsystem, subsystem, 16);
 	return sizeof(struct hotplug_msg);
 }
 
-static void free_hotplugmsg(struct hotplug_msg *pmsg)
-{
-	free(pmsg);
-}
-
 static int start_daemon(void)
 {
 	pid_t pid;
@@ -94,7 +89,9 @@ static int start_daemon(void)
 		switch (child_pid) {
 		case 0:
 			/* daemon */
-			execl(DEFAULT_UDEVD_EXEC, NULL);
+			setsid();
+			chdir("/");
+			execl(UDEVD_BIN, "udevd", NULL);
 			dbg("exec of daemon failed");
 			exit(1);
 		case -1:
@@ -108,18 +105,14 @@ static int start_daemon(void)
 		dbg("fork of helper failed");
 		return -1;
 	default:
-		wait(0);
+		wait(NULL);
 	}
 	return 0;
 }
 
-
 int main(int argc, char* argv[])
 {
-	int msgid;
-	key_t key;
-	struct msqid_ds  msg_queue;
-	struct msgbuf *pmsg;
+	struct hotplug_msg message;
 	char *action;
 	char *devpath;
 	char *subsystem;
@@ -129,6 +122,12 @@ int main(int argc, char* argv[])
 	int size;
 	int loop;
 	struct timespec tspec;
+	int sock;
+	struct sockaddr_un saddr;
+
+#ifdef DEBUG
+	init_logging("udevsend");
+#endif
 
 	subsystem = argv[1];
 	if (subsystem == NULL) {
@@ -155,41 +154,58 @@ int main(int argc, char* argv[])
 	}
 	seq = atoi(seqnum);
 
-	/* create ipc message queue or get id of our existing one */
-	key = ftok(DEFAULT_UDEVD_EXEC, IPC_KEY_ID);
-	size =  build_hotplugmsg( (struct hotplug_msg**) &pmsg, action, devpath, subsystem, seq);
-	msgid = msgget(key, IPC_CREAT);
-	if (msgid == -1) {
-		dbg("error open ipc queue");
+	sock = socket(AF_LOCAL, SOCK_STREAM, 0);
+	if (sock == -1) {
+		dbg("error getting socket");
 		goto exit;
 	}
 
-	/* send ipc message to the daemon */
-	retval = msgsnd(msgid, pmsg, size, 0);
-	free_hotplugmsg( (struct hotplug_msg*) pmsg);
-	if (retval == -1) {
-		dbg("error sending ipc message");
-		goto exit;
+	memset(&saddr, 0x00, sizeof(saddr));
+	saddr.sun_family = AF_LOCAL;
+	strcpy(saddr.sun_path, UDEVD_SOCK);
+
+	/* try to connect, if it fails start daemon */
+	retval = connect(sock, (struct sockaddr *) &saddr, sizeof(saddr));
+	if (retval != -1) {
+		goto send;
+	} else {
+		dbg("connect failed, try starting daemon...");
+		retval = start_daemon();
+		if (retval == 0) {
+			dbg("daemon started");
+		} else {
+			dbg("error starting daemon");
+			goto exit;
+		}
 	}
 
-	/* get state of ipc queue */
+	/* try to connect while daemon to starts */
 	tspec.tv_sec = 0;
-	tspec.tv_nsec = 10000000;  /* 10 millisec */
-	loop = 20;
+	tspec.tv_nsec = 100000000;  /* 100 millisec */
+	loop = UDEVSEND_CONNECT_RETRY;
 	while (loop--) {
-		retval = msgctl(msgid, IPC_STAT, &msg_queue);
-		if (retval == -1) {
-			dbg("error getting info on ipc queue");
-			goto exit;
-		}
-		if (msg_queue.msg_qnum == 0)
-			goto exit;
+		retval = connect(sock, (struct sockaddr *) &saddr, sizeof(saddr));
+		if (retval != -1)
+			goto send;
+		else
+			dbg("retry to connect %d",
+			    UDEVSEND_CONNECT_RETRY - loop);
 		nanosleep(&tspec, NULL);
 	}
+	dbg("error connecting to daemon, start daemon failed");
+	goto exit;
 
-	info("message is still in the ipc queue, starting daemon...");
-	retval = start_daemon();
+send:
+	size = build_hotplugmsg(&message, action, devpath, subsystem, seq);
+	retval = send(sock, &message, size, 0);
+	if (retval == -1) {
+		dbg("error sending message");
+		close (sock);
+		goto exit;
+	}
+	close (sock);
+	return 0;
 
 exit:
-	return retval;
+	return 1;
 }