X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=udev_db.c;h=bf369ac2e66c54b249afeeb35d6fa450c477de77;hp=264af79d063c49500753913028df3f352323c3ed;hb=a743be9a785e1223ce628a4225b63546281d9e66;hpb=b8476286d62c82a1a0bd8de318aa3f7d835222a0

diff --git a/udev_db.c b/udev_db.c
index 264af79d0..bf369ac2e 100644
--- a/udev_db.c
+++ b/udev_db.c
@@ -1,8 +1,6 @@
 /*
  * udev_db.c
  *
- * Userspace devfs
- *
  * Copyright (C) 2003 Greg Kroah-Hartman <greg@kroah.com>
  * Copyright (C) 2004-2005 Kay Sievers <kay.sievers@vrfy.org>
  *
@@ -41,20 +39,35 @@
 
 #define PATH_TO_NAME_CHAR		'@'
 
-static int get_db_filename(const char *devpath, char *filename, int len)
+static int devpath_to_db_path(const char *devpath, char *filename, size_t len)
 {
-	char temp[PATH_SIZE];
-	char *pos;
+	size_t start, end, i;
+
+	/* add location of db files */
+	start = strlcpy(filename, udev_db_path, len);
+	end = strlcat(filename, devpath, len);
+	if (end > len)
+		end = len;
 
 	/* replace '/' to transform path into a filename */
-	strlcpy(temp, devpath, sizeof(temp));
-	pos = strchr(&temp[1], '/');
-	while (pos) {
-		pos[0] = PATH_TO_NAME_CHAR;
-		pos = strchr(&pos[1], '/');
-	}
-	snprintf(filename, len, "%s%s", udev_db_path, temp);
-	filename[len-1] = '\0';
+	for (i = start+1; i < end; i++)
+		if (filename[i] == '/')
+			filename[i] = PATH_TO_NAME_CHAR;
+
+	return 0;
+}
+
+static int db_file_to_devpath(const char *filename, char *devpath, size_t len)
+{
+	size_t end, i;
+
+	strlcpy(devpath, "/", len);
+	end = strlcat(devpath, filename, len);
+
+	/* replace PATH_TO_NAME_CHAR to transform name into devpath */
+	for (i = 1; i < end; i++)
+		if (devpath[i] == PATH_TO_NAME_CHAR)
+			devpath[i] = '/';
 
 	return 0;
 }
@@ -68,10 +81,18 @@ int udev_db_add_device(struct udevice *udev)
 	if (udev->test_run)
 		return 0;
 
-	get_db_filename(udev->devpath, filename, sizeof(filename));
+	/* don't write anything if udev created only the node with the
+	 * kernel name without any interesting data to remember
+	 */
+	if (strcmp(udev->name, udev->kernel_name) == 0 &&
+	    list_empty(&udev->symlink_list) && list_empty(&udev->env_list) &&
+	    !udev->partitions && !udev->ignore_remove) {
+		dbg("nothing interesting to store in udevdb, skip");
+		goto exit;
+	}
 
+	devpath_to_db_path(udev->devpath, filename, sizeof(filename));
 	create_path(filename);
-
 	f = fopen(filename, "w");
 	if (f == NULL) {
 		err("unable to create db file '%s'", filename);
@@ -79,22 +100,25 @@ int udev_db_add_device(struct udevice *udev)
 	}
 	dbg("storing data for device '%s' in '%s'", udev->devpath, filename);
 
-	fprintf(f, "P:%s\n", udev->devpath);
 	fprintf(f, "N:%s\n", udev->name);
 	list_for_each_entry(name_loop, &udev->symlink_list, node)
 		fprintf(f, "S:%s\n", name_loop->name);
 	fprintf(f, "M:%u:%u\n", major(udev->devt), minor(udev->devt));
-	fprintf(f, "A:%u\n", udev->partitions);
-	fprintf(f, "R:%u\n", udev->ignore_remove);
+	if (udev->partitions)
+		fprintf(f, "A:%u\n", udev->partitions);
+	if (udev->ignore_remove)
+		fprintf(f, "R:%u\n", udev->ignore_remove);
 	list_for_each_entry(name_loop, &udev->env_list, node)
 		fprintf(f, "E:%s\n", name_loop->name);
 	fclose(f);
 
+exit:
 	return 0;
 }
 
-static int parse_db_file(struct udevice *udev, const char *filename)
+int udev_db_get_device(struct udevice *udev, const char *devpath)
 {
+	char filename[PATH_SIZE];
 	char line[PATH_SIZE];
 	unsigned int major, minor;
 	char *bufline;
@@ -103,11 +127,13 @@ static int parse_db_file(struct udevice *udev, const char *filename)
 	size_t cur;
 	size_t count;
 
+	devpath_to_db_path(devpath, filename, sizeof(filename));
 	if (file_map(filename, &buf, &bufsize) != 0) {
-		err("unable to read db file '%s'", filename);
+		dbg("no db file to read '%s'", filename);
 		return -1;
 	}
 
+	strlcpy(udev->devpath, devpath, sizeof(udev->devpath));
 	cur = 0;
 	while (cur < bufsize) {
 		count = buf_get_line(buf, bufsize, cur);
@@ -115,45 +141,46 @@ static int parse_db_file(struct udevice *udev, const char *filename)
 		cur += count+1;
 
 		switch(bufline[0]) {
-		case 'P':
-			if (count > sizeof(udev->devpath))
-				count = sizeof(udev->devpath);
-			strlcpy(udev->devpath, &bufline[2], count-1);
-			break;
 		case 'N':
 			if (count > sizeof(udev->name))
 				count = sizeof(udev->name);
-			strlcpy(udev->name, &bufline[2], count-1);
+			memcpy(udev->name, &bufline[2], count-2);
+			udev->name[count-2] = '\0';
 			break;
 		case 'M':
 			if (count > sizeof(line))
 				count = sizeof(line);
-			strlcpy(line, &bufline[2], count-1);
+			memcpy(line, &bufline[2], count-2);
+			line[count-2] = '\0';
 			sscanf(line, "%u:%u", &major, &minor);
 			udev->devt = makedev(major, minor);
 			break;
 		case 'S':
 			if (count > sizeof(line))
 				count =  sizeof(line);
-			strlcpy(line, &bufline[2], count-1);
+			memcpy(line, &bufline[2], count-2);
+			line[count-2] = '\0';
 			name_list_add(&udev->symlink_list, line, 0);
 			break;
 		case 'A':
 			if (count > sizeof(line))
 				count =  sizeof(line);
-			strlcpy(line, &bufline[2], count-1);
+			memcpy(line, &bufline[2], count-2);
+			line[count-2] = '\0';
 			udev->partitions = atoi(line);
 			break;
 		case 'R':
 			if (count > sizeof(line))
 				count =  sizeof(line);
-			strlcpy(line, &bufline[2], count-1);
+			memcpy(line, &bufline[2], count-2);
+			line[count-2] = '\0';
 			udev->ignore_remove = atoi(line);
 			break;
 		case 'E':
 			if (count > sizeof(line))
 				count =  sizeof(line);
-			strlcpy(line, &bufline[2], count-1);
+			memcpy(line, &bufline[2], count-2);
+			line[count-2] = '\0';
 			name_list_add(&udev->env_list, line, 0);
 			break;
 		}
@@ -170,27 +197,16 @@ int udev_db_delete_device(struct udevice *udev)
 {
 	char filename[PATH_SIZE];
 
-	get_db_filename(udev->devpath, filename, sizeof(filename));
+	devpath_to_db_path(udev->devpath, filename, sizeof(filename));
 	unlink(filename);
 
 	return 0;
 }
 
-int udev_db_get_device(struct udevice *udev, const char *devpath)
-{
-	char filename[PATH_SIZE];
-
-	get_db_filename(devpath, filename, sizeof(filename));
-
-	if (parse_db_file(udev, filename) != 0)
-		return -1;
-
-	return 0;
-}
-
-int udev_db_search_name(char *devpath, size_t len, const char *name)
+int udev_db_lookup_name(const char *name, char *devpath, size_t len)
 {
 	DIR *dir;
+	int found = 0;
 
 	dir = opendir(udev_db_path);
 	if (dir == NULL) {
@@ -198,10 +214,9 @@ int udev_db_search_name(char *devpath, size_t len, const char *name)
 		return -1;
 	}
 
-	while (1) {
+	while (!found) {
 		struct dirent *ent;
 		char filename[PATH_SIZE];
-		char path[PATH_SIZE];
 		char nodename[PATH_SIZE];
 		char *bufline;
 		char *buf;
@@ -212,7 +227,6 @@ int udev_db_search_name(char *devpath, size_t len, const char *name)
 		ent = readdir(dir);
 		if (ent == NULL || ent->d_name[0] == '\0')
 			break;
-
 		if (ent->d_name[0] == '.')
 			continue;
 
@@ -226,28 +240,22 @@ int udev_db_search_name(char *devpath, size_t len, const char *name)
 		}
 
 		cur = 0;
-		while (cur < bufsize) {
+		while (cur < bufsize && !found) {
 			count = buf_get_line(buf, bufsize, cur);
 			bufline = &buf[cur];
 			cur += count+1;
 
 			switch(bufline[0]) {
-			case 'P':
-				if (count > sizeof(path))
-					count = sizeof(path);
-				strlcpy(path, &bufline[2], count-1);
-				break;
 			case 'N':
 			case 'S':
 				if (count > sizeof(nodename))
 					count = sizeof(nodename);
-				strlcpy(nodename, &bufline[2], count-1);
+				memcpy(nodename, &bufline[2], count-2);
+				nodename[count-2] = '\0';
 				dbg("compare '%s' '%s'", nodename, name);
 				if (strcmp(nodename, name) == 0) {
-					strlcpy(devpath, path, len);
-					file_unmap(buf, bufsize);
-					closedir(dir);
-					return 0;
+					db_file_to_devpath(ent->d_name, devpath, len);
+					found = 1;
 				}
 				break;
 			default:
@@ -258,10 +266,13 @@ int udev_db_search_name(char *devpath, size_t len, const char *name)
 	}
 
 	closedir(dir);
-	return -1;
+	if (found)
+		return 0;
+	else
+		return -1;
 }
 
-int udev_db_dump_names(int (*handler_function)(const char *path, const char *name))
+int udev_db_get_all_entries(struct list_head *name_list)
 {
 	DIR *dir;
 
@@ -273,61 +284,21 @@ int udev_db_dump_names(int (*handler_function)(const char *path, const char *nam
 
 	while (1) {
 		struct dirent *ent;
-		char filename[PATH_SIZE];
-		char path[PATH_SIZE];
-		char nodename[PATH_SIZE];
-		char *bufline;
-		char *buf;
-		size_t bufsize;
-		size_t cur;
-		size_t count;
+		char filename[PATH_SIZE] = "/";
+		size_t end, i;
 
 		ent = readdir(dir);
 		if (ent == NULL || ent->d_name[0] == '\0')
 			break;
-
 		if (ent->d_name[0] == '.')
 			continue;
 
-		snprintf(filename, sizeof(filename), "%s/%s", udev_db_path, ent->d_name);
-		filename[sizeof(filename)-1] = '\0';
-		dbg("looking at '%s'", filename);
-
-		if (file_map(filename, &buf, &bufsize) != 0) {
-			err("unable to read db file '%s'", filename);
-			continue;
-		}
-
-		path[0] = '\0';
-		nodename[0] = '\0';
-		cur = 0;
-		while (cur < bufsize) {
-			count = buf_get_line(buf, bufsize, cur);
-			bufline = &buf[cur];
-			cur += count+1;
-
-			switch(bufline[0]) {
-			case 'P':
-				if (count > sizeof(path))
-					count = sizeof(path);
-				strlcpy(path, &bufline[2], count-1);
-				break;
-			case 'N':
-				if (count > sizeof(nodename))
-					count = sizeof(nodename);
-				strlcpy(nodename, &bufline[2], count-1);
-				break;
-			default:
-				continue;
-			}
-		}
-		file_unmap(buf, bufsize);
-
-		if (path[0] == '\0' || nodename[0] == '\0')
-			continue;
-
-		if (handler_function(path, nodename) != 0)
-			break;
+		end = strlcat(filename, ent->d_name, sizeof(filename));
+		for (i = 1; i < end; i++)
+			if (filename[i] == PATH_TO_NAME_CHAR)
+				filename[i] = '/';
+		name_list_add(name_list, filename, 1);
+		dbg("added '%s'", filename);
 	}
 
 	closedir(dir);