X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=udev%2Ftest-udev.c;h=07716897b446e839bf8b4acdd1335280bc10569f;hp=d304a1cc159a96ea8ac5a7a1fb2f4708440c4ada;hb=829f6902fe09d2eb1cff459fa5e26ed53f98ebc8;hpb=dcdcb8cc06c044a0429a688266799838e914f88d;ds=sidebyside

diff --git a/udev/test-udev.c b/udev/test-udev.c
index d304a1cc1..07716897b 100644
--- a/udev/test-udev.c
+++ b/udev/test-udev.c
@@ -23,54 +23,33 @@
 #include <fcntl.h>
 #include <ctype.h>
 #include <errno.h>
-#include <signal.h>
 #include <unistd.h>
 #include <syslog.h>
 #include <grp.h>
+#include <sys/signalfd.h>
 
 #include "udev.h"
 
-static void asmlinkage sig_handler(int signum)
-{
-	switch (signum) {
-		case SIGALRM:
-			exit(1);
-		case SIGINT:
-		case SIGTERM:
-			exit(20 + signum);
-	}
-}
-
 int main(int argc, char *argv[])
 {
 	struct udev *udev;
-	struct udev_event *event;
-	struct udev_device *dev;
-	struct udev_rules *rules;
+	struct udev_event *event = NULL;
+	struct udev_device *dev = NULL;
+	struct udev_rules *rules = NULL;
 	char syspath[UTIL_PATH_SIZE];
 	const char *devpath;
 	const char *action;
 	const char *subsystem;
-	struct sigaction act;
+	sigset_t mask, sigmask_orig;
 	int err = -EINVAL;
 
 	udev = udev_new();
 	if (udev == NULL)
 		exit(1);
 	info(udev, "version %s\n", VERSION);
-	selinux_init(udev);
+	udev_selinux_init(udev);
 
-	/* set signal handlers */
-	memset(&act, 0x00, sizeof(act));
-	act.sa_handler = (void (*)(int)) sig_handler;
-	sigemptyset (&act.sa_mask);
-	act.sa_flags = 0;
-	sigaction(SIGALRM, &act, NULL);
-	sigaction(SIGINT, &act, NULL);
-	sigaction(SIGTERM, &act, NULL);
-
-	/* trigger timeout to prevent hanging processes */
-	alarm(UDEV_EVENT_TIMEOUT);
+	sigprocmask(SIG_SETMASK, NULL, &sigmask_orig);
 
 	action = getenv("ACTION");
 	devpath = getenv("DEVPATH");
@@ -78,17 +57,16 @@ int main(int argc, char *argv[])
 
 	if (action == NULL || subsystem == NULL || devpath == NULL) {
 		err(udev, "action, subsystem or devpath missing\n");
-		goto exit;
+		goto out;
 	}
 
-	rules = udev_rules_new(udev, 0);
+	rules = udev_rules_new(udev, 1);
 
-	util_strlcpy(syspath, udev_get_sys_path(udev), sizeof(syspath));
-	util_strlcat(syspath, devpath, sizeof(syspath));
+	util_strscpyl(syspath, sizeof(syspath), udev_get_sys_path(udev), devpath, NULL);
 	dev = udev_device_new_from_syspath(udev, syspath);
 	if (dev == NULL) {
 		info(udev, "unknown device '%s'\n", devpath);
-		goto fail;
+		goto out;
 	}
 
 	/* skip reading of db, but read kernel parameters */
@@ -97,21 +75,25 @@ int main(int argc, char *argv[])
 
 	udev_device_set_action(dev, action);
 	event = udev_event_new(dev);
-	err = udev_event_execute_rules(event, rules);
-
-	/* rules may change/disable the timeout */
-	if (udev_device_get_event_timeout(dev) >= 0)
-		alarm(udev_device_get_event_timeout(dev));
 
-	if (err == 0 && !event->ignore_device && udev_get_run(udev))
-		udev_rules_run(event);
+	sigfillset(&mask);
+	sigprocmask(SIG_SETMASK, &mask, &sigmask_orig);
+	event->fd_signal = signalfd(-1, &mask, SFD_NONBLOCK|SFD_CLOEXEC);
+	if (event->fd_signal < 0) {
+		fprintf(stderr, "error creating signalfd\n");
+		goto out;
+	}
 
+	err = udev_event_execute_rules(event, rules, &sigmask_orig);
+	if (err == 0)
+		udev_event_execute_run(event, NULL);
+out:
+	if (event != NULL && event->fd_signal >= 0)
+		close(event->fd_signal);
 	udev_event_unref(event);
 	udev_device_unref(dev);
-fail:
 	udev_rules_unref(rules);
-exit:
-	selinux_exit(udev);
+	udev_selinux_exit(udev);
 	udev_unref(udev);
 	if (err != 0)
 		return 1;