X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=src%2Fudev%2Fudevadm-trigger.c;h=7735e4b67b8d1b535177634b2bbdf1274be79549;hp=3cce23dfb220149b928df5021ec62b1c491b7fa9;hb=33502ffe2eb7b56cdd018a4fb6830d7828519fad;hpb=6df831f25ebc9f55cd939f04392dad9237706e45 diff --git a/src/udev/udevadm-trigger.c b/src/udev/udevadm-trigger.c index 3cce23dfb..7735e4b67 100644 --- a/src/udev/udevadm-trigger.c +++ b/src/udev/udevadm-trigger.c @@ -38,7 +38,6 @@ static int dry_run; static void exec_list(struct udev_enumerate *udev_enumerate, const char *action) { - struct udev *udev = udev_enumerate_get_udev(udev_enumerate); struct udev_list_entry *entry; udev_list_entry_foreach(entry, udev_enumerate_get_list_entry(udev_enumerate)) { @@ -51,12 +50,10 @@ static void exec_list(struct udev_enumerate *udev_enumerate, const char *action) continue; util_strscpyl(filename, sizeof(filename), udev_list_entry_get_name(entry), "/uevent", NULL); fd = open(filename, O_WRONLY); - if (fd < 0) { - dbg(udev, "error on opening %s: %m\n", filename); + if (fd < 0) continue; - } if (write(fd, action, strlen(action)) < 0) - info(udev, "error writing '%s' to '%s': %m\n", action, filename); + log_debug("error writing '%s' to '%s': %m\n", action, filename); close(fd); } } @@ -101,7 +98,6 @@ static int adm_trigger(struct udev *udev, int argc, char *argv[]) struct udev_enumerate *udev_enumerate; int rc = 0; - dbg(udev, "version %s\n", VERSION); udev_enumerate = udev_enumerate_new(udev); if (udev_enumerate == NULL) { rc = 1; @@ -131,7 +127,7 @@ static int adm_trigger(struct udev *udev, int argc, char *argv[]) } else if (strcmp(optarg, "subsystems") == 0) { device_type = TYPE_SUBSYSTEMS; } else { - err(udev, "unknown type --type=%s\n", optarg); + log_error("unknown type --type=%s\n", optarg); rc = 2; goto exit; } @@ -168,14 +164,14 @@ static int adm_trigger(struct udev *udev, int argc, char *argv[]) struct udev_device *dev; /* add sys dir if needed */ - if (strncmp(optarg, udev_get_sys_path(udev), strlen(udev_get_sys_path(udev))) != 0) - util_strscpyl(path, sizeof(path), udev_get_sys_path(udev), optarg, NULL); + if (!startswith(optarg, "/sys")) + util_strscpyl(path, sizeof(path), "/sys", optarg, NULL); else util_strscpy(path, sizeof(path), optarg); util_remove_trailing_chars(path, '/'); dev = udev_device_new_from_syspath(udev, path); if (dev == NULL) { - err(udev, "unable to open the device '%s'\n", optarg); + log_error("unable to open the device '%s'\n", optarg); rc = 2; goto exit; }