X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=src%2Fudev%2Fudev-node.c;h=0429c35ff7fc1a2b1a0a9e7f8d053e5356995d90;hp=187e24e5b6f988ab66aa6258a4c9d73559367c72;hb=4987623d011c534a22a490b17a8e0ec81d1ac30c;hpb=463b5dbb0d10227230468ee3adc3b50fce7d0707 diff --git a/src/udev/udev-node.c b/src/udev/udev-node.c index 187e24e5b..0429c35ff 100644 --- a/src/udev/udev-node.c +++ b/src/udev/udev-node.c @@ -28,11 +28,9 @@ #include #include #include -#ifdef HAVE_XATTR -#include -#endif #include "udev.h" +#include "smack-util.h" static int node_symlink(struct udev_device *dev, const char *node, const char *slink) { @@ -284,9 +282,7 @@ static int node_permissions_apply(struct udev_device *dev, bool apply, if (apply) { bool selinux = false; -#ifdef HAVE_SMACK bool smack = false; -#endif if ((stats.st_mode & 0777) != (mode & 0777) || stats.st_uid != uid || stats.st_gid != gid) { log_debug("set permissions %s, %#o, uid=%u, gid=%u\n", devnode, mode, uid, gid); @@ -310,14 +306,12 @@ static int node_permissions_apply(struct udev_device *dev, bool apply, else log_debug("SECLABEL: set SELinux label '%s'", label); -#ifdef HAVE_SMACK } else if (streq(name, "smack")) { smack = true; - if (lsetxattr(devnode, "security.SMACK64", label, strlen(label), 0) < 0) + if (smack_label_path(devnode, label) < 0) log_error("SECLABEL: failed to set SMACK label '%s'", label); else log_debug("SECLABEL: set SMACK label '%s'", label); -#endif } else log_error("SECLABEL: unknown subsystem, ignoring '%s'='%s'", name, label); @@ -326,10 +320,8 @@ static int node_permissions_apply(struct udev_device *dev, bool apply, /* set the defaults */ if (!selinux) label_fix(devnode, true, false); -#ifdef HAVE_SMACK if (!smack) - lremovexattr(devnode, "security.SMACK64"); -#endif + smack_label_path(devnode, NULL); } /* always update timestamp when we re-use the node, like on media change events */