X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=src%2Ftest%2Ftest-unit-name.c;h=86cb2b8da64c42ecd75a9b1bf41ce1fa0c288a2c;hp=b1a4134f48add8de69adb237f14227b711b20f68;hb=4ad490007b70e6ac18d3cb04fa2ed92eba1451fa;hpb=1682ff60114b7a57972a03aa99f9864064593f72

diff --git a/src/test/test-unit-name.c b/src/test/test-unit-name.c
index b1a4134f4..86cb2b8da 100644
--- a/src/test/test-unit-name.c
+++ b/src/test/test-unit-name.c
@@ -38,7 +38,7 @@
 static void test_replacements(void) {
 #define expect(pattern, repl, expected)                            \
         {                                                          \
-                char _cleanup_free_ *t =                           \
+                _cleanup_free_ char *t =                           \
                         unit_name_replace_instance(pattern, repl); \
                 puts(t);                                           \
                 assert(streq(t, expected));                        \
@@ -57,7 +57,7 @@ static void test_replacements(void) {
 #undef expect
 #define expect(path, suffix, expected)                             \
         {                                                          \
-                char _cleanup_free_ *k, *t =                       \
+                _cleanup_free_ char *k, *t =                       \
                         unit_name_from_path(path, suffix);         \
                 puts(t);                                           \
                 k = unit_name_to_path(t);                          \
@@ -75,7 +75,7 @@ static void test_replacements(void) {
 #undef expect
 #define expect(pattern, path, suffix, expected)                         \
         {                                                               \
-                char _cleanup_free_ *t =                                \
+                _cleanup_free_ char *t =                                \
                         unit_name_from_path_instance(pattern, path, suffix); \
                 puts(t);                                                \
                 assert(streq(t, expected));                             \
@@ -90,7 +90,7 @@ static void test_replacements(void) {
 #undef expect
 #define expect(pattern)                                                 \
         {                                                               \
-                char _cleanup_free_ *k, *t;                             \
+                _cleanup_free_ char *k, *t;                             \
                 assert_se(t = unit_name_mangle(pattern));               \
                 assert_se(k = unit_name_mangle(t));                     \
                 puts(t);                                                \
@@ -108,11 +108,12 @@ static void test_replacements(void) {
 #undef expect
 }
 
-static void test_unit_printf(void) {
+static int test_unit_printf(void) {
         Manager *m;
         Unit *u, *u2;
+        int r;
 
-        char _cleanup_free_ *mid, *bid, *host, *root_uid;
+        _cleanup_free_ char *mid, *bid, *host, *root_uid;
         struct passwd *root;
 
         assert_se((mid = specifier_machine_id('m', NULL, NULL)));
@@ -122,14 +123,23 @@ static void test_unit_printf(void) {
         assert_se((root = getpwnam("root")));
         assert_se(asprintf(&root_uid, "%d", (int) root->pw_uid) > 0);
 
-        assert_se(manager_new(SYSTEMD_SYSTEM, &m) == 0);
+        r = manager_new(SYSTEMD_USER, &m);
+        if (r == -EPERM) {
+                puts("manager_new: Permission denied. Skipping test.");
+                return EXIT_TEST_SKIP;
+        }
+        assert(r == 0);
 
 #define expect(unit, pattern, expected)                                 \
         {                                                               \
-                char _cleanup_free_ *t =                                \
+                char *e;                                                \
+                _cleanup_free_ char *t =                                \
                         unit_full_printf(unit, pattern);                \
-                printf("result: %s\n", t);                              \
-                assert(streq(t, expected));                             \
+                printf("result: %s\nexpect: %s\n", t, expected);        \
+                if ((e = endswith(expected, "*")))                      \
+                        assert(strncmp(t, e, e-expected));              \
+                else                                                    \
+                        assert(streq(t, expected));                     \
         }
 
         assert_se(setenv("USER", "root", 1) == 0);
@@ -154,11 +164,11 @@ static void test_unit_printf(void) {
         expect(u, "%u", root->pw_name);
         expect(u, "%U", root_uid);
         expect(u, "%h", root->pw_dir);
-        expect(u, "%s", root->pw_shell);
+        expect(u, "%s", "/bin/sh");
         expect(u, "%m", mid);
         expect(u, "%b", bid);
         expect(u, "%H", host);
-        expect(u, "%t", "/run");
+        expect(u, "%t", "/run/user/*");
 
         /* templated */
         assert_se(u2 = unit_new(m, sizeof(Service)));
@@ -174,16 +184,16 @@ static void test_unit_printf(void) {
         expect(u2, "%u", root->pw_name);
         expect(u2, "%U", root_uid);
         expect(u2, "%h", root->pw_dir);
-        expect(u2, "%s", root->pw_shell);
+        expect(u2, "%s", "/bin/sh");
         expect(u2, "%m", mid);
         expect(u2, "%b", bid);
         expect(u2, "%H", host);
-        expect(u2, "%t", "/run");
+        expect(u2, "%t", "/run/user/*");
+
+        return 0;
 }
 
 int main(int argc, char* argv[]) {
         test_replacements();
-        test_unit_printf();
-
-        return 0;
+        return test_unit_printf();
 }