X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=src%2Fsystemctl%2Fsystemctl.c;h=24295e411bafe1c99db85218b7ebc6c21393ac68;hp=9d22aad28700ebe1247aaa54ba769b862702a20a;hb=852c1b4d297e5c36a47254fed44bf0a967d66a90;hpb=eb9da376d76b48585b3b63b4f91903b54f7abd36 diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index 9d22aad28..24295e411 100644 --- a/src/systemctl/systemctl.c +++ b/src/systemctl/systemctl.c @@ -4,6 +4,7 @@ This file is part of systemd. Copyright 2010 Lennart Poettering + Copyright 2013 Marc-Antoine Perennou systemd is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by @@ -20,6 +21,8 @@ ***/ #include +#include +#include #include #include #include @@ -34,12 +37,11 @@ #include #include #include -#include - -#include -#include -#include +#include "sd-daemon.h" +#include "sd-shutdown.h" +#include "sd-login.h" +#include "sd-bus.h" #include "log.h" #include "util.h" #include "macro.h" @@ -49,7 +51,6 @@ #include "initreq.h" #include "path-util.h" #include "strv.h" -#include "dbus-common.h" #include "cgroup-show.h" #include "cgroup-util.h" #include "list.h" @@ -67,6 +68,9 @@ #include "path-util.h" #include "socket-util.h" #include "fileio.h" +#include "bus-util.h" +#include "bus-message.h" +#include "bus-error.h" static char **arg_types = NULL; static char **arg_states = NULL; @@ -101,7 +105,7 @@ static int arg_signal = SIGTERM; static const char *arg_root = NULL; static usec_t arg_when = 0; static enum action { - ACTION_INVALID, + _ACTION_INVALID, ACTION_SYSTEMCTL, ACTION_HALT, ACTION_POWEROFF, @@ -124,21 +128,14 @@ static enum action { ACTION_CANCEL_SHUTDOWN, _ACTION_MAX } arg_action = ACTION_SYSTEMCTL; -static enum transport { - TRANSPORT_NORMAL, - TRANSPORT_SSH, - TRANSPORT_POLKIT -} arg_transport = TRANSPORT_NORMAL; +static BusTransport arg_transport = BUS_TRANSPORT_LOCAL; static char *arg_host = NULL; -static char *arg_user = NULL; static unsigned arg_lines = 10; static OutputMode arg_output = OUTPUT_SHORT; static bool arg_plain = false; -static bool private_bus = false; - -static int daemon_reload(DBusConnection *bus, char **args); -static void halt_now(enum action a); +static int daemon_reload(sd_bus *bus, char **args); +static int halt_now(enum action a); static void pager_open_if_enabled(void) { @@ -158,6 +155,9 @@ static void ask_password_agent_open_if_enabled(void) { if (arg_scope != UNIT_FILE_SYSTEM) return; + if (arg_transport != BUS_TRANSPORT_LOCAL) + return; + ask_password_agent_open(); } @@ -172,30 +172,33 @@ static void polkit_agent_open_if_enabled(void) { if (arg_scope != UNIT_FILE_SYSTEM) return; + if (arg_transport != BUS_TRANSPORT_LOCAL) + return; + polkit_agent_open(); } #endif -static int translate_bus_error_to_exit_status(int r, const DBusError *error) { +static int translate_bus_error_to_exit_status(int r, const sd_bus_error *error) { assert(error); - if (!dbus_error_is_set(error)) + if (!sd_bus_error_is_set(error)) return r; - if (dbus_error_has_name(error, DBUS_ERROR_ACCESS_DENIED) || - dbus_error_has_name(error, BUS_ERROR_ONLY_BY_DEPENDENCY) || - dbus_error_has_name(error, BUS_ERROR_NO_ISOLATION) || - dbus_error_has_name(error, BUS_ERROR_TRANSACTION_IS_DESTRUCTIVE)) + if (sd_bus_error_has_name(error, SD_BUS_ERROR_ACCESS_DENIED) || + sd_bus_error_has_name(error, BUS_ERROR_ONLY_BY_DEPENDENCY) || + sd_bus_error_has_name(error, BUS_ERROR_NO_ISOLATION) || + sd_bus_error_has_name(error, BUS_ERROR_TRANSACTION_IS_DESTRUCTIVE)) return EXIT_NOPERMISSION; - if (dbus_error_has_name(error, BUS_ERROR_NO_SUCH_UNIT)) + if (sd_bus_error_has_name(error, BUS_ERROR_NO_SUCH_UNIT)) return EXIT_NOTINSTALLED; - if (dbus_error_has_name(error, BUS_ERROR_JOB_TYPE_NOT_APPLICABLE) || - dbus_error_has_name(error, BUS_ERROR_NOT_SUPPORTED)) + if (sd_bus_error_has_name(error, BUS_ERROR_JOB_TYPE_NOT_APPLICABLE) || + sd_bus_error_has_name(error, BUS_ERROR_NOT_SUPPORTED)) return EXIT_NOTIMPLEMENTED; - if (dbus_error_has_name(error, BUS_ERROR_LOAD_FAILED)) + if (sd_bus_error_has_name(error, BUS_ERROR_LOAD_FAILED)) return EXIT_NOTCONFIGURED; if (r != 0) @@ -257,8 +260,8 @@ static bool avoid_bus(void) { } static int compare_unit_info(const void *a, const void *b) { + const UnitInfo *u = a, *v = b; const char *d1, *d2; - const struct unit_info *u = a, *v = b; d1 = strrchr(u->id, '.'); d2 = strrchr(v->id, '.'); @@ -274,11 +277,14 @@ static int compare_unit_info(const void *a, const void *b) { return strcasecmp(u->id, v->id); } -static bool output_show_unit(const struct unit_info *u) { +static bool output_show_unit(const UnitInfo *u) { const char *dot; if (!strv_isempty(arg_states)) - return strv_contains(arg_states, u->load_state) || strv_contains(arg_states, u->sub_state) || strv_contains(arg_states, u->active_state); + return + strv_contains(arg_states, u->load_state) || + strv_contains(arg_states, u->sub_state) || + strv_contains(arg_states, u->active_state); return (!arg_types || ((dot = strrchr(u->id, '.')) && strv_find(arg_types, dot+1))) && @@ -286,12 +292,14 @@ static bool output_show_unit(const struct unit_info *u) { || u->following[0]) || u->job_id > 0); } -static void output_units_list(const struct unit_info *unit_infos, unsigned c) { - unsigned id_len, max_id_len, active_len, sub_len, job_len, desc_len, n_shown = 0; - const struct unit_info *u; +static void output_units_list(const UnitInfo *unit_infos, unsigned c) { + unsigned id_len, max_id_len, load_len, active_len, sub_len, job_len, desc_len; + const UnitInfo *u; + unsigned n_shown = 0; int job_count = 0; max_id_len = sizeof("UNIT")-1; + load_len = sizeof("LOAD")-1; active_len = sizeof("ACTIVE")-1; sub_len = sizeof("SUB")-1; job_len = sizeof("JOB")-1; @@ -302,8 +310,10 @@ static void output_units_list(const struct unit_info *unit_infos, unsigned c) { continue; max_id_len = MAX(max_id_len, strlen(u->id)); + load_len = MAX(load_len, strlen(u->load_state)); active_len = MAX(active_len, strlen(u->active_state)); sub_len = MAX(sub_len, strlen(u->sub_state)); + if (u->job_id != 0) { job_len = MAX(job_len, strlen(u->job_type)); job_count++; @@ -312,18 +322,23 @@ static void output_units_list(const struct unit_info *unit_infos, unsigned c) { if (!arg_full && original_stdout_is_tty) { unsigned basic_len; + id_len = MIN(max_id_len, 25u); basic_len = 5 + id_len + 5 + active_len + sub_len; + if (job_count) basic_len += job_len + 1; + if (basic_len < (unsigned) columns()) { unsigned extra_len, incr; extra_len = columns() - basic_len; + /* Either UNIT already got 25, or is fully satisfied. * Grant up to 25 to DESC now. */ incr = MIN(extra_len, 25u); desc_len += incr; extra_len -= incr; + /* split the remaining space between UNIT and DESC, * but do not give UNIT more than it needs. */ if (extra_len > 0) { @@ -344,10 +359,15 @@ static void output_units_list(const struct unit_info *unit_infos, unsigned c) { continue; if (!n_shown && !arg_no_legend) { - printf("%-*s %-6s %-*s %-*s ", id_len, "UNIT", "LOAD", - active_len, "ACTIVE", sub_len, "SUB"); + printf("%-*s %-*s %-*s %-*s ", + id_len, "UNIT", + load_len, "LOAD", + active_len, "ACTIVE", + sub_len, "SUB"); + if (job_count) printf("%-*s ", job_len, "JOB"); + if (!arg_full && arg_no_pager) printf("%.*s\n", desc_len, "DESCRIPTION"); else @@ -371,12 +391,13 @@ static void output_units_list(const struct unit_info *unit_infos, unsigned c) { e = arg_full ? NULL : ellipsize(u->id, id_len, 33); - printf("%s%-*s%s %s%-6s%s %s%-*s %-*s%s %-*s", + printf("%s%-*s%s %s%-*s%s %s%-*s %-*s%s %-*s", on, id_len, e ? e : u->id, off, - on_loaded, u->load_state, off_loaded, + on_loaded, load_len, u->load_state, off_loaded, on_active, active_len, u->active_state, sub_len, u->sub_state, off_active, job_count ? job_len + 1 : 0, u->job_id ? u->job_type : ""); + if (desc_len > 0) printf("%.*s\n", desc_len, u->description); else @@ -412,183 +433,149 @@ static void output_units_list(const struct unit_info *unit_infos, unsigned c) { } static int get_unit_list( - DBusConnection *bus, - DBusMessage **reply, - struct unit_info **unit_infos, - unsigned *c) { + sd_bus *bus, + sd_bus_message **_reply, + UnitInfo **_unit_infos) { - DBusMessageIter iter, sub; + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; + _cleanup_bus_message_unref_ sd_bus_message *reply = NULL; + _cleanup_free_ UnitInfo *unit_infos = NULL; size_t size = 0; - int r; + int r, c = 0; + UnitInfo u; assert(bus); - assert(unit_infos); - assert(c); + assert(_reply); + assert(_unit_infos); - r = bus_method_call_with_reply( + r = sd_bus_call_method( bus, "org.freedesktop.systemd1", "/org/freedesktop/systemd1", "org.freedesktop.systemd1.Manager", "ListUnits", - reply, - NULL, - DBUS_TYPE_INVALID); - if (r < 0) + &error, + &reply, + NULL); + if (r < 0) { + log_error("Failed to list units: %s", bus_error_message(&error, r)); return r; - - if (!dbus_message_iter_init(*reply, &iter) || - dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_ARRAY || - dbus_message_iter_get_element_type(&iter) != DBUS_TYPE_STRUCT) { - log_error("Failed to parse reply."); - return -EIO; } - dbus_message_iter_recurse(&iter, &sub); + r = sd_bus_message_enter_container(reply, SD_BUS_TYPE_ARRAY, "(ssssssouso)"); + if (r < 0) + return bus_log_parse_error(r); - while (dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_INVALID) { - if (!GREEDY_REALLOC(*unit_infos, size, *c + 1)) - return log_oom(); + while ((r = bus_parse_unit_info(reply, &u)) > 0) { - bus_parse_unit_info(&sub, *unit_infos + *c); - (*c)++; + if (!GREEDY_REALLOC(unit_infos, size, c+1)) + return log_oom(); - dbus_message_iter_next(&sub); + unit_infos[c++] = u; } + if (r < 0) + return bus_log_parse_error(r); - return 0; + r = sd_bus_message_exit_container(reply); + if (r < 0) + return bus_log_parse_error(r); + + *_reply = reply; + reply = NULL; + + *_unit_infos = unit_infos; + unit_infos = NULL; + + return c; } -static int list_units(DBusConnection *bus, char **args) { - _cleanup_dbus_message_unref_ DBusMessage *reply = NULL; - _cleanup_free_ struct unit_info *unit_infos = NULL; - unsigned c = 0; +static int list_units(sd_bus *bus, char **args) { + _cleanup_bus_message_unref_ sd_bus_message *reply = NULL; + _cleanup_free_ UnitInfo *unit_infos = NULL; int r; pager_open_if_enabled(); - r = get_unit_list(bus, &reply, &unit_infos, &c); + r = get_unit_list(bus, &reply, &unit_infos); if (r < 0) return r; - qsort_safe(unit_infos, c, sizeof(struct unit_info), compare_unit_info); - - output_units_list(unit_infos, c); + qsort_safe(unit_infos, r, sizeof(UnitInfo), compare_unit_info); + output_units_list(unit_infos, r); return 0; } static int get_triggered_units( - DBusConnection *bus, - const char* unit_path, - char*** triggered) { + sd_bus *bus, + const char* path, + char*** ret) { - const char *interface = "org.freedesktop.systemd1.Unit", - *triggers_property = "Triggers"; - _cleanup_dbus_message_unref_ DBusMessage *reply = NULL; - DBusMessageIter iter, sub; + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; int r; - r = bus_method_call_with_reply(bus, - "org.freedesktop.systemd1", - unit_path, - "org.freedesktop.DBus.Properties", - "Get", - &reply, - NULL, - DBUS_TYPE_STRING, &interface, - DBUS_TYPE_STRING, &triggers_property, - DBUS_TYPE_INVALID); - if (r < 0) - return r; - - if (!dbus_message_iter_init(reply, &iter) || - dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_VARIANT) { - log_error("Failed to parse reply."); - return -EBADMSG; - } - - dbus_message_iter_recurse(&iter, &sub); - dbus_message_iter_recurse(&sub, &iter); - sub = iter; - - while (dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_INVALID) { - const char *unit; - - if (dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_STRING) { - log_error("Failed to parse reply."); - return -EBADMSG; - } - - dbus_message_iter_get_basic(&sub, &unit); - r = strv_extend(triggered, unit); - if (r < 0) - return r; + r = sd_bus_get_property_strv( + bus, + "org.freedesktop.systemd1", + path, + "org.freedesktop.systemd1.Unit", + "Triggers", + &error, + ret); - dbus_message_iter_next(&sub); - } + if (r < 0) + log_error("Failed to determine triggers: %s", bus_error_message(&error, r)); return 0; } -static int get_listening(DBusConnection *bus, const char* unit_path, - char*** listen, unsigned *c) -{ - const char *interface = "org.freedesktop.systemd1.Socket", - *listen_property = "Listen"; - _cleanup_dbus_message_unref_ DBusMessage *reply = NULL; - DBusMessageIter iter, sub; +static int get_listening( + sd_bus *bus, + const char* unit_path, + char*** listening, + unsigned *c) { + + _cleanup_bus_message_unref_ sd_bus_message *reply = NULL; + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; + const char *type, *path; int r; - r = bus_method_call_with_reply(bus, - "org.freedesktop.systemd1", - unit_path, - "org.freedesktop.DBus.Properties", - "Get", - &reply, - NULL, - DBUS_TYPE_STRING, &interface, - DBUS_TYPE_STRING, &listen_property, - DBUS_TYPE_INVALID); - if (r < 0) + r = sd_bus_get_property( + bus, + "org.freedesktop.systemd1", + unit_path, + "org.freedesktop.systemd1.Socket", + "Listen", + &error, + &reply, + "a(ss)"); + if (r < 0) { + log_error("Failed to get list of listening sockets: %s", bus_error_message(&error, r)); return r; - - if (!dbus_message_iter_init(reply, &iter) || - dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_VARIANT) { - log_error("Failed to parse reply."); - return -EBADMSG; } - dbus_message_iter_recurse(&iter, &sub); - dbus_message_iter_recurse(&sub, &iter); - sub = iter; - - while (dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_INVALID) { - DBusMessageIter sub2; - const char *type, *path; - - if (dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_STRUCT) { - log_error("Failed to parse reply."); - return -EBADMSG; - } - - dbus_message_iter_recurse(&sub, &sub2); + r = sd_bus_message_enter_container(reply, SD_BUS_TYPE_ARRAY, "(ss)"); + if (r < 0) + return bus_log_parse_error(r); - if (bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &type, true) >= 0 && - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &path, false) >= 0) { - r = strv_extend(listen, type); - if (r < 0) - return r; + while ((r = sd_bus_message_read(reply, "(ss)", &type, &path)) > 0) { - r = strv_extend(listen, path); - if (r < 0) - return r; + r = strv_extend(listening, type); + if (r < 0) + return log_oom(); - (*c) ++; - } + r = strv_extend(listening, path); + if (r < 0) + return log_oom(); - dbus_message_iter_next(&sub); + (*c)++; } + if (r < 0) + return bus_log_parse_error(r); + + r = sd_bus_message_exit_container(reply); + if (r < 0) + return bus_log_parse_error(r); return 0; } @@ -609,9 +596,12 @@ struct socket_info { }; static int socket_info_compare(struct socket_info *a, struct socket_info *b) { - int o = strcmp(a->path, b->path); + int o; + + o = strcmp(a->path, b->path); if (o == 0) o = strcmp(a->type, b->type); + return o; } @@ -624,8 +614,8 @@ static int output_sockets_list(struct socket_info *socket_infos, unsigned cs) { const char *on, *off; for (s = socket_infos; s < socket_infos + cs; s++) { - char **a; unsigned tmp = 0; + char **a; socklen = MAX(socklen, strlen(s->id)); if (arg_show_types) @@ -678,11 +668,11 @@ static int output_sockets_list(struct socket_info *socket_infos, unsigned cs) { return 0; } -static int list_sockets(DBusConnection *bus, char **args) { - _cleanup_dbus_message_unref_ DBusMessage *reply = NULL; - _cleanup_free_ struct unit_info *unit_infos = NULL; +static int list_sockets(sd_bus *bus, char **args) { + _cleanup_bus_message_unref_ sd_bus_message *reply = NULL; + _cleanup_free_ UnitInfo *unit_infos = NULL; struct socket_info *socket_infos = NULL; - const struct unit_info *u; + const UnitInfo *u; struct socket_info *s; unsigned cu = 0, cs = 0; size_t size = 0; @@ -690,26 +680,27 @@ static int list_sockets(DBusConnection *bus, char **args) { pager_open_if_enabled(); - r = get_unit_list(bus, &reply, &unit_infos, &cu); + r = get_unit_list(bus, &reply, &unit_infos); if (r < 0) return r; + cu = (unsigned) r; + for (u = unit_infos; u < unit_infos + cu; u++) { - const char *dot; - _cleanup_strv_free_ char **listen = NULL, **triggered = NULL; + _cleanup_strv_free_ char **listening = NULL, **triggered = NULL; unsigned c = 0, i; if (!output_show_unit(u)) continue; - if ((dot = strrchr(u->id, '.')) && !streq(dot+1, "socket")) + if (!endswith(u->id, ".socket")) continue; r = get_triggered_units(bus, u->unit_path, &triggered); if (r < 0) goto cleanup; - r = get_listening(bus, u->unit_path, &listen, &c); + r = get_listening(bus, u->unit_path, &listening, &c); if (r < 0) goto cleanup; @@ -721,16 +712,16 @@ static int list_sockets(DBusConnection *bus, char **args) { for (i = 0; i < c; i++) socket_infos[cs + i] = (struct socket_info) { .id = u->id, - .type = listen[i*2], - .path = listen[i*2 + 1], + .type = listening[i*2], + .path = listening[i*2 + 1], .triggered = triggered, .own_triggered = i==0, }; /* from this point on we will cleanup those socket_infos */ cs += c; - free(listen); - listen = triggered = NULL; /* avoid cleanup */ + free(listening); + listening = triggered = NULL; /* avoid cleanup */ } qsort_safe(socket_infos, cs, sizeof(struct socket_info), @@ -781,6 +772,7 @@ static void output_unit_file_list(const UnitFileList *units, unsigned c) { max_id_len = sizeof("UNIT FILE")-1; state_cols = sizeof("STATE")-1; + for (u = units; u < units + c; u++) { if (!output_show_unit_file(u)) continue; @@ -791,6 +783,7 @@ static void output_unit_file_list(const UnitFileList *units, unsigned c) { if (!arg_full) { unsigned basic_cols; + id_cols = MIN(max_id_len, 25u); basic_cols = 1 + id_cols + state_cols; if (basic_cols < (unsigned) columns()) @@ -799,7 +792,9 @@ static void output_unit_file_list(const UnitFileList *units, unsigned c) { id_cols = max_id_len; if (!arg_no_legend) - printf("%-*s %-*s\n", id_cols, "UNIT FILE", state_cols, "STATE"); + printf("%-*s %-*s\n", + id_cols, "UNIT FILE", + state_cols, "STATE"); for (u = units; u < units + c; u++) { _cleanup_free_ char *e = NULL; @@ -836,11 +831,13 @@ static void output_unit_file_list(const UnitFileList *units, unsigned c) { printf("\n%u unit files listed.\n", n_shown); } -static int list_unit_files(DBusConnection *bus, char **args) { - _cleanup_dbus_message_unref_ DBusMessage *reply = NULL; +static int list_unit_files(sd_bus *bus, char **args) { + _cleanup_bus_message_unref_ sd_bus_message *reply = NULL; + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; _cleanup_free_ UnitFileList *units = NULL; - DBusMessageIter iter, sub, sub2; - unsigned c = 0, n_units = 0; + unsigned c = 0; + const char *state; + char *path; int r; pager_open_if_enabled(); @@ -849,6 +846,7 @@ static int list_unit_files(DBusConnection *bus, char **args) { Hashmap *h; UnitFileList *u; Iterator i; + unsigned n_units; h = hashmap_new(string_hash_func, string_compare_func); if (!h) @@ -873,61 +871,45 @@ static int list_unit_files(DBusConnection *bus, char **args) { free(u); } + assert(c == n_units); hashmap_free(h); } else { - r = bus_method_call_with_reply( + size_t size = 0; + + r = sd_bus_call_method( bus, "org.freedesktop.systemd1", "/org/freedesktop/systemd1", "org.freedesktop.systemd1.Manager", "ListUnitFiles", + &error, &reply, - NULL, - DBUS_TYPE_INVALID); - if (r < 0) + NULL); + if (r < 0) { + log_error("Failed to list unit files: %s", bus_error_message(&error, r)); return r; - - if (!dbus_message_iter_init(reply, &iter) || - dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_ARRAY || - dbus_message_iter_get_element_type(&iter) != DBUS_TYPE_STRUCT) { - log_error("Failed to parse reply."); - return -EIO; } - dbus_message_iter_recurse(&iter, &sub); - - while (dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_INVALID) { - UnitFileList *u; - const char *state; - - assert(dbus_message_iter_get_arg_type(&sub) == DBUS_TYPE_STRUCT); - - if (c >= n_units) { - UnitFileList *w; - - n_units = MAX(2*c, 16u); - w = realloc(units, sizeof(struct UnitFileList) * n_units); - if (!w) - return log_oom(); - - units = w; - } - - u = units + c; + r = sd_bus_message_enter_container(reply, SD_BUS_TYPE_ARRAY, "(ss)"); + if (r < 0) + return bus_log_parse_error(r); - dbus_message_iter_recurse(&sub, &sub2); + while ((r = sd_bus_message_read(reply, "(ss)", &path, &state)) > 0) { - if (bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &u->path, true) < 0 || - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &state, false) < 0) { - log_error("Failed to parse reply."); - return -EIO; - } - - u->state = unit_file_state_from_string(state); + if (!GREEDY_REALLOC(units, size, c + 1)) + return log_oom(); - dbus_message_iter_next(&sub); - c++; + units[c++] = (struct UnitFileList) { + path, + unit_file_state_from_string(state) + }; } + if (r < 0) + return bus_log_parse_error(r); + + r = sd_bus_message_exit_container(reply); + if (r < 0) + return bus_log_parse_error(r); } if (c > 0) { @@ -939,12 +921,13 @@ static int list_unit_files(DBusConnection *bus, char **args) { } static int list_dependencies_print(const char *name, int level, unsigned int branches, bool last) { - int i; _cleanup_free_ char *n = NULL; - size_t len = 0; size_t max_len = MAX(columns(),20u); + size_t len = 0; + int i; if (!arg_plain) { + for (i = level - 1; i >= 0; i--) { len += 2; if(len > max_len - 3 && !arg_full) { @@ -954,14 +937,16 @@ static int list_dependencies_print(const char *name, int level, unsigned int bra printf("%s", draw_special_char(branches & (1 << i) ? DRAW_TREE_VERT : DRAW_TREE_SPACE)); } len += 2; + if(len > max_len - 3 && !arg_full) { printf("%s...\n",max_len % 2 ? "" : " "); return 0; } + printf("%s", draw_special_char(last ? DRAW_TREE_RIGHT : DRAW_TREE_BRANCH)); } - if(arg_full){ + if (arg_full){ printf("%s\n", name); return 0; } @@ -974,7 +959,8 @@ static int list_dependencies_print(const char *name, int level, unsigned int bra return 0; } -static int list_dependencies_get_dependencies(DBusConnection *bus, const char *name, char ***deps) { +static int list_dependencies_get_dependencies(sd_bus *bus, const char *name, char ***deps) { + static const char *dependencies[] = { [DEPENDENCY_FORWARD] = "Requires\0" "RequiresOverridable\0" @@ -989,117 +975,109 @@ static int list_dependencies_get_dependencies(DBusConnection *bus, const char *n [DEPENDENCY_BEFORE] = "Before\0", }; - _cleanup_free_ char *path; - const char *interface = "org.freedesktop.systemd1.Unit"; - - _cleanup_dbus_message_unref_ DBusMessage *reply = NULL; - DBusMessageIter iter, sub, sub2, sub3; - - int r = 0; - char **ret = NULL; + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; + _cleanup_bus_message_unref_ sd_bus_message *reply = NULL; + _cleanup_strv_free_ char **ret = NULL; + _cleanup_free_ char *path = NULL; + int r; assert(bus); assert(name); assert(deps); + assert(arg_dependency < ELEMENTSOF(dependencies)); path = unit_dbus_path_from_name(name); - if (path == NULL) { - r = -EINVAL; - goto finish; - } - - r = bus_method_call_with_reply( - bus, - "org.freedesktop.systemd1", - path, - "org.freedesktop.DBus.Properties", - "GetAll", - &reply, - NULL, - DBUS_TYPE_STRING, &interface, - DBUS_TYPE_INVALID); - if (r < 0) - goto finish; + if (!path) + return log_oom(); - if (!dbus_message_iter_init(reply, &iter) || - dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_ARRAY || - dbus_message_iter_get_element_type(&iter) != DBUS_TYPE_DICT_ENTRY) { - log_error("Failed to parse reply."); - r = -EIO; - goto finish; + r = sd_bus_call_method( + bus, + "org.freedesktop.systemd1", + path, + "org.freedesktop.DBus.Properties", + "GetAll", + &error, + &reply, + "s", "org.freedesktop.systemd1.Unit"); + if (r < 0) { + log_error("Failed to get properties of %s: %s", name, bus_error_message(&error, r)); + return r; } - dbus_message_iter_recurse(&iter, &sub); + r = sd_bus_message_enter_container(reply, SD_BUS_TYPE_ARRAY, "{sv}"); + if (r < 0) + return bus_log_parse_error(r); - while (dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_INVALID) { + while ((r = sd_bus_message_enter_container(reply, SD_BUS_TYPE_DICT_ENTRY, "sv")) > 0) { const char *prop; - assert(dbus_message_iter_get_arg_type(&sub) == DBUS_TYPE_DICT_ENTRY); - dbus_message_iter_recurse(&sub, &sub2); + r = sd_bus_message_read(reply, "s", &prop); + if (r < 0) + return bus_log_parse_error(r); - if (bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &prop, true) < 0) { - log_error("Failed to parse reply."); - r = -EIO; - goto finish; - } + if (!nulstr_contains(dependencies[arg_dependency], prop)) { + r = sd_bus_message_skip(reply, "v"); + if (r < 0) + return bus_log_parse_error(r); + } else { - if (dbus_message_iter_get_arg_type(&sub2) != DBUS_TYPE_VARIANT) { - log_error("Failed to parse reply."); - r = -EIO; - goto finish; - } + r = sd_bus_message_enter_container(reply, SD_BUS_TYPE_VARIANT, "as"); + if (r < 0) + return bus_log_parse_error(r); - dbus_message_iter_recurse(&sub2, &sub3); - dbus_message_iter_next(&sub); + r = bus_message_read_strv_extend(reply, &ret); + if (r < 0) + return bus_log_parse_error(r); - assert(arg_dependency < ELEMENTSOF(dependencies)); - if (!nulstr_contains(dependencies[arg_dependency], prop)) - continue; + r = sd_bus_message_exit_container(reply); + if (r < 0) + return bus_log_parse_error(r); + } - if (dbus_message_iter_get_arg_type(&sub3) == DBUS_TYPE_ARRAY) { - if (dbus_message_iter_get_element_type(&sub3) == DBUS_TYPE_STRING) { - DBusMessageIter sub4; - dbus_message_iter_recurse(&sub3, &sub4); + r = sd_bus_message_exit_container(reply); + if (r < 0) + return bus_log_parse_error(r); - while (dbus_message_iter_get_arg_type(&sub4) != DBUS_TYPE_INVALID) { - const char *s; + } + if (r < 0) + return bus_log_parse_error(r); - assert(dbus_message_iter_get_arg_type(&sub4) == DBUS_TYPE_STRING); - dbus_message_iter_get_basic(&sub4, &s); + r = sd_bus_message_exit_container(reply); + if (r < 0) + return bus_log_parse_error(r); - r = strv_extend(&ret, s); - if (r < 0) { - log_oom(); - goto finish; - } + *deps = ret; + ret = NULL; - dbus_message_iter_next(&sub4); - } - } - } - } -finish: - if (r < 0) - strv_free(ret); - else - *deps = ret; - return r; + return 0; } static int list_dependencies_compare(const void *_a, const void *_b) { const char **a = (const char**) _a, **b = (const char**) _b; + if (unit_name_to_type(*a) == UNIT_TARGET && unit_name_to_type(*b) != UNIT_TARGET) return 1; if (unit_name_to_type(*a) != UNIT_TARGET && unit_name_to_type(*b) == UNIT_TARGET) return -1; + return strcasecmp(*a, *b); } -static int list_dependencies_one(DBusConnection *bus, const char *name, int level, char ***units, unsigned int branches) { +static int list_dependencies_one( + sd_bus *bus, + const char *name, + int level, + char ***units, + unsigned int branches) { + _cleanup_strv_free_ char **deps = NULL, **u; char **c; int r = 0; + assert(bus); + assert(name); + assert(units); + u = strv_append(*units, name); if (!u) return log_oom(); @@ -1130,17 +1108,19 @@ static int list_dependencies_one(DBusConnection *bus, const char *name, int leve return r; } } + if (arg_plain) { strv_free(*units); *units = u; u = NULL; } + return 0; } -static int list_dependencies(DBusConnection *bus, char **args) { - _cleanup_free_ char *unit = NULL; +static int list_dependencies(sd_bus *bus, char **args) { _cleanup_strv_free_ char **units = NULL; + _cleanup_free_ char *unit = NULL; const char *u; assert(bus); @@ -1160,67 +1140,55 @@ static int list_dependencies(DBusConnection *bus, char **args) { return list_dependencies_one(bus, u, 0, &units, 0); } -static int get_default(DBusConnection *bus, char **args) { - char *path = NULL; - _cleanup_dbus_message_unref_ DBusMessage *reply = NULL; +static int get_default(sd_bus *bus, char **args) { + _cleanup_bus_message_unref_ sd_bus_message *reply = NULL; + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; + _cleanup_free_ char *_path = NULL; + const char *path; int r; - _cleanup_dbus_error_free_ DBusError error; - - dbus_error_init(&error); if (!bus || avoid_bus()) { - r = unit_file_get_default(arg_scope, arg_root, &path); - + r = unit_file_get_default(arg_scope, arg_root, &_path); if (r < 0) { - log_error("Operation failed: %s", strerror(-r)); - goto finish; + log_error("Failed to get default target: %s", strerror(-r)); + return r; } + path = _path; - r = 0; } else { - r = bus_method_call_with_reply( - bus, - "org.freedesktop.systemd1", - "/org/freedesktop/systemd1", - "org.freedesktop.systemd1.Manager", - "GetDefaultTarget", - &reply, - NULL, - DBUS_TYPE_INVALID); - + r = sd_bus_call_method( + bus, + "org.freedesktop.systemd1", + "/org/freedesktop/systemd1", + "org.freedesktop.systemd1.Manager", + "GetDefaultTarget", + &error, + &reply, + NULL); if (r < 0) { - log_error("Operation failed: %s", strerror(-r)); - goto finish; + log_error("Failed to get default target: %s", bus_error_message(&error, -r)); + return r; } - if (!dbus_message_get_args(reply, &error, - DBUS_TYPE_STRING, &path, - DBUS_TYPE_INVALID)) { - log_error("Failed to parse reply: %s", bus_error_message(&error)); - dbus_error_free(&error); - return -EIO; - } + r = sd_bus_message_read(reply, "s", &path); + if (r < 0) + return bus_log_parse_error(r); } if (path) printf("%s\n", path); -finish: - if ((!bus || avoid_bus()) && path) - free(path); - - return r; - + return 0; } struct job_info { uint32_t id; - char *name, *type, *state; + const char *name, *type, *state; }; -static void list_jobs_print(struct job_info* jobs, size_t n) { - size_t i; - struct job_info *j; +static void output_jobs_list(const struct job_info* jobs, unsigned n) { + unsigned id_len, unit_len, type_len, state_len; + const struct job_info *j; const char *on, *off; bool shorten = false; @@ -1236,136 +1204,108 @@ static void list_jobs_print(struct job_info* jobs, size_t n) { pager_open_if_enabled(); - { - /* JOB UNIT TYPE STATE */ - unsigned l0 = 3, l1 = 4, l2 = 4, l3 = 5; + id_len = sizeof("JOB")-1; + unit_len = sizeof("UNIT")-1; + type_len = sizeof("TYPE")-1; + state_len = sizeof("STATE")-1; - for (i = 0, j = jobs; i < n; i++, j++) { - assert(j->name && j->type && j->state); - l0 = MAX(l0, DECIMAL_STR_WIDTH(j->id)); - l1 = MAX(l1, strlen(j->name)); - l2 = MAX(l2, strlen(j->type)); - l3 = MAX(l3, strlen(j->state)); - } + for (j = jobs; j < jobs + n; j++) { + uint32_t id = j->id; + assert(j->name && j->type && j->state); - if (!arg_full && l0 + 1 + l1 + l2 + 1 + l3 > columns()) { - l1 = MAX(33u, columns() - l0 - l2 - l3 - 3); - shorten = true; - } + id_len = MAX(id_len, DECIMAL_STR_WIDTH(id)); + unit_len = MAX(unit_len, strlen(j->name)); + type_len = MAX(type_len, strlen(j->type)); + state_len = MAX(state_len, strlen(j->state)); + } + + if (!arg_full && id_len + 1 + unit_len + type_len + 1 + state_len > columns()) { + unit_len = MAX(33u, columns() - id_len - type_len - state_len - 3); + shorten = true; + } - if (on_tty()) - printf("%*s %-*s %-*s %-*s\n", - l0, "JOB", - l1, "UNIT", - l2, "TYPE", - l3, "STATE"); + printf("%*s %-*s %-*s %-*s\n", + id_len, "JOB", + unit_len, "UNIT", + type_len, "TYPE", + state_len, "STATE"); - for (i = 0, j = jobs; i < n; i++, j++) { - _cleanup_free_ char *e = NULL; + for (j = jobs; j < jobs + n; j++) { + _cleanup_free_ char *e = NULL; - if (streq(j->state, "running")) { - on = ansi_highlight(); - off = ansi_highlight_off(); - } else - on = off = ""; - - e = shorten ? ellipsize(j->name, l1, 33) : NULL; - printf("%*u %s%-*s%s %-*s %s%-*s%s\n", - l0, j->id, - on, l1, e ? e : j->name, off, - l2, j->type, - on, l3, j->state, off); - } + if (streq(j->state, "running")) { + on = ansi_highlight(); + off = ansi_highlight_off(); + } else + on = off = ""; + + e = shorten ? ellipsize(j->name, unit_len, 33) : NULL; + printf("%*u %s%-*s%s %-*s %s%-*s%s\n", + id_len, j->id, + on, unit_len, e ? e : j->name, off, + type_len, j->type, + on, state_len, j->state, off); } on = ansi_highlight(); off = ansi_highlight_off(); - if (on_tty()) - printf("\n%s%zu jobs listed%s.\n", on, n, off); + printf("\n%s%u jobs listed%s.\n", on, n, off); } -static int list_jobs(DBusConnection *bus, char **args) { - _cleanup_dbus_message_unref_ DBusMessage *reply = NULL; - DBusMessageIter iter, sub, sub2; +static int list_jobs(sd_bus *bus, char **args) { + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; + _cleanup_bus_message_unref_ sd_bus_message *reply = NULL; + const char *name, *type, *state, *job_path, *unit_path; + _cleanup_free_ struct job_info *jobs = NULL; + size_t size = 0; + unsigned c = 0; + uint32_t id; int r; - struct job_info *jobs = NULL; - size_t size = 0, used = 0; - r = bus_method_call_with_reply( + r = sd_bus_call_method( bus, "org.freedesktop.systemd1", "/org/freedesktop/systemd1", "org.freedesktop.systemd1.Manager", "ListJobs", + &error, &reply, - NULL, - DBUS_TYPE_INVALID); - if (r < 0) + NULL); + if (r < 0) { + log_error("Failed to list jobs: %s", bus_error_message(&error, r)); return r; - - if (!dbus_message_iter_init(reply, &iter) || - dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_ARRAY || - dbus_message_iter_get_element_type(&iter) != DBUS_TYPE_STRUCT) { - log_error("Failed to parse reply."); - return -EIO; } - dbus_message_iter_recurse(&iter, &sub); - - while (dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_INVALID) { - const char *name, *type, *state, *job_path, *unit_path; - uint32_t id; - - if (dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_STRUCT) { - log_error("Failed to parse reply."); - return -EIO; - } - - dbus_message_iter_recurse(&sub, &sub2); - - if (bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_UINT32, &id, true) < 0 || - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &name, true) < 0 || - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &type, true) < 0 || - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &state, true) < 0 || - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_OBJECT_PATH, &job_path, true) < 0 || - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_OBJECT_PATH, &unit_path, false) < 0) { - log_error("Failed to parse reply."); - r = -EIO; - goto finish; - } + r = sd_bus_message_enter_container(reply, 'a', "(usssoo)"); + if (r < 0) + return bus_log_parse_error(r); - if (!GREEDY_REALLOC(jobs, size, used + 1)) { - r = log_oom(); - goto finish; - } + while ((r = sd_bus_message_read(reply, "(usssoo)", &id, &name, &type, &state, &job_path, &unit_path)) > 0) { - jobs[used++] = (struct job_info) { id, - strdup(name), - strdup(type), - strdup(state) }; - if (!jobs[used-1].name || !jobs[used-1].type || !jobs[used-1].state) { - r = log_oom(); - goto finish; - } + if (!GREEDY_REALLOC(jobs, size, c + 1)) + return log_oom(); - dbus_message_iter_next(&sub); + jobs[c++] = (struct job_info) { + id, + name, + type, + state + }; } + if (r < 0) + return bus_log_parse_error(r); - list_jobs_print(jobs, used); - - finish: - while (used--) { - free(jobs[used].name); - free(jobs[used].type); - free(jobs[used].state); - } - free(jobs); + r = sd_bus_message_exit_container(reply); + if (r < 0) + return bus_log_parse_error(r); - return 0; + output_jobs_list(jobs, c); + return r; } -static int cancel_job(DBusConnection *bus, char **args) { +static int cancel_job(sd_bus *bus, char **args) { + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; char **name; assert(args); @@ -1379,91 +1319,71 @@ static int cancel_job(DBusConnection *bus, char **args) { r = safe_atou32(*name, &id); if (r < 0) { - log_error("Failed to parse job id: %s", strerror(-r)); + log_error("Failed to parse job id \"%s\": %s", *name, strerror(-r)); return r; } - r = bus_method_call_with_reply( + r = sd_bus_call_method( bus, "org.freedesktop.systemd1", "/org/freedesktop/systemd1", "org.freedesktop.systemd1.Manager", "CancelJob", + &error, NULL, - NULL, - DBUS_TYPE_UINT32, &id, - DBUS_TYPE_INVALID); - if (r < 0) + "u", id); + if (r < 0) { + log_error("Failed to cancel job %u: %s", (unsigned) id, bus_error_message(&error, r)); return r; + } } return 0; } -static int need_daemon_reload(DBusConnection *bus, const char *unit) { - _cleanup_dbus_message_unref_ DBusMessage *reply = NULL; - _cleanup_dbus_error_free_ DBusError error; - dbus_bool_t b = FALSE; - DBusMessageIter iter, sub; - const char - *interface = "org.freedesktop.systemd1.Unit", - *property = "NeedDaemonReload", - *path; +static int need_daemon_reload(sd_bus *bus, const char *unit) { + _cleanup_bus_message_unref_ sd_bus_message *reply = NULL; _cleanup_free_ char *n = NULL; - int r; - - dbus_error_init(&error); + const char *path; + int b, r; - /* We ignore all errors here, since this is used to show a warning only */ + /* We ignore all errors here, since this is used to show a + * warning only */ n = unit_name_mangle(unit); if (!n) - return log_oom(); + return -ENOMEM; + + /* We don't use unit_dbus_path_from_name() directly since we + * don't want to load the unit if it isn't loaded. */ - r = bus_method_call_with_reply( + r = sd_bus_call_method( bus, "org.freedesktop.systemd1", "/org/freedesktop/systemd1", "org.freedesktop.systemd1.Manager", "GetUnit", + NULL, &reply, - &error, - DBUS_TYPE_STRING, &n, - DBUS_TYPE_INVALID); + "s", n); if (r < 0) return r; - if (!dbus_message_get_args(reply, NULL, - DBUS_TYPE_OBJECT_PATH, &path, - DBUS_TYPE_INVALID)) - return -EIO; - - dbus_message_unref(reply); - reply = NULL; + r = sd_bus_message_read(reply, "o", &path); + if (r < 0) + return r; - r = bus_method_call_with_reply( + r = sd_bus_get_property_trivial( bus, "org.freedesktop.systemd1", path, - "org.freedesktop.DBus.Properties", - "Get", - &reply, - &error, - DBUS_TYPE_STRING, &interface, - DBUS_TYPE_STRING, &property, - DBUS_TYPE_INVALID); + "org.freedesktop.systemd1.Unit", + "NeedDaemonReload", + NULL, + 'b', &b); if (r < 0) return r; - if (!dbus_message_iter_init(reply, &iter) || - dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_VARIANT) - return -EIO; - - dbus_message_iter_recurse(&iter, &sub); - if (dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_BOOLEAN) - return -EIO; - - dbus_message_iter_get_basic(&sub, &b); return b; } @@ -1474,42 +1394,34 @@ typedef struct WaitData { char *result; } WaitData; -static DBusHandlerResult wait_filter(DBusConnection *connection, DBusMessage *message, void *data) { - _cleanup_dbus_error_free_ DBusError error; +static int wait_filter(sd_bus *bus, sd_bus_message *m, void *data) { WaitData *d = data; - dbus_error_init(&error); - - assert(connection); - assert(message); + assert(bus); + assert(m); assert(d); log_debug("Got D-Bus request: %s.%s() on %s", - dbus_message_get_interface(message), - dbus_message_get_member(message), - dbus_message_get_path(message)); + sd_bus_message_get_interface(m), + sd_bus_message_get_member(m), + sd_bus_message_get_path(m)); - if (dbus_message_is_signal(message, DBUS_INTERFACE_LOCAL, "Disconnected")) { + if (sd_bus_message_is_signal(m, "org.freedesktop.DBus.Local", "Disconnected")) { log_error("Warning! D-Bus connection terminated."); - dbus_connection_close(connection); - - } else if (dbus_message_is_signal(message, "org.freedesktop.systemd1.Manager", "JobRemoved")) { + sd_bus_close(bus); + } else if (sd_bus_message_is_signal(m, "org.freedesktop.systemd1.Manager", "JobRemoved")) { uint32_t id; const char *path, *result, *unit; - char *r; - - if (dbus_message_get_args(message, &error, - DBUS_TYPE_UINT32, &id, - DBUS_TYPE_OBJECT_PATH, &path, - DBUS_TYPE_STRING, &unit, - DBUS_TYPE_STRING, &result, - DBUS_TYPE_INVALID)) { + char *ret; + int r; - r = set_remove(d->set, (char*) path); - if (!r) - return DBUS_HANDLER_RESULT_NOT_YET_HANDLED; + r = sd_bus_message_read(m, "uoss", &id, &path, &unit, &result); + if (r >= 0) { + ret = set_remove(d->set, (char*) path); + if (!ret) + return 0; - free(r); + free(ret); if (!isempty(result)) d->result = strdup(result); @@ -1517,57 +1429,45 @@ static DBusHandlerResult wait_filter(DBusConnection *connection, DBusMessage *me if (!isempty(unit)) d->name = strdup(unit); - return DBUS_HANDLER_RESULT_NOT_YET_HANDLED; + return 0; } #ifndef NOLEGACY - dbus_error_free(&error); - if (dbus_message_get_args(message, &error, - DBUS_TYPE_UINT32, &id, - DBUS_TYPE_OBJECT_PATH, &path, - DBUS_TYPE_STRING, &result, - DBUS_TYPE_INVALID)) { - /* Compatibility with older systemd versions < - * 183 during upgrades. This should be dropped - * one day. */ - r = set_remove(d->set, (char*) path); - if (!r) - return DBUS_HANDLER_RESULT_NOT_YET_HANDLED; - - free(r); + r = sd_bus_message_read(m, "uos", &id, &path, &result); + if (r >= 0) { + ret = set_remove(d->set, (char*) path); + if (!ret) + return 0; + + free(ret); if (*result) d->result = strdup(result); - return DBUS_HANDLER_RESULT_NOT_YET_HANDLED; + return 0; } #endif - log_error("Failed to parse message: %s", bus_error_message(&error)); + log_error("Failed to parse message."); } - return DBUS_HANDLER_RESULT_NOT_YET_HANDLED; + return 0; } -static int enable_wait_for_jobs(DBusConnection *bus) { - DBusError error; +static int enable_wait_for_jobs(sd_bus *bus) { + int r; assert(bus); - if (private_bus) - return 0; - - dbus_error_init(&error); - dbus_bus_add_match(bus, - "type='signal'," - "sender='org.freedesktop.systemd1'," - "interface='org.freedesktop.systemd1.Manager'," - "member='JobRemoved'," - "path='/org/freedesktop/systemd1'", - &error); - - if (dbus_error_is_set(&error)) { - log_error("Failed to add match: %s", bus_error_message(&error)); - dbus_error_free(&error); + r = sd_bus_add_match( + bus, + "type='signal'," + "sender='org.freedesktop.systemd1'," + "interface='org.freedesktop.systemd1.Manager'," + "member='JobRemoved'," + "path='/org/freedesktop/systemd1'", + NULL, NULL); + if (r < 0) { + log_error("Failed to add match"); return -EIO; } @@ -1575,21 +1475,27 @@ static int enable_wait_for_jobs(DBusConnection *bus) { return 0; } -static int wait_for_jobs(DBusConnection *bus, Set *s) { - int r = 0; +static int wait_for_jobs(sd_bus *bus, Set *s) { WaitData d = { .set = s }; + int r; assert(bus); assert(s); - if (!dbus_connection_add_filter(bus, wait_filter, &d, NULL)) + r = sd_bus_add_filter(bus, wait_filter, &d); + if (r < 0) return log_oom(); while (!set_isempty(s)) { - - if (!dbus_connection_read_write_dispatch(bus, -1)) { - log_error("Disconnected from bus."); - return -ECONNREFUSED; + for(;;) { + r = sd_bus_process(bus, NULL); + if (r < 0) + return r; + if (r > 0) + break; + r = sd_bus_wait(bus, (uint64_t) -1); + if (r < 0) + return r; } if (!d.result) @@ -1621,220 +1527,141 @@ static int wait_for_jobs(DBusConnection *bus, Set *s) { d.name = NULL; } - dbus_connection_remove_filter(bus, wait_filter, &d); - return r; + return sd_bus_remove_filter(bus, wait_filter, &d); } -static int check_one_unit(DBusConnection *bus, const char *name, char **check_states, bool quiet) { - _cleanup_dbus_message_unref_ DBusMessage *reply = NULL; - _cleanup_free_ char *n = NULL; - DBusMessageIter iter, sub; - const char - *interface = "org.freedesktop.systemd1.Unit", - *property = "ActiveState"; - const char *state, *path; - DBusError error; +static int check_one_unit(sd_bus *bus, const char *name, const char *good_states, bool quiet) { + _cleanup_bus_message_unref_ sd_bus_message *reply = NULL; + _cleanup_free_ char *n = NULL, *state = NULL; + const char *path; int r; assert(name); - dbus_error_init(&error); - n = unit_name_mangle(name); if (!n) return log_oom(); - r = bus_method_call_with_reply ( + /* We don't use unit_dbus_path_from_name() directly since we + * don't want to load the unit if it isn't loaded. */ + + r = sd_bus_call_method( bus, "org.freedesktop.systemd1", "/org/freedesktop/systemd1", "org.freedesktop.systemd1.Manager", "GetUnit", + NULL, &reply, - &error, - DBUS_TYPE_STRING, &n, - DBUS_TYPE_INVALID); + "s", n); if (r < 0) { - dbus_error_free(&error); - if (!quiet) puts("unknown"); return 0; } - if (!dbus_message_get_args(reply, NULL, - DBUS_TYPE_OBJECT_PATH, &path, - DBUS_TYPE_INVALID)) { - log_error("Failed to parse reply."); - return -EIO; - } - - dbus_message_unref(reply); - reply = NULL; + r = sd_bus_message_read(reply, "o", &path); + if (r < 0) + return bus_log_parse_error(r); - r = bus_method_call_with_reply( + r = sd_bus_get_property_string( bus, "org.freedesktop.systemd1", path, - "org.freedesktop.DBus.Properties", - "Get", - &reply, + "org.freedesktop.systemd1.Unit", + "ActiveState", NULL, - DBUS_TYPE_STRING, &interface, - DBUS_TYPE_STRING, &property, - DBUS_TYPE_INVALID); + &state); if (r < 0) { if (!quiet) puts("unknown"); return 0; } - if (!dbus_message_iter_init(reply, &iter) || - dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_VARIANT) { - log_error("Failed to parse reply."); - return r; - } - - dbus_message_iter_recurse(&iter, &sub); - - if (dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_STRING) { - log_error("Failed to parse reply."); - return r; - } - - dbus_message_iter_get_basic(&sub, &state); - if (!quiet) puts(state); - return strv_find(check_states, state) ? 1 : 0; + return nulstr_contains(good_states, state); } -static void check_triggering_units( - DBusConnection *bus, - const char *unit_name) { - - _cleanup_dbus_message_unref_ DBusMessage *reply = NULL; - DBusMessageIter iter, sub; - const char *interface = "org.freedesktop.systemd1.Unit", - *load_state_property = "LoadState", - *triggered_by_property = "TriggeredBy", - *state; - _cleanup_free_ char *unit_path = NULL, *n = NULL; +static int check_triggering_units( + sd_bus *bus, + const char *name) { + + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; + _cleanup_free_ char *path = NULL, *n = NULL, *state = NULL; + _cleanup_strv_free_ char **triggered_by = NULL; bool print_warning_label = true; + char **i; int r; - n = unit_name_mangle(unit_name); - if (!n) { - log_oom(); - return; - } + n = unit_name_mangle(name); + if (!n) + return log_oom(); - unit_path = unit_dbus_path_from_name(n); - if (!unit_path) { - log_oom(); - return; - } + path = unit_dbus_path_from_name(n); + if (!path) + return log_oom(); - r = bus_method_call_with_reply( + r = sd_bus_get_property_string( bus, "org.freedesktop.systemd1", - unit_path, - "org.freedesktop.DBus.Properties", - "Get", - &reply, - NULL, - DBUS_TYPE_STRING, &interface, - DBUS_TYPE_STRING, &load_state_property, - DBUS_TYPE_INVALID); - if (r < 0) - return; - - if (!dbus_message_iter_init(reply, &iter) || - dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_VARIANT) { - log_error("Failed to parse reply."); - return; - } - - dbus_message_iter_recurse(&iter, &sub); - - if (dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_STRING) { - log_error("Failed to parse reply."); - return; + path, + "org.freedesktop.systemd1.Unit", + "LoadState", + &error, + &state); + if (r < 0) { + log_error("Failed to get load state of %s: %s", n, bus_error_message(&error, r)); + return r; } - dbus_message_iter_get_basic(&sub, &state); - if (streq(state, "masked")) - return; - - dbus_message_unref(reply); - reply = NULL; + return 0; - r = bus_method_call_with_reply( + r = sd_bus_get_property_strv( bus, "org.freedesktop.systemd1", - unit_path, - "org.freedesktop.DBus.Properties", - "Get", - &reply, - NULL, - DBUS_TYPE_STRING, &interface, - DBUS_TYPE_STRING, &triggered_by_property, - DBUS_TYPE_INVALID); - if (r < 0) - return; - - if (!dbus_message_iter_init(reply, &iter) || - dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_VARIANT) { - log_error("Failed to parse reply."); - return; + path, + "org.freedesktop.systemd1.Unit", + "TriggeredBy", + &error, + &triggered_by); + if (r < 0) { + log_error("Failed to get triggered by array of %s: %s", n, bus_error_message(&error, r)); + return r; } - dbus_message_iter_recurse(&iter, &sub); - dbus_message_iter_recurse(&sub, &iter); - sub = iter; - - while (dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_INVALID) { - const char * const check_states[] = { - "active", - "reloading", - NULL - }; - const char *service_trigger; - - if (dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_STRING) { - log_error("Failed to parse reply."); - return; + STRV_FOREACH(i, triggered_by) { + r = check_one_unit(bus, *i, "active\0reloading\0", true); + if (r < 0) { + log_error("Failed to check unit: %s", strerror(-r)); + return r; } - dbus_message_iter_get_basic(&sub, &service_trigger); - - r = check_one_unit(bus, service_trigger, (char**) check_states, true); - if (r < 0) - return; - if (r > 0) { - if (print_warning_label) { - log_warning("Warning: Stopping %s, but it can still be activated by:", unit_name); - print_warning_label = false; - } + if (r == 0) + continue; - log_warning(" %s", service_trigger); + if (print_warning_label) { + log_warning("Warning: Stopping %s, but it can still be activated by:", n); + print_warning_label = false; } - dbus_message_iter_next(&sub); + log_warning(" %s", *i); } + + return 0; } static int start_unit_one( - DBusConnection *bus, + sd_bus *bus, const char *method, const char *name, const char *mode, - DBusError *error, + sd_bus_error *error, Set *s) { - _cleanup_dbus_message_unref_ DBusMessage *reply = NULL; + _cleanup_bus_message_unref_ sd_bus_message *reply = NULL; _cleanup_free_ char *n; const char *path; int r; @@ -1848,38 +1675,32 @@ static int start_unit_one( if (!n) return log_oom(); - r = bus_method_call_with_reply( + r = sd_bus_call_method( bus, "org.freedesktop.systemd1", "/org/freedesktop/systemd1", "org.freedesktop.systemd1.Manager", method, - &reply, error, - DBUS_TYPE_STRING, &n, - DBUS_TYPE_STRING, &mode, - DBUS_TYPE_INVALID); - if (r) { + &reply, + "ss", n, mode); + if (r < 0) { if (r == -ENOENT && arg_action != ACTION_SYSTEMCTL) /* There's always a fallback possible for * legacy actions. */ - r = -EADDRNOTAVAIL; - else - log_error("Failed to issue method call: %s", bus_error_message(error)); + return -EADDRNOTAVAIL; + log_error("Failed to start %s: %s", name, bus_error_message(error, r)); return r; } - if (!dbus_message_get_args(reply, error, - DBUS_TYPE_OBJECT_PATH, &path, - DBUS_TYPE_INVALID)) { - log_error("Failed to parse reply: %s", bus_error_message(error)); - return -EIO; - } + r = sd_bus_message_read(reply, "o", &path); + if (r < 0) + return bus_log_parse_error(r); if (need_daemon_reload(bus, n) > 0) - log_warning("Warning: Unit file of %s changed on disk, 'systemctl %sdaemon-reload' recommended.", - n, arg_scope == UNIT_FILE_SYSTEM ? "" : "--user "); + log_warning("Warning: Unit file of %s changed on disk, 'systemctl%s daemon-reload' recommended.", + n, arg_scope == UNIT_FILE_SYSTEM ? "" : " --user"); if (s) { char *p; @@ -1889,10 +1710,8 @@ static int start_unit_one( return log_oom(); r = set_consume(s, p); - if (r < 0) { - log_error("Failed to add path to set."); - return r; - } + if (r < 0) + return log_oom(); } return 0; @@ -1923,21 +1742,19 @@ static const struct { static enum action verb_to_action(const char *verb) { enum action i; - for (i = ACTION_INVALID; i < _ACTION_MAX; i++) - if (action_table[i].verb && streq(verb, action_table[i].verb)) + for (i = _ACTION_INVALID; i < _ACTION_MAX; i++) + if (streq_ptr(action_table[i].verb, verb)) return i; - return ACTION_INVALID; -} -static int start_unit(DBusConnection *bus, char **args) { + return _ACTION_INVALID; +} - int r, ret = 0; - const char *method, *mode, *one_name; +static int start_unit(sd_bus *bus, char **args) { + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; _cleanup_set_free_free_ Set *s = NULL; - _cleanup_dbus_error_free_ DBusError error; + const char *method, *mode, *one_name; char **name; - - dbus_error_init(&error); + int r; assert(bus); @@ -1957,8 +1774,7 @@ static int start_unit(DBusConnection *bus, char **args) { streq(args[0], "reload-or-restart") ? "ReloadOrRestartUnit" : streq(args[0], "reload-or-try-restart") || - streq(args[0], "condreload") || - + streq(args[0], "condreload") || streq(args[0], "force-reload") ? "ReloadOrTryRestartUnit" : "StartUnit"; action = verb_to_action(args[0]); @@ -1967,7 +1783,6 @@ static int start_unit(DBusConnection *bus, char **args) { action_table[action].mode ?: arg_job_mode; one_name = action_table[action].target; - } else { assert(arg_action < ELEMENTSOF(action_table)); assert(action_table[arg_action].target); @@ -1979,10 +1794,10 @@ static int start_unit(DBusConnection *bus, char **args) { } if (!arg_no_block) { - ret = enable_wait_for_jobs(bus); - if (ret < 0) { - log_error("Could not watch jobs: %s", strerror(-ret)); - return ret; + r = enable_wait_for_jobs(bus); + if (r < 0) { + log_error("Could not watch jobs: %s", strerror(-r)); + return r; } s = set_new(string_hash_func, string_compare_func); @@ -1991,23 +1806,29 @@ static int start_unit(DBusConnection *bus, char **args) { } if (one_name) { - ret = start_unit_one(bus, method, one_name, mode, &error, s); - if (ret < 0) - ret = translate_bus_error_to_exit_status(ret, &error); + r = start_unit_one(bus, method, one_name, mode, &error, s); + if (r < 0) + r = translate_bus_error_to_exit_status(r, &error); } else { + r = 0; + STRV_FOREACH(name, args+1) { - r = start_unit_one(bus, method, *name, mode, &error, s); - if (r < 0) { - ret = translate_bus_error_to_exit_status(r, &error); - dbus_error_free(&error); + int q; + + q = start_unit_one(bus, method, *name, mode, &error, s); + if (q < 0) { + r = translate_bus_error_to_exit_status(r, &error); + sd_bus_error_free(&error); } } } if (!arg_no_block) { - r = wait_for_jobs(bus, s); - if (r < 0) - return r; + int q; + + q = wait_for_jobs(bus, s); + if (q < 0) + return q; /* When stopping units, warn if they can still be triggered by * another active unit (socket, path, timer) */ @@ -2020,15 +1841,16 @@ static int start_unit(DBusConnection *bus, char **args) { } } - return ret; + return r; } /* Ask systemd-logind, which might grant access to unprivileged users * through PolicyKit */ -static int reboot_with_logind(DBusConnection *bus, enum action a) { +static int reboot_with_logind(sd_bus *bus, enum action a) { #ifdef HAVE_LOGIND + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; const char *method; - dbus_bool_t interactive = true; + int r; if (!bus) return -EIO; @@ -2061,29 +1883,34 @@ static int reboot_with_logind(DBusConnection *bus, enum action a) { return -EINVAL; } - return bus_method_call_with_reply( + r = sd_bus_call_method( bus, "org.freedesktop.login1", "/org/freedesktop/login1", "org.freedesktop.login1.Manager", method, + &error, NULL, - NULL, - DBUS_TYPE_BOOLEAN, &interactive, - DBUS_TYPE_INVALID); + "b", true); + if (r < 0) + log_error("Failed to execute operation: %s", bus_error_message(&error, r)); + + return r; #else return -ENOSYS; #endif } -static int check_inhibitors(DBusConnection *bus, enum action a) { +static int check_inhibitors(sd_bus *bus, enum action a) { #ifdef HAVE_LOGIND - _cleanup_dbus_message_unref_ DBusMessage *reply = NULL; - DBusMessageIter iter, sub, sub2; - int r; - unsigned c = 0; + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; + _cleanup_bus_message_unref_ sd_bus_message *reply = NULL; _cleanup_strv_free_ char **sessions = NULL; + const char *what, *who, *why, *mode; + uint32_t uid, pid; + unsigned c = 0; char **s; + int r; if (!bus) return 0; @@ -2100,52 +1927,29 @@ static int check_inhibitors(DBusConnection *bus, enum action a) { if (!on_tty()) return 0; - r = bus_method_call_with_reply( + r = sd_bus_call_method( bus, "org.freedesktop.login1", "/org/freedesktop/login1", "org.freedesktop.login1.Manager", "ListInhibitors", - &reply, NULL, - DBUS_TYPE_INVALID); + &reply, + NULL); if (r < 0) /* If logind is not around, then there are no inhibitors... */ return 0; - if (!dbus_message_iter_init(reply, &iter) || - dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_ARRAY || - dbus_message_iter_get_element_type(&iter) != DBUS_TYPE_STRUCT) { - log_error("Failed to parse reply."); - return -EIO; - } + r = sd_bus_message_enter_container(reply, SD_BUS_TYPE_ARRAY, "(ssssuu)"); + if (r < 0) + return bus_log_parse_error(r); - dbus_message_iter_recurse(&iter, &sub); - while (dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_INVALID) { - const char *what, *who, *why, *mode; - uint32_t uid, pid; - _cleanup_strv_free_ char **sv = NULL; + while ((r = sd_bus_message_read(reply, "(ssssuu)", &what, &who, &why, &mode, &uid, &pid)) > 0) { _cleanup_free_ char *comm = NULL, *user = NULL; - - if (dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_STRUCT) { - log_error("Failed to parse reply."); - return -EIO; - } - - dbus_message_iter_recurse(&sub, &sub2); - - if (bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &what, true) < 0 || - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &who, true) < 0 || - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &why, true) < 0 || - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &mode, true) < 0 || - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_UINT32, &uid, true) < 0 || - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_UINT32, &pid, false) < 0) { - log_error("Failed to parse reply."); - return -EIO; - } + _cleanup_strv_free_ char **sv = NULL; if (!streq(mode, "block")) - goto next; + continue; sv = strv_split(what, ":"); if (!sv) @@ -2156,24 +1960,26 @@ static int check_inhibitors(DBusConnection *bus, enum action a) { a == ACTION_POWEROFF || a == ACTION_REBOOT || a == ACTION_KEXEC ? "shutdown" : "sleep")) - goto next; + continue; get_process_comm(pid, &comm); user = uid_to_name(uid); + log_warning("Operation inhibited by \"%s\" (PID %lu \"%s\", user %s), reason is \"%s\".", who, (unsigned long) pid, strna(comm), strna(user), why); - c++; - next: - dbus_message_iter_next(&sub); + c++; } + if (r < 0) + return bus_log_parse_error(r); - dbus_message_iter_recurse(&iter, &sub); + r = sd_bus_message_exit_container(reply); + if (r < 0) + return bus_log_parse_error(r); /* Check for current sessions */ sd_get_sessions(&sessions); STRV_FOREACH(s, sessions) { - uid_t uid; _cleanup_free_ char *type = NULL, *tty = NULL, *seat = NULL, *user = NULL, *service = NULL, *class = NULL; if (sd_session_get_uid(*s, &uid) < 0 || uid == getuid()) @@ -2206,7 +2012,7 @@ static int check_inhibitors(DBusConnection *bus, enum action a) { #endif } -static int start_special(DBusConnection *bus, char **args) { +static int start_special(sd_bus *bus, char **args) { enum action a; int r; @@ -2227,7 +2033,7 @@ static int start_special(DBusConnection *bus, char **args) { (a == ACTION_HALT || a == ACTION_POWEROFF || a == ACTION_REBOOT)) - halt_now(a); + return halt_now(a); if (arg_force >= 1 && (a == ACTION_HALT || @@ -2256,13 +2062,7 @@ static int start_special(DBusConnection *bus, char **args) { return r; } -static int check_unit_active(DBusConnection *bus, char **args) { - const char * const check_states[] = { - "active", - "reloading", - NULL - }; - +static int check_unit_active(sd_bus *bus, char **args) { char **name; int r = 3; /* According to LSB: "program is not running" */ @@ -2272,7 +2072,7 @@ static int check_unit_active(DBusConnection *bus, char **args) { STRV_FOREACH(name, args+1) { int state; - state = check_one_unit(bus, *name, (char**) check_states, arg_quiet); + state = check_one_unit(bus, *name, "active\0reloading\0", arg_quiet); if (state < 0) return state; if (state > 0) @@ -2282,12 +2082,7 @@ static int check_unit_active(DBusConnection *bus, char **args) { return r; } -static int check_unit_failed(DBusConnection *bus, char **args) { - const char * const check_states[] = { - "failed", - NULL - }; - +static int check_unit_failed(sd_bus *bus, char **args) { char **name; int r = 1; @@ -2297,7 +2092,7 @@ static int check_unit_failed(DBusConnection *bus, char **args) { STRV_FOREACH(name, args+1) { int state; - state = check_one_unit(bus, *name, (char**) check_states, arg_quiet); + state = check_one_unit(bus, *name, "failed\0", arg_quiet); if (state < 0) return state; if (state > 0) @@ -2307,7 +2102,8 @@ static int check_unit_failed(DBusConnection *bus, char **args) { return r; } -static int kill_unit(DBusConnection *bus, char **args) { +static int kill_unit(sd_bus *bus, char **args) { + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; char **name; int r = 0; @@ -2324,21 +2120,21 @@ static int kill_unit(DBusConnection *bus, char **args) { if (!n) return log_oom(); - r = bus_method_call_with_reply( + r = sd_bus_call_method( bus, "org.freedesktop.systemd1", "/org/freedesktop/systemd1", "org.freedesktop.systemd1.Manager", "KillUnit", + &error, NULL, - NULL, - DBUS_TYPE_STRING, &n, - DBUS_TYPE_STRING, &arg_kill_who, - DBUS_TYPE_INT32, &arg_signal, - DBUS_TYPE_INVALID); - if (r < 0) + "ssi", n, arg_kill_who, arg_signal); + if (r < 0) { + log_error("Failed to kill unit %s: %s", n, bus_error_message(&error, r)); return r; + } } + return 0; } @@ -2368,72 +2164,43 @@ static void exec_status_info_free(ExecStatusInfo *i) { free(i); } -static int exec_status_info_deserialize(DBusMessageIter *sub, ExecStatusInfo *i) { +static int exec_status_info_deserialize(sd_bus_message *m, ExecStatusInfo *i) { uint64_t start_timestamp, exit_timestamp, start_timestamp_monotonic, exit_timestamp_monotonic; - DBusMessageIter sub2, sub3; - const char*path; - unsigned n; + const char *path; uint32_t pid; int32_t code, status; - dbus_bool_t ignore; + int ignore, r; + assert(m); assert(i); - assert(i); - - if (dbus_message_iter_get_arg_type(sub) != DBUS_TYPE_STRUCT) - return -EIO; - dbus_message_iter_recurse(sub, &sub2); + r = sd_bus_message_enter_container(m, SD_BUS_TYPE_STRUCT, "sasbttttuii"); + if (r < 0) + return bus_log_parse_error(r); + else if (r == 0) + return 0; - if (bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &path, true) < 0) - return -EIO; + r = sd_bus_message_read(m, "s", &path); + if (r < 0) + return bus_log_parse_error(r); i->path = strdup(path); if (!i->path) - return -ENOMEM; - - if (dbus_message_iter_get_arg_type(&sub2) != DBUS_TYPE_ARRAY || - dbus_message_iter_get_element_type(&sub2) != DBUS_TYPE_STRING) - return -EIO; - - n = 0; - dbus_message_iter_recurse(&sub2, &sub3); - while (dbus_message_iter_get_arg_type(&sub3) != DBUS_TYPE_INVALID) { - assert(dbus_message_iter_get_arg_type(&sub3) == DBUS_TYPE_STRING); - dbus_message_iter_next(&sub3); - n++; - } - - i->argv = new0(char*, n+1); - if (!i->argv) - return -ENOMEM; - - n = 0; - dbus_message_iter_recurse(&sub2, &sub3); - while (dbus_message_iter_get_arg_type(&sub3) != DBUS_TYPE_INVALID) { - const char *s; - - assert(dbus_message_iter_get_arg_type(&sub3) == DBUS_TYPE_STRING); - dbus_message_iter_get_basic(&sub3, &s); - dbus_message_iter_next(&sub3); - - i->argv[n] = strdup(s); - if (!i->argv[n]) - return -ENOMEM; - - n++; - } + return log_oom(); - if (!dbus_message_iter_next(&sub2) || - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_BOOLEAN, &ignore, true) < 0 || - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_UINT64, &start_timestamp, true) < 0 || - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_UINT64, &start_timestamp_monotonic, true) < 0 || - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_UINT64, &exit_timestamp, true) < 0 || - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_UINT64, &exit_timestamp_monotonic, true) < 0 || - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_UINT32, &pid, true) < 0 || - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_INT32, &code, true) < 0 || - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_INT32, &status, false) < 0) - return -EIO; + r = sd_bus_message_read_strv(m, &i->argv); + if (r < 0) + return bus_log_parse_error(r); + + r = sd_bus_message_read(m, + "bttttuii", + &ignore, + &start_timestamp, &start_timestamp_monotonic, + &exit_timestamp, &exit_timestamp_monotonic, + &pid, + &code, &status); + if (r < 0) + return bus_log_parse_error(r); i->ignore = ignore; i->start_timestamp = (usec_t) start_timestamp; @@ -2442,7 +2209,11 @@ static int exec_status_info_deserialize(DBusMessageIter *sub, ExecStatusInfo *i) i->code = code; i->status = status; - return 0; + r = sd_bus_message_exit_container(m); + if (r < 0) + return bus_log_parse_error(r); + + return 1; } typedef struct UnitStatusInfo { @@ -2513,8 +2284,10 @@ typedef struct UnitStatusInfo { LIST_HEAD(ExecStatusInfo, exec); } UnitStatusInfo; -static void print_status_info(UnitStatusInfo *i, - bool *ellipsized) { +static void print_status_info( + UnitStatusInfo *i, + bool *ellipsized) { + ExecStatusInfo *p; const char *on, *off, *ss; usec_t timestamp; @@ -2566,15 +2339,16 @@ static void print_status_info(UnitStatusInfo *i, on, strna(i->load_state), off); if (!strv_isempty(i->dropin_paths)) { - char ** dropin; - char * dir = NULL; + _cleanup_free_ char *dir = NULL; bool last = false; + char ** dropin; STRV_FOREACH(dropin, i->dropin_paths) { if (! dir || last) { printf(dir ? " " : " Drop-In: "); free(dir); + dir = NULL; if (path_get_parent(*dropin, &dir) < 0) { log_oom(); @@ -2589,8 +2363,6 @@ static void print_status_info(UnitStatusInfo *i, printf("%s%s", path_get_file_name(*dropin), last ? "\n" : ", "); } - - free(dir); } ss = streq_ptr(i->active_state, i->sub_state) ? NULL : i->sub_state; @@ -2758,7 +2530,7 @@ static void print_status_info(UnitStatusInfo *i, printf(" CGroup: %s\n", i->control_group); - if (arg_transport != TRANSPORT_SSH) { + if (arg_transport == BUS_TRANSPORT_LOCAL || arg_transport == BUS_TRANSPORT_CONTAINER) { unsigned k = 0; pid_t extra[2]; char prefix[] = " "; @@ -2780,7 +2552,7 @@ static void print_status_info(UnitStatusInfo *i, } } - if (i->id && arg_transport != TRANSPORT_SSH) { + if (i->id && arg_transport == BUS_TRANSPORT_LOCAL) { printf("\n"); show_journal_by_unit(stdout, i->id, @@ -2814,11 +2586,11 @@ static void show_unit_help(UnitStatusInfo *i) { STRV_FOREACH(p, i->documentation) { if (startswith(*p, "man:")) { - size_t k; - char *e = NULL; - _cleanup_free_ char *page = NULL, *section = NULL; const char *args[4] = { "man", NULL, NULL, NULL }; + _cleanup_free_ char *page = NULL, *section = NULL; + char *e = NULL; pid_t pid; + size_t k; k = strlen(*p); @@ -2857,18 +2629,21 @@ static void show_unit_help(UnitStatusInfo *i) { } } -static int status_property(const char *name, DBusMessageIter *iter, UnitStatusInfo *i) { +static int status_property(const char *name, sd_bus_message *m, UnitStatusInfo *i, const char *contents) { + int r; assert(name); - assert(iter); + assert(m); assert(i); - switch (dbus_message_iter_get_arg_type(iter)) { + switch (contents[0]) { - case DBUS_TYPE_STRING: { + case SD_BUS_TYPE_STRING: { const char *s; - dbus_message_iter_get_basic(iter, &s); + r = sd_bus_message_read(m, "s", &s); + if (r < 0) + return bus_log_parse_error(r); if (!isempty(s)) { if (streq(name, "Id")) @@ -2916,10 +2691,12 @@ static int status_property(const char *name, DBusMessageIter *iter, UnitStatusIn break; } - case DBUS_TYPE_BOOLEAN: { - dbus_bool_t b; + case SD_BUS_TYPE_BOOLEAN: { + int b; - dbus_message_iter_get_basic(iter, &b); + r = sd_bus_message_read(m, "b", &b); + if (r < 0) + return bus_log_parse_error(r); if (streq(name, "Accept")) i->accept = b; @@ -2931,10 +2708,12 @@ static int status_property(const char *name, DBusMessageIter *iter, UnitStatusIn break; } - case DBUS_TYPE_UINT32: { + case SD_BUS_TYPE_UINT32: { uint32_t u; - dbus_message_iter_get_basic(iter, &u); + r = sd_bus_message_read(m, "u", &u); + if (r < 0) + return bus_log_parse_error(r); if (streq(name, "MainPID")) { if (u > 0) { @@ -2954,10 +2733,12 @@ static int status_property(const char *name, DBusMessageIter *iter, UnitStatusIn break; } - case DBUS_TYPE_INT32: { + case SD_BUS_TYPE_INT32: { int32_t j; - dbus_message_iter_get_basic(iter, &j); + r = sd_bus_message_read(m, "i", &j); + if (r < 0) + return bus_log_parse_error(r); if (streq(name, "ExecMainCode")) i->exit_code = (int) j; @@ -2967,10 +2748,12 @@ static int status_property(const char *name, DBusMessageIter *iter, UnitStatusIn break; } - case DBUS_TYPE_UINT64: { + case SD_BUS_TYPE_UINT64: { uint64_t u; - dbus_message_iter_get_basic(iter, &u); + r = sd_bus_message_read(m, "t", &u); + if (r < 0) + return bus_log_parse_error(r); if (streq(name, "ExecMainStartTimestamp")) i->start_timestamp = (usec_t) u; @@ -2992,193 +2775,190 @@ static int status_property(const char *name, DBusMessageIter *iter, UnitStatusIn break; } - case DBUS_TYPE_ARRAY: { + case SD_BUS_TYPE_ARRAY: - if (dbus_message_iter_get_element_type(iter) == DBUS_TYPE_STRUCT && - startswith(name, "Exec")) { - DBusMessageIter sub; + if (contents[1] == SD_BUS_TYPE_STRUCT_BEGIN && startswith(name, "Exec")) { + _cleanup_free_ ExecStatusInfo *info = NULL; - dbus_message_iter_recurse(iter, &sub); - while (dbus_message_iter_get_arg_type(&sub) == DBUS_TYPE_STRUCT) { - ExecStatusInfo *info; - int r; + r = sd_bus_message_enter_container(m, SD_BUS_TYPE_ARRAY, "(sasbttttuii)"); + if (r < 0) + return bus_log_parse_error(r); - info = new0(ExecStatusInfo, 1); - if (!info) - return -ENOMEM; + info = new0(ExecStatusInfo, 1); + if (!info) + return log_oom(); - info->name = strdup(name); - if (!info->name) { - free(info); - return -ENOMEM; - } + while ((r = exec_status_info_deserialize(m, info)) > 0) { - r = exec_status_info_deserialize(&sub, info); - if (r < 0) { - free(info); - return r; - } + info->name = strdup(name); + if (!info->name) + log_oom(); LIST_PREPEND(exec, i->exec, info); - dbus_message_iter_next(&sub); + info = new0(ExecStatusInfo, 1); + if (!info) + log_oom(); } - } else if (dbus_message_iter_get_element_type(iter) == DBUS_TYPE_STRUCT && - streq(name, "Listen")) { - DBusMessageIter sub, sub2; + if (r < 0) + return bus_log_parse_error(r); + + r = sd_bus_message_exit_container(m); + if (r < 0) + return bus_log_parse_error(r); - dbus_message_iter_recurse(iter, &sub); - while (dbus_message_iter_get_arg_type(&sub) == DBUS_TYPE_STRUCT) { - const char *type, *path; + return 0; - dbus_message_iter_recurse(&sub, &sub2); + } else if (contents[1] == SD_BUS_TYPE_STRUCT_BEGIN && streq(name, "Listen")) { + const char *type, *path; - if (bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &type, true) >= 0 && - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &path, false) >= 0) { - int r; + r = sd_bus_message_enter_container(m, SD_BUS_TYPE_ARRAY, "(ss)"); + if (r < 0) + return bus_log_parse_error(r); - r = strv_extend(&i->listen, type); - if (r < 0) - return r; - r = strv_extend(&i->listen, path); - if (r < 0) - return r; - } + while ((r = sd_bus_message_read(m, "(ss)", &type, &path)) > 0) { - dbus_message_iter_next(&sub); - } + r = strv_extend(&i->listen, type); + if (r < 0) + return r; - return 0; + r = strv_extend(&i->listen, path); + if (r < 0) + return r; + } + if (r < 0) + return bus_log_parse_error(r); - } else if (dbus_message_iter_get_element_type(iter) == DBUS_TYPE_STRING && - streq(name, "DropInPaths")) { - int r = bus_parse_strv_iter(iter, &i->dropin_paths); + r = sd_bus_message_exit_container(m); if (r < 0) - return r; + return bus_log_parse_error(r); - } else if (dbus_message_iter_get_element_type(iter) == DBUS_TYPE_STRING && - streq(name, "Documentation")) { + return 0; - DBusMessageIter sub; + } else if (contents[1] == SD_BUS_TYPE_STRING && streq(name, "DropInPaths")) { - dbus_message_iter_recurse(iter, &sub); - while (dbus_message_iter_get_arg_type(&sub) == DBUS_TYPE_STRING) { - const char *s; - int r; + r = sd_bus_message_read_strv(m, &i->dropin_paths); + if (r < 0) + return bus_log_parse_error(r); - dbus_message_iter_get_basic(&sub, &s); + } else if (contents[1] == SD_BUS_TYPE_STRING && streq(name, "Documentation")) { - r = strv_extend(&i->documentation, s); - if (r < 0) - return r; + r = sd_bus_message_read_strv(m, &i->documentation); + if (r < 0) + return bus_log_parse_error(r); - dbus_message_iter_next(&sub); - } + } else if (contents[1] == SD_BUS_TYPE_STRUCT_BEGIN && streq(name, "Conditions")) { + const char *cond, *param; + int trigger, negate; + int32_t state; - } else if (dbus_message_iter_get_element_type(iter) == DBUS_TYPE_STRUCT && - streq(name, "Conditions")) { - DBusMessageIter sub, sub2; - - dbus_message_iter_recurse(iter, &sub); - while (dbus_message_iter_get_arg_type(&sub) == DBUS_TYPE_STRUCT) { - const char *cond, *param; - dbus_bool_t trigger, negate; - dbus_int32_t state; - - dbus_message_iter_recurse(&sub, &sub2); - log_debug("here"); - - if(bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &cond, true) >= 0 && - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_BOOLEAN, &trigger, true) >= 0 && - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_BOOLEAN, &negate, true) >= 0 && - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, ¶m, true) >= 0 && - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_INT32, &state, false) >= 0) { - log_debug("%s %d %d %s %d", cond, trigger, negate, param, state); - if (state < 0 && (!trigger || !i->failed_condition)) { - i->failed_condition = cond; - i->failed_condition_trigger = trigger; - i->failed_condition_negate = negate; - i->failed_condition_param = param; - } + r = sd_bus_message_enter_container(m, SD_BUS_TYPE_ARRAY, "(sbbsi)"); + if (r < 0) + return bus_log_parse_error(r); + + while ((r = sd_bus_message_read(m, "(sbbsi)", &cond, &trigger, &negate, ¶m, &state)) > 0) { + log_debug("%s %d %d %s %d", cond, trigger, negate, param, state); + if (state < 0 && (!trigger || !i->failed_condition)) { + i->failed_condition = cond; + i->failed_condition_trigger = trigger; + i->failed_condition_negate = negate; + i->failed_condition_param = param; } - - dbus_message_iter_next(&sub); } - } + if (r < 0) + return bus_log_parse_error(r); + + r = sd_bus_message_exit_container(m); + if (r < 0) + return bus_log_parse_error(r); + + } else + goto skip; break; - } - case DBUS_TYPE_STRUCT: { + case SD_BUS_TYPE_STRUCT_BEGIN: if (streq(name, "LoadError")) { - DBusMessageIter sub; const char *n, *message; - int r; - - dbus_message_iter_recurse(iter, &sub); - - r = bus_iter_get_basic_and_next(&sub, DBUS_TYPE_STRING, &n, true); - if (r < 0) - return r; - r = bus_iter_get_basic_and_next(&sub, DBUS_TYPE_STRING, &message, false); + r = sd_bus_message_read(m, "(ss)", &n, &message); if (r < 0) - return r; + return bus_log_parse_error(r); if (!isempty(message)) i->load_error = message; - } + } else + goto skip; break; + + default: + goto skip; } - } + + return 0; + +skip: + r = sd_bus_message_skip(m, contents); + if (r < 0) + return bus_log_parse_error(r); return 0; } -static int print_property(const char *name, DBusMessageIter *iter) { +static int print_property(const char *name, sd_bus_message *m, const char *contents) { + int r; + assert(name); - assert(iter); + assert(m); /* This is a low-level property printer, see * print_status_info() for the nicer output */ - if (arg_properties && !strv_find(arg_properties, name)) - return 0; + if (arg_properties && !strv_find(arg_properties, name)) { + /* skip what we didn't read */ + r = sd_bus_message_skip(m, contents); + return r; + } - switch (dbus_message_iter_get_arg_type(iter)) { + switch (contents[0]) { - case DBUS_TYPE_STRUCT: { - DBusMessageIter sub; - dbus_message_iter_recurse(iter, &sub); + case SD_BUS_TYPE_STRUCT_BEGIN: - if (dbus_message_iter_get_arg_type(&sub) == DBUS_TYPE_UINT32 && streq(name, "Job")) { + if (contents[1] == SD_BUS_TYPE_UINT32 && streq(name, "Job")) { uint32_t u; - dbus_message_iter_get_basic(&sub, &u); + r = sd_bus_message_read(m, "(uo)", &u, NULL); + if (r < 0) + return bus_log_parse_error(r); - if (u) + if (u > 0) printf("%s=%u\n", name, (unsigned) u); else if (arg_all) printf("%s=\n", name); return 0; - } else if (dbus_message_iter_get_arg_type(&sub) == DBUS_TYPE_STRING && streq(name, "Unit")) { + + } else if (contents[1] == SD_BUS_TYPE_STRING && streq(name, "Unit")) { const char *s; - dbus_message_iter_get_basic(&sub, &s); + r = sd_bus_message_read(m, "(so)", &s, NULL); + if (r < 0) + return bus_log_parse_error(r); - if (arg_all || s[0]) + if (arg_all || !isempty(s)) printf("%s=%s\n", name, s); return 0; - } else if (dbus_message_iter_get_arg_type(&sub) == DBUS_TYPE_STRING && streq(name, "LoadError")) { + + } else if (contents[1] == SD_BUS_TYPE_STRING && streq(name, "LoadError")) { const char *a = NULL, *b = NULL; - if (bus_iter_get_basic_and_next(&sub, DBUS_TYPE_STRING, &a, true) >= 0) - bus_iter_get_basic_and_next(&sub, DBUS_TYPE_STRING, &b, false); + r = sd_bus_message_read(m, "(ss)", &a, &b); + if (r < 0) + return bus_log_parse_error(r); if (arg_all || !isempty(a) || !isempty(b)) printf("%s=%s \"%s\"\n", name, strempty(a), strempty(b)); @@ -3187,262 +2967,279 @@ static int print_property(const char *name, DBusMessageIter *iter) { } break; - } - case DBUS_TYPE_ARRAY: + case SD_BUS_TYPE_ARRAY: - if (dbus_message_iter_get_element_type(iter) == DBUS_TYPE_STRUCT && streq(name, "EnvironmentFiles")) { - DBusMessageIter sub, sub2; + if (contents[1] == SD_BUS_TYPE_STRUCT_BEGIN && streq(name, "EnvironmentFiles")) { + const char *path; + int ignore; - dbus_message_iter_recurse(iter, &sub); - while (dbus_message_iter_get_arg_type(&sub) == DBUS_TYPE_STRUCT) { - const char *path; - dbus_bool_t ignore; + r = sd_bus_message_enter_container(m, SD_BUS_TYPE_ARRAY, "(sb)"); + if (r < 0) + return bus_log_parse_error(r); - dbus_message_iter_recurse(&sub, &sub2); + while ((r = sd_bus_message_read(m, "(sb)", &path, &ignore)) > 0) + printf("EnvironmentFile=%s (ignore_errors=%s)\n", path, yes_no(ignore)); - if (bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &path, true) >= 0 && - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_BOOLEAN, &ignore, false) >= 0) - printf("EnvironmentFile=%s (ignore_errors=%s)\n", path, yes_no(ignore)); + if (r < 0) + return bus_log_parse_error(r); - dbus_message_iter_next(&sub); - } + r = sd_bus_message_exit_container(m); + if (r < 0) + return bus_log_parse_error(r); return 0; - } else if (dbus_message_iter_get_element_type(iter) == DBUS_TYPE_STRUCT && streq(name, "Paths")) { - DBusMessageIter sub, sub2; - - dbus_message_iter_recurse(iter, &sub); - - while (dbus_message_iter_get_arg_type(&sub) == DBUS_TYPE_STRUCT) { - const char *type, *path; + } else if (contents[1] == SD_BUS_TYPE_STRUCT_BEGIN && streq(name, "Paths")) { + const char *type, *path; - dbus_message_iter_recurse(&sub, &sub2); + r = sd_bus_message_enter_container(m, SD_BUS_TYPE_ARRAY, "(ss)"); + if (r < 0) + return bus_log_parse_error(r); - if (bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &type, true) >= 0 && - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &path, false) >= 0) - printf("%s=%s\n", type, path); + while ((r = sd_bus_message_read(m, "(ss)", &type, &path)) > 0) + printf("%s=%s\n", type, path); + if (r < 0) + return bus_log_parse_error(r); - dbus_message_iter_next(&sub); - } + r = sd_bus_message_exit_container(m); + if (r < 0) + return bus_log_parse_error(r); return 0; - } else if (dbus_message_iter_get_element_type(iter) == DBUS_TYPE_STRUCT && streq(name, "Listen")) { - DBusMessageIter sub, sub2; + } else if (contents[1] == SD_BUS_TYPE_STRUCT_BEGIN && streq(name, "Listen")) { + const char *type, *path; - dbus_message_iter_recurse(iter, &sub); - while (dbus_message_iter_get_arg_type(&sub) == DBUS_TYPE_STRUCT) { - const char *type, *path; - - dbus_message_iter_recurse(&sub, &sub2); + r = sd_bus_message_enter_container(m, SD_BUS_TYPE_ARRAY, "(ss)"); + if (r < 0) + return bus_log_parse_error(r); - if (bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &type, true) >= 0 && - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &path, false) >= 0) - printf("Listen%s=%s\n", type, path); + while ((r = sd_bus_message_read(m, "(ss)", &type, &path)) > 0) + printf("Listen%s=%s\n", type, path); + if (r < 0) + return bus_log_parse_error(r); - dbus_message_iter_next(&sub); - } + r = sd_bus_message_exit_container(m); + if (r < 0) + return bus_log_parse_error(r); return 0; - } else if (dbus_message_iter_get_element_type(iter) == DBUS_TYPE_STRUCT && streq(name, "Timers")) { - DBusMessageIter sub, sub2; - - dbus_message_iter_recurse(iter, &sub); - while (dbus_message_iter_get_arg_type(&sub) == DBUS_TYPE_STRUCT) { - const char *base; - uint64_t value, next_elapse; + } else if (contents[1] == SD_BUS_TYPE_STRUCT_BEGIN && streq(name, "Timers")) { + const char *base; + uint64_t value, next_elapse; - dbus_message_iter_recurse(&sub, &sub2); - - if (bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &base, true) >= 0 && - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_UINT64, &value, true) >= 0 && - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_UINT64, &next_elapse, false) >= 0) { - char timespan1[FORMAT_TIMESPAN_MAX], timespan2[FORMAT_TIMESPAN_MAX]; + r = sd_bus_message_enter_container(m, SD_BUS_TYPE_ARRAY, "(stt)"); + if (r < 0) + return bus_log_parse_error(r); - printf("%s={ value=%s ; next_elapse=%s }\n", - base, - format_timespan(timespan1, sizeof(timespan1), value, 0), - format_timespan(timespan2, sizeof(timespan2), next_elapse, 0)); - } + while ((r = sd_bus_message_read(m, "(stt)", &base, &value, &next_elapse)) > 0) { + char timespan1[FORMAT_TIMESPAN_MAX], timespan2[FORMAT_TIMESPAN_MAX]; - dbus_message_iter_next(&sub); + printf("%s={ value=%s ; next_elapse=%s }\n", + base, + format_timespan(timespan1, sizeof(timespan1), value, 0), + format_timespan(timespan2, sizeof(timespan2), next_elapse, 0)); } + if (r < 0) + return bus_log_parse_error(r); + + r = sd_bus_message_exit_container(m); + if (r < 0) + return bus_log_parse_error(r); return 0; - } else if (dbus_message_iter_get_element_type(iter) == DBUS_TYPE_STRUCT && startswith(name, "Exec")) { - DBusMessageIter sub; - - dbus_message_iter_recurse(iter, &sub); - while (dbus_message_iter_get_arg_type(&sub) == DBUS_TYPE_STRUCT) { - ExecStatusInfo info = {}; - - if (exec_status_info_deserialize(&sub, &info) >= 0) { - char timestamp1[FORMAT_TIMESTAMP_MAX], timestamp2[FORMAT_TIMESTAMP_MAX]; - _cleanup_free_ char *t; - - t = strv_join(info.argv, " "); - - printf("%s={ path=%s ; argv[]=%s ; ignore_errors=%s ; start_time=[%s] ; stop_time=[%s] ; pid=%u ; code=%s ; status=%i%s%s }\n", - name, - strna(info.path), - strna(t), - yes_no(info.ignore), - strna(format_timestamp(timestamp1, sizeof(timestamp1), info.start_timestamp)), - strna(format_timestamp(timestamp2, sizeof(timestamp2), info.exit_timestamp)), - (unsigned) info. pid, - sigchld_code_to_string(info.code), - info.status, - info.code == CLD_EXITED ? "" : "/", - strempty(info.code == CLD_EXITED ? NULL : signal_to_string(info.status))); - } + } else if (contents[1] == SD_BUS_TYPE_STRUCT_BEGIN && startswith(name, "Exec")) { + ExecStatusInfo info = {}; + + r = sd_bus_message_enter_container(m, SD_BUS_TYPE_ARRAY, "(sasbttttuii)"); + if (r < 0) + return bus_log_parse_error(r); + + while ((r = exec_status_info_deserialize(m, &info)) > 0) { + char timestamp1[FORMAT_TIMESTAMP_MAX], timestamp2[FORMAT_TIMESTAMP_MAX]; + _cleanup_free_ char *tt; + + tt = strv_join(info.argv, " "); + + printf("%s={ path=%s ; argv[]=%s ; ignore_errors=%s ; start_time=[%s] ; stop_time=[%s] ; pid=%u ; code=%s ; status=%i%s%s }\n", + name, + strna(info.path), + strna(tt), + yes_no(info.ignore), + strna(format_timestamp(timestamp1, sizeof(timestamp1), info.start_timestamp)), + strna(format_timestamp(timestamp2, sizeof(timestamp2), info.exit_timestamp)), + (unsigned) info. pid, + sigchld_code_to_string(info.code), + info.status, + info.code == CLD_EXITED ? "" : "/", + strempty(info.code == CLD_EXITED ? NULL : signal_to_string(info.status))); free(info.path); strv_free(info.argv); - - dbus_message_iter_next(&sub); + zero(info); } + r = sd_bus_message_exit_container(m); + if (r < 0) + return bus_log_parse_error(r); + return 0; - } else if (dbus_message_iter_get_element_type(iter) == DBUS_TYPE_STRUCT && streq(name, "DeviceAllow")) { - DBusMessageIter sub, sub2; + } else if (contents[1] == SD_BUS_TYPE_STRUCT_BEGIN && streq(name, "DeviceAllow")) { + const char *path, *rwm; - dbus_message_iter_recurse(iter, &sub); - while (dbus_message_iter_get_arg_type(&sub) == DBUS_TYPE_STRUCT) { - const char *path, *rwm; + r = sd_bus_message_enter_container(m, SD_BUS_TYPE_ARRAY, "(ss)"); + if (r < 0) + return bus_log_parse_error(r); - dbus_message_iter_recurse(&sub, &sub2); + while ((r = sd_bus_message_read(m, "(ss)", &path, &rwm)) > 0) + printf("%s=%s %s\n", name, strna(path), strna(rwm)); + if (r < 0) + return bus_log_parse_error(r); - if (bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &path, true) >= 0 && - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &rwm, false) >= 0) - printf("%s=%s %s\n", name, strna(path), strna(rwm)); + r = sd_bus_message_exit_container(m); + if (r < 0) + return bus_log_parse_error(r); - dbus_message_iter_next(&sub); - } return 0; - } else if (dbus_message_iter_get_element_type(iter) == DBUS_TYPE_STRUCT && streq(name, "BlockIODeviceWeight")) { - DBusMessageIter sub, sub2; + } else if (contents[1] == SD_BUS_TYPE_STRUCT_BEGIN && streq(name, "BlockIODeviceWeight")) { + const char *path; + uint64_t weight; - dbus_message_iter_recurse(iter, &sub); - while (dbus_message_iter_get_arg_type(&sub) == DBUS_TYPE_STRUCT) { - const char *path; - uint64_t weight; + r = sd_bus_message_enter_container(m, SD_BUS_TYPE_ARRAY, "(st)"); + if (r < 0) + return bus_log_parse_error(r); - dbus_message_iter_recurse(&sub, &sub2); + while ((r = sd_bus_message_read(m, "(st)", &path, &weight)) > 0) + printf("%s=%s %" PRIu64 "\n", name, strna(path), weight); + if (r < 0) + return bus_log_parse_error(r); - if (bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &path, true) >= 0 && - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_UINT64, &weight, false) >= 0) - printf("%s=%s %" PRIu64 "\n", name, strna(path), weight); + r = sd_bus_message_exit_container(m); + if (r < 0) + return bus_log_parse_error(r); - dbus_message_iter_next(&sub); - } return 0; - } else if (dbus_message_iter_get_element_type(iter) == DBUS_TYPE_STRUCT && (streq(name, "BlockIOReadBandwidth") || streq(name, "BlockIOWriteBandwidth"))) { - DBusMessageIter sub, sub2; + } else if (contents[1] == SD_BUS_TYPE_STRUCT_BEGIN && (streq(name, "BlockIOReadBandwidth") || streq(name, "BlockIOWriteBandwidth"))) { + const char *path; + uint64_t bandwidth; - dbus_message_iter_recurse(iter, &sub); - while (dbus_message_iter_get_arg_type(&sub) == DBUS_TYPE_STRUCT) { - const char *path; - uint64_t bandwidth; + r = sd_bus_message_enter_container(m, SD_BUS_TYPE_ARRAY, "(st)"); + if (r < 0) + return bus_log_parse_error(r); - dbus_message_iter_recurse(&sub, &sub2); + while ((r = sd_bus_message_read(m, "(st)", &path, &bandwidth)) > 0) + printf("%s=%s %" PRIu64 "\n", name, strna(path), bandwidth); + if (r < 0) + return bus_log_parse_error(r); - if (bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &path, true) >= 0 && - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_UINT64, &bandwidth, false) >= 0) - printf("%s=%s %" PRIu64 "\n", name, strna(path), bandwidth); + r = sd_bus_message_exit_container(m); + if (r < 0) + return bus_log_parse_error(r); - dbus_message_iter_next(&sub); - } return 0; } - break; } - if (generic_print_property(name, iter, arg_all) > 0) - return 0; + r = bus_print_property(name, m, arg_all); + if (r < 0) + return bus_log_parse_error(r); + + if (r == 0) { + r = sd_bus_message_skip(m, contents); + if (r < 0) + return bus_log_parse_error(r); - if (arg_all) - printf("%s=[unprintable]\n", name); + if (arg_all) + printf("%s=[unprintable]\n", name); + } return 0; } -static int show_one(const char *verb, - DBusConnection *bus, - const char *path, - bool show_properties, - bool *new_line, - bool *ellipsized) { - _cleanup_free_ DBusMessage *reply = NULL; - const char *interface = ""; - int r; - DBusMessageIter iter, sub, sub2, sub3; +static int show_one( + const char *verb, + sd_bus *bus, + const char *path, + bool show_properties, + bool *new_line, + bool *ellipsized) { + + _cleanup_bus_message_unref_ sd_bus_message *reply = NULL; + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; UnitStatusInfo info = {}; ExecStatusInfo *p; + int r; assert(path); assert(new_line); - r = bus_method_call_with_reply( + r = sd_bus_call_method( bus, "org.freedesktop.systemd1", path, "org.freedesktop.DBus.Properties", "GetAll", + &error, &reply, - NULL, - DBUS_TYPE_STRING, &interface, - DBUS_TYPE_INVALID); - if (r < 0) + "s", ""); + if (r < 0) { + log_error("Failed to get properties: %s", bus_error_message(&error, r)); return r; - - if (!dbus_message_iter_init(reply, &iter) || - dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_ARRAY || - dbus_message_iter_get_element_type(&iter) != DBUS_TYPE_DICT_ENTRY) { - log_error("Failed to parse reply."); - return -EIO; } - dbus_message_iter_recurse(&iter, &sub); + r = sd_bus_message_enter_container(reply, SD_BUS_TYPE_ARRAY, "{sv}"); + if (r < 0) + return bus_log_parse_error(r); if (*new_line) printf("\n"); *new_line = true; - while (dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_INVALID) { - const char *name; + while ((r = sd_bus_message_enter_container(reply, SD_BUS_TYPE_DICT_ENTRY, "sv")) > 0) { + const char *name, *contents; - assert(dbus_message_iter_get_arg_type(&sub) == DBUS_TYPE_DICT_ENTRY); - dbus_message_iter_recurse(&sub, &sub2); + r = sd_bus_message_read(reply, "s", &name); + if (r < 0) + return bus_log_parse_error(r); - if (bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &name, true) < 0 || - dbus_message_iter_get_arg_type(&sub2) != DBUS_TYPE_VARIANT) { - log_error("Failed to parse reply."); - return -EIO; - } + r = sd_bus_message_peek_type(reply, NULL, &contents); + if (r < 0) + return bus_log_parse_error(r); - dbus_message_iter_recurse(&sub2, &sub3); + r = sd_bus_message_enter_container(reply, SD_BUS_TYPE_VARIANT, contents); + if (r < 0) + return bus_log_parse_error(r); if (show_properties) - r = print_property(name, &sub3); + r = print_property(name, reply, contents); else - r = status_property(name, &sub3, &info); - if (r < 0) { - log_error("Failed to parse reply."); - return -EIO; - } + r = status_property(name, reply, &info, contents); + if (r < 0) + return r; + + r = sd_bus_message_exit_container(reply); + if (r < 0) + return bus_log_parse_error(r); - dbus_message_iter_next(&sub); + r = sd_bus_message_exit_container(reply); + if (r < 0) + return bus_log_parse_error(r); } + if (r < 0) + return bus_log_parse_error(r); + + r = sd_bus_message_exit_container(reply); + if (r < 0) + return bus_log_parse_error(r); r = 0; @@ -3481,58 +3278,60 @@ static int show_one(const char *verb, return r; } -static int show_one_by_pid(const char *verb, - DBusConnection *bus, - uint32_t pid, - bool *new_line, - bool *ellipsized) { - _cleanup_dbus_message_unref_ DBusMessage *reply = NULL; +static int show_one_by_pid( + const char *verb, + sd_bus *bus, + uint32_t pid, + bool *new_line, + bool *ellipsized) { + + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; + _cleanup_bus_message_unref_ sd_bus_message *reply = NULL; const char *path = NULL; - _cleanup_dbus_error_free_ DBusError error; int r; - dbus_error_init(&error); - - r = bus_method_call_with_reply( + r = sd_bus_call_method( bus, "org.freedesktop.systemd1", "/org/freedesktop/systemd1", "org.freedesktop.systemd1.Manager", "GetUnitByPID", + &error, &reply, - NULL, - DBUS_TYPE_UINT32, &pid, - DBUS_TYPE_INVALID); - if (r < 0) + "u", pid); + if (r < 0) { + log_error("Failed to get unit for PID %lu: %s", (unsigned long) pid, bus_error_message(&error, r)); return r; - - if (!dbus_message_get_args(reply, &error, - DBUS_TYPE_OBJECT_PATH, &path, - DBUS_TYPE_INVALID)) { - log_error("Failed to parse reply: %s", bus_error_message(&error)); - return -EIO; } - r = show_one(verb, bus, path, false, new_line, ellipsized); - return r; + r = sd_bus_message_read(reply, "o", &path); + if (r < 0) + return bus_log_parse_error(r); + + return show_one(verb, bus, path, false, new_line, ellipsized); } -static int show_all(const char* verb, - DBusConnection *bus, - bool show_properties, - bool *new_line, - bool *ellipsized) { - _cleanup_dbus_message_unref_ DBusMessage *reply = NULL; - _cleanup_free_ struct unit_info *unit_infos = NULL; - unsigned c = 0; - const struct unit_info *u; +static int show_all( + const char* verb, + sd_bus *bus, + bool show_properties, + bool *new_line, + bool *ellipsized) { + + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; + _cleanup_bus_message_unref_ sd_bus_message *reply = NULL; + _cleanup_free_ UnitInfo *unit_infos = NULL; + const UnitInfo *u; + unsigned c; int r; - r = get_unit_list(bus, &reply, &unit_infos, &c); + r = get_unit_list(bus, &reply, &unit_infos); if (r < 0) return r; - qsort_safe(unit_infos, c, sizeof(struct unit_info), compare_unit_info); + c = (unsigned) r; + + qsort_safe(unit_infos, c, sizeof(UnitInfo), compare_unit_info); for (u = unit_infos; u < unit_infos + c; u++) { _cleanup_free_ char *p = NULL; @@ -3554,7 +3353,7 @@ static int show_all(const char* verb, return 0; } -static int show(DBusConnection *bus, char **args) { +static int show(sd_bus *bus, char **args) { int r, ret = 0; bool show_properties, show_status, new_line = false; char **name; @@ -3621,13 +3420,12 @@ static int show(DBusConnection *bus, char **args) { return ret; } -static int append_assignment(DBusMessageIter *iter, const char *assignment) { +static int append_assignment(sd_bus_message *m, const char *assignment) { const char *eq; char *field; - DBusMessageIter sub; int r; - assert(iter); + assert(m); assert(assignment); eq = strchr(assignment, '='); @@ -3639,13 +3437,13 @@ static int append_assignment(DBusMessageIter *iter, const char *assignment) { field = strndupa(assignment, eq - assignment); eq ++; - if (!dbus_message_iter_append_basic(iter, DBUS_TYPE_STRING, &field)) - return log_oom(); + r = sd_bus_message_append_basic(m, SD_BUS_TYPE_STRING, field); + if (r < 0) + return bus_log_create_error(r); if (streq(field, "CPUAccounting") || streq(field, "MemoryAccounting") || streq(field, "BlockIOAccounting")) { - dbus_bool_t b; r = parse_boolean(eq); if (r < 0) { @@ -3653,14 +3451,10 @@ static int append_assignment(DBusMessageIter *iter, const char *assignment) { return -EINVAL; } - b = r; - if (!dbus_message_iter_open_container(iter, DBUS_TYPE_VARIANT, "b", &sub) || - !dbus_message_iter_append_basic(&sub, DBUS_TYPE_BOOLEAN, &b)) - return log_oom(); + r = sd_bus_message_append(m, "v", "b", r); } else if (streq(field, "MemoryLimit")) { off_t bytes; - uint64_t u; r = parse_bytes(eq, &bytes); if (r < 0) { @@ -3668,10 +3462,7 @@ static int append_assignment(DBusMessageIter *iter, const char *assignment) { return -EINVAL; } - u = bytes; - if (!dbus_message_iter_open_container(iter, DBUS_TYPE_VARIANT, "t", &sub) || - !dbus_message_iter_append_basic(&sub, DBUS_TYPE_UINT64, &u)) - return log_oom(); + r = sd_bus_message_append(m, "v", "t", (uint64_t) bytes); } else if (streq(field, "CPUShares") || streq(field, "BlockIOWeight")) { uint64_t u; @@ -3682,26 +3473,17 @@ static int append_assignment(DBusMessageIter *iter, const char *assignment) { return -EINVAL; } - if (!dbus_message_iter_open_container(iter, DBUS_TYPE_VARIANT, "t", &sub) || - !dbus_message_iter_append_basic(&sub, DBUS_TYPE_UINT64, &u)) - return log_oom(); - - } else if (streq(field, "DevicePolicy")) { - - if (!dbus_message_iter_open_container(iter, DBUS_TYPE_VARIANT, "s", &sub) || - !dbus_message_iter_append_basic(&sub, DBUS_TYPE_STRING, &eq)) - return log_oom(); + r = sd_bus_message_append(m, "v", "t", u); - } else if (streq(field, "DeviceAllow")) { - DBusMessageIter sub2; + } else if (streq(field, "DevicePolicy")) + r = sd_bus_message_append(m, "v", "s", eq); - if (!dbus_message_iter_open_container(iter, DBUS_TYPE_VARIANT, "a(ss)", &sub) || - !dbus_message_iter_open_container(&sub, DBUS_TYPE_ARRAY, "(ss)", &sub2)) - return log_oom(); + else if (streq(field, "DeviceAllow")) { - if (!isempty(eq)) { + if (isempty(eq)) + r = sd_bus_message_append(m, "v", "a(ss)", 0); + else { const char *path, *rwm; - DBusMessageIter sub3; char *e; e = strchr(eq, ' '); @@ -3718,27 +3500,15 @@ static int append_assignment(DBusMessageIter *iter, const char *assignment) { return -EINVAL; } - if (!dbus_message_iter_open_container(&sub2, DBUS_TYPE_STRUCT, NULL, &sub3) || - !dbus_message_iter_append_basic(&sub3, DBUS_TYPE_STRING, &path) || - !dbus_message_iter_append_basic(&sub3, DBUS_TYPE_STRING, &rwm) || - !dbus_message_iter_close_container(&sub2, &sub3)) - return log_oom(); + r = sd_bus_message_append(m, "v", "a(ss)", 1, path, rwm); } - if (!dbus_message_iter_close_container(&sub, &sub2)) - return log_oom(); - } else if (streq(field, "BlockIOReadBandwidth") || streq(field, "BlockIOWriteBandwidth")) { - DBusMessageIter sub2; - if (!dbus_message_iter_open_container(iter, DBUS_TYPE_VARIANT, "a(st)", &sub) || - !dbus_message_iter_open_container(&sub, DBUS_TYPE_ARRAY, "(st)", &sub2)) - return log_oom(); - - if (!isempty(eq)) { + if (isempty(eq)) + r = sd_bus_message_append(m, "v", "a(st)", 0); + else { const char *path, *bandwidth; - DBusMessageIter sub3; - uint64_t u; off_t bytes; char *e; @@ -3762,28 +3532,15 @@ static int append_assignment(DBusMessageIter *iter, const char *assignment) { return -EINVAL; } - u = (uint64_t) bytes; - - if (!dbus_message_iter_open_container(&sub2, DBUS_TYPE_STRUCT, NULL, &sub3) || - !dbus_message_iter_append_basic(&sub3, DBUS_TYPE_STRING, &path) || - !dbus_message_iter_append_basic(&sub3, DBUS_TYPE_UINT64, &u) || - !dbus_message_iter_close_container(&sub2, &sub3)) - return log_oom(); + r = sd_bus_message_append(m, "v", "a(st)", 1, path, (uint64_t) bytes); } - if (!dbus_message_iter_close_container(&sub, &sub2)) - return log_oom(); - } else if (streq(field, "BlockIODeviceWeight")) { - DBusMessageIter sub2; - if (!dbus_message_iter_open_container(iter, DBUS_TYPE_VARIANT, "a(st)", &sub) || - !dbus_message_iter_open_container(&sub, DBUS_TYPE_ARRAY, "(st)", &sub2)) - return log_oom(); - - if (!isempty(eq)) { + if (isempty(eq)) + r = sd_bus_message_append(m, "v", "a(st)", 0); + else { const char *path, *weight; - DBusMessageIter sub3; uint64_t u; char *e; @@ -3806,101 +3563,82 @@ static int append_assignment(DBusMessageIter *iter, const char *assignment) { log_error("Failed to parse %s value %s.", field, weight); return -EINVAL; } - if (!dbus_message_iter_open_container(&sub2, DBUS_TYPE_STRUCT, NULL, &sub3) || - !dbus_message_iter_append_basic(&sub3, DBUS_TYPE_STRING, &path) || - !dbus_message_iter_append_basic(&sub3, DBUS_TYPE_UINT64, &u) || - !dbus_message_iter_close_container(&sub2, &sub3)) - return log_oom(); + r = sd_bus_message_append(m, "v", "a(st)", path, u); } - if (!dbus_message_iter_close_container(&sub, &sub2)) - return log_oom(); - } else { log_error("Unknown assignment %s.", assignment); return -EINVAL; } - if (!dbus_message_iter_close_container(iter, &sub)) - return log_oom(); + if (r < 0) + return bus_log_create_error(r); return 0; } -static int set_property(DBusConnection *bus, char **args) { - - _cleanup_dbus_message_unref_ DBusMessage *m = NULL, *reply = NULL; +static int set_property(sd_bus *bus, char **args) { + _cleanup_bus_message_unref_ sd_bus_message *m = NULL; + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; _cleanup_free_ char *n = NULL; - DBusMessageIter iter, sub; - dbus_bool_t runtime; - DBusError error; char **i; int r; - dbus_error_init(&error); - - m = dbus_message_new_method_call( + r = sd_bus_message_new_method_call( + bus, "org.freedesktop.systemd1", "/org/freedesktop/systemd1", "org.freedesktop.systemd1.Manager", - "SetUnitProperties"); - if (!m) - return log_oom(); - - dbus_message_iter_init_append(m, &iter); - - runtime = arg_runtime; + "SetUnitProperties", + &m); + if (r < 0) + return bus_log_create_error(r); n = unit_name_mangle(args[1]); if (!n) return log_oom(); - if (!dbus_message_iter_append_basic(&iter, DBUS_TYPE_STRING, &n) || - !dbus_message_iter_append_basic(&iter, DBUS_TYPE_BOOLEAN, &runtime) || - !dbus_message_iter_open_container(&iter, DBUS_TYPE_ARRAY, "(sv)", &sub)) - return log_oom(); + r = sd_bus_message_append(m, "sb", n, arg_runtime); + if (r < 0) + return bus_log_create_error(r); - STRV_FOREACH(i, args + 2) { - DBusMessageIter sub2; + r = sd_bus_message_open_container(m, SD_BUS_TYPE_ARRAY, "(sv)"); + if (r < 0) + return bus_log_create_error(r); - if (!dbus_message_iter_open_container(&sub, DBUS_TYPE_STRUCT, NULL, &sub2)) - return log_oom(); + STRV_FOREACH(i, args + 2) { + r = sd_bus_message_open_container(m, SD_BUS_TYPE_STRUCT, "sv"); + if (r < 0) + return bus_log_create_error(r); - r = append_assignment(&sub2, *i); + r = append_assignment(m, *i); if (r < 0) return r; - if (!dbus_message_iter_close_container(&sub, &sub2)) - return log_oom(); - + r = sd_bus_message_close_container(m); + if (r < 0) + return bus_log_create_error(r); } - if (!dbus_message_iter_close_container(&iter, &sub)) - return log_oom(); + r = sd_bus_message_close_container(m); + if (r < 0) + return bus_log_create_error(r); - reply = dbus_connection_send_with_reply_and_block(bus, m, -1, &error); - if (!reply) { - log_error("Failed to issue method call: %s", bus_error_message(&error)); - dbus_error_free(&error); - return -EIO; + r = sd_bus_send_with_reply_and_block(bus, m, -1, &error, NULL); + if (r < 0) { + log_error("Failed to set unit properties on %s: %s", n, bus_error_message(&error, r)); + return r; } return 0; } -static int snapshot(DBusConnection *bus, char **args) { - _cleanup_dbus_message_unref_ DBusMessage *reply = NULL; - DBusError error; +static int snapshot(sd_bus *bus, char **args) { + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; + _cleanup_bus_message_unref_ sd_bus_message *reply = NULL; + _cleanup_free_ char *n = NULL, *id = NULL; + const char *path; int r; - dbus_bool_t cleanup = FALSE; - DBusMessageIter iter, sub; - const char - *path, *id, - *interface = "org.freedesktop.systemd1.Unit", - *property = "Id"; - _cleanup_free_ char *n = NULL; - - dbus_error_init(&error); if (strv_length(args) > 1) n = unit_name_mangle_with_suffix(args[1], ".snapshot"); @@ -3909,100 +3647,79 @@ static int snapshot(DBusConnection *bus, char **args) { if (!n) return log_oom(); - r = bus_method_call_with_reply( + r = sd_bus_call_method( bus, "org.freedesktop.systemd1", "/org/freedesktop/systemd1", "org.freedesktop.systemd1.Manager", "CreateSnapshot", + &error, &reply, - NULL, - DBUS_TYPE_STRING, &n, - DBUS_TYPE_BOOLEAN, &cleanup, - DBUS_TYPE_INVALID); - if (r < 0) + "sb", n, false); + if (r < 0) { + log_error("Failed to create snapshot: %s", bus_error_message(&error, r)); return r; - - if (!dbus_message_get_args(reply, &error, - DBUS_TYPE_OBJECT_PATH, &path, - DBUS_TYPE_INVALID)) { - log_error("Failed to parse reply: %s", bus_error_message(&error)); - dbus_error_free(&error); - return -EIO; } - dbus_message_unref(reply); - reply = NULL; + r = sd_bus_message_read(reply, "o", &path); + if (r < 0) + return bus_log_parse_error(r); - r = bus_method_call_with_reply ( + r = sd_bus_get_property_string( bus, "org.freedesktop.systemd1", path, - "org.freedesktop.DBus.Properties", - "Get", - &reply, - NULL, - DBUS_TYPE_STRING, &interface, - DBUS_TYPE_STRING, &property, - DBUS_TYPE_INVALID); - if (r < 0) + "org.freedesktop.systemd1.Unit", + "Id", + &error, + &id); + if (r < 0) { + log_error("Failed to get ID of snapshot: %s", bus_error_message(&error, r)); return r; - - if (!dbus_message_iter_init(reply, &iter) || - dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_VARIANT) { - log_error("Failed to parse reply."); - return -EIO; - } - - dbus_message_iter_recurse(&iter, &sub); - - if (dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_STRING) { - log_error("Failed to parse reply."); - return -EIO; } - dbus_message_iter_get_basic(&sub, &id); - if (!arg_quiet) puts(id); return 0; } -static int delete_snapshot(DBusConnection *bus, char **args) { +static int delete_snapshot(sd_bus *bus, char **args) { + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; char **name; + int r; assert(args); STRV_FOREACH(name, args+1) { _cleanup_free_ char *n = NULL; - int r; n = unit_name_mangle_with_suffix(*name, ".snapshot"); if (!n) return log_oom(); - r = bus_method_call_with_reply( + r = sd_bus_call_method( bus, "org.freedesktop.systemd1", "/org/freedesktop/systemd1", "org.freedesktop.systemd1.Manager", "RemoveSnapshot", + &error, NULL, - NULL, - DBUS_TYPE_STRING, &n, - DBUS_TYPE_INVALID); - if (r < 0) + "s", n); + if (r < 0) { + log_error("Failed to remove snapshot %s: %s", n, bus_error_message(&error, r)); return r; + } } return 0; } -static int daemon_reload(DBusConnection *bus, char **args) { - int r; +static int daemon_reload(sd_bus *bus, char **args) { + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; const char *method; - DBusError error; + int r; if (arg_action == ACTION_RELOAD) method = "Reload"; @@ -4024,15 +3741,15 @@ static int daemon_reload(DBusConnection *bus, char **args) { /* "daemon-reload" */ "Reload"; } - r = bus_method_call_with_reply( + r = sd_bus_call_method( bus, "org.freedesktop.systemd1", "/org/freedesktop/systemd1", "org.freedesktop.systemd1.Manager", method, - NULL, &error, - DBUS_TYPE_INVALID); + NULL, + NULL); if (r == -ENOENT && arg_action != ACTION_SYSTEMCTL) /* There's always a fallback possible for @@ -4043,15 +3760,15 @@ static int daemon_reload(DBusConnection *bus, char **args) { * reply */ r = 0; else if (r < 0) - log_error("Failed to issue method call: %s", bus_error_message(&error)); + log_error("Failed to execute operation: %s", bus_error_message(&error, r)); - dbus_error_free(&error); return r; } -static int reset_failed(DBusConnection *bus, char **args) { - int r = 0; +static int reset_failed(sd_bus *bus, char **args) { + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; char **name; + int r; if (strv_length(args) <= 1) return daemon_reload(bus, args); @@ -4063,84 +3780,68 @@ static int reset_failed(DBusConnection *bus, char **args) { if (!n) return log_oom(); - r = bus_method_call_with_reply( + r = sd_bus_call_method( bus, "org.freedesktop.systemd1", "/org/freedesktop/systemd1", "org.freedesktop.systemd1.Manager", "ResetFailedUnit", + &error, NULL, - NULL, - DBUS_TYPE_STRING, &n, - DBUS_TYPE_INVALID); - if (r < 0) + "s", n); + if (r < 0) { + log_error("Failed to reset failed state of unit %s: %s", n, bus_error_message(&error, r)); return r; + } } return 0; } -static int show_enviroment(DBusConnection *bus, char **args) { - _cleanup_dbus_message_unref_ DBusMessage *reply = NULL; - DBusMessageIter iter, sub, sub2; +static int show_environment(sd_bus *bus, char **args) { + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; + _cleanup_bus_message_unref_ sd_bus_message *reply = NULL; + const char *text; int r; - const char - *interface = "org.freedesktop.systemd1.Manager", - *property = "Environment"; pager_open_if_enabled(); - r = bus_method_call_with_reply( + r = sd_bus_get_property( bus, "org.freedesktop.systemd1", "/org/freedesktop/systemd1", - "org.freedesktop.DBus.Properties", - "Get", + "org.freedesktop.systemd1.Manager", + "Environment", + &error, &reply, - NULL, - DBUS_TYPE_STRING, &interface, - DBUS_TYPE_STRING, &property, - DBUS_TYPE_INVALID); - if (r < 0) + "as"); + if (r < 0) { + log_error("Failed to get environment: %s", bus_error_message(&error, r)); return r; - - if (!dbus_message_iter_init(reply, &iter) || - dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_VARIANT) { - log_error("Failed to parse reply."); - return -EIO; - } - - dbus_message_iter_recurse(&iter, &sub); - - if (dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_ARRAY || - dbus_message_iter_get_element_type(&sub) != DBUS_TYPE_STRING) { - log_error("Failed to parse reply."); - return -EIO; } - dbus_message_iter_recurse(&sub, &sub2); - - while (dbus_message_iter_get_arg_type(&sub2) != DBUS_TYPE_INVALID) { - const char *text; - - if (dbus_message_iter_get_arg_type(&sub2) != DBUS_TYPE_STRING) { - log_error("Failed to parse reply."); - return -EIO; - } + r = sd_bus_message_enter_container(reply, SD_BUS_TYPE_ARRAY, "s"); + if (r < 0) + return bus_log_parse_error(r); - dbus_message_iter_get_basic(&sub2, &text); + while ((r = sd_bus_message_read_basic(reply, SD_BUS_TYPE_STRING, &text)) > 0) puts(text); + if (r < 0) + return bus_log_parse_error(r); - dbus_message_iter_next(&sub2); - } + r = sd_bus_message_exit_container(reply); + if (r < 0) + return bus_log_parse_error(r); return 0; } -static int switch_root(DBusConnection *bus, char **args) { - unsigned l; - const char *root; +static int switch_root(sd_bus *bus, char **args) { + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; _cleanup_free_ char *init = NULL; + const char *root; + unsigned l; + int r; l = strv_length(args); if (l < 2 || l > 3) { @@ -4160,59 +3861,60 @@ static int switch_root(DBusConnection *bus, char **args) { if (!init) init = strdup(""); } + if (!init) return log_oom(); log_debug("switching root - root: %s; init: %s", root, init); - return bus_method_call_with_reply( + r = sd_bus_call_method( bus, "org.freedesktop.systemd1", "/org/freedesktop/systemd1", "org.freedesktop.systemd1.Manager", "SwitchRoot", + &error, NULL, - NULL, - DBUS_TYPE_STRING, &root, - DBUS_TYPE_STRING, &init, - DBUS_TYPE_INVALID); + "ss", root, init); + if (r < 0) { + log_error("Failed to switch root: %s", bus_error_message(&error, r)); + return r; + } + + return 0; } -static int set_environment(DBusConnection *bus, char **args) { - _cleanup_dbus_message_unref_ DBusMessage *m = NULL, *reply = NULL; - DBusError error; +static int set_environment(sd_bus *bus, char **args) { + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; + _cleanup_bus_message_unref_ sd_bus_message *m = NULL; const char *method; - DBusMessageIter iter; int r; assert(bus); assert(args); - dbus_error_init(&error); - method = streq(args[0], "set-environment") ? "SetEnvironment" : "UnsetEnvironment"; - m = dbus_message_new_method_call( + r = sd_bus_message_new_method_call( + bus, "org.freedesktop.systemd1", "/org/freedesktop/systemd1", "org.freedesktop.systemd1.Manager", - method); - if (!m) - return log_oom(); - - dbus_message_iter_init_append(m, &iter); + method, + &m); + if (r < 0) + return bus_log_create_error(r); - r = bus_append_strv_iter(&iter, args + 1); + r = sd_bus_message_append_strv(m, args + 1); if (r < 0) - return log_oom(); + return bus_log_create_error(r); - reply = dbus_connection_send_with_reply_and_block(bus, m, -1, &error); - if (!reply) { - log_error("Failed to issue method call: %s", bus_error_message(&error)); - dbus_error_free(&error); - return -EIO; + r = sd_bus_send_with_reply_and_block(bus, m, -1, &error, NULL); + if (r < 0) { + log_error("Failed to set environment: %s", bus_error_message(&error, r)); + return r; } return 0; @@ -4408,17 +4110,15 @@ static int mangle_names(char **original_names, char ***mangled_names) { return 0; } -static int enable_unit(DBusConnection *bus, char **args) { +static int enable_unit(sd_bus *bus, char **args) { + _cleanup_bus_message_unref_ sd_bus_message *reply = NULL, *m = NULL; + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; + _cleanup_strv_free_ char **mangled_names = NULL; const char *verb = args[0]; UnitFileChange *changes = NULL; unsigned n_changes = 0, i; int carries_install_info = -1; - _cleanup_dbus_message_unref_ DBusMessage *m = NULL, *reply = NULL; int r; - _cleanup_dbus_error_free_ DBusError error; - _cleanup_strv_free_ char **mangled_names = NULL; - - dbus_error_init(&error); if (!args[1]) return 0; @@ -4470,10 +4170,9 @@ static int enable_unit(DBusConnection *bus, char **args) { r = 0; } else { - const char *method; - bool send_force = true, expect_carries_install_info = false; - dbus_bool_t a, b; - DBusMessageIter iter, sub, sub2; + const char *method, *type, *path, *source; + int expect_carries_install_info = false; + bool send_force = true; if (streq(verb, "enable")) { method = "EnableUnitFiles"; @@ -4499,103 +4198,66 @@ static int enable_unit(DBusConnection *bus, char **args) { } else assert_not_reached("Unknown verb"); - m = dbus_message_new_method_call( + r = sd_bus_message_new_method_call( + bus, "org.freedesktop.systemd1", "/org/freedesktop/systemd1", "org.freedesktop.systemd1.Manager", - method); - if (!m) { - r = log_oom(); - goto finish; - } - - dbus_message_iter_init_append(m, &iter); + method, + &m); + if (r < 0) + return bus_log_create_error(r); - r = bus_append_strv_iter(&iter, mangled_names); - if (r < 0) { - log_error("Failed to append unit files."); - goto finish; - } + r = sd_bus_message_append_strv(m, mangled_names); + if (r < 0) + return bus_log_create_error(r); - a = arg_runtime; - if (!dbus_message_iter_append_basic(&iter, DBUS_TYPE_BOOLEAN, &a)) { - log_error("Failed to append runtime boolean."); - r = -ENOMEM; - goto finish; - } + r = sd_bus_message_append(m, "b", arg_runtime); + if (r < 0) + return bus_log_create_error(r); if (send_force) { - b = arg_force; - - if (!dbus_message_iter_append_basic(&iter, DBUS_TYPE_BOOLEAN, &b)) { - log_error("Failed to append force boolean."); - r = -ENOMEM; - goto finish; - } - } - - reply = dbus_connection_send_with_reply_and_block(bus, m, -1, &error); - if (!reply) { - log_error("Failed to issue method call: %s", bus_error_message(&error)); - r = -EIO; - goto finish; + r = sd_bus_message_append(m, "b", arg_force); + if (r < 0) + return bus_log_create_error(r); } - if (!dbus_message_iter_init(reply, &iter)) { - log_error("Failed to initialize iterator."); - goto finish; + r = sd_bus_send_with_reply_and_block(bus, m, -0, &error, &reply); + if (r < 0) { + log_error("Failed to execute operation: %s", bus_error_message(&error, r)); + return r; } if (expect_carries_install_info) { - r = bus_iter_get_basic_and_next(&iter, DBUS_TYPE_BOOLEAN, &b, true); - if (r < 0) { - log_error("Failed to parse reply."); - goto finish; - } - - carries_install_info = b; - } - - if (dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_ARRAY || - dbus_message_iter_get_element_type(&iter) != DBUS_TYPE_STRUCT) { - log_error("Failed to parse reply."); - r = -EIO; - goto finish; + r = sd_bus_message_read(reply, "b", &carries_install_info); + if (r < 0) + return bus_log_parse_error(r); } - dbus_message_iter_recurse(&iter, &sub); - while (dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_INVALID) { - const char *type, *path, *source; - - if (dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_STRUCT) { - log_error("Failed to parse reply."); - r = -EIO; - goto finish; - } - - dbus_message_iter_recurse(&sub, &sub2); - - if (bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &type, true) < 0 || - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &path, true) < 0 || - bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &source, false) < 0) { - log_error("Failed to parse reply."); - r = -EIO; - goto finish; - } + r = sd_bus_message_enter_container(reply, SD_BUS_TYPE_ARRAY, "(sss)"); + if (r < 0) + return bus_log_parse_error(r); + while ((r = sd_bus_message_read(reply, "(sss)", &type, &path, &source)) > 0) { if (!arg_quiet) { if (streq(type, "symlink")) log_info("ln -s '%s' '%s'", source, path); else log_info("rm '%s'", path); } - - dbus_message_iter_next(&sub); } + if (r < 0) + return bus_log_parse_error(r); + + r = sd_bus_message_exit_container(reply); + if (r < 0) + return bus_log_parse_error(r); /* Try to reload if enabeld */ if (!arg_no_reload) r = daemon_reload(bus, args); + else + r = 0; } if (carries_install_info == 0) @@ -4615,15 +4277,13 @@ finish: return r; } -static int unit_is_enabled(DBusConnection *bus, char **args) { - _cleanup_dbus_error_free_ DBusError error; - int r; - _cleanup_dbus_message_unref_ DBusMessage *reply = NULL; +static int unit_is_enabled(sd_bus *bus, char **args) { + + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; + _cleanup_strv_free_ char **mangled_names = NULL; bool enabled; char **name; - _cleanup_strv_free_ char **mangled_names = NULL; - - dbus_error_init(&error); + int r; r = mangle_names(args+1, &mangled_names); if (r < 0) @@ -4641,9 +4301,10 @@ static int unit_is_enabled(DBusConnection *bus, char **args) { UnitFileState state; state = unit_file_get_state(arg_scope, arg_root, *name); - - if (state < 0) + if (state < 0) { + log_error("Failed to get unit file state for %s: %s", *name, strerror(-state)); return state; + } if (state == UNIT_FILE_ENABLED || state == UNIT_FILE_ENABLED_RUNTIME || @@ -4656,31 +4317,26 @@ static int unit_is_enabled(DBusConnection *bus, char **args) { } else { STRV_FOREACH(name, mangled_names) { + _cleanup_bus_message_unref_ sd_bus_message *reply = NULL; const char *s; - r = bus_method_call_with_reply ( + r = sd_bus_call_method( bus, "org.freedesktop.systemd1", "/org/freedesktop/systemd1", "org.freedesktop.systemd1.Manager", "GetUnitFileState", + &error, &reply, - NULL, - DBUS_TYPE_STRING, name, - DBUS_TYPE_INVALID); - - if (r) + "s", name); + if (r < 0) { + log_error("Failed to get unit file state for %s: %s", *name, bus_error_message(&error, r)); return r; - - if (!dbus_message_get_args(reply, &error, - DBUS_TYPE_STRING, &s, - DBUS_TYPE_INVALID)) { - log_error("Failed to parse reply: %s", bus_error_message(&error)); - return -EIO; } - dbus_message_unref(reply); - reply = NULL; + r = sd_bus_message_read(reply, "s", &s); + if (r < 0) + return bus_log_parse_error(r); if (streq(s, "enabled") || streq(s, "enabled-runtime") || @@ -4692,7 +4348,7 @@ static int unit_is_enabled(DBusConnection *bus, char **args) { } } - return enabled ? 0 : 1; + return !enabled; } static int systemctl_help(void) { @@ -4703,6 +4359,12 @@ static int systemctl_help(void) { "Query or send control commands to the systemd manager.\n\n" " -h --help Show this help\n" " --version Show package version\n" + " --system Connect to system manager\n" + " --user Connect to user service manager\n" + " -H --host=[USER@]HOST\n" + " Operate on remote host\n" + " -M --machine=CONTAINER\n" + " Operate on local container\n" " -t --type=TYPE List only units of a particular type\n" " --state=STATE List only units with particular LOAD or SUB or ACTIVE state\n" " -p --property=NAME Show only properties by this name\n" @@ -4722,9 +4384,6 @@ static int systemctl_help(void) { " When shutting down or sleeping, ignore inhibitors\n" " --kill-who=WHO Who to send signal to\n" " -s --signal=SIGNAL Which signal to send\n" - " -H --host=[USER@]HOST\n" - " Show information for remote host\n" - " -P --privileged Acquire privileges before execution\n" " -q --quiet Suppress output\n" " --no-block Do not wait until operation finished\n" " --no-wall Don't send wall message before halt/power-off/reboot\n" @@ -4734,8 +4393,6 @@ static int systemctl_help(void) { " --no-pager Do not pipe output into a pager\n" " --no-ask-password\n" " Do not ask for system passwords\n" - " --system Connect to system manager\n" - " --user Connect to user service manager\n" " --global Enable/disable unit files globally\n" " --runtime Enable unit files only temporarily until next reboot\n" " -f --force When enabling unit files, override existing symlinks\n" @@ -4804,7 +4461,7 @@ static int systemctl_help(void) { " emergency Enter system emergency mode\n" " halt Shut down and halt the system\n" " poweroff Shut down and power-off the system\n" - " reboot Shut down and reboot the system\n" + " reboot [ARG] Shut down and reboot the system\n" " kexec Shut down and reboot the system with kexec\n" " exit Request user instance exit\n" " switch-root [ROOT] [INIT] Change to a different root file system\n" @@ -4818,7 +4475,7 @@ static int systemctl_help(void) { static int halt_help(void) { - printf("%s [OPTIONS...]\n\n" + printf("%s [OPTIONS...]%s\n\n" "%s the system.\n\n" " --help Show this help\n" " --halt Halt the machine\n" @@ -4829,6 +4486,7 @@ static int halt_help(void) { " -d --no-wtmp Don't write wtmp record\n" " --no-wall Don't send wall message before halt/power-off/reboot\n", program_invocation_short_name, + arg_action == ACTION_REBOOT ? " [ARG]" : "", arg_action == ACTION_REBOOT ? "Reboot" : arg_action == ACTION_POWEROFF ? "Power off" : "Halt"); @@ -4955,7 +4613,7 @@ static int systemctl_parse_argv(int argc, char *argv[]) { { "signal", required_argument, NULL, 's' }, { "no-ask-password", no_argument, NULL, ARG_NO_ASK_PASSWORD }, { "host", required_argument, NULL, 'H' }, - { "privileged", no_argument, NULL, 'P' }, + { "machine", required_argument, NULL, 'M' }, { "runtime", no_argument, NULL, ARG_RUNTIME }, { "lines", required_argument, NULL, 'n' }, { "output", required_argument, NULL, 'o' }, @@ -4969,7 +4627,7 @@ static int systemctl_parse_argv(int argc, char *argv[]) { assert(argc >= 0); assert(argv); - while ((c = getopt_long(argc, argv, "ht:p:alqfs:H:Pn:o:i", options, NULL)) >= 0) { + while ((c = getopt_long(argc, argv, "ht:p:alqfs:H:M:n:o:i", options, NULL)) >= 0) { switch (c) { @@ -5027,7 +4685,7 @@ static int systemctl_parse_argv(int argc, char *argv[]) { /* Make sure that if the empty property list was specified, we won't show any properties. */ if (isempty(optarg) && !arg_properties) { - arg_properties = strv_new(NULL, NULL); + arg_properties = new0(char*, 1); if (!arg_properties) return log_oom(); } else { @@ -5161,13 +4819,14 @@ static int systemctl_parse_argv(int argc, char *argv[]) { arg_ask_password = false; break; - case 'P': - arg_transport = TRANSPORT_POLKIT; + case 'H': + arg_transport = BUS_TRANSPORT_REMOTE; + arg_host = optarg; break; - case 'H': - arg_transport = TRANSPORT_SSH; - parse_user_at_host(optarg, &arg_user, &arg_host); + case 'M': + arg_transport = BUS_TRANSPORT_CONTAINER; + arg_host = optarg; break; case ARG_RUNTIME: @@ -5224,7 +4883,7 @@ static int systemctl_parse_argv(int argc, char *argv[]) { } } - if (arg_transport != TRANSPORT_NORMAL && arg_scope != UNIT_FILE_SYSTEM) { + if (arg_transport != BUS_TRANSPORT_LOCAL && arg_scope != UNIT_FILE_SYSTEM) { log_error("Cannot access user instance remotely."); return -EINVAL; } @@ -5253,7 +4912,7 @@ static int halt_parse_argv(int argc, char *argv[]) { {} }; - int c, runlevel; + int c, r, runlevel; assert(argc >= 0); assert(argv); @@ -5311,7 +4970,14 @@ static int halt_parse_argv(int argc, char *argv[]) { } } - if (optind < argc) { + if (arg_action == ACTION_REBOOT && argc == optind + 1) { + r = write_string_file(REBOOT_PARAM_FILE, argv[optind]); + if (r < 0) { + log_error("Failed to write reboot param to " + REBOOT_PARAM_FILE": %s", strerror(-r)); + return r; + } + } else if (optind < argc) { log_error("Too many arguments."); return -EINVAL; } @@ -5616,7 +5282,7 @@ static int parse_argv(int argc, char *argv[]) { } else if (strstr(program_invocation_short_name, "init")) { if (sd_booted() > 0) { - arg_action = ACTION_INVALID; + arg_action = _ACTION_INVALID; return telinit_parse_argv(argc, argv); } else { /* Hmm, so some other init system is @@ -5659,18 +5325,21 @@ _pure_ static int action_to_runlevel(void) { } static int talk_initctl(void) { - struct init_request request = {}; - int r; + + struct init_request request = { + .magic = INIT_MAGIC, + .sleeptime = 0, + .cmd = INIT_CMD_RUNLVL + }; + _cleanup_close_ int fd = -1; char rl; + int r; rl = action_to_runlevel(); if (!rl) return 0; - request.magic = INIT_MAGIC; - request.sleeptime = 0; - request.cmd = INIT_CMD_RUNLVL; request.runlevel = rl; fd = open(INIT_FIFO, O_WRONLY|O_NDELAY|O_CLOEXEC|O_NOCTTY); @@ -5692,7 +5361,7 @@ static int talk_initctl(void) { return 1; } -static int systemctl_main(DBusConnection *bus, int argc, char *argv[], DBusError *error) { +static int systemctl_main(sd_bus *bus, int argc, char *argv[], int bus_error) { static const struct { const char* verb; @@ -5702,7 +5371,7 @@ static int systemctl_main(DBusConnection *bus, int argc, char *argv[], DBusError EQUAL } argc_cmp; const int argc; - int (* const dispatch)(DBusConnection *bus, char **args); + int (* const dispatch)(sd_bus *bus, char **args); } verbs[] = { { "list-units", LESS, 1, list_units }, { "list-unit-files", EQUAL, 1, list_unit_files }, @@ -5733,7 +5402,7 @@ static int systemctl_main(DBusConnection *bus, int argc, char *argv[], DBusError { "delete", MORE, 2, delete_snapshot }, { "daemon-reload", EQUAL, 1, daemon_reload }, { "daemon-reexec", EQUAL, 1, daemon_reload }, - { "show-environment", EQUAL, 1, show_enviroment }, + { "show-environment", EQUAL, 1, show_environment }, { "set-environment", MORE, 2, set_environment }, { "unset-environment", MORE, 2, set_environment }, { "halt", EQUAL, 1, start_special }, @@ -5768,7 +5437,6 @@ static int systemctl_main(DBusConnection *bus, int argc, char *argv[], DBusError assert(argc >= 0); assert(argv); - assert(error); left = argc - optind; @@ -5844,16 +5512,14 @@ static int systemctl_main(DBusConnection *bus, int argc, char *argv[], DBusError if (((!streq(verbs[i].verb, "reboot") && !streq(verbs[i].verb, "halt") && !streq(verbs[i].verb, "poweroff")) || arg_force <= 0) && !bus) { - log_error("Failed to get D-Bus connection: %s", - dbus_error_is_set(error) ? error->message : "No connection to service manager."); + log_error("Failed to get D-Bus connection: %s", strerror (-bus_error)); return -EIO; } } else { if (!bus && !avoid_bus()) { - log_error("Failed to get D-Bus connection: %s", - dbus_error_is_set(error) ? error->message : "No connection to service manager."); + log_error("Failed to get D-Bus connection: %s", strerror (-bus_error)); return -EIO; } } @@ -5862,22 +5528,24 @@ static int systemctl_main(DBusConnection *bus, int argc, char *argv[], DBusError } static int send_shutdownd(usec_t t, char mode, bool dry_run, bool warn, const char *message) { - _cleanup_close_ int fd; + struct sd_shutdown_command c = { .usec = t, .mode = mode, .dry_run = dry_run, .warn_wall = warn, }; + union sockaddr_union sockaddr = { .un.sun_family = AF_UNIX, .un.sun_path = "/run/systemd/shutdownd", }; - struct iovec iovec[2] = { - {.iov_base = (char*) &c, + + struct iovec iovec[2] = {{ + .iov_base = (char*) &c, .iov_len = offsetof(struct sd_shutdown_command, wall_message), - } - }; + }}; + struct msghdr msghdr = { .msg_name = &sockaddr, .msg_namelen = offsetof(struct sockaddr_un, sun_path) @@ -5886,6 +5554,8 @@ static int send_shutdownd(usec_t t, char mode, bool dry_run, bool warn, const ch .msg_iovlen = 1, }; + _cleanup_close_ int fd; + fd = socket(AF_UNIX, SOCK_DGRAM|SOCK_CLOEXEC, 0); if (fd < 0) return -errno; @@ -5902,7 +5572,7 @@ static int send_shutdownd(usec_t t, char mode, bool dry_run, bool warn, const ch return 0; } -static int reload_with_fallback(DBusConnection *bus) { +static int reload_with_fallback(sd_bus *bus) { if (bus) { /* First, try systemd via D-Bus. */ @@ -5921,7 +5591,7 @@ static int reload_with_fallback(DBusConnection *bus) { return 0; } -static int start_with_fallback(DBusConnection *bus) { +static int start_with_fallback(sd_bus *bus) { if (bus) { /* First, try systemd via D-Bus. */ @@ -5942,9 +5612,9 @@ done: return 0; } -static _noreturn_ void halt_now(enum action a) { +static int halt_now(enum action a) { - /* Make sure C-A-D is handled by the kernel from this +/* Make sure C-A-D is handled by the kernel from this * point on... */ reboot(RB_ENABLE_CAD); @@ -5953,26 +5623,33 @@ static _noreturn_ void halt_now(enum action a) { case ACTION_HALT: log_info("Halting."); reboot(RB_HALT_SYSTEM); - break; + return -errno; case ACTION_POWEROFF: log_info("Powering off."); reboot(RB_POWER_OFF); - break; + return -errno; + + case ACTION_REBOOT: { + _cleanup_free_ char *param = NULL; + + if (read_one_line_file(REBOOT_PARAM_FILE, ¶m) >= 0) { + log_info("Rebooting with argument '%s'.", param); + syscall(SYS_reboot, LINUX_REBOOT_MAGIC1, LINUX_REBOOT_MAGIC2, + LINUX_REBOOT_CMD_RESTART2, param); + } - case ACTION_REBOOT: log_info("Rebooting."); reboot(RB_AUTOBOOT); - break; + return -errno; + } default: - assert_not_reached("Unknown halt action."); + assert_not_reached("Unknown action."); } - - assert_not_reached("Uh? This shouldn't happen."); } -static int halt_main(DBusConnection *bus) { +static int halt_main(sd_bus *bus) { int r; r = check_inhibitors(bus, arg_action); @@ -6002,6 +5679,9 @@ static int halt_main(DBusConnection *bus) { _cleanup_free_ char *m; m = strv_join(arg_wall, " "); + if (!m) + return log_oom(); + r = send_shutdownd(arg_when, arg_action == ACTION_HALT ? 'H' : arg_action == ACTION_POWEROFF ? 'P' : @@ -6038,9 +5718,10 @@ static int halt_main(DBusConnection *bus) { if (arg_dry) return 0; - halt_now(arg_action); - /* We should never reach this. */ - return -ENOSYS; + r = halt_now(arg_action); + log_error("Failed to reboot: %s", strerror(-r)); + + return r; } static int runlevel_main(void) { @@ -6060,11 +5741,8 @@ static int runlevel_main(void) { } int main(int argc, char*argv[]) { - int r, retval = EXIT_FAILURE; - DBusConnection *bus = NULL; - _cleanup_dbus_error_free_ DBusError error; - - dbus_error_init(&error); + _cleanup_bus_unref_ sd_bus *bus = NULL; + int r; setlocale(LC_ALL, ""); log_parse_environment(); @@ -6076,44 +5754,32 @@ int main(int argc, char*argv[]) { original_stdout_is_tty = isatty(STDOUT_FILENO); r = parse_argv(argc, argv); - if (r < 0) - goto finish; - else if (r == 0) { - retval = EXIT_SUCCESS; + if (r <= 0) goto finish; - } /* /sbin/runlevel doesn't need to communicate via D-Bus, so * let's shortcut this */ if (arg_action == ACTION_RUNLEVEL) { r = runlevel_main(); - retval = r < 0 ? EXIT_FAILURE : r; goto finish; } if (running_in_chroot() > 0 && arg_action != ACTION_SYSTEMCTL) { log_info("Running in chroot, ignoring request."); - retval = 0; + r = 0; goto finish; } - if (!avoid_bus()) { - if (arg_transport == TRANSPORT_NORMAL) - bus_connect(arg_scope == UNIT_FILE_SYSTEM ? DBUS_BUS_SYSTEM : DBUS_BUS_SESSION, &bus, &private_bus, &error); - else if (arg_transport == TRANSPORT_POLKIT) { - bus_connect_system_polkit(&bus, &error); - private_bus = false; - } else if (arg_transport == TRANSPORT_SSH) { - bus_connect_system_ssh(arg_user, arg_host, &bus, &error); - private_bus = false; - } else - assert_not_reached("Uh, invalid transport..."); - } + if (!avoid_bus()) + r = bus_open_transport_systemd(arg_transport, arg_host, arg_scope != UNIT_FILE_SYSTEM, &bus); + + /* systemctl_main() will print an error message for the bus + * connection, but only if it needs to */ switch (arg_action) { case ACTION_SYSTEMCTL: - r = systemctl_main(bus, argc, argv, &error); + r = systemctl_main(bus, argc, argv, r); break; case ACTION_HALT: @@ -6139,46 +5805,36 @@ int main(int argc, char*argv[]) { break; case ACTION_CANCEL_SHUTDOWN: { - char *m = NULL; + _cleanup_free_ char *m = NULL; if (arg_wall) { m = strv_join(arg_wall, " "); if (!m) { - retval = EXIT_FAILURE; + r = log_oom(); goto finish; } } + r = send_shutdownd(arg_when, SD_SHUTDOWN_NONE, false, !arg_no_wall, m); if (r < 0) log_warning("Failed to talk to shutdownd, shutdown hasn't been cancelled: %s", strerror(-r)); - free(m); break; } - case ACTION_INVALID: case ACTION_RUNLEVEL: + case _ACTION_INVALID: default: assert_not_reached("Unknown action"); } - retval = r < 0 ? EXIT_FAILURE : r; - finish: - if (bus) { - dbus_connection_flush(bus); - dbus_connection_close(bus); - dbus_connection_unref(bus); - } - - dbus_shutdown(); + pager_close(); + ask_password_agent_close(); + polkit_agent_close(); strv_free(arg_types); strv_free(arg_states); strv_free(arg_properties); - pager_close(); - ask_password_agent_close(); - polkit_agent_close(); - - return retval; + return r < 0 ? EXIT_FAILURE : r; }