X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=src%2Fswap.c;h=4a672fbdffe047560ab2430bfc620ce973c28f4e;hp=d093c2e790c2985b24f4f6434919e1bb0313443a;hb=f3d41013e24a81b2c853393593d1d52c156826ec;hpb=2c966c038dc32ef39baa176371395cde4e541d01 diff --git a/src/swap.c b/src/swap.c index d093c2e79..4a672fbdf 100644 --- a/src/swap.c +++ b/src/swap.c @@ -1,4 +1,4 @@ -/*-*- Mode: C; c-basic-offset: 8 -*-*/ +/*-*- Mode: C; c-basic-offset: 8; indent-tabs-mode: nil -*-*/ /*** This file is part of systemd. @@ -110,7 +110,7 @@ static int swap_add_target_links(Swap *s) { else return 0; - if ((r = manager_load_unit(s->meta.manager, SPECIAL_SWAP_TARGET, NULL, &tu)) < 0) + if ((r = manager_load_unit(s->meta.manager, SPECIAL_SWAP_TARGET, NULL, NULL, &tu)) < 0) return r; if (!p->noauto && p->handle && s->meta.manager->running_as == MANAGER_SYSTEM) @@ -120,6 +120,24 @@ static int swap_add_target_links(Swap *s) { return unit_add_dependency(UNIT(s), UNIT_BEFORE, tu, true); } +static int swap_add_default_dependencies(Swap *s) { + int r; + + assert(s); + + if (s->meta.manager->running_as == MANAGER_SYSTEM) { + + if ((r = unit_add_dependency_by_name(UNIT(s), UNIT_AFTER, SPECIAL_SYSINIT_TARGET, NULL, true)) < 0) + return r; + + /* Note that by default we don't disable swap devices + * on shutdown. i.e. there is no umount.target + * conflicts here. */ + } + + return 0; +} + static int swap_verify(Swap *s) { bool b; char *e; @@ -177,7 +195,9 @@ static int swap_load(Unit *u) { if ((r = unit_set_description(u, s->what)) < 0) return r; - if ((r = unit_add_node_link(u, s->what, u->meta.manager->running_as == MANAGER_SYSTEM)) < 0) + if ((r = unit_add_node_link(u, s->what, + u->meta.manager->running_as == MANAGER_SYSTEM && + u->meta.manager->swap_on_plug)) < 0) return r; if ((r = swap_add_mount_links(s)) < 0) @@ -185,6 +205,10 @@ static int swap_load(Unit *u) { if ((r = swap_add_target_links(s)) < 0) return r; + + if (s->meta.default_dependencies) + if ((r = swap_add_default_dependencies(s)) < 0) + return r; } return swap_verify(s); @@ -378,7 +402,7 @@ static void swap_dump(Unit *u, FILE *f, const char *prefix) { static void swap_enter_dead(Swap *s, bool success) { assert(s); - swap_set_state(s, success ? SWAP_MAINTENANCE : SWAP_DEAD); + swap_set_state(s, success ? SWAP_DEAD : SWAP_MAINTENANCE); } static int swap_start(Unit *u) { @@ -520,14 +544,6 @@ static void swap_shutdown(Manager *m) { } } -static const char* const swap_state_table[_SWAP_STATE_MAX] = { - [SWAP_DEAD] = "dead", - [SWAP_ACTIVE] = "active", - [SWAP_MAINTENANCE] = "maintenance" -}; - -DEFINE_STRING_TABLE_LOOKUP(swap_state, SwapState); - static int swap_enumerate(Manager *m) { int r; assert(m); @@ -542,11 +558,29 @@ static int swap_enumerate(Manager *m) { return r; } +static void swap_reset_maintenance(Unit *u) { + Swap *s = SWAP(u); + + assert(s); + + if (s->state == SWAP_MAINTENANCE) + swap_set_state(s, SWAP_DEAD); +} + +static const char* const swap_state_table[_SWAP_STATE_MAX] = { + [SWAP_DEAD] = "dead", + [SWAP_ACTIVE] = "active", + [SWAP_MAINTENANCE] = "maintenance" +}; + +DEFINE_STRING_TABLE_LOOKUP(swap_state, SwapState); + const UnitVTable swap_vtable = { .suffix = ".swap", .no_instances = true, .no_isolate = true, + .show_status = true, .init = swap_init, .load = swap_load, @@ -567,7 +601,11 @@ const UnitVTable swap_vtable = { .check_gc = swap_check_gc, + .bus_interface = "org.freedesktop.systemd1.Swap", .bus_message_handler = bus_swap_message_handler, + .bus_invalidating_properties = bus_swap_invalidating_properties, + + .reset_maintenance = swap_reset_maintenance, .enumerate = swap_enumerate, .shutdown = swap_shutdown