X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=src%2Fshared%2Flog.c;h=af1a932c86e9e37971c821f2e30b07d9a7481171;hp=56469b32b5d44dfe69e822921130cbe2c8c7163b;hb=bf371116f69261c17e47dc3dbb51cfaa3c9369ff;hpb=8f16f51d9323e87cc78d28e9656984c028071f94 diff --git a/src/shared/log.c b/src/shared/log.c index 56469b32b..af1a932c8 100644 --- a/src/shared/log.c +++ b/src/shared/log.c @@ -106,8 +106,8 @@ void log_close_syslog(void) { } static int create_log_socket(int type) { - int fd; struct timeval tv; + int fd; fd = socket(AF_UNIX, type|SOCK_CLOEXEC, 0); if (fd < 0) @@ -128,12 +128,14 @@ static int create_log_socket(int type) { } static int log_open_syslog(void) { - int r; - union sockaddr_union sa = { + + static const union sockaddr_union sa = { .un.sun_family = AF_UNIX, .un.sun_path = "/dev/log", }; + int r; + if (syslog_fd >= 0) return 0; @@ -176,10 +178,12 @@ void log_close_journal(void) { } static int log_open_journal(void) { - union sockaddr_union sa = { + + static const union sockaddr_union sa = { .un.sun_family = AF_UNIX, .un.sun_path = "/run/systemd/journal/socket", }; + int r; if (journal_fd >= 0) @@ -303,7 +307,7 @@ void log_set_facility(int facility) { static int write_to_console( int level, int error, - const char*file, + const char *file, int line, const char *func, const char *object_field, @@ -359,7 +363,7 @@ static int write_to_console( static int write_to_syslog( int level, int error, - const char*file, + const char *file, int line, const char *func, const char *object_field, @@ -529,17 +533,17 @@ static int write_to_journal( static int log_dispatch( int level, int error, - const char*file, + const char *file, int line, const char *func, const char *object_field, const char *object, char *buffer) { - int r = 0; + assert(buffer); if (log_target == LOG_TARGET_NULL) - return 0; + return -error; /* Patch in LOG_DAEMON facility if necessary */ if ((level & LOG_FACMASK) == 0) @@ -569,8 +573,7 @@ static int log_dispatch( if (k != -EAGAIN) log_close_journal(); log_open_kmsg(); - } else if (k > 0) - r++; + } } if (log_target == LOG_TARGET_SYSLOG_OR_KMSG || @@ -581,8 +584,7 @@ static int log_dispatch( if (k != -EAGAIN) log_close_syslog(); log_open_kmsg(); - } else if (k > 0) - r++; + } } if (k <= 0 && @@ -596,26 +598,22 @@ static int log_dispatch( if (k < 0) { log_close_kmsg(); log_open_console(); - } else if (k > 0) - r++; + } } - if (k <= 0) { - k = write_to_console(level, error, file, line, func, object_field, object, buffer); - if (k < 0) - return k; - } + if (k <= 0) + (void) write_to_console(level, error, file, line, func, object_field, object, buffer); buffer = e; } while (buffer); - return r; + return -error; } int log_dump_internal( int level, int error, - const char*file, + const char *file, int line, const char *func, char *buffer) { @@ -624,8 +622,11 @@ int log_dump_internal( /* This modifies the buffer... */ + if (error < 0) + error = -error; + if (_likely_(LOG_PRI(level) > log_max_level)) - return 0; + return -error; return log_dispatch(level, error, file, line, func, NULL, NULL, buffer); } @@ -642,12 +643,15 @@ int log_internalv( PROTECT_ERRNO; char buffer[LINE_MAX]; + if (error < 0) + error = -error; + if (_likely_(LOG_PRI(level) > log_max_level)) - return 0; + return -error; /* Make sure that %m maps to the specified error */ if (error != 0) - errno = abs(error); + errno = error; vsnprintf(buffer, sizeof(buffer), format, ap); char_array_0(buffer); @@ -663,8 +667,8 @@ int log_internal( const char *func, const char *format, ...) { - int r; va_list ap; + int r; va_start(ap, format); r = log_internalv(level, error, file, line, func, format, ap); @@ -687,12 +691,15 @@ int log_object_internalv( PROTECT_ERRNO; char buffer[LINE_MAX]; + if (error < 0) + error = -error; + if (_likely_(LOG_PRI(level) > log_max_level)) - return 0; + return -error; /* Make sure that %m maps to the specified error */ if (error != 0) - errno = abs(error); + errno = error; vsnprintf(buffer, sizeof(buffer), format, ap); char_array_0(buffer); @@ -710,8 +717,8 @@ int log_object_internal( const char *object, const char *format, ...) { - int r; va_list ap; + int r; va_start(ap, format); r = log_object_internalv(level, error, file, line, func, object_field, object, format, ap); @@ -771,27 +778,27 @@ int log_struct_internal( const char *func, const char *format, ...) { + char buf[LINE_MAX]; + bool found = false; PROTECT_ERRNO; va_list ap; - int r; + + if (error < 0) + error = -error; if (_likely_(LOG_PRI(level) > log_max_level)) - return 0; + return -error; if (log_target == LOG_TARGET_NULL) - return 0; + return -error; if ((level & LOG_FACMASK) == 0) level = log_facility | LOG_PRI(level); - if (error < 0) - error = -error; - if ((log_target == LOG_TARGET_AUTO || log_target == LOG_TARGET_JOURNAL_OR_KMSG || log_target == LOG_TARGET_JOURNAL) && journal_fd >= 0) { - char header[LINE_MAX]; struct iovec iovec[17] = {}; unsigned n = 0, i; @@ -799,6 +806,7 @@ int log_struct_internal( .msg_iov = iovec, }; static const char nl = '\n'; + bool fallback = false; /* If the journal is available do structured logging */ log_do_header(header, sizeof(header), level, error, file, line, func, NULL, NULL); @@ -806,17 +814,20 @@ int log_struct_internal( va_start(ap, format); while (format && n + 1 < ELEMENTSOF(iovec)) { - char *buf; va_list aq; + char *m; /* We need to copy the va_list structure, * since vasprintf() leaves it afterwards at * an undefined location */ + if (error != 0) + errno = error; + va_copy(aq, ap); - if (vasprintf(&buf, format, aq) < 0) { + if (vasprintf(&m, format, aq) < 0) { va_end(aq); - r = -ENOMEM; + fallback = true; goto finish; } va_end(aq); @@ -825,7 +836,7 @@ int log_struct_internal( * the next format string */ VA_FORMAT_ADVANCE(format, ap); - IOVEC_SET_STRING(iovec[n++], buf); + IOVEC_SET_STRING(iovec[n++], m); iovec[n].iov_base = (char*) &nl; iovec[n].iov_len = 1; @@ -836,49 +847,46 @@ int log_struct_internal( mh.msg_iovlen = n; - if (sendmsg(journal_fd, &mh, MSG_NOSIGNAL) < 0) - r = -errno; - else - r = 1; + (void) sendmsg(journal_fd, &mh, MSG_NOSIGNAL); finish: va_end(ap); for (i = 1; i < n; i += 2) free(iovec[i].iov_base); - } else { - char buf[LINE_MAX]; - bool found = false; - - /* Fallback if journal logging is not available */ + if (!fallback) + return -error; + } - va_start(ap, format); - while (format) { - va_list aq; + /* Fallback if journal logging is not available or didn't work. */ - va_copy(aq, ap); - vsnprintf(buf, sizeof(buf), format, aq); - va_end(aq); - char_array_0(buf); + va_start(ap, format); + while (format) { + va_list aq; - if (startswith(buf, "MESSAGE=")) { - found = true; - break; - } + if (error != 0) + errno = error; - VA_FORMAT_ADVANCE(format, ap); + va_copy(aq, ap); + vsnprintf(buf, sizeof(buf), format, aq); + va_end(aq); + char_array_0(buf); - format = va_arg(ap, char *); + if (startswith(buf, "MESSAGE=")) { + found = true; + break; } - va_end(ap); - if (found) - r = log_dispatch(level, error, file, line, func, NULL, NULL, buf + 8); - else - r = -EINVAL; + VA_FORMAT_ADVANCE(format, ap); + + format = va_arg(ap, char *); } + va_end(ap); - return r; + if (!found) + return -error; + + return log_dispatch(level, error, file, line, func, NULL, NULL, buf + 8); } int log_set_target_from_string(const char *e) {