X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=src%2Fshared%2Fhwclock.c;h=7059d9c75b8367a0cb1d3b39983d74087cc54f6d;hp=17f12de51fc6fdb6c652ceee3fac259270e7ed6c;hb=c50e4f95d8cfcd21bde2b0d1ff24b4de8fef4976;hpb=e9dd9f9547350c7dc0473583b5c2228dc8f0ab76 diff --git a/src/shared/hwclock.c b/src/shared/hwclock.c index 17f12de51..7059d9c75 100644 --- a/src/shared/hwclock.c +++ b/src/shared/hwclock.c @@ -44,8 +44,7 @@ #include "fileio.h" int hwclock_get_time(struct tm *tm) { - int fd; - int err = 0; + _cleanup_close_ int fd = -1; assert(tm); @@ -56,20 +55,17 @@ int hwclock_get_time(struct tm *tm) { /* This leaves the timezone fields of struct tm * uninitialized! */ if (ioctl(fd, RTC_RD_TIME, tm) < 0) - err = -errno; + return -errno; /* We don't know daylight saving, so we reset this in order not - * to confused mktime(). */ + * to confuse mktime(). */ tm->tm_isdst = -1; - close_nointr_nofail(fd); - - return err; + return 0; } int hwclock_set_time(const struct tm *tm) { - int fd; - int err = 0; + _cleanup_close_ int fd = -1; assert(tm); @@ -78,11 +74,9 @@ int hwclock_set_time(const struct tm *tm) { return -errno; if (ioctl(fd, RTC_SET_TIME, tm) < 0) - err = -errno; - - close_nointr_nofail(fd); + return -errno; - return err; + return 0; } int hwclock_is_localtime(void) {