X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=src%2Flibsystemd-bus%2Fbusctl.c;h=57bc83d1c19364f2d1082d6e45e0ec223e2cd9bc;hp=717b91120ee1aea864c92a49ebd6abf2797baf00;hb=30caf8f3afd29da8507c0edbcead7935604c9f3e;hpb=eb9da376d76b48585b3b63b4f91903b54f7abd36 diff --git a/src/libsystemd-bus/busctl.c b/src/libsystemd-bus/busctl.c index 717b91120..57bc83d1c 100644 --- a/src/libsystemd-bus/busctl.c +++ b/src/libsystemd-bus/busctl.c @@ -31,10 +31,12 @@ #include "bus-message.h" #include "bus-internal.h" #include "bus-util.h" +#include "bus-dump.h" static bool arg_no_pager = false; static char *arg_address = NULL; static bool arg_no_unique = false; +static bool arg_no_machine = false; static char **arg_matches = NULL; static BusTransport arg_transport = BUS_TRANSPORT_LOCAL; static char *arg_host = NULL; @@ -50,14 +52,14 @@ static void pager_open_if_enabled(void) { } static int list_bus_names(sd_bus *bus, char **argv) { - _cleanup_strv_free_ char **l = NULL; + _cleanup_strv_free_ char **acquired = NULL, **activatable = NULL; char **i; int r; size_t max_i = 0; assert(bus); - r = sd_bus_list_names(bus, &l); + r = sd_bus_list_names(bus, &acquired, &activatable); if (r < 0) { log_error("Failed to list names: %s", strerror(-r)); return r; @@ -65,61 +67,110 @@ static int list_bus_names(sd_bus *bus, char **argv) { pager_open_if_enabled(); - strv_sort(l); + strv_sort(acquired); + strv_sort(activatable); - STRV_FOREACH(i, l) + STRV_FOREACH(i, acquired) max_i = MAX(max_i, strlen(*i)); - printf("%-*s %*s %-*s %-*s CONNECTION\n", - (int) max_i, "NAME", 10, "PID", 15, "PROCESS", 16, "USER"); + STRV_FOREACH(i, activatable) + max_i = MAX(max_i, strlen(*i)); + + printf("%-*s %*s %-*s %-*s %-*s", + (int) max_i, "NAME", 10, "PID", 15, "PROCESS", 16, "USER", 20, "CONNECTION"); + + if (!arg_no_machine) + puts(" MACHINE"); + else + putchar('\n'); + + STRV_FOREACH(i, activatable) { + + /* Skip the bus driver */ + if (streq(*i, "org.freedesktop.DBus")) + continue; + + if (strv_contains(acquired, *i)) + continue; + + printf("%-*s", (int) max_i, *i); + printf(" - - - (activation) "); + if (arg_no_machine) + putchar('\n'); + else + puts(" -"); + } - STRV_FOREACH(i, l) { - _cleanup_free_ char *owner = NULL; - pid_t pid; - uid_t uid; + STRV_FOREACH(i, acquired) { + _cleanup_bus_creds_unref_ sd_bus_creds *creds = NULL; + sd_id128_t mid; if (arg_no_unique && (*i)[0] == ':') continue; + /* Skip the bus driver */ + if (streq(*i, "org.freedesktop.DBus")) + continue; + printf("%-*s", (int) max_i, *i); - r = sd_bus_get_owner_pid(bus, *i, &pid); + r = sd_bus_get_owner(bus, *i, SD_BUS_CREDS_UID|SD_BUS_CREDS_PID|SD_BUS_CREDS_COMM|SD_BUS_CREDS_UNIQUE_NAME, &creds); if (r >= 0) { - _cleanup_free_ char *comm = NULL; + const char *unique; + pid_t pid; + uid_t uid; - printf(" %10lu", (unsigned long) pid); + r = sd_bus_creds_get_pid(creds, &pid); + if (r >= 0) { + const char *comm = NULL; - get_process_comm(pid, &comm); - printf(" %-15s", strna(comm)); - } else - printf(" - - "); + sd_bus_creds_get_comm(creds, &comm); - r = sd_bus_get_owner_uid(bus, *i, &uid); - if (r >= 0) { - _cleanup_free_ char *u = NULL; + printf(" %10lu %-15s", (unsigned long) pid, strna(comm)); + } else + fputs(" - - ", stdout); - u = uid_to_name(uid); - if (!u) - return log_oom(); + r = sd_bus_creds_get_uid(creds, &uid); + if (r >= 0) { + _cleanup_free_ char *u = NULL; - if (strlen(u) > 16) - u[16] = 0; + u = uid_to_name(uid); + if (!u) + return log_oom(); - printf(" %-16s", u); - } else - printf(" - "); + if (strlen(u) > 16) + u[16] = 0; - r = sd_bus_get_owner(bus, *i, &owner); - if (r >= 0) - printf(" %s\n", owner); - else - printf(" -\n"); + printf(" %-16s", u); + } else + fputs(" - ", stdout); + + r = sd_bus_creds_get_unique_name(creds, &unique); + if (r >= 0) + printf(" %-20s", unique); + else + fputs(" - ", stdout); + + } else + printf(" - - - - "); + + if (arg_no_machine) + putchar('\n'); + else { + r = sd_bus_get_owner_machine_id(bus, *i, &mid); + if (r >= 0) { + char m[SD_ID128_STRING_MAX]; + printf(" %s\n", sd_id128_to_string(mid, m)); + } else + puts(" -"); + } } return 0; } static int monitor(sd_bus *bus, char *argv[]) { + bool added_something = false; char **i; int r; @@ -140,6 +191,8 @@ static int monitor(sd_bus *bus, char *argv[]) { log_error("Failed to add match: %s", strerror(-r)); return r; } + + added_something = true; } STRV_FOREACH(i, arg_matches) { @@ -148,6 +201,16 @@ static int monitor(sd_bus *bus, char *argv[]) { log_error("Failed to add match: %s", strerror(-r)); return r; } + + added_something = true; + } + + if (!added_something) { + r = sd_bus_add_match(bus, "", NULL, NULL); + if (r < 0) { + log_error("Failed to add match: %s", strerror(-r)); + return r; + } } for (;;) { @@ -173,8 +236,33 @@ static int monitor(sd_bus *bus, char *argv[]) { return r; } } +} - return -EINVAL; +static int status(sd_bus *bus, char *argv[]) { + _cleanup_bus_creds_unref_ sd_bus_creds *creds = NULL; + pid_t pid; + int r; + + assert(bus); + + if (strv_length(argv) != 2) { + log_error("Expects one argument."); + return -EINVAL; + } + + r = parse_pid(argv[1], &pid); + if (r < 0) + r = sd_bus_get_owner(bus, argv[1], _SD_BUS_CREDS_ALL, &creds); + else + r = sd_bus_creds_new_from_pid(pid, _SD_BUS_CREDS_ALL, &creds); + + if (r < 0) { + log_error("Failed to get credentials: %s", strerror(-r)); + return r; + } + + bus_creds_dump(creds, NULL); + return 0; } static int help(void) { @@ -183,17 +271,20 @@ static int help(void) { "Introspect the bus.\n\n" " -h --help Show this help\n" " --version Show package version\n" + " --no-pager Do not pipe output into a pager\n" " --system Connect to system bus\n" " --user Connect to user bus\n" " -H --host=[USER@]HOST Operate on remote host\n" " -M --machine=CONTAINER Operate on local container\n" " --address=ADDRESS Connect to bus specified by address\n" " --no-unique Only show well-known names\n" - " --match=MATCH Only show matching messages\n" - " --no-pager Do not pipe output into a pager\n\n" + " --no-machine Don't show machine ID column in list\n" + " --match=MATCH Only show matching messages\n\n" "Commands:\n" " list List bus names\n" - " monitor [SERVICE...] Show bus traffic\n", + " monitor [SERVICE...] Show bus traffic\n" + " status ENDPOINT Show endpoint status\n" + " help Show this help\n", program_invocation_short_name); return 0; @@ -208,18 +299,22 @@ static int parse_argv(int argc, char *argv[]) { ARG_USER, ARG_ADDRESS, ARG_MATCH, - ARG_NO_UNIQUE + ARG_NO_UNIQUE, + ARG_NO_MACHINE, }; static const struct option options[] = { - { "help", no_argument, NULL, 'h' }, - { "version", no_argument, NULL, ARG_VERSION }, - { "no-pager", no_argument, NULL, ARG_NO_PAGER }, - { "system", no_argument, NULL, ARG_SYSTEM }, - { "user", no_argument, NULL, ARG_USER }, - { "address", required_argument, NULL, ARG_ADDRESS }, - { "no-unique", no_argument, NULL, ARG_NO_UNIQUE }, - { "match", required_argument, NULL, ARG_MATCH }, + { "help", no_argument, NULL, 'h' }, + { "version", no_argument, NULL, ARG_VERSION }, + { "no-pager", no_argument, NULL, ARG_NO_PAGER }, + { "system", no_argument, NULL, ARG_SYSTEM }, + { "user", no_argument, NULL, ARG_USER }, + { "address", required_argument, NULL, ARG_ADDRESS }, + { "no-unique", no_argument, NULL, ARG_NO_UNIQUE }, + { "no-machine", no_argument, NULL, ARG_NO_MACHINE }, + { "match", required_argument, NULL, ARG_MATCH }, + { "host", required_argument, NULL, 'H' }, + { "machine", required_argument, NULL, 'M' }, {}, }; @@ -260,6 +355,10 @@ static int parse_argv(int argc, char *argv[]) { arg_no_unique = true; break; + case ARG_NO_MACHINE: + arg_no_machine = true; + break; + case ARG_MATCH: if (strv_extend(&arg_matches, optarg) < 0) return log_oom(); @@ -296,6 +395,9 @@ static int busctl_main(sd_bus *bus, int argc, char *argv[]) { if (streq(argv[optind], "monitor")) return monitor(bus, argv + optind); + if (streq(argv[optind], "status")) + return status(bus, argv + optind); + if (streq(argv[optind], "help")) return help();