X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=src%2Fdelta%2Fdelta.c;h=99305716ed7a30998a255238ce44a23ea4e4e4ae;hp=2a1ad3d951f55517291c21da7faaa79a30d92ca8;hb=820d3acfe924e58965d14b4711d5df31c5db199a;hpb=0a1beeb64207eaa88ab9236787b1cbc2f704ae14 diff --git a/src/delta/delta.c b/src/delta/delta.c index 2a1ad3d95..99305716e 100644 --- a/src/delta/delta.c +++ b/src/delta/delta.c @@ -185,16 +185,15 @@ static int found_override(const char *top, const char *bottom) { fflush(stdout); pid = fork(); - if (pid < 0) { - log_error("Failed to fork off diff: %m"); - return -errno; - } else if (pid == 0) { + if (pid < 0) + return log_error_errno(errno, "Failed to fork off diff: %m"); + else if (pid == 0) { execlp("diff", "diff", "-us", "--", bottom, top, NULL); - log_error("Failed to execute diff: %m"); + log_error_errno(errno, "Failed to execute diff: %m"); _exit(1); } - wait_for_terminate_and_warn("diff", pid); + wait_for_terminate_and_warn("diff", pid, false); putchar('\n'); return k; @@ -226,10 +225,8 @@ static int enumerate_dir_d(Hashmap *top, Hashmap *bottom, Hashmap *drops, const *c = 0; r = get_files_in_directory(path, &list); - if (r < 0){ - log_error_errno(-r, "Failed to enumerate %s: %m", path); - return r; - } + if (r < 0) + return log_error_errno(r, "Failed to enumerate %s: %m", path); STRV_FOREACH(file, list) { Hashmap *h; @@ -307,7 +304,7 @@ static int enumerate_dir(Hashmap *top, Hashmap *bottom, Hashmap *drops, const ch if (errno == ENOENT) return 0; - log_error("Failed to open %s: %m", path); + log_error_errno(errno, "Failed to open %s: %m", path); return -errno; }