X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=src%2Fcore%2Fnamespace.c;h=a2025459f1447823ed0fe3f43208e9720d345280;hp=c2215090a9dfa2bea6d7ecc572d1e22d362b2dac;hb=79008bddf679a5e0900369950eb346c9fa687107;hpb=d267c5aa3d0fe4960165a1e1c00a840eef8b7d00 diff --git a/src/core/namespace.c b/src/core/namespace.c index c2215090a..a2025459f 100644 --- a/src/core/namespace.c +++ b/src/core/namespace.c @@ -145,7 +145,7 @@ static int mount_dev(BindMount *m) { "/dev/tty\0"; char temporary_mount[] = "/tmp/namespace-dev-XXXXXX"; - const char *d, *dev = NULL, *devpts = NULL, *devshm = NULL, *devkdbus = NULL, *devhugepages = NULL, *devmqueue = NULL, *devlog = NULL, *devptmx = NULL; + const char *d, *dev = NULL, *devpts = NULL, *devshm = NULL, *devhugepages = NULL, *devmqueue = NULL, *devlog = NULL, *devptmx = NULL; _cleanup_umask_ mode_t u; int r; @@ -157,14 +157,14 @@ static int mount_dev(BindMount *m) { return -errno; dev = strappenda(temporary_mount, "/dev"); - mkdir(dev, 0755); + (void)mkdir(dev, 0755); if (mount("tmpfs", dev, "tmpfs", MS_NOSUID|MS_STRICTATIME, "mode=755") < 0) { r = -errno; goto fail; } devpts = strappenda(temporary_mount, "/dev/pts"); - mkdir(devpts, 0755); + (void)mkdir(devpts, 0755); if (mount("/dev/pts", devpts, NULL, MS_BIND, NULL) < 0) { r = -errno; goto fail; @@ -174,7 +174,7 @@ static int mount_dev(BindMount *m) { symlink("pts/ptmx", devptmx); devshm = strappenda(temporary_mount, "/dev/shm"); - mkdir(devshm, 01777); + (void)mkdir(devshm, 01777); r = mount("/dev/shm", devshm, NULL, MS_BIND, NULL); if (r < 0) { r = -errno; @@ -182,15 +182,11 @@ static int mount_dev(BindMount *m) { } devmqueue = strappenda(temporary_mount, "/dev/mqueue"); - mkdir(devmqueue, 0755); + (void)mkdir(devmqueue, 0755); mount("/dev/mqueue", devmqueue, NULL, MS_BIND, NULL); - devkdbus = strappenda(temporary_mount, "/dev/kdbus"); - mkdir(devkdbus, 0755); - mount("/dev/kdbus", devkdbus, NULL, MS_BIND, NULL); - devhugepages = strappenda(temporary_mount, "/dev/hugepages"); - mkdir(devhugepages, 0755); + (void)mkdir(devhugepages, 0755); mount("/dev/hugepages", devhugepages, NULL, MS_BIND, NULL); devlog = strappenda(temporary_mount, "/dev/log"); @@ -225,9 +221,9 @@ static int mount_dev(BindMount *m) { goto fail; } - label_context_set(d, st.st_mode); + mac_selinux_create_file_prepare(d, st.st_mode); r = mknod(dn, st.st_mode, st.st_rdev); - label_context_clear(); + mac_selinux_create_file_clear(); if (r < 0) { r = -errno; @@ -254,9 +250,6 @@ fail: if (devshm) umount(devshm); - if (devkdbus) - umount(devkdbus); - if (devhugepages) umount(devhugepages); @@ -289,7 +282,7 @@ static int mount_kdbus(BindMount *m) { } root = strappenda(temporary_mount, "/kdbus"); - mkdir(root, 0755); + (void)mkdir(root, 0755); if (mount("tmpfs", root, "tmpfs", MS_NOSUID|MS_STRICTATIME, "mode=777") < 0) { r = -errno; goto fail; @@ -424,9 +417,9 @@ int setup_namespace( char** read_write_dirs, char** read_only_dirs, char** inaccessible_dirs, - char* tmp_dir, - char* var_tmp_dir, - char* bus_endpoint_path, + const char* tmp_dir, + const char* var_tmp_dir, + const char* bus_endpoint_path, bool private_dev, ProtectHome protect_home, ProtectSystem protect_system,