X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=src%2Fcore%2Fdbus-job.c;h=fdc1dce1777e16517c0f34810f9419fd6dd4fd8d;hp=1b86e96624369016d05b122545c1fac3dfb3d539;hb=ffc227c9568eb0a12dc750761d1e5d68ea125aad;hpb=5430f7f2bc7330f3088b894166bf3524a067e3d8 diff --git a/src/core/dbus-job.c b/src/core/dbus-job.c index 1b86e9662..fdc1dce17 100644 --- a/src/core/dbus-job.c +++ b/src/core/dbus-job.c @@ -25,6 +25,7 @@ #include "log.h" #include "dbus-job.h" #include "dbus-common.h" +#include "selinux-access.h" #define BUS_JOB_INTERFACE \ " \n" \ @@ -68,7 +69,8 @@ static int bus_job_append_unit(DBusMessageIter *i, const char *property, void *d if (!dbus_message_iter_open_container(i, DBUS_TYPE_STRUCT, NULL, &sub)) return -ENOMEM; - if (!(p = unit_dbus_path(j->unit))) + p = unit_dbus_path(j->unit); + if (!p) return -ENOMEM; if (!dbus_message_iter_append_basic(&sub, DBUS_TYPE_STRING, &j->unit->id) || @@ -94,43 +96,39 @@ static const BusProperty bus_job_properties[] = { }; static DBusHandlerResult bus_job_message_dispatch(Job *j, DBusConnection *connection, DBusMessage *message) { - DBusMessage *reply = NULL; + _cleanup_dbus_message_unref_ DBusMessage *reply = NULL; if (dbus_message_is_method_call(message, "org.freedesktop.systemd1.Job", "Cancel")) { - if (!(reply = dbus_message_new_method_return(message))) - goto oom; - job_finish_and_invalidate(j, JOB_CANCELED); + SELINUX_UNIT_ACCESS_CHECK(j->unit, connection, message, "stop"); + + reply = dbus_message_new_method_return(message); + if (!reply) + return DBUS_HANDLER_RESULT_NEED_MEMORY; + job_finish_and_invalidate(j, JOB_CANCELED, true); } else { const BusBoundProperties bps[] = { { "org.freedesktop.systemd1.Job", bus_job_properties, j }, { NULL, } }; - return bus_default_message_handler(connection, message, INTROSPECTION, INTERFACES_LIST, bps); - } - if (reply) { - if (!dbus_connection_send(connection, reply, NULL)) - goto oom; + SELINUX_UNIT_ACCESS_CHECK(j->unit, connection, message, "status"); - dbus_message_unref(reply); + return bus_default_message_handler(connection, message, INTROSPECTION, INTERFACES_LIST, bps); } - return DBUS_HANDLER_RESULT_HANDLED; - -oom: - if (reply) - dbus_message_unref(reply); + if (!dbus_connection_send(connection, reply, NULL)) + return DBUS_HANDLER_RESULT_NEED_MEMORY; - return DBUS_HANDLER_RESULT_NEED_MEMORY; + return DBUS_HANDLER_RESULT_HANDLED; } static DBusHandlerResult bus_job_message_handler(DBusConnection *connection, DBusMessage *message, void *data) { Manager *m = data; Job *j; int r; - DBusMessage *reply; + _cleanup_dbus_message_unref_ DBusMessage *reply = NULL; assert(connection); assert(message); @@ -145,7 +143,10 @@ static DBusHandlerResult bus_job_message_handler(DBusConnection *connection, DBu Iterator i; size_t size; - if (!(reply = dbus_message_new_method_return(message))) + SELINUX_ACCESS_CHECK(connection, message, "status"); + + reply = dbus_message_new_method_return(message); + if (!reply) goto oom; /* We roll our own introspection code here, instead of @@ -153,7 +154,8 @@ static DBusHandlerResult bus_job_message_handler(DBusConnection *connection, DBu * need to generate our introspection string * dynamically. */ - if (!(f = open_memstream(&introspection, &size))) + f = open_memstream(&introspection, &size); + if (!f) goto oom; fputs(DBUS_INTROSPECT_1_0_XML_DOCTYPE_DECL_NODE @@ -188,36 +190,28 @@ static DBusHandlerResult bus_job_message_handler(DBusConnection *connection, DBu if (!dbus_connection_send(connection, reply, NULL)) goto oom; - dbus_message_unref(reply); - return DBUS_HANDLER_RESULT_HANDLED; } return DBUS_HANDLER_RESULT_NOT_YET_HANDLED; } - if ((r = manager_get_job_from_dbus_path(m, dbus_message_get_path(message), &j)) < 0) { - - if (r == -ENOMEM) - return DBUS_HANDLER_RESULT_NEED_MEMORY; - - if (r == -ENOENT) { - DBusError e; - - dbus_error_init(&e); - dbus_set_error_const(&e, DBUS_ERROR_UNKNOWN_OBJECT, "Unknown job"); - return bus_send_error_reply(connection, message, &e, r); - } + r = manager_get_job_from_dbus_path(m, dbus_message_get_path(message), &j); + if (r == -ENOMEM) + goto oom; + if (r == -ENOENT) { + DBusError e; - return bus_send_error_reply(connection, message, NULL, r); + dbus_error_init(&e); + dbus_set_error_const(&e, DBUS_ERROR_UNKNOWN_OBJECT, "Unknown job"); + return bus_send_error_reply(connection, message, &e, r); } + if (r < 0) + return bus_send_error_reply(connection, message, NULL, r); return bus_job_message_dispatch(j, connection, message); oom: - if (reply) - dbus_message_unref(reply); - return DBUS_HANDLER_RESULT_NEED_MEMORY; } @@ -225,106 +219,101 @@ const DBusObjectPathVTable bus_job_vtable = { .message_function = bus_job_message_handler }; -static int job_send_message(Job *j, DBusMessage *m) { +static int job_send_message(Job *j, DBusMessage* (*new_message)(Job *j)) { + DBusMessage *m = NULL; int r; assert(j); - assert(m); + assert(new_message); - if (bus_has_subscriber(j->manager)) { - if ((r = bus_broadcast(j->manager, m)) < 0) + if (bus_has_subscriber(j->manager) || j->forgot_bus_clients) { + m = new_message(j); + if (!m) + goto oom; + r = bus_broadcast(j->manager, m); + dbus_message_unref(m); + if (r < 0) return r; - } else if (j->bus_client) { + } else { /* If nobody is subscribed, we just send the message - * to the client which created the job */ + * to the client(s) which created the job */ + JobBusClient *cl; + assert(j->bus_client_list); + LIST_FOREACH(client, cl, j->bus_client_list) { + assert(cl->bus); + + m = new_message(j); + if (!m) + goto oom; - assert(j->bus); + if (!dbus_message_set_destination(m, cl->name)) + goto oom; - if (!dbus_message_set_destination(m, j->bus_client)) - return -ENOMEM; + if (!dbus_connection_send(cl->bus, m, NULL)) + goto oom; - if (!dbus_connection_send(j->bus, m, NULL)) - return -ENOMEM; + dbus_message_unref(m); + m = NULL; + } } return 0; +oom: + if (m) + dbus_message_unref(m); + return -ENOMEM; } -void bus_job_send_change_signal(Job *j) { - char *p = NULL; +static DBusMessage* new_change_signal_message(Job *j) { DBusMessage *m = NULL; + char *p = NULL; - assert(j); - - if (j->in_dbus_queue) { - LIST_REMOVE(Job, dbus_queue, j->manager->dbus_job_queue, j); - j->in_dbus_queue = false; - } - - if (!bus_has_subscriber(j->manager) && !j->bus_client) { - j->sent_dbus_new_signal = true; - return; - } - - if (!(p = job_dbus_path(j))) + p = job_dbus_path(j); + if (!p) goto oom; if (j->sent_dbus_new_signal) { /* Send a properties changed signal */ - - if (!(m = bus_properties_changed_new(p, "org.freedesktop.systemd1.Job", INVALIDATING_PROPERTIES))) + m = bus_properties_changed_new(p, "org.freedesktop.systemd1.Job", INVALIDATING_PROPERTIES); + if (!m) goto oom; } else { /* Send a new signal */ - if (!(m = dbus_message_new_signal("/org/freedesktop/systemd1", "org.freedesktop.systemd1.Manager", "JobNew"))) + m = dbus_message_new_signal("/org/freedesktop/systemd1", "org.freedesktop.systemd1.Manager", "JobNew"); + if (!m) goto oom; if (!dbus_message_append_args(m, DBUS_TYPE_UINT32, &j->id, DBUS_TYPE_OBJECT_PATH, &p, + DBUS_TYPE_STRING, &j->unit->id, DBUS_TYPE_INVALID)) goto oom; } - if (job_send_message(j, m) < 0) - goto oom; - - free(p); - dbus_message_unref(m); - - j->sent_dbus_new_signal = true; - - return; + return m; oom: - free(p); - if (m) dbus_message_unref(m); - - log_error("Failed to allocate job change signal."); + free(p); + return NULL; } -void bus_job_send_removed_signal(Job *j) { - char *p = NULL; +static DBusMessage* new_removed_signal_message(Job *j) { DBusMessage *m = NULL; + char *p = NULL; const char *r; - assert(j); - - if (!bus_has_subscriber(j->manager) && !j->bus_client) - return; - - if (!j->sent_dbus_new_signal) - bus_job_send_change_signal(j); - - if (!(p = job_dbus_path(j))) + p = job_dbus_path(j); + if (!p) goto oom; - if (!(m = dbus_message_new_signal("/org/freedesktop/systemd1", "org.freedesktop.systemd1.Manager", "JobRemoved"))) + m = dbus_message_new_signal("/org/freedesktop/systemd1", "org.freedesktop.systemd1.Manager", "JobRemoved"); + if (!m) goto oom; r = job_result_to_string(j->result); @@ -332,23 +321,58 @@ void bus_job_send_removed_signal(Job *j) { if (!dbus_message_append_args(m, DBUS_TYPE_UINT32, &j->id, DBUS_TYPE_OBJECT_PATH, &p, + DBUS_TYPE_STRING, &j->unit->id, DBUS_TYPE_STRING, &r, DBUS_TYPE_INVALID)) goto oom; - if (job_send_message(j, m) < 0) - goto oom; + return m; +oom: + if (m) + dbus_message_unref(m); free(p); - dbus_message_unref(m); + return NULL; +} + +void bus_job_send_change_signal(Job *j) { + assert(j); + + if (j->in_dbus_queue) { + LIST_REMOVE(Job, dbus_queue, j->manager->dbus_job_queue, j); + j->in_dbus_queue = false; + } + + if (!bus_has_subscriber(j->manager) && !j->bus_client_list && !j->forgot_bus_clients) { + j->sent_dbus_new_signal = true; + return; + } + + if (job_send_message(j, new_change_signal_message) < 0) + goto oom; + + j->sent_dbus_new_signal = true; return; oom: - free(p); + log_error("Failed to allocate job change signal."); +} - if (m) - dbus_message_unref(m); +void bus_job_send_removed_signal(Job *j) { + assert(j); + if (!bus_has_subscriber(j->manager) && !j->bus_client_list && !j->forgot_bus_clients) + return; + + if (!j->sent_dbus_new_signal) + bus_job_send_change_signal(j); + + if (job_send_message(j, new_removed_signal_message) < 0) + goto oom; + + return; + +oom: log_error("Failed to allocate job remove signal."); }