X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=src%2Fask-password-api.c;h=f57105c132e22ec70a529e2f3bcde46a75792501;hp=04d5623d9ee19597bf849de6a13c7c018d5b5dcf;hb=1d6702e8d3877c0bebf3ac817dc45ff72f5ecfa9;hpb=260d370833ba5449f77d4184a8eb80e5501be900 diff --git a/src/ask-password-api.c b/src/ask-password-api.c index 04d5623d9..f57105c13 100644 --- a/src/ask-password-api.c +++ b/src/ask-password-api.c @@ -250,6 +250,7 @@ static int create_socket(char **name) { } sa; int one = 1, r; char *c; + mode_t u; assert(name); @@ -262,7 +263,11 @@ static int create_socket(char **name) { sa.un.sun_family = AF_UNIX; snprintf(sa.un.sun_path, sizeof(sa.un.sun_path)-1, "/run/systemd/ask-password/sck.%llu", random_ull()); - if (bind(fd, &sa.sa, offsetof(struct sockaddr_un, sun_path) + strlen(sa.un.sun_path)) < 0) { + u = umask(0177); + r = bind(fd, &sa.sa, offsetof(struct sockaddr_un, sun_path) + strlen(sa.un.sun_path)); + umask(u); + + if (r < 0) { r = -errno; log_error("bind() failed: %m"); goto fail; @@ -310,6 +315,7 @@ int ask_password_agent( int socket_fd = -1, signal_fd = -1; sigset_t mask, oldmask; struct pollfd pollfd[_FD_MAX]; + mode_t u; assert(_passphrases); @@ -319,7 +325,11 @@ int ask_password_agent( mkdir_p("/run/systemd/ask-password", 0755); - if ((fd = mkostemp(temp, O_CLOEXEC|O_CREAT|O_WRONLY)) < 0) { + u = umask(0022); + fd = mkostemp(temp, O_CLOEXEC|O_CREAT|O_WRONLY); + umask(u); + + if (fd < 0) { log_error("Failed to create password file: %m"); r = -errno; goto finish;