X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=extras%2Fusb_id%2Fusb_id.c;h=c4ce0c610365583c3f55635d905a84dbb51e1da8;hp=bca80f8de10b332a1da62e3eead06819a1062871;hb=c907c823c388dfbdfa7054cfb2f4e9b92eb31e2e;hpb=7618e112b44e1ea3b7d0fa790eff9fbab452ae4f

diff --git a/extras/usb_id/usb_id.c b/extras/usb_id/usb_id.c
index bca80f8de..c4ce0c610 100644
--- a/extras/usb_id/usb_id.c
+++ b/extras/usb_id/usb_id.c
@@ -72,16 +72,17 @@ static char revision_str[16];
 static char type_str[16];
 
 static int use_usb_info;
+static int use_num_info;
 static int export;
+static int debug;
 
-static void set_str(char *to, const unsigned char *from, int count)
+static void set_str(char *to, const char *from, size_t count)
 {
-	int i, j;
-	int len;
+	size_t i, j, len;
 
 	/* strip trailing whitespace */
 	len = strnlen(from, count);
-	while (isspace(from[len-1]))
+	while (len && isspace(from[len-1]))
 		len--;
 
 	/* strip leading whitespace */
@@ -118,25 +119,26 @@ static void set_str(char *to, const unsigned char *from, int count)
  *
  * Set the type based on the USB interface class
  */
-static void set_usb_iftype(char *to, const char *from, int count)
+static void set_usb_iftype(char *to, const char *from, size_t len)
 {
 	int type_num;
 	char *eptr;
+	char *type = "generic";
 
 	type_num = strtoul(from, &eptr, 0);
 	if (eptr != from) {
 		switch (type_num) {
 		case 1:
-			sprintf(to, "audio");
+			type = "audio";
 			break;
 		case 3:
-			sprintf(to, "hid");
+			type = "hid";
 			break;
 		case 7:
-			sprintf(to, "printer");
+			type = "printer";
 			break;
 		case 8:
-			sprintf(to, "disk");
+			type = "disk";
 			break;
 		case 2: /* CDC-Control */
 		case 5: /* Physical */
@@ -151,12 +153,11 @@ static void set_usb_iftype(char *to, const char *from, int count)
 		case 0xf2: /* Application-specific */
 		case 0xff: /* Vendor-specific */
 		default:
-			sprintf(to, "generic");
 			break;
 		}
-	} else {
-		sprintf(to, "generic");
 	}
+	strncpy(to, type, len);
+	to[len-1] = '\0';
 }
 
 /*
@@ -165,32 +166,35 @@ static void set_usb_iftype(char *to, const char *from, int count)
  * Set the type base on the interfaceSubClass.
  * Valid for Mass-Storage devices (type 8) only.
  */
-static int set_usb_ifsubtype(char *to, const char *from, int count)
+static int set_usb_ifsubtype(char *to, const char *from, size_t len)
 {
 	int type_num = 0;
 	char *eptr;
+	char *type = "generic";
 
 	type_num = strtoul(from, &eptr, 0);
 	if (eptr != from) {
 		switch (type_num) {
 		case 2:
-			sprintf(to, "cd");
+			type = "cd";
 			break;
 		case 3:
-			sprintf(to, "tape");
+			type = "tape";
 			break;
 		case 4: /* UFI */
 		case 5: /* SFF-8070i */
-			sprintf(to, "floppy");
+			type = "floppy";
 			break;
 		case 1: /* RBC devices */
 		case 6: /* Transparent SPC-2 devices */
-			sprintf(to, "disk");
+			type = "disk";
+			break;
+		default:
 			break;
 		}
-	} else {
-		sprintf(to, "generic");
 	}
+	strncpy(to, type, len);
+	to[len-1] = '\0';
 
 	return type_num;
 }
@@ -259,7 +263,7 @@ static int usb_id(const char *target_path)
 	struct sysfs_device *target_dev;
 	struct sysfs_device *host_dev, *interface_dev, *usb_dev;
 	struct sysfs_attribute *scsi_model, *scsi_vendor, *scsi_type, *scsi_rev;
-	struct sysfs_attribute *usb_model, *usb_vendor, *usb_rev, *usb_serial;
+	struct sysfs_attribute *usb_model = NULL, *usb_vendor = NULL, *usb_rev, *usb_serial;
 	struct sysfs_attribute *if_class, *if_subclass;
 	int if_class_num;
 	int protocol = 0;
@@ -314,19 +318,20 @@ static int usb_id(const char *target_path)
 	/* usb device directory */
 	usb_dev = sysfs_get_device_parent(interface_dev);
 
-	if (!strcmp(interface_dev->bus, "bus") != 0) {
+	if (strcmp(interface_dev->bus, "usb") != 0) {
 		info("%s is not an usb device", target_path);
 		return 1;
 	}
-	
+
 	if_class = sysfs_get_device_attr(interface_dev, "bInterfaceClass");
 	if (!if_class) {
 		info("%s: cannot get bInterfaceClass attribute", interface_dev->name);
-		return -1;
+		return 1;
 	}
 	if_class_num = strtoul(if_class->value, NULL, 16);
 	if (if_class_num != 8) {
 		set_usb_iftype(type_str, if_class->value, sizeof(type_str) - 1);
+		protocol = 0;
 	} else {
 		if_subclass = sysfs_get_device_attr(interface_dev, 
 						    "bInterfaceSubClass");
@@ -338,29 +343,29 @@ static int usb_id(const char *target_path)
 		/* Generic SPC-2 device */
 		scsi_vendor = sysfs_get_device_attr(scsi_dev, "vendor");
 		if (!scsi_vendor) {
-			info("%s: cannot get vendor attribute", scsi_dev->name);
-			return -1;
+			info("%s: cannot get SCSI vendor attribute", scsi_dev->name);
+			return 1;
 		}
 		set_str(vendor_str, scsi_vendor->value, sizeof(vendor_str)-1);
 
 		scsi_model = sysfs_get_device_attr(scsi_dev, "model");
 		if (!scsi_model) {
-			info("%s: cannot get model attribute", scsi_dev->name);
-			return -1;
+			info("%s: cannot get SCSI model attribute", scsi_dev->name);
+			return 1;
 		}
 		set_str(model_str, scsi_model->value, sizeof(model_str)-1);
 
 		scsi_type = sysfs_get_device_attr(scsi_dev, "type");
 		if (!scsi_type) {
-			info("%s: cannot get type attribute", scsi_dev->name);
-			return -1;
+			info("%s: cannot get SCSI type attribute", scsi_dev->name);
+			return 1;
 		}
 		set_scsi_type(type_str, scsi_type->value, sizeof(type_str)-1);
 
 		scsi_rev = sysfs_get_device_attr(scsi_dev, "rev");
 		if (!scsi_rev) {
-			info("%s: cannot get type attribute", scsi_dev->name);
-			return -1;
+			info("%s: cannot get SCSI revision attribute", scsi_dev->name);
+			return 1;
 		}
 		set_str(revision_str, scsi_rev->value, sizeof(revision_str)-1);
 
@@ -368,19 +373,29 @@ static int usb_id(const char *target_path)
 
 	/* Fallback to USB vendor & device */
 	if (vendor_str[0] == '\0') {
-		usb_vendor = sysfs_get_device_attr(usb_dev, "manufacturer");
+		if (!use_num_info)
+			if (!(usb_vendor = sysfs_get_device_attr(usb_dev, "manufacturer")))
+				dbg("No USB vendor string found, using idVendor");
+
 		if (!usb_vendor) {
-			dbg("No USB vendor string found, using idVendor");
-			usb_vendor = sysfs_get_device_attr(usb_dev, "idVendor");
+			if (!(usb_vendor = sysfs_get_device_attr(usb_dev, "idVendor"))) {
+				dbg("No USB vendor information available\n");
+				sprintf(vendor_str,"0000");
+			}
 		}
 		set_str(vendor_str,usb_vendor->value, sizeof(vendor_str) - 1);
 	}
 	
 	if (model_str[0] == '\0') {
-		usb_model = sysfs_get_device_attr(usb_dev, "product");
+		if (!use_num_info)
+			if (!(usb_model = sysfs_get_device_attr(usb_dev, "product")))
+				dbg("No USB model string found, using idProduct");
+		
 		if (!usb_model) {
-			dbg("No USB model string found, using idProduct");
-			usb_model = sysfs_get_device_attr(usb_dev, "idProduct");
+			if (!(usb_model = sysfs_get_device_attr(usb_dev, "idProduct"))) {
+				dbg("No USB model information available\n");
+				sprintf(model_str,"0000");
+			}
 		}
 		set_str(model_str, usb_model->value, sizeof(model_str) - 1);
 	}
@@ -417,13 +432,20 @@ int main(int argc, char **argv)
 		exit(1);
 	}
 
-	while ((option = getopt(argc, argv, "ux")) != -1 ) {
+	while ((option = getopt(argc, argv, "dnux")) != -1 ) {
 		if (optarg)
 			dbg("option '%c' arg '%s'", option, optarg);
 		else
 			dbg("option '%c'", option);
 
 		switch (option) {
+		case 'd':
+			debug = 1;
+			break;
+		case 'n':
+			use_num_info=1;
+			use_usb_info=1;
+			break;
 		case 'u':
 			use_usb_info=1;
 			break;
@@ -432,7 +454,7 @@ int main(int argc, char **argv)
 			break;
 		default:
 			info("Unknown or bad option '%c' (0x%x)", option, option);
-			retval = -1;
+			retval = 1;
 			break;
 		}
 	}
@@ -452,29 +474,29 @@ int main(int argc, char **argv)
 
 	retval = usb_id(target_path);
 
-	if (export) {
-		printf("ID_VENDOR=%s\n", vendor_str);
-		printf("ID_MODEL=%s\n", model_str);
-		printf("ID_REVISION=%s\n", revision_str);
-		if (serial_str[0] == '\0') {
-			printf("ID_SERIAL=%s_%s\n", 
-			       vendor_str, model_str);
+	if (retval == 0) {
+		if (export) {
+			printf("ID_VENDOR=%s\n", vendor_str);
+			printf("ID_MODEL=%s\n", model_str);
+			printf("ID_REVISION=%s\n", revision_str);
+			if (serial_str[0] == '\0') {
+				printf("ID_SERIAL=%s_%s\n", 
+				       vendor_str, model_str);
+			} else {
+				printf("ID_SERIAL=%s_%s_%s\n", 
+				       vendor_str, model_str, serial_str);
+			}
+			printf("ID_TYPE=%s\n", type_str);
+			printf("ID_BUS=usb\n");
 		} else {
-			printf("ID_SERIAL=%s_%s_%s\n", 
-			       vendor_str, model_str, serial_str);
-		}
-		printf("ID_TYPE=%s\n", type_str);
-	} else {
-		if (serial_str[0] == '\0') {
-			printf("%s_%s\n", 
-			       vendor_str, model_str);
-		} else {
-			printf("%s_%s_%s\n", 
-			       vendor_str, model_str, serial_str);
+			if (serial_str[0] == '\0') {
+				printf("%s_%s\n", 
+				       vendor_str, model_str);
+			} else {
+				printf("%s_%s_%s\n", 
+				       vendor_str, model_str, serial_str);
+			}
 		}
 	}
 	exit(retval);
 }
-
-
-