X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=extras%2Fname_cdrom.pl;h=766f6f366a6ac756a5e50cf006f3c56bdcf1fbca;hp=569b119be7d616127fb3fc396927733b44d383c7;hb=d25e14ae1ef476fdc1d2b690b9426bd45bafd34e;hpb=a05b77509e6e3723f3e969eefd1c2a34bad79675

diff --git a/extras/name_cdrom.pl b/extras/name_cdrom.pl
index 569b119be..766f6f366 100644
--- a/extras/name_cdrom.pl
+++ b/extras/name_cdrom.pl
@@ -2,19 +2,17 @@
 
 # a horribly funny script that shows how flexible udev can really be
 # This is to be executed by udev with the following rules:
-# CALLOUT, BUS="ide", PROGRAM="name_cdrom.pl %M %m", ID="good*", NAME="%1c", SYMLINK="cdrom" 
-# CALLOUT, BUS="scsi", PROGRAM="name_cdrom.pl %M %m", ID="good*", NAME="%1c", SYMLINK="cdrom" 
-#
-# The scsi rule catches USB cdroms and ide-scsi devices.
-#
+# KERNEL="[hs]d[a-z]", PROGRAM="name_cdrom.pl %M %m", NAME="%c{1}", SYMLINK="cdrom"
 
-use CDDB_get qw( get_cddb );
+use strict;
+use warnings;
 
-my %config;
+use CDDB_get qw( get_cddb );
 
-$dev_node = "/tmp/cd_foo";
+my $dev_node = "/tmp/cd_foo";
 
 # following variables just need to be declared if different from defaults
+my %config;
 $config{CDDB_HOST}="freedb.freedb.org";		# set cddb host
 $config{CDDB_PORT}=8880;			# set cddb port
 $config{CDDB_MODE}="cddb";			# set cddb mode: cddb or http
@@ -23,13 +21,14 @@ $config{CD_DEVICE}="$dev_node";			# set cd device
 # No user interaction, this is a automated script!
 $config{input}=0;
 
-$major = $ARGV[0];
-$minor = $ARGV[1];
+my $major = $ARGV[0];
+my $minor = $ARGV[1];
 
 # create our temp device node to read the cd info from
+unlink($dev_node);
 if (system("mknod $dev_node b $major $minor")) {
        die "bad mknod failed";
-       }
+}
 
 # get it on
 my %cd=get_cddb(\%config);
@@ -37,9 +36,11 @@ my %cd=get_cddb(\%config);
 # remove the dev node we just created
 unlink($dev_node);
 
-# print out our cd name if we have found it
-unless(defined $cd{title}) {
-	print"bad unknown cdrom\n";
+# print out our cd name if we have found it or skip rule by nonzero exit
+if (defined $cd{title}) {
+	$cd{artist} =~ s/ /_/g;
+	$cd{title} =~ s/ /_/g;
+	print "$cd{artist}-$cd{title}\n";
 } else {
-	print "good $cd{artist}_$cd{title}\n";
+	exit -1;
 }