X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=CODING_STYLE;h=b687e729f4676c3c91ce054eeced49322a4e339f;hp=557401348789e0322ea45a1d699d56430da329eb;hb=ea7b52374caa7f687c7e09b0102dbf834e5d2d88;hpb=eef46c372f64f40dd75415b2c504c73138719c8d

diff --git a/CODING_STYLE b/CODING_STYLE
index 557401348..b687e729f 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -208,3 +208,21 @@
   is needed. Everytime you need that please immediately undefine
   basename(), and add a comment about it, so that no code ever ends up
   using the XDG version!
+
+- Use the bool type for booleans, not integers. One exception: in public
+  headers (i.e those in src/systemd/sd-*.h) use integers after all, as "bool"
+  is C99 and in our public APIs we try to stick to C89 (with a few extension).
+
+- When you invoke certain calls like unlink(), or mkdir_p() and you
+  know it is safe to ignore the error it might return (because a later
+  call would detect the failure anyway, or because the error is in an
+  error path and you thus couldn't do anything about it anyway), then
+  make this clear by casting the invocation explicitly to (void). Code
+  checks like Coverity understand that, and will not complain about
+  ignored error codes. Hence, please use this:
+
+      (void) unlink("/foo/bar/baz");
+
+  instead of just this:
+
+      unlink("/foo/bar/baz");