X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=CODING_STYLE;fp=CODING_STYLE;h=4439ee6099abb707a4114a8b32b7e94608a75cea;hp=598d241b2baa048c1bc18644ade20ea9dcfb3d49;hb=7f8bf08f9036de419ad14c55b61eda74c6659d3a;hpb=dbfd41e2df44113d1d2d07fb751db11b443f186b

diff --git a/CODING_STYLE b/CODING_STYLE
index 598d241b2..4439ee609 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -182,7 +182,11 @@
   is_main_thread() to detect whether the calling thread is the main
   thread.
 
-- Option parsing:
+- Command line option parsing:
   - Do not print full help() on error, be specific about the error.
   - Do not print messages to stdout on error.
   - Do not POSIX_ME_HARDER unless necessary, i.e. avoid "+" in option string.
+
+- Do not write functions that clobber call-by-reference variables on
+  failure. Use temporary variables for these cases and change the
+  passed in variables only on success.