[PATCH] cleanup db functions

[elogind.git] / udevtest.c

diff --git a/udevtest.c b/udevtest.c
index 37ec767e138ad189073255fa209065082e213c75..4e02ac7dbc2b4f351947c1793a31d68ba405a11e 100644 (file)
--- a/udevtest.c
+++ b/udevtest.c
@@ -29,6 +29,7 @@
 
 #include "libsysfs/sysfs/libsysfs.h"
 #include "udev.h"
+#include "udev_sysfs.h"
 #include "udev_utils.h"
 #include "udev_version.h"
 #include "namedev.h"
@@ -36,7 +37,6 @@
 
 
 #ifdef LOG
-unsigned char logname[LOGNAME_SIZE];
 void log_message (int level, const char *format, ...)
 {
        va_list args;
@@ -55,19 +55,23 @@ int main(int argc, char *argv[], char *envp[])
        char *devpath;
        char path[SYSFS_PATH_MAX];
        char temp[NAME_SIZE];
-       char *subsystem = "";
        struct udevice udev;
+       char *subsystem = NULL;
 
        info("version %s", UDEV_VERSION);
 
-       if (argv[1] == NULL) {
-               info("udevinfo expects the DEVPATH of the sysfs device as a argument");
+       if (argc < 2 || argc > 3) {
+               info("Usage: udevtest <devpath> [subsystem]");
                return 1;
        }
 
+       /* initialize our configuration */
+       udev_init_config();
+
        /* remove sysfs_path if given */
-       if (strncmp(argv[1], sysfs_path, strlen(sysfs_path)) == 0)
-               devpath = argv[1] + strlen(sysfs_path);
+       if (strncmp(argv[1], sysfs_path, strlen(sysfs_path)) == 0) {
+               devpath = &argv[1][strlen(sysfs_path)] ;
+       }
        else
                if (argv[1][0] != '/') {
                        /* prepend '/' if missing */
@@ -80,23 +84,20 @@ int main(int argc, char *argv[], char *envp[])
 
        info("looking at '%s'", devpath);
 
-       /* we only care about class devices and block stuff */
-       if (!strstr(devpath, "class") && !strstr(devpath, "block")) {
-               dbg("not a block or class device");
-               return 2;
-       }
-
-       /* initialize our configuration */
-       udev_init_config();
-
        /* initialize the naming deamon */
        namedev_init();
 
-       if (argv[2] != NULL)
+       if (argc == 3)
                subsystem = argv[2];
 
        /* fill in values and test_run flag*/
-       udev_set_values(&udev, devpath, subsystem, "add");
+       udev_init_device(&udev, devpath, subsystem);
+
+       /* skip subsystems without "dev", but handle net devices */
+       if (udev.type != NET && subsystem_expect_no_dev(udev.subsystem)) {
+               info("don't care about '%s' devices", udev.subsystem);
+               return 2;
+       }
 
        /* open the device */
        snprintf(path, SYSFS_PATH_MAX, "%s%s", sysfs_path, udev.devpath);
@@ -106,7 +107,7 @@ int main(int argc, char *argv[], char *envp[])
                return 1;
        }
 
-       dbg("opened class_dev->name='%s'", class_dev->name);
+       info("opened class_dev->name='%s'", class_dev->name);
 
        /* simulate node creation with test flag */
        udev.test_run = 1;