chiark / gitweb /
[PATCH] correct enum device_type
[elogind.git] / udevtest.c
index 084fde07064a2fe2b39cbdc942ca2d61bde65d04..1e0037978beca92797abad2a628f7cb32fb4ef7d 100644 (file)
@@ -1,5 +1,5 @@
 /*
- * udev.c
+ * udevtest.c
  *
  * Userspace devfs
  *
@@ -53,8 +53,8 @@ int main(int argc, char *argv[], char *envp[])
 {
        struct sysfs_class_device *class_dev;
        char *devpath;
-       char path[SYSFS_PATH_MAX];
-       char temp[NAME_SIZE];
+       char path[PATH_SIZE];
+       char temp[PATH_SIZE];
        struct udevice udev;
        char *subsystem = NULL;
 
@@ -69,18 +69,16 @@ int main(int argc, char *argv[], char *envp[])
        udev_init_config();
 
        /* remove sysfs_path if given */
-       if (strncmp(argv[1], sysfs_path, strlen(sysfs_path)) == 0) {
+       if (strncmp(argv[1], sysfs_path, strlen(sysfs_path)) == 0)
                devpath = &argv[1][strlen(sysfs_path)] ;
-       }
        else
                if (argv[1][0] != '/') {
                        /* prepend '/' if missing */
-                       strfieldcpy(temp, "/");
-                       strfieldcat(temp, argv[1]);
+                       snprintf(temp, sizeof(temp), "/%s", argv[1]);
+                       temp[sizeof(temp)-1] = '\0';
                        devpath = temp;
-               } else {
+               } else
                        devpath = argv[1];
-               }
 
        info("looking at '%s'", devpath);
 
@@ -94,13 +92,14 @@ int main(int argc, char *argv[], char *envp[])
        udev_init_device(&udev, devpath, subsystem);
 
        /* skip subsystems without "dev", but handle net devices */
-       if (udev.type != NET && subsystem_expect_no_dev(udev.subsystem)) {
+       if (udev.type != DEV_NET && subsystem_expect_no_dev(udev.subsystem)) {
                info("don't care about '%s' devices", udev.subsystem);
                return 2;
        }
 
        /* open the device */
-       snprintf(path, SYSFS_PATH_MAX, "%s%s", sysfs_path, udev.devpath);
+       snprintf(path, sizeof(path), "%s%s", sysfs_path, udev.devpath);
+       path[sizeof(path)-1] = '\0';
        class_dev = sysfs_open_class_device_path(path);
        if (class_dev == NULL) {
                info("sysfs_open_class_device_path failed");