chiark / gitweb /
[PATCH] udevd: add possible initialization of expected_seqnum
[elogind.git] / udevd.c
diff --git a/udevd.c b/udevd.c
index 569458484010ac79be923a7fc99a5fb75049b83b..a8328bbb81a60d2a093089d6490ddb8f7e58577b 100644 (file)
--- a/udevd.c
+++ b/udevd.c
@@ -101,13 +101,24 @@ static void msg_queue_insert(struct hotplug_msg *msg)
        struct hotplug_msg *loop_msg;
        struct sysinfo info;
 
-       /* sort message by sequence number into list. events
-        * will tend to come in order, so scan the list backwards
-        */
-       list_for_each_entry_reverse(loop_msg, &msg_list, list)
+       if (msg->seqnum == 0) {
+               dbg("no SEQNUM, move straight to the exec queue");
+               list_add(&msg->list, &exec_list);
+               run_exec_q = 1;
+               return;
+       }
+
+       /* sort message by sequence number into list */
+       list_for_each_entry_reverse(loop_msg, &msg_list, list) {
                if (loop_msg->seqnum < msg->seqnum)
                        break;
 
+               if (loop_msg->seqnum == msg->seqnum) {
+                       dbg("ignoring duplicate message seq %llu", msg->seqnum);
+                       return;
+               }
+       }
+
        /* store timestamp of queuing */
        sysinfo(&info);
        msg->queue_time = info.uptime;
@@ -118,7 +129,7 @@ static void msg_queue_insert(struct hotplug_msg *msg)
        /* run msg queue manager */
        run_msg_q = 1;
 
-       return ;
+       return;
 }
 
 /* forks event and removes event from run queue when finished */
@@ -279,8 +290,8 @@ recheck:
        }
 }
 
-/* receive the msg, do some basic sanity checks, and queue it */
-static void handle_udevsend_msg(int sock)
+/* receive the udevsend message and do some sanity checks */
+static struct hotplug_msg *get_udevsend_msg(void)
 {
        static struct udevsend_msg usend_msg;
        struct hotplug_msg *msg;
@@ -304,33 +315,36 @@ static void handle_udevsend_msg(int sock)
        smsg.msg_control = cred_msg;
        smsg.msg_controllen = sizeof(cred_msg);
 
-       size = recvmsg(sock, &smsg, 0);
+       size = recvmsg(udevsendsock, &smsg, 0);
        if (size <  0) {
                if (errno != EINTR)
-                       dbg("unable to receive message");
-               return;
+                       dbg("unable to receive udevsend message");
+               return NULL;
        }
        cmsg = CMSG_FIRSTHDR(&smsg);
        cred = (struct ucred *) CMSG_DATA(cmsg);
 
        if (cmsg == NULL || cmsg->cmsg_type != SCM_CREDENTIALS) {
                dbg("no sender credentials received, message ignored");
-               goto exit;
+               return NULL;
        }
 
        if (cred->uid != 0) {
                dbg("sender uid=%i, message ignored", cred->uid);
-               goto exit;
+               return NULL;
        }
 
        if (strncmp(usend_msg.magic, UDEV_MAGIC, sizeof(UDEV_MAGIC)) != 0 ) {
                dbg("message magic '%s' doesn't match, ignore it", usend_msg.magic);
-               goto exit;
+               return NULL;
        }
 
        envbuf_size = size - offsetof(struct udevsend_msg, envbuf);
        dbg("envbuf_size=%i", envbuf_size);
        msg = malloc(sizeof(struct hotplug_msg) + envbuf_size);
+       if (msg == NULL)
+               return NULL;
+
        memset(msg, 0x00, sizeof(struct hotplug_msg) + envbuf_size);
 
        /* copy environment buffer and reconstruct envp */
@@ -365,16 +379,7 @@ static void handle_udevsend_msg(int sock)
        msg->envp[i++] = "UDEVD_EVENT=1";
        msg->envp[i] = NULL;
 
-       /* if no seqnum is given, we move straight to exec queue */
-       if (msg->seqnum == 0) {
-               list_add(&msg->list, &exec_list);
-               run_exec_q = 1;
-       } else {
-               msg_queue_insert(msg);
-       }
-
-exit:
-       return;
+       return msg;
 }
 
 static void asmlinkage sig_handler(int signum)
@@ -445,6 +450,7 @@ static void reap_sigchilds(void)
 static void user_sighandler(void)
 {
        int sig;
+
        while(1) {
                int rc = read(pipefds[0], &sig, sizeof(sig));
                if (rc < 0)
@@ -454,16 +460,48 @@ static void user_sighandler(void)
        }
 }
 
-int main(int argc, char *argv[], char *envp[])
+static int init_udevsend_socket(void)
 {
-       struct sysinfo info;
-       int maxsockplus;
        struct sockaddr_un saddr;
        socklen_t addrlen;
-       int retval, fd;
        const int feature_on = 1;
+       int retval;
+
+       memset(&saddr, 0x00, sizeof(saddr));
+       saddr.sun_family = AF_LOCAL;
+       /* use abstract namespace for socket path */
+       strcpy(&saddr.sun_path[1], UDEVD_SOCK_PATH);
+       addrlen = offsetof(struct sockaddr_un, sun_path) + strlen(saddr.sun_path+1) + 1;
+
+       udevsendsock = socket(AF_LOCAL, SOCK_DGRAM, 0);
+       if (udevsendsock == -1) {
+               dbg("error getting socket, %s", strerror(errno));
+               return -1;
+       }
+
+       /* the bind takes care of ensuring only one copy running */
+       retval = bind(udevsendsock, (struct sockaddr *) &saddr, addrlen);
+       if (retval < 0) {
+               dbg("bind failed, %s", strerror(errno));
+               close(udevsendsock);
+               return -1;
+       }
+
+       /* enable receiving of the sender credentials */
+       setsockopt(udevsendsock, SOL_SOCKET, SO_PASSCRED, &feature_on, sizeof(feature_on));
+
+       return 0;
+}
+
+int main(int argc, char *argv[], char *envp[])
+{
+       struct sysinfo info;
+       int maxsockplus;
+       int retval;
+       int fd;
        struct sigaction act;
        fd_set readfds;
+       const char *udevd_expected_seqnum;
 
        logging_init("udevd");
        dbg("version %s", UDEV_VERSION);
@@ -473,21 +511,38 @@ int main(int argc, char *argv[], char *envp[])
                goto exit;
        }
 
+       /* daemonize on request */
+       if (argc == 2 && strcmp(argv[1], "-d") == 0) {
+               pid_t pid;
+
+               pid = fork();
+               switch (pid) {
+               case 0:
+                       dbg("damonized fork running");
+                       break;
+               case -1:
+                       dbg("fork of daemon failed");
+                       goto exit;
+               default:
+                       logging_close();
+                       exit(0);
+               }
+       }
+
        /* make sure we don't lock any path */
        chdir("/");
        umask(umask(077) | 022);
 
        /* Set fds to dev/null */
        fd = open( "/dev/null", O_RDWR );
-       if ( fd < 0 ) {
+       if (fd >= 0)  {
+               dup2(fd, 0);
+               dup2(fd, 1);
+               dup2(fd, 2);
+               if (fd > 2)
+                       close(fd);
+       } else
                dbg("error opening /dev/null %s", strerror(errno));
-               goto exit;
-       }
-       dup2(fd, 0);
-       dup2(fd, 1);
-       dup2(fd, 2);
-       if (fd > 2) 
-               close(fd);
 
        /* become session leader */
        setsid();
@@ -505,10 +560,8 @@ int main(int argc, char *argv[], char *envp[])
                goto exit;
        }
        retval = fcntl(pipefds[0], F_SETFD, FD_CLOEXEC);
-       if (retval < 0) {
+       if (retval < 0)
                dbg("error fcntl on read pipe: %s", strerror(errno));
-               goto exit;
-       }
 
        retval = fcntl(pipefds[1], F_SETFL, O_NONBLOCK);
        if (retval < 0) {
@@ -516,10 +569,8 @@ int main(int argc, char *argv[], char *envp[])
                goto exit;
        }
        retval = fcntl(pipefds[1], F_SETFD, FD_CLOEXEC);
-       if (retval < 0) {
+       if (retval < 0)
                dbg("error fcntl on write pipe: %s", strerror(errno));
-               goto exit;
-       }
 
        /* set signal handlers */
        act.sa_handler = (void (*) (int))sig_handler;
@@ -530,29 +581,15 @@ int main(int argc, char *argv[], char *envp[])
        sigaction(SIGALRM, &act, NULL);
        sigaction(SIGCHLD, &act, NULL);
 
-       memset(&saddr, 0x00, sizeof(saddr));
-       saddr.sun_family = AF_LOCAL;
-       /* use abstract namespace for socket path */
-       strcpy(&saddr.sun_path[1], UDEVD_SOCK_PATH);
-       addrlen = offsetof(struct sockaddr_un, sun_path) + strlen(saddr.sun_path+1) + 1;
+       if (init_udevsend_socket() < 0) {
+               if (errno == EADDRINUSE)
+                       dbg("another udevd running, exit");
+               else
+                       dbg("error initialising udevsend socket: %s", strerror(errno));
 
-       udevsendsock = socket(AF_LOCAL, SOCK_DGRAM, 0);
-       if (udevsendsock == -1) {
-               dbg("error getting socket, exit");
                goto exit;
        }
 
-       /* the bind takes care of ensuring only one copy running */
-       retval = bind(udevsendsock, (struct sockaddr *) &saddr, addrlen);
-       if (retval < 0) {
-               dbg("bind failed, exit");
-               close(udevsendsock);
-               goto exit;
-       }
-
-       /* enable receiving of the sender credentials */
-       setsockopt(udevsendsock, SOL_SOCKET, SO_PASSCRED, &feature_on, sizeof(feature_on));
-
        /* possible override of udev binary, used for testing */
        udev_bin = getenv("UDEV_BIN");
        if (udev_bin != NULL)
@@ -560,7 +597,14 @@ int main(int argc, char *argv[], char *envp[])
        else
                udev_bin = UDEV_BIN;
 
-       /* handle special startup timeout*/
+       /* possible set of expected_seqnum number */
+       udevd_expected_seqnum = getenv("UDEVD_EXPECTED_SEQNUM");
+       if (udevd_expected_seqnum != NULL) {
+               expected_seqnum = strtoull(udevd_expected_seqnum, NULL, 10);
+               dbg("initialize expected_seqnum to %llu", expected_seqnum);
+       }
+
+       /* get current time to provide shorter startup timeout */
        sysinfo(&info);
        startup_time = info.uptime;
 
@@ -569,6 +613,8 @@ int main(int argc, char *argv[], char *envp[])
        FD_SET(pipefds[0], &readfds);
        maxsockplus = udevsendsock+1;
        while (1) {
+               struct hotplug_msg *msg;
+
                fd_set workreadfds = readfds;
                retval = select(maxsockplus, &workreadfds, NULL, NULL, NULL);
 
@@ -578,8 +624,11 @@ int main(int argc, char *argv[], char *envp[])
                        continue;
                }
 
-               if (FD_ISSET(udevsendsock, &workreadfds))
-                       handle_udevsend_msg(udevsendsock);
+               if (FD_ISSET(udevsendsock, &workreadfds)) {
+                       msg = get_udevsend_msg();
+                       if (msg)
+                               msg_queue_insert(msg);
+               }
 
                if (FD_ISSET(pipefds[0], &workreadfds))
                        user_sighandler();