chiark / gitweb /
~ianmdlvl / elogind.git / blobdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | inline | side by side
path_id: prepare for new sysfs layout
[elogind.git] / udevd.c
diff --git a/udevd.c b/udevd.c
index 3fd3bfe6adbf61e67f95bf8173975469064836f6..02c4887f541d304ff091ff4f6341570b042ac27b 100644 (file)
--- a/udevd.c
+++ b/udevd.c
@@ -42,16 +42,11 @@
 #include <linux/types.h>
 #include <linux/netlink.h>
 
 #include <linux/types.h>
 #include <linux/netlink.h>
 
-#include "list.h"
-#include "udev_libc_wrapper.h"
 #include "udev.h"
 #include "udev.h"
-#include "udev_version.h"
 #include "udev_rules.h"
 #include "udev_rules.h"
-#include "udev_utils.h"
 #include "udevd.h"
 #include "udevd.h"
-#include "logging.h"
 
 
-struct udev_rules rules;
+static struct udev_rules rules;
 static int udevd_sock;
 static int uevent_netlink_sock;
 static int inotify_fd;
 static int udevd_sock;
 static int uevent_netlink_sock;
 static int inotify_fd;
@@ -94,8 +89,7 @@ static void asmlinkage udev_event_sig_handler(int signum)
 static int udev_event_process(struct uevent_msg *msg)
 {
        struct sigaction act;
 static int udev_event_process(struct uevent_msg *msg)
 {
        struct sigaction act;
-       struct udevice udev;
-       struct name_entry *name_loop;
+       struct udevice *udev;
        int i;
        int retval;
 
        int i;
        int retval;
 
@@ -106,40 +100,149 @@ static int udev_event_process(struct uevent_msg *msg)
        act.sa_flags = 0;
        sigaction(SIGALRM, &act, NULL);
 
        act.sa_flags = 0;
        sigaction(SIGALRM, &act, NULL);
 
+       /* reset to default */
+       act.sa_handler = SIG_DFL;
+       sigaction(SIGINT, &act, NULL);
+       sigaction(SIGTERM, &act, NULL);
+       sigaction(SIGCHLD, &act, NULL);
+       sigaction(SIGHUP, &act, NULL);
+
        /* trigger timeout to prevent hanging processes */
        alarm(UDEV_ALARM_TIMEOUT);
 
        /* trigger timeout to prevent hanging processes */
        alarm(UDEV_ALARM_TIMEOUT);
 
-       /* reconstruct env from message */
+       /* reconstruct event environment from message */
        for (i = 0; msg->envp[i]; i++)
                putenv(msg->envp[i]);
 
        for (i = 0; msg->envp[i]; i++)
                putenv(msg->envp[i]);
 
-       udev_init_device(&udev, msg->devpath, msg->subsystem, msg->action);
-       retval = udev_process_event(&rules, &udev);
+       udev = udev_device_init();
+       if (udev == NULL)
+               return -1;
+       strlcpy(udev->action, msg->action, sizeof(udev->action));
+       sysfs_device_set_values(udev->dev, msg->devpath, msg->subsystem);
+       udev->devt = msg->devt;
+
+       retval = udev_device_event(&rules, udev);
 
        /* run programs collected by RUN-key*/
 
        /* run programs collected by RUN-key*/
-       if (!retval) {
-               list_for_each_entry(name_loop, &udev.run_list, node) {
+       if (retval == 0 && !udev->ignore_device && udev_run) {
+               struct name_entry *name_loop;
+
+               dbg("executing run list");
+               list_for_each_entry(name_loop, &udev->run_list, node) {
                        if (strncmp(name_loop->name, "socket:", strlen("socket:")) == 0)
                        if (strncmp(name_loop->name, "socket:", strlen("socket:")) == 0)
-                               pass_env_to_socket(&name_loop->name[strlen("socket:")], msg->devpath, msg->action);
-                       else
-                               run_program(name_loop->name, udev.subsystem, NULL, 0, NULL, (udev_log_priority >= LOG_INFO));
+                               pass_env_to_socket(&name_loop->name[strlen("socket:")], udev->dev->devpath, udev->action);
+                       else {
+                               char program[PATH_SIZE];
+
+                               strlcpy(program, name_loop->name, sizeof(program));
+                               udev_rules_apply_format(udev, program, sizeof(program));
+                               if (run_program(program, udev->dev->subsystem, NULL, 0, NULL,
+                                               (udev_log_priority >= LOG_INFO)))
+                                       retval = -1;
+                       }
                }
        }
 
                }
        }
 
-       udev_cleanup_device(&udev);
+       udev_device_cleanup(udev);
+       return retval;
+}
 
 
-       return 0;
+enum event_state {
+       EVENT_QUEUED,
+       EVENT_FINISHED,
+       EVENT_FAILED,
+};
+
+static void export_event_state(struct uevent_msg *msg, enum event_state state)
+{
+       char filename[PATH_SIZE];
+       char filename_failed[PATH_SIZE];
+       char target[PATH_SIZE];
+       size_t start, end, i;
+       struct uevent_msg *loop_msg;
+
+       /* add location of queue files */
+       strlcpy(filename, udev_root, sizeof(filename));
+       strlcat(filename, "/", sizeof(filename));
+       start = strlcat(filename, EVENT_QUEUE_DIR, sizeof(filename));
+       end = strlcat(filename, msg->devpath, sizeof(filename));
+       if (end > sizeof(filename))
+               end = sizeof(filename);
+
+       /* replace '/' to transform path into a filename */
+       for (i = start+1; i < end; i++)
+               if (filename[i] == '/')
+                       filename[i] = PATH_TO_NAME_CHAR;
+
+       /* add location of failed files */
+       strlcpy(filename_failed, udev_root, sizeof(filename_failed));
+       strlcat(filename_failed, "/", sizeof(filename_failed));
+       start = strlcat(filename_failed, EVENT_FAILED_DIR, sizeof(filename_failed));
+       end = strlcat(filename_failed, msg->devpath, sizeof(filename_failed));
+       if (end > sizeof(filename_failed))
+               end = sizeof(filename_failed);
+
+       /* replace '/' to transform path into a filename */
+       for (i = start+1; i < end; i++)
+               if (filename_failed[i] == '/')
+                       filename_failed[i] = PATH_TO_NAME_CHAR;
+
+       switch (state) {
+       case EVENT_QUEUED:
+               unlink(filename_failed);
+               delete_path(filename_failed);
+
+               strlcpy(target, sysfs_path, sizeof(target));
+               strlcat(target, msg->devpath, sizeof(target));
+               create_path(filename);
+               symlink(target, filename);
+               return;
+       case EVENT_FINISHED:
+       case EVENT_FAILED:
+               unlink(filename_failed);
+               delete_path(filename_failed);
+
+               /* don't remove, if events for the same path are still pending */
+               list_for_each_entry(loop_msg, &running_list, node)
+                       if (loop_msg->devpath && strcmp(loop_msg->devpath, msg->devpath) == 0)
+                               return;
+
+               list_for_each_entry(loop_msg, &exec_list, node)
+                       if (loop_msg->devpath && strcmp(loop_msg->devpath, msg->devpath) == 0)
+                               return;
+
+               /* move failed events to the failed directory */
+               if (state == EVENT_FAILED) {
+                       create_path(filename_failed);
+                       rename(filename, filename_failed);
+               } else {
+                       unlink(filename);
+               }
+
+               /* clean up the queue directory */
+               delete_path(filename);
+
+               return;
+       }
 }
 
 static void msg_queue_delete(struct uevent_msg *msg)
 {
        list_del(&msg->node);
 }
 
 static void msg_queue_delete(struct uevent_msg *msg)
 {
        list_del(&msg->node);
+
+       /* mark as failed, if add event returns non-zero */
+       if (msg->exitstatus && strcmp(msg->action, "add") == 0)
+               export_event_state(msg, EVENT_FAILED);
+       else
+               export_event_state(msg, EVENT_FINISHED);
+
        free(msg);
 }
 
 static void udev_event_run(struct uevent_msg *msg)
 {
        pid_t pid;
        free(msg);
 }
 
 static void udev_event_run(struct uevent_msg *msg)
 {
        pid_t pid;
+       int retval;
 
        pid = fork();
        switch (pid) {
 
        pid = fork();
        switch (pid) {
@@ -147,7 +250,7 @@ static void udev_event_run(struct uevent_msg *msg)
                /* child */
                close(uevent_netlink_sock);
                close(udevd_sock);
                /* child */
                close(uevent_netlink_sock);
                close(udevd_sock);
-               if (inotify_fd > 0)
+               if (inotify_fd >= 0)
                        close(inotify_fd);
                close(signal_pipe[READ_END]);
                close(signal_pipe[WRITE_END]);
                        close(inotify_fd);
                close(signal_pipe[READ_END]);
                close(signal_pipe[WRITE_END]);
@@ -155,10 +258,12 @@ static void udev_event_run(struct uevent_msg *msg)
 
                logging_init("udevd-event");
                setpriority(PRIO_PROCESS, 0, UDEV_PRIORITY);
 
                logging_init("udevd-event");
                setpriority(PRIO_PROCESS, 0, UDEV_PRIORITY);
-               udev_event_process(msg);
+               retval = udev_event_process(msg);
                info("seq %llu finished", msg->seqnum);
 
                logging_close();
                info("seq %llu finished", msg->seqnum);
 
                logging_close();
+               if (retval)
+                       exit(1);
                exit(0);
        case -1:
                err("fork of child failed: %s", strerror(errno));
                exit(0);
        case -1:
                err("fork of child failed: %s", strerror(errno));
@@ -174,8 +279,25 @@ static void udev_event_run(struct uevent_msg *msg)
 
 static void msg_queue_insert(struct uevent_msg *msg)
 {
 
 static void msg_queue_insert(struct uevent_msg *msg)
 {
+       char filename[PATH_SIZE];
+       int fd;
+
        msg->queue_time = time(NULL);
 
        msg->queue_time = time(NULL);
 
+       strlcpy(filename, udev_root, sizeof(filename));
+       strlcat(filename, "/" EVENT_SEQNUM, sizeof(filename));
+       fd = open(filename, O_WRONLY|O_TRUNC|O_CREAT, 0644);
+       if (fd >= 0) {
+               char str[32];
+               int len;
+
+               len = sprintf(str, "%llu\n", msg->seqnum);
+               write(fd, str, len);
+               close(fd);
+       }
+
+       export_event_state(msg, EVENT_QUEUED);
+
        /* run all events with a timeout set immediately */
        if (msg->timeout != 0) {
                list_add_tail(&msg->node, &running_list);
        /* run all events with a timeout set immediately */
        if (msg->timeout != 0) {
                list_add_tail(&msg->node, &running_list);
@@ -426,31 +548,28 @@ static struct uevent_msg *get_msg_from_envbuf(const char *buf, int buf_size)
        msg->envp[i++] = "UDEVD_EVENT=1";
        msg->envp[i] = NULL;
 
        msg->envp[i++] = "UDEVD_EVENT=1";
        msg->envp[i] = NULL;
 
-       if (!msg->devpath) {
-               info("DEVPATH missing, ingnore message");
+       if (msg->devpath == NULL || msg->action == NULL) {
+               info("DEVPATH or ACTION missing, ignore message");
                free(msg);
                return NULL;
        }
                free(msg);
                return NULL;
        }
-
        return msg;
 }
 
 /* receive the udevd message from userspace */
 static struct uevent_msg *get_udevd_msg(void)
 {
        return msg;
 }
 
 /* receive the udevd message from userspace */
 static struct uevent_msg *get_udevd_msg(void)
 {
-       static struct udevd_msg usend_msg;
-       struct uevent_msg *msg;
+       static struct udevd_msg ctrl_msg;
        ssize_t size;
        struct msghdr smsg;
        struct cmsghdr *cmsg;
        struct iovec iov;
        struct ucred *cred;
        char cred_msg[CMSG_SPACE(sizeof(struct ucred))];
        ssize_t size;
        struct msghdr smsg;
        struct cmsghdr *cmsg;
        struct iovec iov;
        struct ucred *cred;
        char cred_msg[CMSG_SPACE(sizeof(struct ucred))];
-       int envbuf_size;
        int *intval;
 
        int *intval;
 
-       memset(&usend_msg, 0x00, sizeof(struct udevd_msg));
-       iov.iov_base = &usend_msg;
+       memset(&ctrl_msg, 0x00, sizeof(struct udevd_msg));
+       iov.iov_base = &ctrl_msg;
        iov.iov_len = sizeof(struct udevd_msg);
 
        memset(&smsg, 0x00, sizeof(struct msghdr));
        iov.iov_len = sizeof(struct udevd_msg);
 
        memset(&smsg, 0x00, sizeof(struct msghdr));
@@ -462,7 +581,7 @@ static struct uevent_msg *get_udevd_msg(void)
        size = recvmsg(udevd_sock, &smsg, 0);
        if (size <  0) {
                if (errno != EINTR)
        size = recvmsg(udevd_sock, &smsg, 0);
        if (size <  0) {
                if (errno != EINTR)
-                       err("unable to receive udevd message: %s", strerror(errno));
+                       err("unable to receive user udevd message: %s", strerror(errno));
                return NULL;
        }
        cmsg = CMSG_FIRSTHDR(&smsg);
                return NULL;
        }
        cmsg = CMSG_FIRSTHDR(&smsg);
@@ -478,22 +597,12 @@ static struct uevent_msg *get_udevd_msg(void)
                return NULL;
        }
 
                return NULL;
        }
 
-       if (strncmp(usend_msg.magic, UDEV_MAGIC, sizeof(UDEV_MAGIC)) != 0 ) {
-               err("message magic '%s' doesn't match, ignore it", usend_msg.magic);
+       if (strncmp(ctrl_msg.magic, UDEV_MAGIC, sizeof(UDEV_MAGIC)) != 0 ) {
+               err("message magic '%s' doesn't match, ignore it", ctrl_msg.magic);
                return NULL;
        }
 
                return NULL;
        }
 
-       switch (usend_msg.type) {
-       case UDEVD_UEVENT_UDEVSEND:
-       case UDEVD_UEVENT_INITSEND:
-               info("udevd event message received");
-               envbuf_size = size - offsetof(struct udevd_msg, envbuf);
-               dbg("envbuf_size=%i", envbuf_size);
-               msg = get_msg_from_envbuf(usend_msg.envbuf, envbuf_size);
-               if (msg == NULL)
-                       return NULL;
-               msg->type = usend_msg.type;
-               return msg;
+       switch (ctrl_msg.type) {
        case UDEVD_STOP_EXEC_QUEUE:
                info("udevd message (STOP_EXEC_QUEUE) received");
                stop_exec_q = 1;
        case UDEVD_STOP_EXEC_QUEUE:
                info("udevd message (STOP_EXEC_QUEUE) received");
                stop_exec_q = 1;
@@ -504,14 +613,14 @@ static struct uevent_msg *get_udevd_msg(void)
                msg_queue_manager();
                break;
        case UDEVD_SET_LOG_LEVEL:
                msg_queue_manager();
                break;
        case UDEVD_SET_LOG_LEVEL:
-               intval = (int *) usend_msg.envbuf;
+               intval = (int *) ctrl_msg.envbuf;
                info("udevd message (SET_LOG_PRIORITY) received, udev_log_priority=%i", *intval);
                udev_log_priority = *intval;
                sprintf(udev_log, "UDEV_LOG=%i", udev_log_priority);
                putenv(udev_log);
                break;
        case UDEVD_SET_MAX_CHILDS:
                info("udevd message (SET_LOG_PRIORITY) received, udev_log_priority=%i", *intval);
                udev_log_priority = *intval;
                sprintf(udev_log, "UDEV_LOG=%i", udev_log_priority);
                putenv(udev_log);
                break;
        case UDEVD_SET_MAX_CHILDS:
-               intval = (int *) usend_msg.envbuf;
+               intval = (int *) ctrl_msg.envbuf;
                info("udevd message (UDEVD_SET_MAX_CHILDS) received, max_childs=%i", *intval);
                max_childs = *intval;
                break;
                info("udevd message (UDEVD_SET_MAX_CHILDS) received, max_childs=%i", *intval);
                max_childs = *intval;
                break;
@@ -531,13 +640,13 @@ static struct uevent_msg *get_netlink_msg(void)
        struct uevent_msg *msg;
        int bufpos;
        ssize_t size;
        struct uevent_msg *msg;
        int bufpos;
        ssize_t size;
-       static char buffer[UEVENT_BUFFER_SIZE + 512];
+       static char buffer[UEVENT_BUFFER_SIZE+512];
        char *pos;
 
        size = recv(uevent_netlink_sock, &buffer, sizeof(buffer), 0);
        if (size <  0) {
                if (errno != EINTR)
        char *pos;
 
        size = recv(uevent_netlink_sock, &buffer, sizeof(buffer), 0);
        if (size <  0) {
                if (errno != EINTR)
-                       err("unable to receive udevd message: %s", strerror(errno));
+                       err("unable to receive kernel netlink message: %s", strerror(errno));
                return NULL;
        }
 
                return NULL;
        }
 
@@ -597,14 +706,16 @@ static void asmlinkage sig_handler(int signum)
        write(signal_pipe[WRITE_END], "", 1);
 }
 
        write(signal_pipe[WRITE_END], "", 1);
 }
 
-static void udev_done(int pid)
+static void udev_done(int pid, int exitstatus)
 {
        /* find msg associated with pid and delete it */
        struct uevent_msg *msg;
 
        list_for_each_entry(msg, &running_list, node) {
                if (msg->pid == pid) {
 {
        /* find msg associated with pid and delete it */
        struct uevent_msg *msg;
 
        list_for_each_entry(msg, &running_list, node) {
                if (msg->pid == pid) {
-                       info("seq %llu, pid [%d] exit, %ld seconds old", msg->seqnum, msg->pid, time(NULL) - msg->queue_time);
+                       info("seq %llu, pid [%d] exit with %i, %ld seconds old", msg->seqnum, msg->pid,
+                            exitstatus, time(NULL) - msg->queue_time);
+                       msg->exitstatus = exitstatus;
                        msg_queue_delete(msg);
 
                        /* there may be events waiting with the same devpath */
                        msg_queue_delete(msg);
 
                        /* there may be events waiting with the same devpath */
@@ -617,12 +728,19 @@ static void udev_done(int pid)
 static void reap_sigchilds(void)
 {
        pid_t pid;
 static void reap_sigchilds(void)
 {
        pid_t pid;
+       int status;
 
        while (1) {
 
        while (1) {
-               pid = waitpid(-1, NULL, WNOHANG);
+               pid = waitpid(-1, &status, WNOHANG);
                if (pid <= 0)
                        break;
                if (pid <= 0)
                        break;
-               udev_done(pid);
+               if (WIFEXITED(status))
+                       status = WEXITSTATUS(status);
+               else if (WIFSIGNALED(status))
+                       status = WTERMSIG(status) + 128;
+               else
+                       status = 0;
+               udev_done(pid, status);
        }
 }
 
        }
 }
 
@@ -692,6 +810,34 @@ static int init_uevent_netlink_sock(void)
        return 0;
 }
 
        return 0;
 }
 
+static void export_initial_seqnum(void)
+{
+       char filename[PATH_SIZE];
+       int fd;
+       char seqnum[32];
+       ssize_t len = 0;
+
+       strlcpy(filename, sysfs_path, sizeof(filename));
+       strlcat(filename, "/kernel/uevent_seqnum", sizeof(filename));
+       fd = open(filename, O_RDONLY);
+       if (fd >= 0) {
+               len = read(fd, seqnum, sizeof(seqnum)-1);
+               close(fd);
+       }
+       if (len <= 0) {
+               strcpy(seqnum, "0\n");
+               len = 3;
+       }
+       strlcpy(filename, udev_root, sizeof(filename));
+       strlcat(filename, "/" EVENT_SEQNUM, sizeof(filename));
+       create_path(filename);
+       fd = open(filename, O_WRONLY|O_TRUNC|O_CREAT, 0644);
+       if (fd >= 0) {
+               write(fd, seqnum, len);
+               close(fd);
+       }
+}
+
 int main(int argc, char *argv[], char *envp[])
 {
        int retval;
 int main(int argc, char *argv[], char *envp[])
 {
        int retval;
@@ -721,7 +867,7 @@ int main(int argc, char *argv[], char *envp[])
        if (fd < 0)
                err("fatal, could not open /dev/null: %s", strerror(errno));
 
        if (fd < 0)
                err("fatal, could not open /dev/null: %s", strerror(errno));
 
-       udev_init_config();
+       udev_config_init();
        dbg("version %s", UDEV_VERSION);
 
        if (getuid() != 0) {
        dbg("version %s", UDEV_VERSION);
 
        if (getuid() != 0) {
@@ -761,8 +907,11 @@ int main(int argc, char *argv[], char *envp[])
        }
 
        /* parse the rules and keep it in memory */
        }
 
        /* parse the rules and keep it in memory */
+       sysfs_init();
        udev_rules_init(&rules, 1);
 
        udev_rules_init(&rules, 1);
 
+       export_initial_seqnum();
+
        if (daemonize) {
                pid_t pid;
 
        if (daemonize) {
                pid_t pid;
 
@@ -806,12 +955,24 @@ int main(int argc, char *argv[], char *envp[])
                err("error getting pipes: %s", strerror(errno));
                goto exit;
        }
                err("error getting pipes: %s", strerror(errno));
                goto exit;
        }
-       retval = fcntl(signal_pipe[READ_END], F_SETFL, O_NONBLOCK);
+
+       retval = fcntl(signal_pipe[READ_END], F_GETFL, 0);
        if (retval < 0) {
                err("error fcntl on read pipe: %s", strerror(errno));
                goto exit;
        }
        if (retval < 0) {
                err("error fcntl on read pipe: %s", strerror(errno));
                goto exit;
        }
-       retval = fcntl(signal_pipe[WRITE_END], F_SETFL, O_NONBLOCK);
+       retval = fcntl(signal_pipe[READ_END], F_SETFL, retval | O_NONBLOCK);
+       if (retval < 0) {
+               err("error fcntl on read pipe: %s", strerror(errno));
+               goto exit;
+       }
+
+       retval = fcntl(signal_pipe[WRITE_END], F_GETFL, 0);
+       if (retval < 0) {
+               err("error fcntl on write pipe: %s", strerror(errno));
+               goto exit;
+       }
+       retval = fcntl(signal_pipe[WRITE_END], F_SETFL, retval | O_NONBLOCK);
        if (retval < 0) {
                err("error fcntl on write pipe: %s", strerror(errno));
                goto exit;
        if (retval < 0) {
                err("error fcntl on write pipe: %s", strerror(errno));
                goto exit;
@@ -829,8 +990,12 @@ int main(int argc, char *argv[], char *envp[])
 
        /* watch rules directory */
        inotify_fd = inotify_init();
 
        /* watch rules directory */
        inotify_fd = inotify_init();
-       if (inotify_fd > 0)
+       if (inotify_fd >= 0)
                inotify_add_watch(inotify_fd, udev_rules_filename, IN_CREATE | IN_DELETE | IN_MOVE | IN_CLOSE_WRITE);
                inotify_add_watch(inotify_fd, udev_rules_filename, IN_CREATE | IN_DELETE | IN_MOVE | IN_CLOSE_WRITE);
+       else if (errno == ENOSYS)
+               err("the kernel does not support inotify, udevd can't monitor configuration file changes");
+       else
+               err("inotify_init failed: %s", strerror(errno));
 
        /* maximum limit of forked childs */
        value = getenv("UDEVD_MAX_CHILDS");
 
        /* maximum limit of forked childs */
        value = getenv("UDEVD_MAX_CHILDS");
@@ -868,7 +1033,7 @@ int main(int argc, char *argv[], char *envp[])
                FD_SET(signal_pipe[READ_END], &readfds);
                FD_SET(udevd_sock, &readfds);
                FD_SET(uevent_netlink_sock, &readfds);
                FD_SET(signal_pipe[READ_END], &readfds);
                FD_SET(udevd_sock, &readfds);
                FD_SET(uevent_netlink_sock, &readfds);
-               if (inotify_fd > 0)
+               if (inotify_fd >= 0)
                        FD_SET(inotify_fd, &readfds);
 
                fdcount = select(maxfd+1, &readfds, NULL, NULL, NULL);
                        FD_SET(inotify_fd, &readfds);
 
                fdcount = select(maxfd+1, &readfds, NULL, NULL, NULL);
@@ -881,13 +1046,8 @@ int main(int argc, char *argv[], char *envp[])
                /* get user socket message */
                if (FD_ISSET(udevd_sock, &readfds)) {
                        msg = get_udevd_msg();
                /* get user socket message */
                if (FD_ISSET(udevd_sock, &readfds)) {
                        msg = get_udevd_msg();
-                       if (msg) {
-                               if (msg->type == UDEVD_UEVENT_UDEVSEND && msg->seqnum != 0) {
-                                       info("skip non-kernel message with SEQNUM");
-                                       free(msg);
-                               } else
-                                       msg_queue_insert(msg);
-                       }
+                       if (msg)
+                               msg_queue_insert(msg);
                }
 
                /* get kernel netlink message */
                }
 
                /* get kernel netlink message */
@@ -905,7 +1065,7 @@ int main(int argc, char *argv[], char *envp[])
                }
 
                /* rules directory inotify watch */
                }
 
                /* rules directory inotify watch */
-               if ((inotify_fd > 0) && FD_ISSET(inotify_fd, &readfds)) {
+               if ((inotify_fd >= 0) && FD_ISSET(inotify_fd, &readfds)) {
                        int nbytes;
 
                        /* discard all possible events, we can just reload the config */
                        int nbytes;
 
                        /* discard all possible events, we can just reload the config */
@@ -927,7 +1087,7 @@ int main(int argc, char *argv[], char *envp[])
                /* rules changed, set by inotify or a signal*/
                if (reload_config) {
                        reload_config = 0;
                /* rules changed, set by inotify or a signal*/
                if (reload_config) {
                        reload_config = 0;
-                       udev_rules_close(&rules);
+                       udev_rules_cleanup(&rules);
                        udev_rules_init(&rules, 1);
                }
 
                        udev_rules_init(&rules, 1);
                }
 
@@ -945,18 +1105,19 @@ int main(int argc, char *argv[], char *envp[])
        }
 
 exit:
        }
 
 exit:
-       udev_rules_close(&rules);
+       udev_rules_cleanup(&rules);
+       sysfs_cleanup();
 
 
-       if (signal_pipe[READ_END] > 0)
+       if (signal_pipe[READ_END] >= 0)
                close(signal_pipe[READ_END]);
                close(signal_pipe[READ_END]);
-       if (signal_pipe[WRITE_END] > 0)
+       if (signal_pipe[WRITE_END] >= 0)
                close(signal_pipe[WRITE_END]);
 
                close(signal_pipe[WRITE_END]);
 
-       if (udevd_sock > 0)
+       if (udevd_sock >= 0)
                close(udevd_sock);
                close(udevd_sock);
-       if (inotify_fd > 0)
+       if (inotify_fd >= 0)
                close(inotify_fd);
                close(inotify_fd);
-       if (uevent_netlink_sock > 0)
+       if (uevent_netlink_sock >= 0)
                close(uevent_netlink_sock);
 
        logging_close();
                close(uevent_netlink_sock);
 
        logging_close();
Unnamed repository; edit this file 'description' to name the repository.