chiark / gitweb /
udevd: improve error message in case exec() fails
[elogind.git] / udev / udevadm-settle.c
index 682819201e46fc2f970626246c25b2608b7d1cec..9492abd401e0dbb8f9efd193ac383d045139ac29 100644 (file)
 #include <syslog.h>
 #include <getopt.h>
 #include <signal.h>
+#include <time.h>
+#include <sys/inotify.h>
+#include <sys/poll.h>
 #include <sys/stat.h>
 #include <sys/types.h>
 
 #include "udev.h"
 
-#define DEFAULT_TIMEOUT                        180
-#define LOOP_PER_SECOND                        20
-
-static volatile sig_atomic_t is_timeout;
-
-static void sig_handler(int signum)
-{
-       switch (signum) {
-               case SIGALRM:
-                       is_timeout = 1;
-               case SIGUSR1:
-                       ;
-       }
-}
-
 int udevadm_settle(struct udev *udev, int argc, char *argv[])
 {
        static const struct option options[] = {
@@ -59,26 +47,19 @@ int udevadm_settle(struct udev *udev, int argc, char *argv[])
                { "help", no_argument, NULL, 'h' },
                {}
        };
+       unsigned long long start_usec = now_usec();
        unsigned long long start = 0;
        unsigned long long end = 0;
        int quiet = 0;
        const char *exists = NULL;
-       int timeout = DEFAULT_TIMEOUT;
-       struct sigaction act;
+       unsigned int timeout = 120;
+       struct pollfd pfd[1];
        struct udev_queue *udev_queue = NULL;
-       int rc = 1;
+       int rc = EXIT_FAILURE;
 
        dbg(udev, "version %s\n", VERSION);
 
-       /* set signal handlers */
-       memset(&act, 0x00, sizeof(act));
-       act.sa_handler = sig_handler;
-       sigemptyset (&act.sa_mask);
-       act.sa_flags = 0;
-       sigaction(SIGALRM, &act, NULL);
-       sigaction(SIGUSR1, &act, NULL);
-
-       while (1) {
+       for (;;) {
                int option;
                int seconds;
 
@@ -119,11 +100,6 @@ int udevadm_settle(struct udev *udev, int argc, char *argv[])
                }
        }
 
-       if (timeout > 0)
-               alarm(timeout);
-       else
-               is_timeout = 1;
-
        udev_queue = udev_queue_new(udev);
        if (udev_queue == NULL)
                exit(2);
@@ -139,14 +115,12 @@ int udevadm_settle(struct udev *udev, int argc, char *argv[])
 
                if (start > end) {
                        err(udev, "seq-start larger than seq-end, ignoring\n");
-                       fprintf(stderr, "seq-start larger than seq-end, ignoring\n");
                        start = 0;
                        end = 0;
                }
 
                if (start > kernel_seq || end > kernel_seq) {
                        err(udev, "seq-start or seq-end larger than current kernel value, ignoring\n");
-                       fprintf(stderr, "seq-start or seq-end larger than current kernel value, ignoring\n");
                        start = 0;
                        end = 0;
                }
@@ -154,7 +128,6 @@ int udevadm_settle(struct udev *udev, int argc, char *argv[])
        } else {
                if (end > 0) {
                        err(udev, "seq-end needs seq-start parameter, ignoring\n");
-                       fprintf(stderr, "seq-end needs seq-start parameter, ignoring\n");
                        end = 0;
                }
        }
@@ -165,61 +138,84 @@ int udevadm_settle(struct udev *udev, int argc, char *argv[])
 
                uctrl = udev_ctrl_new_from_socket(udev, UDEV_CTRL_SOCK_PATH);
                if (uctrl != NULL) {
-                       sigset_t mask, oldmask;
-
-                       sigemptyset(&mask);
-                       sigaddset(&mask, SIGUSR1);
-                       sigaddset(&mask, SIGALRM);
-                       sigprocmask(SIG_BLOCK, &mask, &oldmask);
-                       if (udev_ctrl_send_settle(uctrl) > 0)
-                               sigsuspend(&oldmask);
-                       sigprocmask(SIG_SETMASK, &oldmask, NULL);
+                       if (udev_ctrl_send_ping(uctrl, timeout) < 0) {
+                               info(udev, "no connection to daemon\n");
+                               udev_ctrl_unref(uctrl);
+                               rc = EXIT_SUCCESS;
+                               goto out;
+                       }
                        udev_ctrl_unref(uctrl);
                }
        }
 
-       while (1) {
+       pfd[0].events = POLLIN;
+       pfd[0].fd = inotify_init1(IN_CLOEXEC);
+       if (pfd[0].fd < 0) {
+               err(udev, "inotify_init failed: %m\n");
+       } else {
+               if (inotify_add_watch(pfd[0].fd, udev_get_run_path(udev), IN_CLOSE_WRITE) < 0) {
+                       err(udev, "watching '%s' failed\n", udev_get_run_path(udev));
+                       close(pfd[0].fd);
+                       pfd[0].fd = -1;
+               }
+       }
+
+       for (;;) {
                struct stat statbuf;
 
                if (exists != NULL && stat(exists, &statbuf) == 0) {
-                       rc = 0;
+                       rc = EXIT_SUCCESS;
                        break;
                }
 
                if (start > 0) {
                        /* if asked for, wait for a specific sequence of events */
                        if (udev_queue_get_seqnum_sequence_is_finished(udev_queue, start, end) == 1) {
-                               rc = 0;
+                               rc = EXIT_SUCCESS;
                                break;
                        }
                } else {
                        /* exit if queue is empty */
                        if (udev_queue_get_queue_is_empty(udev_queue)) {
-                               rc = 0;
+                               rc = EXIT_SUCCESS;
                                break;
                        }
                }
 
-               if (is_timeout)
-                       break;
+               if (pfd[0].fd >= 0) {
+                       /* wake up once every second, or whenever the queue file gets gets closed */
+                       if (poll(pfd, 1, 1000) > 0 && pfd[0].revents & POLLIN) {
+                               char buf[sizeof(struct inotify_event) + PATH_MAX];
 
-               usleep(1000 * 1000 / LOOP_PER_SECOND);
-       }
+                               read(pfd[0].fd, buf, sizeof(buf));
+                       }
+               } else {
+                       sleep(1);
+               }
 
-       /* if we reached the timeout, print the list of remaining events */
-       if (is_timeout) {
-               struct udev_list_entry *list_entry;
-
-               if (!quiet && udev_queue_get_queued_list_entry(udev_queue) != NULL) {
-                       info(udev, "timeout waiting for udev queue\n");
-                       printf("\nudevadm settle - timeout of %i seconds reached, the event queue contains:\n", timeout);
-                       udev_list_entry_foreach(list_entry, udev_queue_get_queued_list_entry(udev_queue))
-                               printf("  %s (%s)\n",
-                                      udev_list_entry_get_name(list_entry),
-                                      udev_list_entry_get_value(list_entry));
+               if (timeout > 0) {
+                       unsigned long long age_usec;
+
+                       age_usec = now_usec() - start_usec;
+                       if (age_usec / (1000 * 1000) >= timeout) {
+                               struct udev_list_entry *list_entry;
+
+                               if (!quiet && udev_queue_get_queued_list_entry(udev_queue) != NULL) {
+                                       info(udev, "timeout waiting for udev queue\n");
+                                       printf("\nudevadm settle - timeout of %i seconds reached, the event queue contains:\n", timeout);
+                                       udev_list_entry_foreach(list_entry, udev_queue_get_queued_list_entry(udev_queue))
+                                               printf("  %s (%s)\n",
+                                               udev_list_entry_get_name(list_entry),
+                                               udev_list_entry_get_value(list_entry));
+                               }
+
+                               break;
+                       }
                }
        }
-
+out:
+       if (pfd[0].fd >= 0)
+               close(pfd[0].fd);
        udev_queue_unref(udev_queue);
        return rc;
 }