[PATCH] Don't use any syslog() in signal handler, cause it may deadlock.

[elogind.git] / udev.c

diff --git a/udev.c b/udev.c
index dfb2baddbc34dfdabbf5264bd9abf587d68304a2..78090605206f1fab763c4a1dccb21d485967940b 100644 (file)
--- a/udev.c
+++ b/udev.c
@@ -20,7 +20,6 @@
  *
  */
 
-#define _KLIBC_HAS_ARCH_SIG_ATOMIC_T
 #include <stdio.h>
 #include <stddef.h>
 #include <stdlib.h>
@@ -28,10 +27,12 @@
 #include <ctype.h>
 #include <errno.h>
 #include <signal.h>
+#include <unistd.h>
 
 #include "libsysfs/sysfs/libsysfs.h"
 #include "udev.h"
 #include "udev_lib.h"
+#include "udev_sysfs.h"
 #include "udev_version.h"
 #include "logging.h"
 #include "namedev.h"
@@ -64,46 +65,13 @@ static void asmlinkage sig_handler(int signum)
        switch (signum) {
                case SIGALRM:
                        gotalarm = 1;
-                       info("error: timeout reached, event probably not handled correctly");
                        break;
                case SIGINT:
                case SIGTERM:
-                       udevdb_exit();
                        exit(20 + signum);
-               default:
-                       dbg("unhandled signal %d", signum);
        }
 }
 
-/* list of subsystems we don't care about. not listing such systems here
- * is not critical, but it makes it faster as we don't look for the "dev" file
- */
-static int subsystem_without_dev(const char *subsystem)
-{
-       char *subsystem_blacklist[] = {
-               "scsi_host",
-               "scsi_device",
-               "usb_host",
-               "pci_bus",
-               "pcmcia_socket",
-               "bluetooth",
-               "i2c-adapter",
-               "pci_bus",
-               "ieee1394",
-               "ieee1394_host",
-               "ieee1394_node",
-               NULL
-       };
-       char **subsys;
-
-       for (subsys = subsystem_blacklist; *subsys != NULL; subsys++) {
-               if (strcmp(subsystem, *subsys) == 0)
-                       return 1;
-       }
-
-       return 0;
-}
-
 int main(int argc, char *argv[], char *envp[])
 {
        struct sigaction act;
@@ -150,7 +118,7 @@ int main(int argc, char *argv[], char *envp[])
                        dbg("no devpath?");
                        goto exit;
                }
-               dbg("looking at '%s'", udev.devpath);
+               dbg("looking at '%s'", devpath);
 
                /* we only care about class devices and block stuff */
                if (!strstr(devpath, "class") && !strstr(devpath, "block")) {
@@ -163,18 +131,20 @@ int main(int argc, char *argv[], char *envp[])
                        goto exit;
                }
 
+               udev_set_values(&udev, devpath, subsystem);
+
                /* skip blacklisted subsystems */
-               if (subsystem_without_dev(subsystem)) {
+               if (udev.type != 'n' && subsystem_expect_no_dev(subsystem)) {
                        dbg("don't care about '%s' devices", subsystem);
                        goto exit;
                };
 
-               udev_set_values(&udev, devpath, subsystem);
        }
 
        /* set signal handlers */
        act.sa_handler = (void (*) (int))sig_handler;
        sigemptyset (&act.sa_mask);
+       act.sa_flags = 0;
        /* alarm must not restart syscalls*/
        sigaction(SIGALRM, &act, NULL);
        sigaction(SIGINT, &act, NULL);
@@ -196,9 +166,6 @@ int main(int argc, char *argv[], char *envp[])
        case ADD:
                dbg("udev add");
 
-               /* init rules */
-               namedev_init();
-
                /* open the device */
                snprintf(path, SYSFS_PATH_MAX, "%s%s", sysfs_path, udev.devpath);
                class_dev = sysfs_open_class_device_path(path);
@@ -208,6 +175,9 @@ int main(int argc, char *argv[], char *envp[])
                }
                dbg("opened class_dev->name='%s'", class_dev->name);
 
+               /* init rules */
+               namedev_init();
+
                /* name, create node, store in db */
                retval = udev_add_device(&udev, class_dev);