#include "udev.h"
#include "sd-daemon.h"
+#include "cgroup-util.h"
static bool debug;
static sigset_t sigmask_orig;
static UDEV_LIST(event_list);
static UDEV_LIST(worker_list);
+char *udev_cgroup;
static bool udev_exit;
enum event_state {
if (fdcount < 0) {
if (errno == EINTR)
continue;
- err = -errno;
log_error("failed to poll: %m\n");
goto out;
}
return 0;
}
-static void worker_kill(struct udev *udev, int retain)
+static void worker_kill(struct udev *udev)
{
struct udev_list_node *loop;
- int max;
-
- if (children <= retain)
- return;
-
- max = children - retain;
udev_list_node_foreach(loop, &worker_list) {
struct worker *worker = node_to_worker(loop);
- if (max-- <= 0)
- break;
-
if (worker->state == WORKER_KILLED)
continue;
log_debug("udevd message (SET_LOG_PRIORITY) received, log_priority=%i\n", i);
log_set_max_level(i);
udev_set_log_priority(udev, i);
- worker_kill(udev, 0);
+ worker_kill(udev);
}
if (udev_ctrl_get_stop_exec_queue(ctrl_msg) > 0) {
}
free(key);
}
- worker_kill(udev, 0);
+ worker_kill(udev);
}
i = udev_ctrl_get_set_children_max(ctrl_msg);
fclose(f);
}
-static int copy_dev_dir(struct udev *udev, DIR *dir_from, DIR *dir_to, int maxdepth)
-{
- struct dirent *dent;
-
- for (dent = readdir(dir_from); dent != NULL; dent = readdir(dir_from)) {
- struct stat stats;
-
- if (dent->d_name[0] == '.')
- continue;
- if (fstatat(dirfd(dir_from), dent->d_name, &stats, AT_SYMLINK_NOFOLLOW) != 0)
- continue;
-
- if (S_ISBLK(stats.st_mode) || S_ISCHR(stats.st_mode)) {
- udev_selinux_setfscreateconat(udev, dirfd(dir_to), dent->d_name, stats.st_mode & 0777);
- if (mknodat(dirfd(dir_to), dent->d_name, stats.st_mode, stats.st_rdev) == 0) {
- fchmodat(dirfd(dir_to), dent->d_name, stats.st_mode & 0777, 0);
- fchownat(dirfd(dir_to), dent->d_name, stats.st_uid, stats.st_gid, 0);
- } else {
- utimensat(dirfd(dir_to), dent->d_name, NULL, 0);
- }
- udev_selinux_resetfscreatecon(udev);
- } else if (S_ISLNK(stats.st_mode)) {
- char target[UTIL_PATH_SIZE];
- ssize_t len;
-
- len = readlinkat(dirfd(dir_from), dent->d_name, target, sizeof(target));
- if (len <= 0 || len == (ssize_t)sizeof(target))
- continue;
- target[len] = '\0';
- udev_selinux_setfscreateconat(udev, dirfd(dir_to), dent->d_name, S_IFLNK);
- if (symlinkat(target, dirfd(dir_to), dent->d_name) < 0 && errno == EEXIST)
- utimensat(dirfd(dir_to), dent->d_name, NULL, AT_SYMLINK_NOFOLLOW);
- udev_selinux_resetfscreatecon(udev);
- } else if (S_ISDIR(stats.st_mode)) {
- DIR *dir2_from, *dir2_to;
-
- if (maxdepth == 0)
- continue;
-
- udev_selinux_setfscreateconat(udev, dirfd(dir_to), dent->d_name, S_IFDIR|0755);
- mkdirat(dirfd(dir_to), dent->d_name, 0755);
- udev_selinux_resetfscreatecon(udev);
-
- dir2_to = fdopendir(openat(dirfd(dir_to), dent->d_name, O_RDONLY|O_NONBLOCK|O_DIRECTORY|O_CLOEXEC));
- if (dir2_to == NULL)
- continue;
-
- dir2_from = fdopendir(openat(dirfd(dir_from), dent->d_name, O_RDONLY|O_NONBLOCK|O_DIRECTORY|O_CLOEXEC));
- if (dir2_from == NULL) {
- closedir(dir2_to);
- continue;
- }
-
- copy_dev_dir(udev, dir2_from, dir2_to, maxdepth-1);
-
- closedir(dir2_to);
- closedir(dir2_from);
- }
- }
-
- return 0;
-}
-
-static void static_dev_create_links(struct udev *udev, DIR *dir)
+/* needed for standalone udev operations */
+static void static_dev_create_links(struct udev *udev)
{
+ DIR *dir;
struct stdlinks {
const char *link;
const char *target;
};
unsigned int i;
+ dir = opendir(udev_get_dev_path(udev));
+ if (dir == NULL)
+ return;
+
for (i = 0; i < ARRAY_SIZE(stdlinks); i++) {
struct stat sb;
udev_selinux_resetfscreatecon(udev);
}
}
-}
-
-static void static_dev_create_from_devices(struct udev *udev, DIR *dir)
-{
- DIR *dir_from;
-
- dir_from = opendir(UDEVLIBEXECDIR "/devices");
- if (dir_from == NULL)
- return;
- copy_dev_dir(udev, dir_from, dir, 8);
- closedir(dir_from);
-}
-
-static void static_dev_create(struct udev *udev)
-{
- DIR *dir;
-
- dir = opendir(udev_get_dev_path(udev));
- if (dir == NULL)
- return;
-
- static_dev_create_links(udev, dir);
- static_dev_create_from_devices(udev, dir);
closedir(dir);
}
int fd_worker = -1;
struct epoll_event ep_ctrl, ep_inotify, ep_signal, ep_netlink, ep_worker;
struct udev_ctrl_connection *ctrl_conn = NULL;
- char **s;
int rc = 1;
udev = udev_new();
break;
case 'D':
debug = true;
- if (udev_get_log_priority(udev) < LOG_INFO)
- udev_set_log_priority(udev, LOG_INFO);
+ log_set_max_level(LOG_DEBUG);
+ udev_set_log_priority(udev, LOG_INFO);
break;
case 'N':
if (strcmp (optarg, "early") == 0) {
mkdir(udev_get_run_path(udev), 0755);
/* create standard links, copy static nodes, create nodes from modules */
- static_dev_create(udev);
+ static_dev_create_links(udev);
static_dev_create_from_modules(udev);
/* before opening new files, make sure std{in,out,err} fds are in a sane state */
rc = 3;
goto exit;
}
+
+ /* get our own cgroup, we regularly kill everything udev has left behind */
+ if (cg_get_by_pid(SYSTEMD_CGROUP_CONTROLLER, 0, &udev_cgroup) < 0)
+ udev_cgroup = NULL;
} else {
/* open control and netlink socket */
udev_ctrl = udev_ctrl_new(udev);
/* discard queued events and kill workers */
event_queue_cleanup(udev, EVENT_QUEUED);
- worker_kill(udev, 0);
+ worker_kill(udev);
/* exit after all has cleaned up */
if (udev_list_node_is_empty(&event_list) && udev_list_node_is_empty(&worker_list))
/* timeout at exit for workers to finish */
timeout = 30 * 1000;
- } else if (udev_list_node_is_empty(&event_list) && children <= 2) {
+ } else if (udev_list_node_is_empty(&event_list) && !children) {
/* we are idle */
timeout = -1;
+
+ /* cleanup possible left-over processes in our cgroup */
+ if (udev_cgroup)
+ cg_kill(SYSTEMD_CGROUP_CONTROLLER, udev_cgroup, SIGKILL, false, true, NULL);
} else {
/* kill idle or hanging workers */
timeout = 3 * 1000;
/* kill idle workers */
if (udev_list_node_is_empty(&event_list)) {
log_debug("cleanup idle workers\n");
- worker_kill(udev, 2);
+ worker_kill(udev);
}
/* check for hanging events */
continue;
if ((now_usec() - worker->event_start_usec) > 30 * 1000 * 1000) {
- log_error("worker [%u] timeout, kill it\n", worker->pid,
+ log_error("worker [%u] %s timeout; kill it\n", worker->pid,
worker->event ? worker->event->devpath : "<idle>");
kill(worker->pid, SIGKILL);
worker->state = WORKER_KILLED;
/* reload requested, HUP signal received, rules changed, builtin changed */
if (reload) {
- worker_kill(udev, 0);
+ worker_kill(udev);
rules = udev_rules_unref(rules);
udev_builtin_exit(udev);
reload = 0;
~ianmdlvl / elogind.git / blobdiff