#include "conf-files.h"
#include "fileio.h"
#include "hashmap.h"
+#include "rtnl-util.h"
struct link_config_ctx {
LIST_HEAD(link_config, links);
int ethtool_fd;
+ bool enable_name_policy;
+
sd_rtnl *rtnl;
char **link_dirs;
int link_config_ctx_new(link_config_ctx **ret) {
_cleanup_link_config_ctx_free_ link_config_ctx *ctx = NULL;
- int r;
if (!ret)
return -EINVAL;
if (!ctx)
return -ENOMEM;
- r = ethtool_connect(&ctx->ethtool_fd);
- if (r < 0)
- return r;
+ LIST_HEAD_INIT(ctx->links);
- r = sd_rtnl_open(0, &ctx->rtnl);
- if (r < 0)
- return r;
+ ctx->ethtool_fd = -1;
- LIST_HEAD_INIT(ctx->links);
+ ctx->enable_name_policy = true;
ctx->link_dirs = strv_new("/etc/systemd/network",
"/run/systemd/network",
return 0;
}
+static int link_config_ctx_connect(link_config_ctx *ctx) {
+ int r;
+
+ if (ctx->ethtool_fd >= 0 && ctx->rtnl)
+ return 0;
+
+ r = ethtool_connect(&ctx->ethtool_fd);
+ if (r < 0)
+ return r;
+
+ r = sd_rtnl_open(0, &ctx->rtnl);
+ if (r < 0)
+ return r;
+
+ return 0;
+}
+
static void link_configs_free(link_config_ctx *ctx) {
link_config *link, *link_next;
return r;
}
+static bool enable_name_policy(void) {
+ _cleanup_free_ char *line;
+ char *w, *state;
+ int r;
+ size_t l;
+
+ r = read_one_line_file("/proc/cmdline", &line);
+ if (r < 0) {
+ log_warning("Failed to read /proc/cmdline, ignoring: %s", strerror(-r));
+ return true; /* something is very wrong, let's not make it worse */
+ }
+
+ FOREACH_WORD_QUOTED(w, l, line, state)
+ if (strneq(w, "net.ifnames=0", l))
+ return false;
+
+ return true;
+}
+
int link_config_load(link_config_ctx *ctx) {
int r;
char **files, **f;
link_configs_free(ctx);
+
+ if (!enable_name_policy()) {
+ ctx->enable_name_policy = false;
+ log_info("Network interface NamePolicy= disabled on kernel commandline, ignoring.");
+ }
+
/* update timestamp */
paths_check_timestamp(ctx->link_dirs, &ctx->link_dirs_ts_usec, true);
link_config *link;
LIST_FOREACH(links, link, ctx->links) {
- if (!match_config(link, device)) {
- log_info("Config file %s does not apply to device %s", link->filename, udev_device_get_sysname(device));
- } else {
- log_info("Config file %s applies to device %s", link->filename, udev_device_get_sysname(device));
+ if (match_config(link, device)) {
+ log_debug("Config file %s applies to device %s", link->filename, udev_device_get_sysname(device));
*ret = link;
return 0;
}
return -ENOENT;
}
-static int rtnl_set_properties(sd_rtnl *rtnl, int ifindex, const char *name, const struct ether_addr *mac, unsigned int mtu) {
- _cleanup_sd_rtnl_message_unref_ sd_rtnl_message *message;
- bool need_update = false;
- int r;
-
- assert(rtnl);
- assert(ifindex > 0);
-
- r = sd_rtnl_message_link_new(RTM_NEWLINK, ifindex, 0, 0, &message);
- if (r < 0)
- return r;
-
- if (name) {
- r = sd_rtnl_message_append(message, IFLA_IFNAME, name);
- if (r < 0)
- return r;
-
- need_update = true;
- }
-
- if (mac) {
- r = sd_rtnl_message_append(message, IFLA_ADDRESS, mac);
- if (r < 0)
- return r;
-
- need_update = true;
- }
-
- if (mtu > 0) {
- r = sd_rtnl_message_append(message, IFLA_MTU, &mtu);
- if (r < 0)
- return r;
-
- need_update = true;
- }
-
- if (need_update) {
- r = sd_rtnl_send_with_reply_and_block(rtnl, message, 5 * USEC_PER_SEC, NULL);
- if (r < 0)
- return r;
- }
-
- return 0;
-}
-
-static bool enable_name_policy(void) {
- _cleanup_free_ char *line;
- char *w, *state;
- int r;
- size_t l;
-
- r = read_one_line_file("/proc/cmdline", &line);
- if (r < 0) {
- log_warning("Failed to read /proc/cmdline, ignoring: %s", strerror(-r));
- return true; /* something is very wrong, let's not make it worse */
- }
-
- FOREACH_WORD_QUOTED(w, l, line, state)
- if (strneq(w, "net.ifnames=0", l))
- return false;
-
- return true;
-}
-
static bool mac_is_random(struct udev_device *device) {
const char *s;
unsigned type;
return 0;
}
-int link_config_apply(link_config_ctx *ctx, link_config *config, struct udev_device *device) {
- const char *name;
+int link_config_apply(link_config_ctx *ctx, link_config *config, struct udev_device *device, const char **name) {
+ const char *old_name;
const char *new_name = NULL;
struct ether_addr generated_mac;
struct ether_addr *mac = NULL;
int r, ifindex;
- name = udev_device_get_sysname(device);
- if (!name)
- return -EINVAL;
+ assert(ctx);
+ assert(config);
+ assert(device);
+ assert(name);
+
+ r = link_config_ctx_connect(ctx);
+ if (r < 0)
+ return r;
- log_info("Configuring %s", name);
+ old_name = udev_device_get_sysname(device);
+ if (!old_name)
+ return -EINVAL;
if (config->description) {
r = udev_device_set_sysattr_value(device, "ifalias",
config->description);
if (r < 0)
log_warning("Could not set description of %s to '%s': %s",
- name, config->description, strerror(-r));
+ old_name, config->description, strerror(-r));
}
- r = ethtool_set_speed(ctx->ethtool_fd, name, config->speed, config->duplex);
+ r = ethtool_set_speed(ctx->ethtool_fd, old_name, config->speed, config->duplex);
if (r < 0)
log_warning("Could not set speed or duplex of %s to %u Mbytes (%s): %s",
- name, config->speed, duplex_to_string(config->duplex), strerror(-r));
+ old_name, config->speed, duplex_to_string(config->duplex), strerror(-r));
- r = ethtool_set_wol(ctx->ethtool_fd, name, config->wol);
+ r = ethtool_set_wol(ctx->ethtool_fd, old_name, config->wol);
if (r < 0)
log_warning("Could not set WakeOnLan of %s to %s: %s",
- name, wol_to_string(config->wol), strerror(-r));
+ old_name, wol_to_string(config->wol), strerror(-r));
ifindex = udev_device_get_ifindex(device);
if (ifindex <= 0) {
return -ENODEV;
}
- if (config->name_policy && enable_name_policy()) {
+ if (ctx->enable_name_policy && config->name_policy) {
NamePolicy *policy;
for (policy = config->name_policy; !new_name && *policy != _NAMEPOLICY_INVALID; policy++) {
}
}
- if (!new_name && config->name) {
- new_name = config->name;
- }
+ if (new_name)
+ *name = new_name; /* a name was set by a policy */
+ else if (config->name)
+ *name = config->name; /* a name was set manually in the config */
+ else
+ *name = NULL;
switch (config->mac_policy) {
case MACPOLICY_PERSISTENT:
mac = config->mac;
}
- r = rtnl_set_properties(ctx->rtnl, ifindex, new_name, mac, config->mtu);
+ r = rtnl_set_link_properties(ctx->rtnl, ifindex, mac, config->mtu);
if (r < 0) {
- log_warning("Could not set Name, MACAddress or MTU on %s: %s", name, strerror(-r));
+ log_warning("Could not set MACAddress or MTU on %s: %s", old_name, strerror(-r));
return r;
}
~ianmdlvl / elogind.git / blobdiff