tmpfiles: add missing missing.h include

[elogind.git] / src / tmpfiles / tmpfiles.c

diff --git a/src/tmpfiles/tmpfiles.c b/src/tmpfiles/tmpfiles.c
index 6b3f70e071e17a10f9cc91a4da8688e1681e5a37..614644a0abe59fadaf7bbf8eb378e6abf233f2ff 100644 (file)
--- a/src/tmpfiles/tmpfiles.c
+++ b/src/tmpfiles/tmpfiles.c
@@ -43,6 +43,7 @@
 #include "log.h"
 #include "util.h"
 #include "macro.h"
 #include "log.h"
 #include "util.h"
 #include "macro.h"

+#include "missing.h"

 #include "mkdir.h"
 #include "path-util.h"
 #include "strv.h"
 #include "mkdir.h"
 #include "path-util.h"
 #include "strv.h"


@@ -134,7 +135,7 @@ static struct Item* find_glob(Hashmap *h, const char *match) {
 }
 
 static void load_unix_sockets(void) {
 }
 
 static void load_unix_sockets(void) {

-        FILE *f = NULL;
+        FILE _cleanup_fclose_ *f = NULL;

         char line[LINE_MAX];
 
         if (unix_sockets)
         char line[LINE_MAX];
 
         if (unix_sockets)


@@ -194,15 +195,11 @@ static void load_unix_sockets(void) {
                 }
         }
 
                 }
         }
 

-        fclose(f);

         return;
 
 fail:
         set_free_free(unix_sockets);
         unix_sockets = NULL;
         return;
 
 fail:
         set_free_free(unix_sockets);
         unix_sockets = NULL;

-
-        if (f)
-                fclose(f);

 }
 
 static bool unix_socket_alive(const char *fn) {
 }
 
 static bool unix_socket_alive(const char *fn) {


@@ -217,6 +214,42 @@ static bool unix_socket_alive(const char *fn) {
         return true;
 }
 
         return true;
 }
 

+static int dir_is_mount_point(DIR *d, const char *subdir) {
+        struct file_handle *h;
+        int mount_id_parent, mount_id;
+        int r_p, r;
+
+        h = alloca(MAX_HANDLE_SZ);
+
+        h->handle_bytes = MAX_HANDLE_SZ;
+        r_p = name_to_handle_at(dirfd(d), ".", h, &mount_id_parent, 0);
+        if (r_p < 0)
+                r_p = -errno;
+
+        h->handle_bytes = MAX_HANDLE_SZ;
+        r = name_to_handle_at(dirfd(d), subdir, h, &mount_id, 0);
+        if (r < 0)
+                r = -errno;
+
+        /* got no handle; make no assumptions, return error */
+        if (r_p < 0 && r < 0)
+                return r_p;
+
+        /* got both handles; if they differ, it is a mount point */
+        if (r_p >= 0 && r >= 0)
+                return mount_id_parent != mount_id;
+
+        /* got only one handle; assume different mount points if one
+         * of both queries was not supported by the filesystem */
+        if (r_p == -ENOSYS || r_p == -ENOTSUP || r == -ENOSYS || r == -ENOTSUP)
+                return true;
+
+        /* return error */
+        if (r_p < 0)
+                return r_p;
+        return r;
+}
+

 static int dir_cleanup(
                 Item *i,
                 const char *p,
 static int dir_cleanup(
                 Item *i,
                 const char *p,


@@ -231,12 +264,12 @@ static int dir_cleanup(
         struct dirent *dent;
         struct timespec times[2];
         bool deleted = false;
         struct dirent *dent;
         struct timespec times[2];
         bool deleted = false;

-        char *sub_path = NULL;

         int r = 0;
 
         while ((dent = readdir(d))) {
                 struct stat s;
                 usec_t age;
         int r = 0;
 
         while ((dent = readdir(d))) {
                 struct stat s;
                 usec_t age;

+                char _cleanup_free_ *sub_path = NULL;

 
                 if (streq(dent->d_name, ".") ||
                     streq(dent->d_name, ".."))
 
                 if (streq(dent->d_name, ".") ||
                     streq(dent->d_name, ".."))


@@ -256,13 +289,16 @@ static int dir_cleanup(
                 if (s.st_dev != rootdev)
                         continue;
 
                 if (s.st_dev != rootdev)
                         continue;
 

+                /* Try to detect bind mounts of the same filesystem instance; they
+                 * do not differ in device major/minors. This type of query is not
+                 * supported on all kernels or filesystem types though. */
+                if (S_ISDIR(s.st_mode) && dir_is_mount_point(d, dent->d_name) > 0)
+                        continue;
+

                 /* Do not delete read-only files owned by root */
                 if (s.st_uid == 0 && !(s.st_mode & S_IWUSR))
                         continue;
 
                 /* Do not delete read-only files owned by root */
                 if (s.st_uid == 0 && !(s.st_mode & S_IWUSR))
                         continue;
 

-                free(sub_path);
-                sub_path = NULL;
-

                 if (asprintf(&sub_path, "%s/%s", p, dent->d_name) < 0) {
                         r = log_oom();
                         goto finish;
                 if (asprintf(&sub_path, "%s/%s", p, dent->d_name) < 0) {
                         r = log_oom();
                         goto finish;


@@ -285,7 +321,7 @@ static int dir_cleanup(
                         if (maxdepth <= 0)
                                 log_warning("Reached max depth on %s.", sub_path);
                         else {
                         if (maxdepth <= 0)
                                 log_warning("Reached max depth on %s.", sub_path);
                         else {

-                                DIR *sub_dir;
+                                DIR _cleanup_closedir_ *sub_dir;

                                 int q;
 
                                 sub_dir = xopendirat(dirfd(d), dent->d_name, O_NOFOLLOW|O_NOATIME);
                                 int q;
 
                                 sub_dir = xopendirat(dirfd(d), dent->d_name, O_NOFOLLOW|O_NOATIME);


@@ -299,7 +335,6 @@ static int dir_cleanup(
                                 }
 
                                 q = dir_cleanup(i, sub_path, sub_dir, &s, cutoff, rootdev, false, maxdepth-1, false);
                                 }
 
                                 q = dir_cleanup(i, sub_path, sub_dir, &s, cutoff, rootdev, false, maxdepth-1, false);

-                                closedir(sub_dir);

 
                                 if (q < 0)
                                         r = q;
 
                                 if (q < 0)
                                         r = q;


@@ -321,7 +356,7 @@ static int dir_cleanup(
                         if (age >= cutoff)
                                 continue;
 
                         if (age >= cutoff)
                                 continue;
 

-                        if (!i->type == IGNORE_DIRECTORY_PATH || !streq(dent->d_name, p)) {
+                        if (i->type != IGNORE_DIRECTORY_PATH || !streq(dent->d_name, p)) {

                                 log_debug("rmdir '%s'\n", sub_path);
 
                                 if (unlinkat(dirfd(d), dent->d_name, AT_REMOVEDIR) < 0) {
                                 log_debug("rmdir '%s'\n", sub_path);
 
                                 if (unlinkat(dirfd(d), dent->d_name, AT_REMOVEDIR) < 0) {


@@ -393,8 +428,6 @@ finish:
                         log_error("utimensat(%s): %m", p);
         }
 
                         log_error("utimensat(%s): %m", p);
         }
 

-        free(sub_path);
-

         return r;
 }
 
         return r;
 }
 


@@ -483,7 +516,7 @@ static int write_one_file(Item *i, const char *path) {
 }
 
 static int recursive_relabel_children(Item *i, const char *path) {
 }
 
 static int recursive_relabel_children(Item *i, const char *path) {

-        DIR *d;
+        DIR _cleanup_closedir_ *d;

         int ret = 0;
 
         /* This returns the first error we run into, but nevertheless
         int ret = 0;
 
         /* This returns the first error we run into, but nevertheless


@@ -498,7 +531,7 @@ static int recursive_relabel_children(Item *i, const char *path) {
                 union dirent_storage buf;
                 bool is_dir;
                 int r;
                 union dirent_storage buf;
                 bool is_dir;
                 int r;

-                char *entry_path;
+                char _cleanup_free_ *entry_path = NULL;

 
                 r = readdir_r(d, &buf.de, &de);
                 if (r != 0) {
 
                 r = readdir_r(d, &buf.de, &de);
                 if (r != 0) {


@@ -525,7 +558,6 @@ static int recursive_relabel_children(Item *i, const char *path) {
                         if (lstat(entry_path, &st) < 0) {
                                 if (ret == 0 && errno != ENOENT)
                                         ret = -errno;
                         if (lstat(entry_path, &st) < 0) {
                                 if (ret == 0 && errno != ENOENT)
                                         ret = -errno;

-                                free(entry_path);

                                 continue;
                         }
 
                                 continue;
                         }
 


@@ -538,7 +570,6 @@ static int recursive_relabel_children(Item *i, const char *path) {
                 if (r < 0) {
                         if (ret == 0 && r != -ENOENT)
                                 ret = r;
                 if (r < 0) {
                         if (ret == 0 && r != -ENOENT)
                                 ret = r;

-                        free(entry_path);

                         continue;
                 }
 
                         continue;
                 }
 


@@ -547,12 +578,8 @@ static int recursive_relabel_children(Item *i, const char *path) {
                         if (r < 0 && ret == 0)
                                 ret = r;
                 }
                         if (r < 0 && ret == 0)
                                 ret = r;
                 }

-
-                free(entry_path);

         }
 
         }
 

-        closedir(d);
-

         return ret;
 }
 
         return ret;
 }
 


@@ -856,7 +883,7 @@ static int remove_item(Item *i) {
 }
 
 static int clean_item_instance(Item *i, const char* instance) {
 }
 
 static int clean_item_instance(Item *i, const char* instance) {

-        DIR *d;
+        DIR _cleanup_closedir_ *d = NULL;

         struct stat s, ps;
         bool mountpoint;
         int r;
         struct stat s, ps;
         bool mountpoint;
         int r;


@@ -884,31 +911,24 @@ static int clean_item_instance(Item *i, const char* instance) {
 
         if (fstat(dirfd(d), &s) < 0) {
                 log_error("stat(%s) failed: %m", i->path);
 
         if (fstat(dirfd(d), &s) < 0) {
                 log_error("stat(%s) failed: %m", i->path);

-                r = -errno;
-                goto finish;
+                return -errno;

         }
 
         if (!S_ISDIR(s.st_mode)) {
                 log_error("%s is not a directory.", i->path);
         }
 
         if (!S_ISDIR(s.st_mode)) {
                 log_error("%s is not a directory.", i->path);

-                r = -ENOTDIR;
-                goto finish;
+                return -ENOTDIR;

         }
 
         if (fstatat(dirfd(d), "..", &ps, AT_SYMLINK_NOFOLLOW) != 0) {
                 log_error("stat(%s/..) failed: %m", i->path);
         }
 
         if (fstatat(dirfd(d), "..", &ps, AT_SYMLINK_NOFOLLOW) != 0) {
                 log_error("stat(%s/..) failed: %m", i->path);

-                r = -errno;
-                goto finish;
+                return -errno;

         }
 
         mountpoint = s.st_dev != ps.st_dev ||
                      (s.st_dev == ps.st_dev && s.st_ino == ps.st_ino);
 
         }
 
         mountpoint = s.st_dev != ps.st_dev ||
                      (s.st_dev == ps.st_dev && s.st_ino == ps.st_ino);
 

-        r = dir_cleanup(i, instance, d, &s, cutoff, s.st_dev, mountpoint, MAX_DEPTH, i->keep_first_level);
-
-finish:
-        if (d)
-                closedir(d);
-
+        r = dir_cleanup(i, instance, d, &s, cutoff, s.st_dev, mountpoint,
+                        MAX_DEPTH, i->keep_first_level);

         return r;
 }
 
         return r;
 }
 


@@ -1002,7 +1022,8 @@ static bool item_equal(Item *a, Item *b) {
 
 static int parse_line(const char *fname, unsigned line, const char *buffer) {
         Item *i, *existing;
 
 static int parse_line(const char *fname, unsigned line, const char *buffer) {
         Item *i, *existing;

-        char *mode = NULL, *user = NULL, *group = NULL, *age = NULL;
+        char _cleanup_free_
+                *mode = NULL, *user = NULL, *group = NULL, *age = NULL;

         char type;
         Hashmap *h;
         int r, n = -1;
         char type;
         Hashmap *h;
         int r, n = -1;


@@ -1015,21 +1036,16 @@ static int parse_line(const char *fname, unsigned line, const char *buffer) {
         if (!i)
                 return log_oom();
 
         if (!i)
                 return log_oom();
 

-        if (sscanf(buffer,
-                   "%c "
-                   "%ms "
-                   "%ms "
-                   "%ms "
-                   "%ms "
-                   "%ms "
-                   "%n",
+        r = sscanf(buffer,
+                   "%c %ms %ms %ms %ms %ms %n",

                    &type,
                    &i->path,
                    &mode,
                    &user,
                    &group,
                    &age,
                    &type,
                    &i->path,
                    &mode,
                    &user,
                    &group,
                    &age,

-                   &n) < 2) {
+                   &n);
+        if (r < 2) {

                 log_error("[%s:%u] Syntax error.", fname, line);
                 r = -EIO;
                 goto finish;
                 log_error("[%s:%u] Syntax error.", fname, line);
                 r = -EIO;
                 goto finish;


@@ -1196,11 +1212,6 @@ static int parse_line(const char *fname, unsigned line, const char *buffer) {
         r = 0;
 
 finish:
         r = 0;
 
 finish:

-        free(user);
-        free(group);
-        free(mode);
-        free(age);
-

         if (i)
                 item_free(i);
 
         if (i)
                 item_free(i);