ptyfwd: simplify how we handle vhangups a bit

[elogind.git] / src / shared / ptyfwd.c

diff --git a/src/shared/ptyfwd.c b/src/shared/ptyfwd.c
index 11356e2def5900deb9afe8b287084870f5a1b809..a780f7de9af99f68c774021f2ee2ddfa3a4fc3b9 100644 (file)
--- a/src/shared/ptyfwd.c
+++ b/src/shared/ptyfwd.c
@@ -53,7 +53,8 @@ struct PTYForward {
         bool master_writable:1;
         bool master_hangup:1;
 
-        bool repeat:1;
+        /* Continue reading after hangup? */
+        bool ignore_vhangup:1;
 
         bool last_char_set:1;
         char last_char;
@@ -171,13 +172,13 @@ static int shovel(PTYForward *f) {
                         if (k < 0) {
 
                                 /* Note that EIO on the master device
-                                 * might be cause by vhangup() or
+                                 * might be caused by vhangup() or
                                  * temporary closing of everything on
                                  * the other side, we treat it like
                                  * EAGAIN here and try again, unless
-                                 * repeat is off. */
+                                 * ignore_vhangup is off. */
 
-                                if (errno == EAGAIN || (errno == EIO && f->repeat))
+                                if (errno == EAGAIN || (errno == EIO && f->ignore_vhangup))
                                         f->master_readable = false;
                                 else if (errno == EPIPE || errno == ECONNRESET || errno == EIO) {
                                         f->master_readable = f->master_writable = false;
@@ -297,7 +298,7 @@ static int on_sigwinch_event(sd_event_source *e, const struct signalfd_siginfo *
         return 0;
 }
 
-int pty_forward_new(sd_event *event, int master, bool repeat, PTYForward **ret) {
+int pty_forward_new(sd_event *event, int master, bool ignore_vhangup, PTYForward **ret) {
         _cleanup_(pty_forward_freep) PTYForward *f = NULL;
         struct winsize ws;
         int r;
@@ -306,7 +307,7 @@ int pty_forward_new(sd_event *event, int master, bool repeat, PTYForward **ret)
         if (!f)
                 return -ENOMEM;
 
-        f->repeat = repeat;
+        f->ignore_vhangup = ignore_vhangup;
 
         if (event)
                 f->event = sd_event_ref(event);
@@ -403,7 +404,7 @@ PTYForward *pty_forward_free(PTYForward *f) {
         return NULL;
 }
 
-int pty_forward_last_char(PTYForward *f, char *ch) {
+int pty_forward_get_last_char(PTYForward *f, char *ch) {
         assert(f);
         assert(ch);
 
@@ -413,3 +414,32 @@ int pty_forward_last_char(PTYForward *f, char *ch) {
         *ch = f->last_char;
         return 0;
 }
+
+int pty_forward_set_ignore_vhangup(PTYForward *f, bool ignore_vhangup) {
+        int r;
+
+        assert(f);
+
+        if (f->ignore_vhangup == ignore_vhangup)
+                return 0;
+
+        f->ignore_vhangup = ignore_vhangup;
+        if (!f->ignore_vhangup) {
+
+                /* We shall now react to vhangup()s? Let's check
+                 * immediately if we might be in one */
+
+                f->master_readable = true;
+                r = shovel(f);
+                if (r < 0)
+                        return r;
+        }
+
+        return 0;
+}
+
+int pty_forward_get_ignore_vhangup(PTYForward *f) {
+        assert(f);
+
+        return f->ignore_vhangup;
+}