chiark / gitweb /
systemd-python: add casts and fix unused variable warnings in _reader
[elogind.git] / src / python-systemd / _reader.c
index 65ca06b97ff48a800522f134cd341fb569b3e9c1..c6f29f5e33de5d6bdebc392fd6b503f8bc3e036b 100644 (file)
 #include <structmember.h>
 #include <datetime.h>
 
+#if PY_MAJOR_VERSION >=3
+# define unicode_FromStringAndSize PyUnicode_FromStringAndSize
+# define unicode_FromString PyUnicode_FromString
+# define long_FromLong PyLong_FromLong
+# define long_FromSize_t PyLong_FromSize_t
+# define long_Check PyLong_Check
+# define long_AsLong PyLong_AsLong
+#else
+/* Python 3 type naming convention is used */
+# define unicode_FromStringAndSize PyString_FromStringAndSize
+# define unicode_FromString PyString_FromString
+# define long_FromLong PyInt_FromLong
+# define long_FromSize_t PyInt_FromSize_t
+# define long_Check PyInt_Check
+# define long_AsLong PyInt_AsLong
+#endif
+
 typedef struct {
     PyObject_HEAD
     sd_journal *j;
@@ -67,12 +84,12 @@ PyDoc_STRVAR(Journal__doc__,
 static int
 Journal_init(Journal *self, PyObject *args, PyObject *keywds)
 {
-    int flags=SD_JOURNAL_LOCAL_ONLY;
-    char *path=NULL;
+    int flags = SD_JOURNAL_LOCAL_ONLY;
+    char *path = NULL;
 
-    static char *kwlist[] = {"flags", "path", NULL};
-    if (! PyArg_ParseTupleAndKeywords(args, keywds, "|iz", kwlist,
-                                      &flags, &path))
+    static const char* const kwlist[] = {"flags", "path", NULL};
+    if (!PyArg_ParseTupleAndKeywords(args, keywds, "|iz", (char**) kwlist,
+                                     &flags, &path))
         return 1;
 
     int r;
@@ -132,11 +149,7 @@ Journal_get_next(Journal *self, PyObject *args)
 
     SD_JOURNAL_FOREACH_DATA(self->j, msg, msg_len) {
         delim_ptr = memchr(msg, '=', msg_len);
-#if PY_MAJOR_VERSION >=3
-        key = PyUnicode_FromStringAndSize(msg, delim_ptr - (const char*) msg);
-#else
-        key = PyString_FromStringAndSize(msg, delim_ptr - (const char*) msg);
-#endif
+        key = unicode_FromStringAndSize(msg, delim_ptr - (const char*) msg);
         value = PyBytes_FromStringAndSize(delim_ptr + 1, (const char*) msg + msg_len - (delim_ptr + 1) );
         if (PyDict_Contains(dict, key)) {
             cur_value = PyDict_GetItem(dict, key);
@@ -160,12 +173,7 @@ Journal_get_next(Journal *self, PyObject *args)
     if (sd_journal_get_realtime_usec(self->j, &realtime) == 0) {
         char realtime_str[20];
         sprintf(realtime_str, "%llu", (long long unsigned) realtime);
-
-#if PY_MAJOR_VERSION >=3
-        key = PyUnicode_FromString("__REALTIME_TIMESTAMP");
-#else
-        key = PyString_FromString("__REALTIME_TIMESTAMP");
-#endif
+        key = unicode_FromString("__REALTIME_TIMESTAMP");
         value = PyBytes_FromString(realtime_str);
         PyDict_SetItem(dict, key, value);
         Py_DECREF(key);
@@ -177,11 +185,7 @@ Journal_get_next(Journal *self, PyObject *args)
     if (sd_journal_get_monotonic_usec(self->j, &monotonic, &sd_id) == 0) {
         char monotonic_str[20];
         sprintf(monotonic_str, "%llu", (long long unsigned) monotonic);
-#if PY_MAJOR_VERSION >=3
-        key = PyUnicode_FromString("__MONOTONIC_TIMESTAMP");
-#else
-        key = PyString_FromString("__MONOTONIC_TIMESTAMP");
-#endif
+        key = unicode_FromString("__MONOTONIC_TIMESTAMP");
         value = PyBytes_FromString(monotonic_str);
 
         PyDict_SetItem(dict, key, value);
@@ -191,11 +195,7 @@ Journal_get_next(Journal *self, PyObject *args)
 
     char *cursor;
     if (sd_journal_get_cursor(self->j, &cursor) > 0) { //Should return 0...
-#if PY_MAJOR_VERSION >=3
-        key = PyUnicode_FromString("__CURSOR");
-#else
-        key = PyString_FromString("__CURSOR");
-#endif
+        key = unicode_FromString("__CURSOR");
         value = PyBytes_FromString(cursor);
         PyDict_SetItem(dict, key, value);
         free(cursor);
@@ -217,7 +217,8 @@ Journal_get_previous(Journal *self, PyObject *args)
     if (! PyArg_ParseTuple(args, "|L", &skip))
         return NULL;
 
-    return PyObject_CallMethod((PyObject *)self, "get_next", "L", -skip);
+    return PyObject_CallMethod((PyObject *)self, (char*) "get_next",
+                               (char*) "L", -skip);
 }
 
 PyDoc_STRVAR(Journal_add_match__doc__,
@@ -280,10 +281,10 @@ Journal_seek(Journal *self, PyObject *args, PyObject *keywds)
 {
     int64_t offset;
     int whence=SEEK_SET;
-    static char *kwlist[] = {"offset", "whence", NULL};
 
-    if (! PyArg_ParseTupleAndKeywords(args, keywds, "L|i", kwlist,
-                                      &offset, &whence))
+    static const char* const kwlist[] = {"offset", "whence", NULL};
+    if (!PyArg_ParseTupleAndKeywords(args, keywds, "L|i", (char**) kwlist,
+                                     &offset, &whence))
         return NULL;
 
     PyObject *result=NULL;
@@ -296,10 +297,12 @@ Journal_seek(Journal *self, PyObject *args, PyObject *keywds)
             return NULL;
 
         if (offset > 0LL) {
-            result = PyObject_CallMethod((PyObject *)self, "get_next", "L", offset);
+            result = PyObject_CallMethod((PyObject *)self, (char*) "get_next",
+                                         (char*) "L", offset);
         }
     }else if (whence == SEEK_CUR){
-        result = PyObject_CallMethod((PyObject *)self, "get_next", "L", offset);
+        result = PyObject_CallMethod((PyObject *)self, (char*) "get_next",
+                                     (char*) "L", offset);
     }else if (whence == SEEK_END){
         int r;
         Py_BEGIN_ALLOW_THREADS
@@ -309,9 +312,11 @@ Journal_seek(Journal *self, PyObject *args, PyObject *keywds)
             return NULL;
 
         if (offset < 0LL) {
-            result = PyObject_CallMethod((PyObject *)self, "get_next", "L", offset);
+            result = PyObject_CallMethod((PyObject *)self, (char*) "get_next",
+                                         (char*) "L", offset);
         }else{
-            result = PyObject_CallMethod((PyObject *)self, "get_next", "L", -1LL);
+            result = PyObject_CallMethod((PyObject *)self, (char*) "get_next",
+                                         (char*) "L", -1LL);
         }
     }else{
         PyErr_SetString(PyExc_ValueError, "Invalid value for whence");
@@ -407,22 +412,19 @@ PyDoc_STRVAR(Journal_wait__doc__,
 static PyObject *
 Journal_wait(Journal *self, PyObject *args, PyObject *keywds)
 {
-    int64_t timeout=0LL;
-    if (! PyArg_ParseTuple(args, "|L", &timeout))
+    int r;
+    int64_t timeout = 0LL;
+
+    if (!PyArg_ParseTuple(args, "|L", &timeout))
         return NULL;
 
-    int r;
     Py_BEGIN_ALLOW_THREADS
     r = sd_journal_wait(self->j, timeout ==0 ? (uint64_t) -1 : timeout * 1E6);
     Py_END_ALLOW_THREADS
     if (set_error(r, NULL, NULL))
         return NULL;
 
-#if PY_MAJOR_VERSION >=3
-    return PyLong_FromLong(r);
-#else
-    return PyInt_FromLong(r);
-#endif
+    return long_FromLong(r);
 }
 
 PyDoc_STRVAR(Journal_seek_cursor__doc__,
@@ -457,7 +459,7 @@ Journal_iternext(PyObject *self)
     PyObject *dict;
     Py_ssize_t dict_size;
 
-    dict = PyObject_CallMethod(self, "get_next", "");
+    dict = PyObject_CallMethod(self, (char*) "get_next", (char*) "");
     if (PyErr_Occurred())
         return NULL;
     dict_size = PyDict_Size(dict);
@@ -493,12 +495,7 @@ Journal_query_unique(Journal *self, PyObject *args)
     const char *delim_ptr;
     PyObject *value_set, *key, *value;
     value_set = PySet_New(0);
-
-#if PY_MAJOR_VERSION >=3
-    key = PyUnicode_FromString(query);
-#else
-    key = PyString_FromString(query);
-#endif
+    key = unicode_FromString(query);
 
     SD_JOURNAL_FOREACH_UNIQUE(self->j, uniq, uniq_len) {
         delim_ptr = memchr(uniq, '=', uniq_len);
@@ -514,19 +511,13 @@ static PyObject *
 Journal_get_data_threshold(Journal *self, void *closure)
 {
     size_t cvalue;
-    PyObject *value;
     int r;
 
     r = sd_journal_get_data_threshold(self->j, &cvalue);
     if (set_error(r, NULL, NULL))
         return NULL;
 
-#if PY_MAJOR_VERSION >=3
-    value = PyLong_FromSize_t(cvalue);
-#else
-    value = PyInt_FromSize_t(cvalue);
-#endif
-    return value;
+    return long_FromSize_t(cvalue);
 }
 
 static int
@@ -536,29 +527,21 @@ Journal_set_data_threshold(Journal *self, PyObject *value, void *closure)
         PyErr_SetString(PyExc_TypeError, "Cannot delete data threshold");
         return -1;
     }
-#if PY_MAJOR_VERSION >=3
-    if (! PyLong_Check(value)){
-#else
-    if (! PyInt_Check(value)){
-#endif
+    if (!long_Check(value)){
         PyErr_SetString(PyExc_TypeError, "Data threshold must be int");
         return -1;
     }
     int r;
-#if PY_MAJOR_VERSION >=3
-    r = sd_journal_set_data_threshold(self->j, (size_t) PyLong_AsLong(value));
-#else
-    r = sd_journal_set_data_threshold(self->j, (size_t) PyInt_AsLong(value));
-#endif
+    r = sd_journal_set_data_threshold(self->j, (size_t) long_AsLong(value));
     return set_error(r, NULL, NULL);
 }
 
 static PyGetSetDef Journal_getseters[] = {
-    {"data_threshold",
-    (getter)Journal_get_data_threshold,
-    (setter)Journal_set_data_threshold,
-    "data threshold",
-    NULL},
+    {(char*) "data_threshold",
+     (getter)Journal_get_data_threshold,
+     (setter)Journal_set_data_threshold,
+     (char*) "data threshold",
+     NULL},
     {NULL}
 };
 
@@ -639,11 +622,14 @@ static PyModuleDef _reader_module = {
 };
 #endif
 
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wmissing-prototypes"
+
 PyMODINIT_FUNC
 #if PY_MAJOR_VERSION >= 3
 PyInit__reader(void)
 #else
-init_reader(void) 
+init_reader(void)
 #endif
 {
     PyObject* m;
@@ -681,3 +667,5 @@ init_reader(void)
     return m;
 #endif
 }
+
+#pragma GCC diagnostic pop