manager: introduce IgnoreOnIsolate flag so that we can keep systemd-logger around...

[elogind.git] / src / mount.c

diff --git a/src/mount.c b/src/mount.c
index dcf0a434744483a6a9944a22a7347c711c646d0d..2b19f497f33bc77bb5129b278b0ae75aa64df654 100644 (file)
--- a/src/mount.c
+++ b/src/mount.c
@@ -35,6 +35,9 @@
 #include "unit-name.h"
 #include "dbus-mount.h"
 #include "special.h"
 #include "unit-name.h"
 #include "dbus-mount.h"
 #include "special.h"

+#include "bus-errors.h"
+#include "exit-status.h"
+#include "def.h"

 
 static const UnitActiveState state_translation_table[_MOUNT_STATE_MAX] = {
         [MOUNT_DEAD] = UNIT_INACTIVE,
 
 static const UnitActiveState state_translation_table[_MOUNT_STATE_MAX] = {
         [MOUNT_DEAD] = UNIT_INACTIVE,


@@ -63,6 +66,11 @@ static void mount_init(Unit *u) {
 
         exec_context_init(&m->exec_context);
 
 
         exec_context_init(&m->exec_context);
 

+        /* The stdio/kmsg bridge socket is on /, in order to avoid a
+         * dep loop, don't use kmsg logging for -.mount */
+        if (!unit_has_name(u, "-.mount"))
+                m->exec_context.std_output = EXEC_OUTPUT_KMSG;
+

         /* We need to make sure that /bin/mount is always called in
          * the same process group as us, so that the autofs kernel
          * side doesn't send us another mount request while we are
         /* We need to make sure that /bin/mount is always called in
          * the same process group as us, so that the autofs kernel
          * side doesn't send us another mount request while we are


@@ -72,6 +80,8 @@ static void mount_init(Unit *u) {
         m->timer_watch.type = WATCH_INVALID;
 
         m->control_command_id = _MOUNT_EXEC_COMMAND_INVALID;
         m->timer_watch.type = WATCH_INVALID;
 
         m->control_command_id = _MOUNT_EXEC_COMMAND_INVALID;

+
+        m->meta.ignore_on_isolate = true;

 }
 
 static void mount_unwatch_control_pid(Mount *m) {
 }
 
 static void mount_unwatch_control_pid(Mount *m) {


@@ -96,12 +106,21 @@ static void mount_parameters_done(MountParameters *p) {
 
 static void mount_done(Unit *u) {
         Mount *m = MOUNT(u);
 
 static void mount_done(Unit *u) {
         Mount *m = MOUNT(u);

+        Meta *other;

 
         assert(m);
 
         free(m->where);
         m->where = NULL;
 
 
         assert(m);
 
         free(m->where);
         m->where = NULL;
 

+        /* Try to detach us from the automount unit if there is any */
+        LIST_FOREACH(units_per_type, other, m->meta.manager->units_per_type[UNIT_AUTOMOUNT]) {
+                Automount *a = (Automount*) other;
+
+                if (a->mount == m)
+                        a->mount = NULL;
+        }
+

         mount_parameters_done(&m->parameters_etc_fstab);
         mount_parameters_done(&m->parameters_proc_self_mountinfo);
         mount_parameters_done(&m->parameters_fragment);
         mount_parameters_done(&m->parameters_etc_fstab);
         mount_parameters_done(&m->parameters_proc_self_mountinfo);
         mount_parameters_done(&m->parameters_fragment);


@@ -115,6 +134,26 @@ static void mount_done(Unit *u) {
         unit_unwatch_timer(u, &m->timer_watch);
 }
 
         unit_unwatch_timer(u, &m->timer_watch);
 }
 

+static MountParameters* get_mount_parameters_configured(Mount *m) {
+        assert(m);
+
+        if (m->from_fragment)
+                return &m->parameters_fragment;
+        else if (m->from_etc_fstab)
+                return &m->parameters_etc_fstab;
+
+        return NULL;
+}
+
+static MountParameters* get_mount_parameters(Mount *m) {
+        assert(m);
+
+        if (m->from_proc_self_mountinfo)
+                return &m->parameters_proc_self_mountinfo;
+
+        return get_mount_parameters_configured(m);
+}
+

 static int mount_add_mount_links(Mount *m) {
         Meta *other;
         int r;
 static int mount_add_mount_links(Mount *m) {
         Meta *other;
         int r;


@@ -122,12 +161,7 @@ static int mount_add_mount_links(Mount *m) {
 
         assert(m);
 
 
         assert(m);
 

-        if (m->from_fragment)
-                pm = &m->parameters_fragment;
-        else if (m->from_etc_fstab)
-                pm = &m->parameters_etc_fstab;
-        else
-                pm = NULL;
+        pm = get_mount_parameters_configured(m);

 
         /* Adds in links to other mount points that might lie below or
          * above us in the hierarchy */
 
         /* Adds in links to other mount points that might lie below or
          * above us in the hierarchy */


@@ -142,19 +176,14 @@ static int mount_add_mount_links(Mount *m) {
                 if (n->meta.load_state != UNIT_LOADED)
                         continue;
 
                 if (n->meta.load_state != UNIT_LOADED)
                         continue;
 

-                if (n->from_fragment)
-                        pn = &n->parameters_fragment;
-                else if (n->from_etc_fstab)
-                        pn = &n->parameters_etc_fstab;
-                else
-                        pn = NULL;
+                pn = get_mount_parameters_configured(n);

 
                 if (path_startswith(m->where, n->where)) {
 
                         if ((r = unit_add_dependency(UNIT(m), UNIT_AFTER, UNIT(n), true)) < 0)
                                 return r;
 
 
                 if (path_startswith(m->where, n->where)) {
 
                         if ((r = unit_add_dependency(UNIT(m), UNIT_AFTER, UNIT(n), true)) < 0)
                                 return r;
 

-                        if (n->from_etc_fstab || n->from_fragment)
+                        if (pn)

                                 if ((r = unit_add_dependency(UNIT(m), UNIT_REQUIRES, UNIT(n), true)) < 0)
                                         return r;
 
                                 if ((r = unit_add_dependency(UNIT(m), UNIT_REQUIRES, UNIT(n), true)) < 0)
                                         return r;
 


@@ -163,7 +192,7 @@ static int mount_add_mount_links(Mount *m) {
                         if ((r = unit_add_dependency(UNIT(n), UNIT_AFTER, UNIT(m), true)) < 0)
                                 return r;
 
                         if ((r = unit_add_dependency(UNIT(n), UNIT_AFTER, UNIT(m), true)) < 0)
                                 return r;
 

-                        if (m->from_etc_fstab || m->from_fragment)
+                        if (pm)

                                 if ((r = unit_add_dependency(UNIT(n), UNIT_REQUIRES, UNIT(m), true)) < 0)
                                         return r;
 
                                 if ((r = unit_add_dependency(UNIT(n), UNIT_REQUIRES, UNIT(m), true)) < 0)
                                         return r;
 


@@ -172,18 +201,16 @@ static int mount_add_mount_links(Mount *m) {
                         if ((r = unit_add_dependency(UNIT(m), UNIT_AFTER, UNIT(n), true)) < 0)
                                 return r;
 
                         if ((r = unit_add_dependency(UNIT(m), UNIT_AFTER, UNIT(n), true)) < 0)
                                 return r;
 

-                        if (m->from_etc_fstab || m->from_fragment)
-                                if ((r = unit_add_dependency(UNIT(m), UNIT_REQUIRES, UNIT(n), true)) < 0)
-                                        return r;
+                        if ((r = unit_add_dependency(UNIT(m), UNIT_REQUIRES, UNIT(n), true)) < 0)
+                                return r;

 
                 } else if (pn && path_startswith(pn->what, m->where)) {
 
                         if ((r = unit_add_dependency(UNIT(n), UNIT_AFTER, UNIT(m), true)) < 0)
                                 return r;
 
 
                 } else if (pn && path_startswith(pn->what, m->where)) {
 
                         if ((r = unit_add_dependency(UNIT(n), UNIT_AFTER, UNIT(m), true)) < 0)
                                 return r;
 

-                        if (n->from_etc_fstab || n->from_fragment)
-                                if ((r = unit_add_dependency(UNIT(n), UNIT_REQUIRES, UNIT(m), true)) < 0)
-                                        return r;
+                        if ((r = unit_add_dependency(UNIT(n), UNIT_REQUIRES, UNIT(m), true)) < 0)
+                                return r;

                 }
         }
 
                 }
         }
 


@@ -259,30 +286,66 @@ static char* mount_test_option(const char *haystack, const char *needle) {
         return hasmntopt(&me, needle);
 }
 
         return hasmntopt(&me, needle);
 }
 

+static bool mount_is_network(MountParameters *p) {
+        assert(p);
+
+        if (mount_test_option(p->options, "_netdev"))
+                return true;
+
+        if (p->fstype && fstype_is_network(p->fstype))
+                return true;
+
+        return false;
+}
+
+static bool mount_is_bind(MountParameters *p) {
+        assert(p);
+
+        if (mount_test_option(p->options, "bind"))
+                return true;
+
+        if (p->fstype && streq(p->fstype, "bind"))
+                return true;
+
+        return false;
+}
+
+static bool needs_quota(MountParameters *p) {
+        assert(p);
+
+        if (mount_is_network(p))
+                return false;
+
+        if (mount_is_bind(p))
+                return false;
+
+        return mount_test_option(p->options, "usrquota") ||
+                mount_test_option(p->options, "grpquota");
+}
+

 static int mount_add_target_links(Mount *m) {
         const char *target, *after = NULL;
         MountParameters *p;
         Unit *tu;
         int r;
 static int mount_add_target_links(Mount *m) {
         const char *target, *after = NULL;
         MountParameters *p;
         Unit *tu;
         int r;

-        bool noauto, handle, automount, user;
+        bool noauto, nofail, handle, automount;

 
         assert(m);
 
 
         assert(m);
 

-        if (m->from_fragment)
-                p = &m->parameters_fragment;
-        else if (m->from_etc_fstab)
-                p = &m->parameters_etc_fstab;
-        else
+        if (!(p = get_mount_parameters_configured(m)))

                 return 0;
 
         noauto = !!mount_test_option(p->options, MNTOPT_NOAUTO);
                 return 0;
 
         noauto = !!mount_test_option(p->options, MNTOPT_NOAUTO);

-        user = mount_test_option(p->options, "user") || mount_test_option(p->options, "users");
-        handle = !!mount_test_option(p->options, "comment=systemd.mount") ||
+        nofail = !!mount_test_option(p->options, "nofail");
+        handle =
+                mount_test_option(p->options, "comment=systemd.mount") ||
+                mount_test_option(p->options, "x-systemd-mount") ||

                 m->meta.manager->mount_auto;
                 m->meta.manager->mount_auto;

-        automount = !!mount_test_option(p->options, "comment=systemd.automount");
+        automount =
+                mount_test_option(p->options, "comment=systemd.automount") ||
+                mount_test_option(p->options, "x-systemd-automount");

 
 

-        if (mount_test_option(p->options, "_netdev") ||
-            fstype_is_network(p->fstype)) {
+        if (mount_is_network(p)) {

                 target = SPECIAL_REMOTE_FS_TARGET;
 
                 if (m->meta.manager->running_as == MANAGER_SYSTEM)
                 target = SPECIAL_REMOTE_FS_TARGET;
 
                 if (m->meta.manager->running_as == MANAGER_SYSTEM)


@@ -294,7 +357,7 @@ static int mount_add_target_links(Mount *m) {
                 return r;
 
         if (after)
                 return r;
 
         if (after)

-                if ((r = unit_add_dependency_by_name(tu, UNIT_AFTER, after, NULL, true)) < 0)
+                if ((r = unit_add_dependency_by_name(UNIT(m), UNIT_AFTER, after, NULL, true)) < 0)

                         return r;
 
         if (automount && m->meta.manager->running_as == MANAGER_SYSTEM) {
                         return r;
 
         if (automount && m->meta.manager->running_as == MANAGER_SYSTEM) {


@@ -309,53 +372,68 @@ static int mount_add_target_links(Mount *m) {
                 /* Automatically add mount points that aren't natively
                  * configured to local-fs.target */
                 if (!noauto &&
                 /* Automatically add mount points that aren't natively
                  * configured to local-fs.target */
                 if (!noauto &&

+                    !nofail &&

                     handle &&
                     handle &&

-                    !m->from_fragment)
-                        if (user || m->meta.manager->running_as == MANAGER_SYSTEM)
-                                if ((r = unit_add_dependency(tu, UNIT_WANTS, UNIT(m), true)) < 0)
-                                        return r;
+                    m->from_etc_fstab &&
+                    m->meta.manager->running_as == MANAGER_SYSTEM)
+                        if ((r = unit_add_dependency(tu, UNIT_WANTS, UNIT(m), true)) < 0)
+                                return r;

 
                 return unit_add_dependency(UNIT(m), UNIT_BEFORE, tu, true);
         }
 }
 
 
                 return unit_add_dependency(UNIT(m), UNIT_BEFORE, tu, true);
         }
 }
 

-static bool mount_is_bind(MountParameters *p) {
-        assert(p);
-
-        if (p->fstype && streq(p->fstype, "bind"))
-                return true;
-
-        if (mount_test_option(p->options, "bind"))
-                return true;
-
-        return false;
-}
-

 static int mount_add_device_links(Mount *m) {
         MountParameters *p;
 static int mount_add_device_links(Mount *m) {
         MountParameters *p;

-        bool nofail, noauto;
+        int r;

 
         assert(m);
 
 
         assert(m);
 

-        if (m->from_fragment)
-                p = &m->parameters_fragment;
-        else if (m->from_etc_fstab)
-                p = &m->parameters_etc_fstab;
-        else
+        if (!(p = get_mount_parameters_configured(m)))

                 return 0;
 
                 return 0;
 

-        if (!p->what || path_equal(m->where, "/"))
+        if (!p->what)

                 return 0;
 
                 return 0;
 

-        if (mount_is_bind(p))
-                return 0;
+        if (!mount_is_bind(p) && !path_equal(m->where, "/")) {
+                bool nofail, noauto;

 
 

-        noauto = !!mount_test_option(p->options, MNTOPT_NOAUTO);
-        nofail = !!mount_test_option(p->options, "nofail");
+                noauto = !!mount_test_option(p->options, MNTOPT_NOAUTO);
+                nofail = !!mount_test_option(p->options, "nofail");

 
 

-        return unit_add_node_link(UNIT(m), p->what,
-                                  !noauto && nofail &&
-                                  UNIT(m)->meta.manager->running_as == MANAGER_SYSTEM);
+                if ((r = unit_add_node_link(UNIT(m), p->what,
+                                            !noauto && nofail &&
+                                            UNIT(m)->meta.manager->running_as == MANAGER_SYSTEM)) < 0)
+                        return r;
+        }
+
+        if (p->passno > 0 &&
+            !mount_is_bind(p) &&
+            UNIT(m)->meta.manager->running_as == MANAGER_SYSTEM &&
+            !path_equal(m->where, "/")) {
+                char *name;
+                Unit *fsck;
+                /* Let's add in the fsck service */
+
+                /* aka SPECIAL_FSCK_SERVICE */
+                if (!(name = unit_name_from_path_instance("fsck", p->what, ".service")))
+                        return -ENOMEM;
+
+                if ((r = manager_load_unit_prepare(m->meta.manager, name, NULL, NULL, &fsck)) < 0) {
+                        log_warning("Failed to prepare unit %s: %s", name, strerror(-r));
+                        free(name);
+                        return r;
+                }
+
+                free(name);
+
+                SERVICE(fsck)->fsck_passno = p->passno;
+
+                if ((r = unit_add_two_dependencies(UNIT(m), UNIT_AFTER, UNIT_REQUIRES, fsck, true)) < 0)
+                        return r;
+        }
+
+        return 0;

 }
 
 static int mount_add_default_dependencies(Mount *m) {
 }
 
 static int mount_add_default_dependencies(Mount *m) {


@@ -365,11 +443,17 @@ static int mount_add_default_dependencies(Mount *m) {
 
         if (m->meta.manager->running_as == MANAGER_SYSTEM &&
             !path_equal(m->where, "/")) {
 
         if (m->meta.manager->running_as == MANAGER_SYSTEM &&
             !path_equal(m->where, "/")) {

+                MountParameters *p;

 
 

-                if ((r = unit_add_dependency_by_name(UNIT(m), UNIT_AFTER, SPECIAL_FSCK_TARGET, NULL, true)) < 0)
-                        return r;
+                p = get_mount_parameters_configured(m);

 
 

-                if ((r = unit_add_two_dependencies_by_name(UNIT(m), UNIT_BEFORE, UNIT_CONFLICTED_BY, SPECIAL_UMOUNT_TARGET, NULL, true)) < 0)
+                if (p && needs_quota(p)) {
+                        if ((r = unit_add_two_dependencies_by_name(UNIT(m), UNIT_BEFORE, UNIT_WANTS, SPECIAL_QUOTACHECK_SERVICE, NULL, true)) < 0 ||
+                            (r = unit_add_two_dependencies_by_name(UNIT(m), UNIT_BEFORE, UNIT_WANTS, SPECIAL_QUOTAON_SERVICE, NULL, true)) < 0)
+                                return r;
+                }
+
+                if ((r = unit_add_two_dependencies_by_name(UNIT(m), UNIT_BEFORE, UNIT_CONFLICTS, SPECIAL_UMOUNT_TARGET, NULL, true)) < 0)

                         return r;
         }
 
                         return r;
         }
 


@@ -398,6 +482,11 @@ static int mount_verify(Mount *m) {
                 return -EINVAL;
         }
 
                 return -EINVAL;
         }
 

+        if (mount_point_is_api(m->where) || mount_point_ignore(m->where)) {
+                log_error("Cannot create mount unit for API file system %s. Refusing.", m->where);
+                return -EINVAL;
+        }
+

         if (m->meta.fragment_path && !m->parameters_fragment.what) {
                 log_error("%s's What setting is missing. Refusing.", m->meta.id);
                 return -EBADMSG;
         if (m->meta.fragment_path && !m->parameters_fragment.what) {
                 log_error("%s's What setting is missing. Refusing.", m->meta.id);
                 return -EBADMSG;


@@ -423,7 +512,8 @@ static int mount_load(Unit *u) {
 
         /* This is a new unit? Then let's add in some extras */
         if (u->meta.load_state == UNIT_LOADED) {
 
         /* This is a new unit? Then let's add in some extras */
         if (u->meta.load_state == UNIT_LOADED) {

-                const char *what = NULL;
+                if ((r = unit_add_exec_dependencies(u, &m->exec_context)) < 0)
+                        return r;

 
                 if (m->meta.fragment_path)
                         m->from_fragment = true;
 
                 if (m->meta.fragment_path)
                         m->from_fragment = true;


@@ -438,13 +528,6 @@ static int mount_load(Unit *u) {
                         if ((r = unit_set_description(u, m->where)) < 0)
                                 return r;
 
                         if ((r = unit_set_description(u, m->where)) < 0)
                                 return r;
 

-                if (m->from_fragment && m->parameters_fragment.what)
-                        what = m->parameters_fragment.what;
-                else if (m->from_etc_fstab && m->parameters_etc_fstab.what)
-                        what = m->parameters_etc_fstab.what;
-                else if (m->from_proc_self_mountinfo && m->parameters_proc_self_mountinfo.what)
-                        what = m->parameters_proc_self_mountinfo.what;
-

                 if ((r = mount_add_device_links(m)) < 0)
                         return r;
 
                 if ((r = mount_add_device_links(m)) < 0)
                         return r;
 


@@ -466,7 +549,7 @@ static int mount_load(Unit *u) {
                 if ((r = mount_add_target_links(m)) < 0)
                         return r;
 
                 if ((r = mount_add_target_links(m)) < 0)
                         return r;
 

-                if ((r = unit_add_default_cgroup(u)) < 0)
+                if ((r = unit_add_default_cgroups(u)) < 0)

                         return r;
 
                 if (m->meta.default_dependencies)
                         return r;
 
                 if (m->meta.default_dependencies)


@@ -532,7 +615,8 @@ static void mount_set_state(Mount *m, MountState state) {
                           mount_state_to_string(old_state),
                           mount_state_to_string(state));
 
                           mount_state_to_string(old_state),
                           mount_state_to_string(state));
 

-        unit_notify(UNIT(m), state_translation_table[old_state], state_translation_table[state]);
+        unit_notify(UNIT(m), state_translation_table[old_state], state_translation_table[state], !m->reload_failure);
+        m->reload_failure = false;

 }
 
 static int mount_coldplug(Unit *u) {
 }
 
 static int mount_coldplug(Unit *u) {


@@ -584,12 +668,7 @@ static void mount_dump(Unit *u, FILE *f, const char *prefix) {
         assert(m);
         assert(f);
 
         assert(m);
         assert(f);
 

-        if (m->from_proc_self_mountinfo)
-                p = &m->parameters_proc_self_mountinfo;
-        else if (m->from_fragment)
-                p = &m->parameters_fragment;
-        else
-                p = &m->parameters_etc_fstab;
+        p = get_mount_parameters(m);

 
         fprintf(f,
                 "%sMount State: %s\n"
 
         fprintf(f,
                 "%sMount State: %s\n"


@@ -691,9 +770,7 @@ static void mount_enter_signal(Mount *m, MountState state, bool success) {
                            state == MOUNT_REMOUNTING_SIGTERM) ? m->exec_context.kill_signal : SIGKILL;
 
                 if (m->control_pid > 0) {
                            state == MOUNT_REMOUNTING_SIGTERM) ? m->exec_context.kill_signal : SIGKILL;
 
                 if (m->control_pid > 0) {

-                        if (kill(m->exec_context.kill_mode == KILL_PROCESS_GROUP ?
-                                 -m->control_pid :
-                                 m->control_pid, sig) < 0 && errno != ESRCH)
+                        if (kill_and_sigcont(m->control_pid, sig) < 0 && errno != ESRCH)

 
                                 log_warning("Failed to kill control process %li: %m", (long) m->control_pid);
                         else
 
                                 log_warning("Failed to kill control process %li: %m", (long) m->control_pid);
                         else


@@ -712,13 +789,14 @@ static void mount_enter_signal(Mount *m, MountState state, bool success) {
                                 if ((r = set_put(pid_set, LONG_TO_PTR(m->control_pid))) < 0)
                                         goto fail;
 
                                 if ((r = set_put(pid_set, LONG_TO_PTR(m->control_pid))) < 0)
                                         goto fail;
 

-                        if ((r = cgroup_bonding_kill_list(m->meta.cgroup_bondings, sig, pid_set)) < 0) {
+                        if ((r = cgroup_bonding_kill_list(m->meta.cgroup_bondings, sig, true, pid_set)) < 0) {

                                 if (r != -EAGAIN && r != -ESRCH && r != -ENOENT)
                                         log_warning("Failed to kill control group: %s", strerror(-r));
                         } else if (r > 0)
                                 wait_for_exit = true;
 
                         set_free(pid_set);
                                 if (r != -EAGAIN && r != -ESRCH && r != -ENOENT)
                                         log_warning("Failed to kill control group: %s", strerror(-r));
                         } else if (r > 0)
                                 wait_for_exit = true;
 
                         set_free(pid_set);

+                        pid_set = NULL;

                 }
         }
 
                 }
         }
 


@@ -780,6 +858,7 @@ fail:
 
 static void mount_enter_mounting(Mount *m) {
         int r;
 
 static void mount_enter_mounting(Mount *m) {
         int r;

+        MountParameters *p;

 
         assert(m);
 
 
         assert(m);
 


@@ -788,13 +867,18 @@ static void mount_enter_mounting(Mount *m) {
 
         mkdir_p(m->where, m->directory_mode);
 
 
         mkdir_p(m->where, m->directory_mode);
 

+        /* Create the source directory for bind-mounts if needed */
+        p = get_mount_parameters_configured(m);
+        if (p && mount_is_bind(p))
+                mkdir_p(p->what, m->directory_mode);
+

         if (m->from_fragment)
                 r = exec_command_set(
                                 m->control_command,
                                 "/bin/mount",
                                 m->parameters_fragment.what,
                                 m->where,
         if (m->from_fragment)
                 r = exec_command_set(
                                 m->control_command,
                                 "/bin/mount",
                                 m->parameters_fragment.what,
                                 m->where,

-                                "-t", m->parameters_fragment.fstype,
+                                "-t", m->parameters_fragment.fstype ? m->parameters_fragment.fstype : "auto",

                                 m->parameters_fragment.options ? "-o" : NULL, m->parameters_fragment.options,
                                 NULL);
         else if (m->from_etc_fstab)
                                 m->parameters_fragment.options ? "-o" : NULL, m->parameters_fragment.options,
                                 NULL);
         else if (m->from_etc_fstab)


@@ -859,7 +943,7 @@ static void mount_enter_remounting(Mount *m, bool success) {
                                 "/bin/mount",
                                 m->parameters_fragment.what,
                                 m->where,
                                 "/bin/mount",
                                 m->parameters_fragment.what,
                                 m->where,

-                                "-t", m->parameters_fragment.fstype,
+                                "-t", m->parameters_fragment.fstype ? m->parameters_fragment.fstype : "auto",

                                 "-o", o,
                                 NULL);
 
                                 "-o", o,
                                 NULL);
 


@@ -874,10 +958,8 @@ static void mount_enter_remounting(Mount *m, bool success) {
         else
                 r = -ENOENT;
 
         else
                 r = -ENOENT;
 

-        if (r < 0) {
-                r = -ENOMEM;
+        if (r < 0)

                 goto fail;
                 goto fail;

-        }

 
         mount_unwatch_control_pid(m);
 
 
         mount_unwatch_control_pid(m);
 


@@ -890,7 +972,8 @@ static void mount_enter_remounting(Mount *m, bool success) {
 
 fail:
         log_warning("%s failed to run 'remount' task: %s", m->meta.id, strerror(-r));
 
 fail:
         log_warning("%s failed to run 'remount' task: %s", m->meta.id, strerror(-r));

-        mount_enter_mounted(m, false);
+        m->reload_failure = true;
+        mount_enter_mounted(m, true);

 }
 
 static int mount_start(Unit *u) {
 }
 
 static int mount_start(Unit *u) {


@@ -902,13 +985,13 @@ static int mount_start(Unit *u) {
          * please! */
         if (m->state == MOUNT_UNMOUNTING ||
             m->state == MOUNT_UNMOUNTING_SIGTERM ||
          * please! */
         if (m->state == MOUNT_UNMOUNTING ||
             m->state == MOUNT_UNMOUNTING_SIGTERM ||

-            m->state == MOUNT_UNMOUNTING_SIGKILL)
+            m->state == MOUNT_UNMOUNTING_SIGKILL ||
+            m->state == MOUNT_MOUNTING_SIGTERM ||
+            m->state == MOUNT_MOUNTING_SIGKILL)

                 return -EAGAIN;
 
         /* Already on it! */
                 return -EAGAIN;
 
         /* Already on it! */

-        if (m->state == MOUNT_MOUNTING ||
-            m->state == MOUNT_MOUNTING_SIGTERM ||
-            m->state == MOUNT_MOUNTING_SIGKILL)
+        if (m->state == MOUNT_MOUNTING)

                 return 0;
 
         assert(m->state == MOUNT_DEAD || m->state == MOUNT_FAILED);
                 return 0;
 
         assert(m->state == MOUNT_DEAD || m->state == MOUNT_FAILED);


@@ -926,14 +1009,14 @@ static int mount_stop(Unit *u) {
         /* Already on it */
         if (m->state == MOUNT_UNMOUNTING ||
             m->state == MOUNT_UNMOUNTING_SIGKILL ||
         /* Already on it */
         if (m->state == MOUNT_UNMOUNTING ||
             m->state == MOUNT_UNMOUNTING_SIGKILL ||

-            m->state == MOUNT_UNMOUNTING_SIGTERM)
+            m->state == MOUNT_UNMOUNTING_SIGTERM ||
+            m->state == MOUNT_MOUNTING_SIGTERM ||
+            m->state == MOUNT_MOUNTING_SIGKILL)

                 return 0;
 
         assert(m->state == MOUNT_MOUNTING ||
                m->state == MOUNT_MOUNTING_DONE ||
                m->state == MOUNT_MOUNTED ||
                 return 0;
 
         assert(m->state == MOUNT_MOUNTING ||
                m->state == MOUNT_MOUNTING_DONE ||
                m->state == MOUNT_MOUNTED ||

-               m->state == MOUNT_MOUNTING_SIGTERM ||
-               m->state == MOUNT_MOUNTING_SIGKILL ||

                m->state == MOUNT_REMOUNTING ||
                m->state == MOUNT_REMOUNTING_SIGTERM ||
                m->state == MOUNT_REMOUNTING_SIGKILL);
                m->state == MOUNT_REMOUNTING ||
                m->state == MOUNT_REMOUNTING_SIGTERM ||
                m->state == MOUNT_REMOUNTING_SIGKILL);


@@ -1057,7 +1140,7 @@ static void mount_sigchld_event(Unit *u, pid_t pid, int code, int status) {
         m->failure = m->failure || !success;
 
         if (m->control_command) {
         m->failure = m->failure || !success;
 
         if (m->control_command) {

-                exec_status_exit(&m->control_command->exec_status, pid, code, status);
+                exec_status_exit(&m->control_command->exec_status, pid, code, status, m->exec_context.utmp_id);

                 m->control_command = NULL;
                 m->control_command_id = _MOUNT_EXEC_COMMAND_INVALID;
         }
                 m->control_command = NULL;
                 m->control_command_id = _MOUNT_EXEC_COMMAND_INVALID;
         }


@@ -1078,9 +1161,6 @@ static void mount_sigchld_event(Unit *u, pid_t pid, int code, int status) {
         case MOUNT_MOUNTING_DONE:
         case MOUNT_MOUNTING_SIGKILL:
         case MOUNT_MOUNTING_SIGTERM:
         case MOUNT_MOUNTING_DONE:
         case MOUNT_MOUNTING_SIGKILL:
         case MOUNT_MOUNTING_SIGTERM:

-        case MOUNT_REMOUNTING:
-        case MOUNT_REMOUNTING_SIGKILL:
-        case MOUNT_REMOUNTING_SIGTERM:

 
                 if (success)
                         mount_enter_mounted(m, true);
 
                 if (success)
                         mount_enter_mounted(m, true);


@@ -1090,6 +1170,18 @@ static void mount_sigchld_event(Unit *u, pid_t pid, int code, int status) {
                         mount_enter_dead(m, false);
                 break;
 
                         mount_enter_dead(m, false);
                 break;
 

+        case MOUNT_REMOUNTING:
+        case MOUNT_REMOUNTING_SIGKILL:
+        case MOUNT_REMOUNTING_SIGTERM:
+
+                m->reload_failure = !success;
+                if (m->from_proc_self_mountinfo)
+                        mount_enter_mounted(m, true);
+                else
+                        mount_enter_dead(m, true);
+
+                break;
+

         case MOUNT_UNMOUNTING:
         case MOUNT_UNMOUNTING_SIGKILL:
         case MOUNT_UNMOUNTING_SIGTERM:
         case MOUNT_UNMOUNTING:
         case MOUNT_UNMOUNTING_SIGKILL:
         case MOUNT_UNMOUNTING_SIGTERM:


@@ -1127,7 +1219,8 @@ static void mount_timer_event(Unit *u, uint64_t elapsed, Watch *w) {
 
         case MOUNT_REMOUNTING:
                 log_warning("%s remounting timed out. Stopping.", u->meta.id);
 
         case MOUNT_REMOUNTING:
                 log_warning("%s remounting timed out. Stopping.", u->meta.id);

-                mount_enter_signal(m, MOUNT_REMOUNTING_SIGTERM, false);
+                m->reload_failure = true;
+                mount_enter_mounted(m, true);

                 break;
 
         case MOUNT_UNMOUNTING:
                 break;
 
         case MOUNT_UNMOUNTING:


@@ -1136,18 +1229,45 @@ static void mount_timer_event(Unit *u, uint64_t elapsed, Watch *w) {
                 break;
 
         case MOUNT_MOUNTING_SIGTERM:
                 break;
 
         case MOUNT_MOUNTING_SIGTERM:

-                log_warning("%s mounting timed out. Killing.", u->meta.id);
-                mount_enter_signal(m, MOUNT_MOUNTING_SIGKILL, false);
+                if (m->exec_context.send_sigkill) {
+                        log_warning("%s mounting timed out. Killing.", u->meta.id);
+                        mount_enter_signal(m, MOUNT_MOUNTING_SIGKILL, false);
+                } else {
+                        log_warning("%s mounting timed out. Skipping SIGKILL. Ignoring.", u->meta.id);
+
+                        if (m->from_proc_self_mountinfo)
+                                mount_enter_mounted(m, false);
+                        else
+                                mount_enter_dead(m, false);
+                }

                 break;
 
         case MOUNT_REMOUNTING_SIGTERM:
                 break;
 
         case MOUNT_REMOUNTING_SIGTERM:

-                log_warning("%s remounting timed out. Killing.", u->meta.id);
-                mount_enter_signal(m, MOUNT_REMOUNTING_SIGKILL, false);
+                if (m->exec_context.send_sigkill) {
+                        log_warning("%s remounting timed out. Killing.", u->meta.id);
+                        mount_enter_signal(m, MOUNT_REMOUNTING_SIGKILL, false);
+                } else {
+                        log_warning("%s remounting timed out. Skipping SIGKILL. Ignoring.", u->meta.id);
+
+                        if (m->from_proc_self_mountinfo)
+                                mount_enter_mounted(m, false);
+                        else
+                                mount_enter_dead(m, false);
+                }

                 break;
 
         case MOUNT_UNMOUNTING_SIGTERM:
                 break;
 
         case MOUNT_UNMOUNTING_SIGTERM:

-                log_warning("%s unmounting timed out. Killing.", u->meta.id);
-                mount_enter_signal(m, MOUNT_UNMOUNTING_SIGKILL, false);
+                if (m->exec_context.send_sigkill) {
+                        log_warning("%s unmounting timed out. Killing.", u->meta.id);
+                        mount_enter_signal(m, MOUNT_UNMOUNTING_SIGKILL, false);
+                } else {
+                        log_warning("%s unmounting timed out. Skipping SIGKILL. Ignoring.", u->meta.id);
+
+                        if (m->from_proc_self_mountinfo)
+                                mount_enter_mounted(m, false);
+                        else
+                                mount_enter_dead(m, false);
+                }

                 break;
 
         case MOUNT_MOUNTING_SIGKILL:
                 break;
 
         case MOUNT_MOUNTING_SIGKILL:


@@ -1172,6 +1292,7 @@ static int mount_add_one(
                 const char *where,
                 const char *options,
                 const char *fstype,
                 const char *where,
                 const char *options,
                 const char *fstype,

+                int passno,

                 bool from_proc_self_mountinfo,
                 bool set_flags) {
         int r;
                 bool from_proc_self_mountinfo,
                 bool set_flags) {
         int r;


@@ -1190,7 +1311,7 @@ static int mount_add_one(
 
         /* Ignore API mount points. They should never be referenced in
          * dependencies ever. */
 
         /* Ignore API mount points. They should never be referenced in
          * dependencies ever. */

-        if (mount_point_is_api(where))
+        if (mount_point_is_api(where) || mount_point_ignore(where))

                 return 0;
 
         if (streq(fstype, "autofs"))
                 return 0;
 
         if (streq(fstype, "autofs"))


@@ -1259,6 +1380,8 @@ static int mount_add_one(
         free(p->fstype);
         p->fstype = f;
 
         free(p->fstype);
         p->fstype = f;
 

+        p->passno = passno;
+

         unit_add_to_dbus_queue(u);
 
         return 0;
         unit_add_to_dbus_queue(u);
 
         return 0;


@@ -1274,56 +1397,6 @@ fail:
         return r;
 }
 
         return r;
 }
 

-static char *fstab_node_to_udev_node(char *p) {
-        char *dn, *t, *u;
-        int r;
-
-        /* FIXME: to follow udev's logic 100% we need to leave valid
-         * UTF8 chars unescaped */
-
-        if (startswith(p, "LABEL=")) {
-
-                if (!(u = unquote(p+6, "\"\'")))
-                        return NULL;
-
-                t = xescape(u, "/ ");
-                free(u);
-
-                if (!t)
-                        return NULL;
-
-                r = asprintf(&dn, "/dev/disk/by-label/%s", t);
-                free(t);
-
-                if (r < 0)
-                        return NULL;
-
-                return dn;
-        }
-
-        if (startswith(p, "UUID=")) {
-
-                if (!(u = unquote(p+5, "\"\'")))
-                        return NULL;
-
-                t = xescape(u, "/ ");
-                free(u);
-
-                if (!t)
-                        return NULL;
-
-                r = asprintf(&dn, "/dev/disk/by-uuid/%s", ascii_strlower(t));
-                free(t);
-
-                if (r < 0)
-                        return NULL;
-
-                return dn;
-        }
-
-        return strdup(p);
-}
-

 static int mount_find_pri(char *options) {
         char *end, *pri;
         unsigned long r;
 static int mount_find_pri(char *options) {
         char *end, *pri;
         unsigned long r;


@@ -1347,7 +1420,7 @@ static int mount_find_pri(char *options) {
 
 static int mount_load_etc_fstab(Manager *m) {
         FILE *f;
 
 static int mount_load_etc_fstab(Manager *m) {
         FILE *f;

-        int r;
+        int r = 0;

         struct mntent* me;
 
         assert(m);
         struct mntent* me;
 
         assert(m);


@@ -1358,6 +1431,7 @@ static int mount_load_etc_fstab(Manager *m) {
 
         while ((me = getmntent(f))) {
                 char *where, *what;
 
         while ((me = getmntent(f))) {
                 char *where, *what;

+                int k;

 
                 if (!(what = fstab_node_to_udev_node(me->mnt_fsname))) {
                         r = -ENOMEM;
 
                 if (!(what = fstab_node_to_udev_node(me->mnt_fsname))) {
                         r = -ENOMEM;


@@ -1380,26 +1454,26 @@ static int mount_load_etc_fstab(Manager *m) {
                         int pri;
 
                         if ((pri = mount_find_pri(me->mnt_opts)) < 0)
                         int pri;
 
                         if ((pri = mount_find_pri(me->mnt_opts)) < 0)

-                                r = pri;
+                                k = pri;

                         else
                         else

-                                r = swap_add_one(m,
+                                k = swap_add_one(m,

                                                  what,
                                                  what,

+                                                 NULL,

                                                  pri,
                                                  !!mount_test_option(me->mnt_opts, MNTOPT_NOAUTO),
                                                  !!mount_test_option(me->mnt_opts, "nofail"),
                                                  !!mount_test_option(me->mnt_opts, "comment=systemd.swapon"),
                                                  false);
                 } else
                                                  pri,
                                                  !!mount_test_option(me->mnt_opts, MNTOPT_NOAUTO),
                                                  !!mount_test_option(me->mnt_opts, "nofail"),
                                                  !!mount_test_option(me->mnt_opts, "comment=systemd.swapon"),
                                                  false);
                 } else

-                        r = mount_add_one(m, what, where, me->mnt_opts, me->mnt_type, false, false);
+                        k = mount_add_one(m, what, where, me->mnt_opts, me->mnt_type, me->mnt_passno, false, false);

 
                 free(what);
                 free(where);
 
                 if (r < 0)
 
                 free(what);
                 free(where);
 
                 if (r < 0)

-                        goto finish;
+                        r = k;

         }
 
         }
 

-        r = 0;

 finish:
 
         endmntent(f);
 finish:
 
         endmntent(f);


@@ -1407,7 +1481,7 @@ finish:
 }
 
 static int mount_load_proc_self_mountinfo(Manager *m, bool set_flags) {
 }
 
 static int mount_load_proc_self_mountinfo(Manager *m, bool set_flags) {

-        int r;
+        int r = 0;

         unsigned i;
         char *device, *path, *options, *options2, *fstype, *d, *p, *o;
 
         unsigned i;
         char *device, *path, *options, *options2, *fstype, *d, *p, *o;
 


@@ -1457,8 +1531,8 @@ static int mount_load_proc_self_mountinfo(Manager *m, bool set_flags) {
                         goto finish;
                 }
 
                         goto finish;
                 }
 

-                if ((r = mount_add_one(m, d, p, o, fstype, true, set_flags)) < 0)
-                        goto finish;
+                if ((k = mount_add_one(m, d, p, o, fstype, 0, true, set_flags)) < 0)
+                        r = k;

 
 clean_up:
                 free(device);
 
 clean_up:
                 free(device);


@@ -1471,8 +1545,6 @@ clean_up:
                 free(o);
         }
 
                 free(o);
         }
 

-        r = 0;
-

 finish:
         free(device);
         free(path);
 finish:
         free(device);
         free(path);


@@ -1508,7 +1580,7 @@ static int mount_enumerate(Manager *m) {
                 m->mount_watch.fd = fileno(m->proc_self_mountinfo);
 
                 zero(ev);
                 m->mount_watch.fd = fileno(m->proc_self_mountinfo);
 
                 zero(ev);

-                ev.events = EPOLLERR;
+                ev.events = EPOLLPRI;

                 ev.data.ptr = &m->mount_watch;
 
                 if (epoll_ctl(m->epoll_fd, EPOLL_CTL_ADD, m->mount_watch.fd, &ev) < 0)
                 ev.data.ptr = &m->mount_watch;
 
                 if (epoll_ctl(m->epoll_fd, EPOLL_CTL_ADD, m->mount_watch.fd, &ev) < 0)


@@ -1533,7 +1605,7 @@ void mount_fd_event(Manager *m, int events) {
         int r;
 
         assert(m);
         int r;
 
         assert(m);

-        assert(events == EPOLLERR);
+        assert(events & EPOLLPRI);

 
         /* The manager calls this for every fd event happening on the
          * /proc/self/mountinfo file, which informs us about mounting
 
         /* The manager calls this for every fd event happening on the
          * /proc/self/mountinfo file, which informs us about mounting


@@ -1576,7 +1648,7 @@ void mount_fd_event(Manager *m, int events) {
 
                 } else if (mount->just_mounted || mount->just_changed) {
 
 
                 } else if (mount->just_mounted || mount->just_changed) {
 

-                        /* New or changed entrymount */
+                        /* New or changed mount entry */

 
                         switch (mount->state) {
 
 
                         switch (mount->state) {
 


@@ -1616,6 +1688,52 @@ static void mount_reset_failed(Unit *u) {
         m->failure = false;
 }
 
         m->failure = false;
 }
 

+static int mount_kill(Unit *u, KillWho who, KillMode mode, int signo, DBusError *error) {
+        Mount *m = MOUNT(u);
+        int r = 0;
+        Set *pid_set = NULL;
+
+        assert(m);
+
+        if (who == KILL_MAIN) {
+                dbus_set_error(error, BUS_ERROR_NO_SUCH_PROCESS, "Mount units have no main processes");
+                return -EINVAL;
+        }
+
+        if (m->control_pid <= 0 && who == KILL_CONTROL) {
+                dbus_set_error(error, BUS_ERROR_NO_SUCH_PROCESS, "No control process to kill");
+                return -ENOENT;
+        }
+
+        if (m->control_pid > 0)
+                if (kill(m->control_pid, signo) < 0)
+                        r = -errno;
+
+        if (mode == KILL_CONTROL_GROUP) {
+                int q;
+
+                if (!(pid_set = set_new(trivial_hash_func, trivial_compare_func)))
+                        return -ENOMEM;
+
+                /* Exclude the control pid from being killed via the cgroup */
+                if (m->control_pid > 0)
+                        if ((q = set_put(pid_set, LONG_TO_PTR(m->control_pid))) < 0) {
+                                r = q;
+                                goto finish;
+                        }
+
+                if ((q = cgroup_bonding_kill_list(m->meta.cgroup_bondings, signo, false, pid_set)) < 0)
+                        if (r != -EAGAIN && r != -ESRCH && r != -ENOENT)
+                                r = q;
+        }
+
+finish:
+        if (pid_set)
+                set_free(pid_set);
+
+        return r;
+}
+

 static const char* const mount_state_table[_MOUNT_STATE_MAX] = {
         [MOUNT_DEAD] = "dead",
         [MOUNT_MOUNTING] = "mounting",
 static const char* const mount_state_table[_MOUNT_STATE_MAX] = {
         [MOUNT_DEAD] = "dead",
         [MOUNT_MOUNTING] = "mounting",


@@ -1647,7 +1765,6 @@ const UnitVTable mount_vtable = {
 
         .no_alias = true,
         .no_instances = true,
 
         .no_alias = true,
         .no_instances = true,

-        .no_isolate = true,

         .show_status = true,
 
         .init = mount_init,
         .show_status = true,
 
         .init = mount_init,


@@ -1662,6 +1779,8 @@ const UnitVTable mount_vtable = {
         .stop = mount_stop,
         .reload = mount_reload,
 
         .stop = mount_stop,
         .reload = mount_reload,
 

+        .kill = mount_kill,
+

         .serialize = mount_serialize,
         .deserialize_item = mount_deserialize_item,
 
         .serialize = mount_serialize,
         .deserialize_item = mount_deserialize_item,