Prep v225: Applying various fixes and changes to src/login that got lost during git...

[elogind.git] / src / login / logind-session.c

diff --git a/src/login/logind-session.c b/src/login/logind-session.c
index 4f3259ca7cd6f3edf7cfa69ab08f1cef4fd59e0d..92a6027a7ef4a085f21ca90c5a60f13823b2d68a 100644 (file)
--- a/src/login/logind-session.c
+++ b/src/login/logind-session.c
@@ -28,9 +28,7 @@
 #include <sys/ioctl.h>
 #include <unistd.h>
 
 #include <sys/ioctl.h>
 #include <unistd.h>
 

-#include "sd-id128.h"

 #include "sd-messages.h"
 #include "sd-messages.h"

-#include "strv.h"

 #include "util.h"
 #include "mkdir.h"
 #include "path-util.h"
 #include "util.h"
 #include "mkdir.h"
 #include "path-util.h"


@@ -39,21 +37,12 @@
 #include "bus-util.h"
 #include "bus-error.h"
 #include "logind-session.h"
 #include "bus-util.h"
 #include "bus-error.h"
 #include "logind-session.h"

+#include "formats-util.h"
+#include "terminal-util.h"

 
 

-static unsigned long devt_hash_func(const void *p, const uint8_t hash_key[HASH_KEY_SIZE]) {
-        uint64_t u = *(const dev_t*)p;
+#define RELEASE_USEC (20*USEC_PER_SEC)

 
 

-        return uint64_hash_func(&u, hash_key);
-}
-
-static int devt_compare_func(const void *_a, const void *_b) {
-        dev_t a, b;
-
-        a = *(const dev_t*) _a;
-        b = *(const dev_t*) _b;
-
-        return a < b ? -1 : (a > b ? 1 : 0);
-}
+static void session_remove_fifo(Session *s);

 
 Session* session_new(Manager *m, const char *id) {
         Session *s;
 
 Session* session_new(Manager *m, const char *id) {
         Session *s;


@@ -72,7 +61,7 @@ Session* session_new(Manager *m, const char *id) {
                 return NULL;
         }
 
                 return NULL;
         }
 

-        s->devices = hashmap_new(devt_hash_func, devt_compare_func);
+        s->devices = hashmap_new(&devt_hash_ops);

         if (!s->devices) {
                 free(s->state_file);
                 free(s);
         if (!s->devices) {
                 free(s->state_file);
                 free(s);


@@ -103,6 +92,8 @@ void session_free(Session *s) {
         if (s->in_gc_queue)
                 LIST_REMOVE(gc_queue, s->manager->session_gc_queue, s);
 
         if (s->in_gc_queue)
                 LIST_REMOVE(gc_queue, s->manager->session_gc_queue, s);
 

+        s->timer_event_source = sd_event_source_unref(s->timer_event_source);
+

         session_remove_fifo(s);
 
         session_drop_controller(s);
         session_remove_fifo(s);
 
         session_drop_controller(s);


@@ -143,6 +134,7 @@ void session_free(Session *s) {
         free(s->remote_host);
         free(s->remote_user);
         free(s->service);
         free(s->remote_host);
         free(s->remote_user);
         free(s->service);

+        free(s->desktop);

 
         hashmap_remove(s->manager->sessions, s->id);
 
 
         hashmap_remove(s->manager->sessions, s->id);
 


@@ -173,11 +165,11 @@ int session_save(Session *s) {
 
         r = mkdir_safe_label("/run/systemd/sessions", 0755, 0, 0);
         if (r < 0)
 
         r = mkdir_safe_label("/run/systemd/sessions", 0755, 0, 0);
         if (r < 0)

-                goto finish;
+                goto fail;

 
         r = fopen_temporary(s->state_file, &f, &temp_path);
         if (r < 0)
 
         r = fopen_temporary(s->state_file, &f, &temp_path);
         if (r < 0)

-                goto finish;
+                goto fail;

 
         assert(s->user);
 
 
         assert(s->user);
 


@@ -185,12 +177,12 @@ int session_save(Session *s) {
 
         fprintf(f,
                 "# This is private data. Do not parse.\n"
 
         fprintf(f,
                 "# This is private data. Do not parse.\n"

-                "UID=%lu\n"
+                "UID="UID_FMT"\n"

                 "USER=%s\n"
                 "ACTIVE=%i\n"
                 "STATE=%s\n"
                 "REMOTE=%i\n",
                 "USER=%s\n"
                 "ACTIVE=%i\n"
                 "STATE=%s\n"
                 "REMOTE=%i\n",

-                (unsigned long) s->user->uid,
+                s->user->uid,

                 s->user->name,
                 session_is_active(s),
                 session_state_to_string(session_get_state(s)),
                 s->user->name,
                 session_is_active(s),
                 session_state_to_string(session_get_state(s)),


@@ -204,7 +196,6 @@ int session_save(Session *s) {
 
         if (s->scope)
                 fprintf(f, "SCOPE=%s\n", s->scope);
 
         if (s->scope)
                 fprintf(f, "SCOPE=%s\n", s->scope);

-

         if (s->scope_job)
                 fprintf(f, "SCOPE_JOB=%s\n", s->scope_job);
 
         if (s->scope_job)
                 fprintf(f, "SCOPE_JOB=%s\n", s->scope_job);
 


@@ -220,57 +211,104 @@ int session_save(Session *s) {
         if (s->display)
                 fprintf(f, "DISPLAY=%s\n", s->display);
 
         if (s->display)
                 fprintf(f, "DISPLAY=%s\n", s->display);
 

-        if (s->remote_host)
-                fprintf(f, "REMOTE_HOST=%s\n", s->remote_host);
+        if (s->remote_host) {
+                _cleanup_free_ char *escaped;
+
+                escaped = cescape(s->remote_host);
+                if (!escaped) {
+                        r = -ENOMEM;
+                        goto fail;
+                }
+
+                fprintf(f, "REMOTE_HOST=%s\n", escaped);
+        }
+
+        if (s->remote_user) {
+                _cleanup_free_ char *escaped;
+
+                escaped = cescape(s->remote_user);
+                if (!escaped) {
+                        r = -ENOMEM;
+                        goto fail;
+                }
+
+                fprintf(f, "REMOTE_USER=%s\n", escaped);
+        }
+
+        if (s->service) {
+                _cleanup_free_ char *escaped;
+
+                escaped = cescape(s->service);
+                if (!escaped) {
+                        r = -ENOMEM;
+                        goto fail;
+                }
+
+                fprintf(f, "SERVICE=%s\n", escaped);
+        }
+
+        if (s->desktop) {
+                _cleanup_free_ char *escaped;
+

 
 

-        if (s->remote_user)
-                fprintf(f, "REMOTE_USER=%s\n", s->remote_user);
+                escaped = cescape(s->desktop);
+                if (!escaped) {
+                        r = -ENOMEM;
+                        goto fail;
+                }

 
 

-        if (s->service)
-                fprintf(f, "SERVICE=%s\n", s->service);
+                fprintf(f, "DESKTOP=%s\n", escaped);
+        }

 
         if (s->seat && seat_has_vts(s->seat))
                 fprintf(f, "VTNR=%u\n", s->vtnr);
 
         if (!s->vtnr)
 
         if (s->seat && seat_has_vts(s->seat))
                 fprintf(f, "VTNR=%u\n", s->vtnr);
 
         if (!s->vtnr)

-                fprintf(f, "POS=%u\n", s->pos);
+                fprintf(f, "POSITION=%u\n", s->position);

 
         if (s->leader > 0)
 
         if (s->leader > 0)

-                fprintf(f, "LEADER=%lu\n", (unsigned long) s->leader);
+                fprintf(f, "LEADER="PID_FMT"\n", s->leader);

 
         if (s->audit_id > 0)
                 fprintf(f, "AUDIT=%"PRIu32"\n", s->audit_id);
 
         if (dual_timestamp_is_set(&s->timestamp))
                 fprintf(f,
 
         if (s->audit_id > 0)
                 fprintf(f, "AUDIT=%"PRIu32"\n", s->audit_id);
 
         if (dual_timestamp_is_set(&s->timestamp))
                 fprintf(f,

-                        "REALTIME=%llu\n"
-                        "MONOTONIC=%llu\n",
-                        (unsigned long long) s->timestamp.realtime,
-                        (unsigned long long) s->timestamp.monotonic);
+                        "REALTIME="USEC_FMT"\n"
+                        "MONOTONIC="USEC_FMT"\n",
+                        s->timestamp.realtime,
+                        s->timestamp.monotonic);

 
         if (s->controller)
                 fprintf(f, "CONTROLLER=%s\n", s->controller);
 
 
         if (s->controller)
                 fprintf(f, "CONTROLLER=%s\n", s->controller);
 

-        fflush(f);
+        r = fflush_and_check(f);
+        if (r < 0)
+                goto fail;

 
 

-        if (ferror(f) || rename(temp_path, s->state_file) < 0) {
+        if (rename(temp_path, s->state_file) < 0) {

                 r = -errno;
                 r = -errno;

-                unlink(s->state_file);
-                unlink(temp_path);
+                goto fail;

         }
 
         }
 

-finish:
-        if (r < 0)
-                log_error("Failed to save session data for %s: %s", s->id, strerror(-r));
+        return 0;

 
 

-        return r;
+fail:
+        (void) unlink(s->state_file);
+
+        if (temp_path)
+                (void) unlink(temp_path);
+
+        return log_error_errno(r, "Failed to save session data %s: %m", s->state_file);

 }
 
 }
 

+

 int session_load(Session *s) {
         _cleanup_free_ char *remote = NULL,
                 *seat = NULL,
                 *vtnr = NULL,
 int session_load(Session *s) {
         _cleanup_free_ char *remote = NULL,
                 *seat = NULL,
                 *vtnr = NULL,

-                *pos = NULL,
+                *state = NULL,
+                *position = NULL,

                 *leader = NULL,
                 *type = NULL,
                 *class = NULL,
                 *leader = NULL,
                 *type = NULL,
                 *class = NULL,


@@ -294,8 +332,10 @@ int session_load(Session *s) {
                            "REMOTE_HOST",    &s->remote_host,
                            "REMOTE_USER",    &s->remote_user,
                            "SERVICE",        &s->service,
                            "REMOTE_HOST",    &s->remote_host,
                            "REMOTE_USER",    &s->remote_user,
                            "SERVICE",        &s->service,

+                           "DESKTOP",        &s->desktop,

                            "VTNR",           &vtnr,
                            "VTNR",           &vtnr,

-                           "POS",            &pos,
+                           "STATE",          &state,
+                           "POSITION",       &position,

                            "LEADER",         &leader,
                            "TYPE",           &type,
                            "CLASS",          &class,
                            "LEADER",         &leader,
                            "TYPE",           &type,
                            "CLASS",          &class,


@@ -305,10 +345,8 @@ int session_load(Session *s) {
                            "CONTROLLER",     &controller,
                            NULL);
 
                            "CONTROLLER",     &controller,
                            NULL);
 

-        if (r < 0) {
-                log_error("Failed to read %s: %s", s->state_file, strerror(-r));
-                return r;
-        }
+        if (r < 0)
+                return log_error_errno(r, "Failed to read %s: %m", s->state_file);

 
         if (!s->user) {
                 uid_t u;
 
         if (!s->user) {
                 uid_t u;


@@ -325,7 +363,7 @@ int session_load(Session *s) {
                         return r;
                 }
 
                         return r;
                 }
 

-                user = hashmap_get(s->manager->users, ULONG_TO_PTR((unsigned long) u));
+                user = hashmap_get(s->manager->users, UID_TO_PTR(u));

                 if (!user) {
                         log_error("User of session %s not known.", s->id);
                         return -ENOENT;
                 if (!user) {
                         log_error("User of session %s not known.", s->id);
                         return -ENOENT;


@@ -356,10 +394,10 @@ int session_load(Session *s) {
         if (!s->seat || !seat_has_vts(s->seat))
                 s->vtnr = 0;
 
         if (!s->seat || !seat_has_vts(s->seat))
                 s->vtnr = 0;
 

-        if (pos && s->seat) {
+        if (position && s->seat) {

                 unsigned int npos;
 
                 unsigned int npos;
 

-                safe_atou(pos, &npos);
+                safe_atou(position, &npos);

                 seat_claim_position(s->seat, s, npos);
         }
 
                 seat_claim_position(s->seat, s, npos);
         }
 


@@ -385,17 +423,21 @@ int session_load(Session *s) {
                         s->class = c;
         }
 
                         s->class = c;
         }
 

+        if (state && streq(state, "closing"))
+                s->stopping = true;
+

         if (s->fifo_path) {
                 int fd;
 
                 /* If we open an unopened pipe for reading we will not
                    get an EOF. to trigger an EOF we hence open it for
         if (s->fifo_path) {
                 int fd;
 
                 /* If we open an unopened pipe for reading we will not
                    get an EOF. to trigger an EOF we hence open it for

-                   reading, but close it right-away which then will
-                   trigger the EOF. */
+                   writing, but close it right away which then will
+                   trigger the EOF. This will happen immediately if no
+                   other process has the FIFO open for writing, i. e.
+                   when the session died before logind (re)started. */

 
                 fd = session_create_fifo(s);
 
                 fd = session_create_fifo(s);

-                if (fd >= 0)
-                        close_nointr_nofail(fd);
+                safe_close(fd);

         }
 
         if (realtime) {
         }
 
         if (realtime) {


@@ -427,7 +469,7 @@ int session_activate(Session *s) {
         assert(s->user);
 
         if (!s->seat)
         assert(s->user);
 
         if (!s->seat)

-                return -ENOTSUP;
+                return -EOPNOTSUPP;

 
         if (s->seat->active == s)
                 return 0;
 
         if (s->seat->active == s)
                 return 0;


@@ -435,7 +477,7 @@ int session_activate(Session *s) {
         /* on seats with VTs, we let VTs manage session-switching */
         if (seat_has_vts(s->seat)) {
                 if (!s->vtnr)
         /* on seats with VTs, we let VTs manage session-switching */
         if (seat_has_vts(s->seat)) {
                 if (!s->vtnr)

-                        return -ENOTSUP;
+                        return -EOPNOTSUPP;

 
                 return chvt(s->vtnr);
         }
 
                 return chvt(s->vtnr);
         }


@@ -467,8 +509,7 @@ static int session_start_scope(Session *s) {
         if (!s->scope) {
                 _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL;
                 _cleanup_free_ char *description = NULL;
         if (!s->scope) {
                 _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL;
                 _cleanup_free_ char *description = NULL;

-                const char *kill_mode;
-                char *scope, *job;
+                char *scope, *job = NULL;

 
                 description = strjoin("Session ", s->id, " of user ", s->user->name, NULL);
                 if (!description)
 
                 description = strjoin("Session ", s->id, " of user ", s->user->name, NULL);
                 if (!description)


@@ -478,9 +519,7 @@ static int session_start_scope(Session *s) {
                 if (!scope)
                         return log_oom();
 
                 if (!scope)
                         return log_oom();
 

-                kill_mode = manager_shall_kill(s->manager, s->user->name) ? "control-group" : "none";
-
-                r = manager_start_scope(s->manager, scope, s->leader, s->user->slice, description, "systemd-user-sessions.service", kill_mode, &error, &job);
+                r = manager_start_scope(s->manager, scope, s->leader, s->user->slice, description, "systemd-logind.service", "systemd-user-sessions.service", &error, &job);

                 if (r < 0) {
                         log_error("Failed to start session scope %s: %s %s",
                                   scope, bus_error_message(&error, r), error.name);
                 if (r < 0) {
                         log_error("Failed to start session scope %s: %s %s",
                                   scope, bus_error_message(&error, r), error.name);


@@ -521,11 +560,11 @@ int session_start(Session *s) {
                 return r;
 
         log_struct(s->class == SESSION_BACKGROUND ? LOG_DEBUG : LOG_INFO,
                 return r;
 
         log_struct(s->class == SESSION_BACKGROUND ? LOG_DEBUG : LOG_INFO,

-                   MESSAGE_ID(SD_MESSAGE_SESSION_START),
+                   LOG_MESSAGE_ID(SD_MESSAGE_SESSION_START),

                    "SESSION_ID=%s", s->id,
                    "USER_ID=%s", s->user->name,
                    "SESSION_ID=%s", s->id,
                    "USER_ID=%s", s->user->name,

-                   "LEADER=%lu", (unsigned long) s->leader,
-                   "MESSAGE=New session %s of user %s.", s->id, s->user->name,
+                   "LEADER="PID_FMT, s->leader,
+                   LOG_MESSAGE("New session %s of user %s.", s->id, s->user->name),

                    NULL);
 
         if (!dual_timestamp_is_set(&s->timestamp))
                    NULL);
 
         if (!dual_timestamp_is_set(&s->timestamp))


@@ -536,29 +575,30 @@ int session_start(Session *s) {
 
         s->started = true;
 
 
         s->started = true;
 

-        /* Save session data */
+        user_elect_display(s->user);
+
+        /* Save data */

         session_save(s);
         user_save(s->user);
         session_save(s);
         user_save(s->user);

+        if (s->seat)
+                seat_save(s->seat);

 
 

+        /* Send signals */

         session_send_signal(s, true);
         session_send_signal(s, true);

-
+        user_send_changed(s->user, "Sessions", "Display", NULL);

         if (s->seat) {
         if (s->seat) {

-                seat_save(s->seat);
-

                 if (s->seat->active == s)
                         seat_send_changed(s->seat, "Sessions", "ActiveSession", NULL);
                 else
                         seat_send_changed(s->seat, "Sessions", NULL);
         }
 
                 if (s->seat->active == s)
                         seat_send_changed(s->seat, "Sessions", "ActiveSession", NULL);
                 else
                         seat_send_changed(s->seat, "Sessions", NULL);
         }
 

-        user_send_changed(s->user, "Sessions", NULL);
-

         return 0;
 }
 
         return 0;
 }
 

-static int session_stop_scope(Session *s) {
+static int session_stop_scope(Session *s, bool force) {

         _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL;
         _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL;

-        char *job;
+        char *job = NULL;

         int r;
 
         assert(s);
         int r;
 
         assert(s);


@@ -566,19 +606,27 @@ static int session_stop_scope(Session *s) {
         if (!s->scope)
                 return 0;
 
         if (!s->scope)
                 return 0;
 

-        r = manager_stop_unit(s->manager, s->scope, &error, &job);
-        if (r < 0) {
-                log_error("Failed to stop session scope: %s", bus_error_message(&error, r));
-                return r;
-        }
+        if (force || manager_shall_kill(s->manager, s->user->name)) {
+                r = manager_stop_unit(s->manager, s->scope, &error, &job);
+                if (r < 0) {
+                        log_error("Failed to stop session scope: %s", bus_error_message(&error, r));
+                        return r;
+                }

 
 

-        free(s->scope_job);
-        s->scope_job = job;
+                free(s->scope_job);
+                s->scope_job = job;
+        } else {
+                r = manager_abandon_scope(s->manager, s->scope, &error);
+                if (r < 0) {
+                        log_error("Failed to abandon session scope: %s", bus_error_message(&error, r));
+                        return r;
+                }
+        }

 
         return 0;
 }
 
 
         return 0;
 }
 

-int session_stop(Session *s) {
+int session_stop(Session *s, bool force) {

         int r;
 
         assert(s);
         int r;
 
         assert(s);


@@ -586,8 +634,20 @@ int session_stop(Session *s) {
         if (!s->user)
                 return -ESTALE;
 
         if (!s->user)
                 return -ESTALE;
 

+        s->timer_event_source = sd_event_source_unref(s->timer_event_source);
+
+        if (s->seat)
+                seat_evict_position(s->seat, s);
+
+        /* We are going down, don't care about FIFOs anymore */
+        session_remove_fifo(s);
+

         /* Kill cgroup */
         /* Kill cgroup */

-        r = session_stop_scope(s);
+        r = session_stop_scope(s, force);
+
+        s->stopping = true;
+
+        user_elect_display(s->user);

 
         session_save(s);
         user_save(s->user);
 
         session_save(s);
         user_save(s->user);


@@ -596,7 +656,6 @@ int session_stop(Session *s) {
 }
 
 int session_finalize(Session *s) {
 }
 
 int session_finalize(Session *s) {

-        int r = 0;

         SessionDevice *sd;
 
         assert(s);
         SessionDevice *sd;
 
         assert(s);


@@ -606,18 +665,23 @@ int session_finalize(Session *s) {
 
         if (s->started)
                 log_struct(s->class == SESSION_BACKGROUND ? LOG_DEBUG : LOG_INFO,
 
         if (s->started)
                 log_struct(s->class == SESSION_BACKGROUND ? LOG_DEBUG : LOG_INFO,

-                           MESSAGE_ID(SD_MESSAGE_SESSION_STOP),
+                           LOG_MESSAGE_ID(SD_MESSAGE_SESSION_STOP),

                            "SESSION_ID=%s", s->id,
                            "USER_ID=%s", s->user->name,
                            "SESSION_ID=%s", s->id,
                            "USER_ID=%s", s->user->name,

-                           "LEADER=%lu", (unsigned long) s->leader,
-                           "MESSAGE=Removed session %s.", s->id,
+                           "LEADER="PID_FMT, s->leader,
+                           LOG_MESSAGE("Removed session %s.", s->id),

                            NULL);
 
                            NULL);
 

+        s->timer_event_source = sd_event_source_unref(s->timer_event_source);
+
+        if (s->seat)
+                seat_evict_position(s->seat, s);
+

         /* Kill session devices */
         while ((sd = hashmap_first(s->devices)))
                 session_device_free(sd);
 
         /* Kill session devices */
         while ((sd = hashmap_first(s->devices)))
                 session_device_free(sd);
 

-        unlink(s->state_file);
+        (void) unlink(s->state_file);

         session_add_to_gc_queue(s);
         user_add_to_gc_queue(s->user);
 
         session_add_to_gc_queue(s);
         user_add_to_gc_queue(s->user);
 


@@ -630,14 +694,40 @@ int session_finalize(Session *s) {
                 if (s->seat->active == s)
                         seat_set_active(s->seat, NULL);
 
                 if (s->seat->active == s)
                         seat_set_active(s->seat, NULL);
 

-                seat_send_changed(s->seat, "Sessions", NULL);

                 seat_save(s->seat);
                 seat_save(s->seat);

+                seat_send_changed(s->seat, "Sessions", NULL);

         }
 
         }
 

-        user_send_changed(s->user, "Sessions", NULL);

         user_save(s->user);
         user_save(s->user);

+        user_send_changed(s->user, "Sessions", "Display", NULL);

 
 

-        return r;
+        return 0;
+}
+
+static int release_timeout_callback(sd_event_source *es, uint64_t usec, void *userdata) {
+        Session *s = userdata;
+
+        assert(es);
+        assert(s);
+
+        session_stop(s, false);
+        return 0;
+}
+
+int session_release(Session *s) {
+        assert(s);
+
+        if (!s->started || s->stopping)
+                return 0;
+
+        if (s->timer_event_source)
+                return 0;
+
+        return sd_event_add_time(s->manager->event,
+                                 &s->timer_event_source,
+                                 CLOCK_MONOTONIC,
+                                 now(CLOCK_MONOTONIC) + RELEASE_USEC, 0,
+                                 release_timeout_callback, s);

 }
 
 bool session_is_active(Session *s) {
 }
 
 bool session_is_active(Session *s) {


@@ -766,7 +856,7 @@ static int session_dispatch_fifo(sd_event_source *es, int fd, uint32_t revents,
         /* EOF on the FIFO means the session died abnormally. */
 
         session_remove_fifo(s);
         /* EOF on the FIFO means the session died abnormally. */
 
         session_remove_fifo(s);

-        session_stop(s);
+        session_stop(s, false);

 
         return 1;
 }
 
         return 1;
 }


@@ -798,7 +888,7 @@ int session_create_fifo(Session *s) {
         }
 
         if (!s->fifo_event_source) {
         }
 
         if (!s->fifo_event_source) {

-                r = sd_event_add_io(s->manager->event, s->fifo_fd, 0, session_dispatch_fifo, s, &s->fifo_event_source);
+                r = sd_event_add_io(s->manager->event, &s->fifo_event_source, s->fifo_fd, 0, session_dispatch_fifo, s);

                 if (r < 0)
                         return r;
 
                 if (r < 0)
                         return r;
 


@@ -815,16 +905,11 @@ int session_create_fifo(Session *s) {
         return r;
 }
 
         return r;
 }
 

-void session_remove_fifo(Session *s) {
+static void session_remove_fifo(Session *s) {

         assert(s);
 
         assert(s);
 

-        if (s->fifo_event_source)
-                s->fifo_event_source = sd_event_source_unref(s->fifo_event_source);
-
-        if (s->fifo_fd >= 0) {
-                close_nointr_nofail(s->fifo_fd);
-                s->fifo_fd = -1;
-        }
+        s->fifo_event_source = sd_event_source_unref(s->fifo_event_source);
+        s->fifo_fd = safe_close(s->fifo_fd);

 
         if (s->fifo_path) {
                 unlink(s->fifo_path);
 
         if (s->fifo_path) {
                 unlink(s->fifo_path);


@@ -834,8 +919,6 @@ void session_remove_fifo(Session *s) {
 }
 
 bool session_check_gc(Session *s, bool drop_not_started) {
 }
 
 bool session_check_gc(Session *s, bool drop_not_started) {

-        int r;
-

         assert(s);
 
         if (drop_not_started && !s->started)
         assert(s);
 
         if (drop_not_started && !s->started)


@@ -845,11 +928,7 @@ bool session_check_gc(Session *s, bool drop_not_started) {
                 return false;
 
         if (s->fifo_fd >= 0) {
                 return false;
 
         if (s->fifo_fd >= 0) {

-                r = pipe_eof(s->fifo_fd);
-                if (r < 0)
-                        return true;
-
-                if (r == 0)
+                if (pipe_eof(s->fifo_fd) <= 0)

                         return true;
         }
 
                         return true;
         }
 


@@ -875,12 +954,13 @@ void session_add_to_gc_queue(Session *s) {
 SessionState session_get_state(Session *s) {
         assert(s);
 
 SessionState session_get_state(Session *s) {
         assert(s);
 

-        if (s->scope_job)
-                return SESSION_OPENING;
-
-        if (s->fifo_fd < 0)
+        /* always check closing first */
+        if (s->stopping || s->timer_event_source)

                 return SESSION_CLOSING;
 
                 return SESSION_CLOSING;
 

+        if (s->scope_job || s->fifo_fd < 0)
+                return SESSION_OPENING;
+

         if (session_is_active(s))
                 return SESSION_ACTIVE;
 
         if (session_is_active(s))
                 return SESSION_ACTIVE;
 


@@ -897,98 +977,132 @@ int session_kill(Session *s, KillWho who, int signo) {
 }
 
 static int session_open_vt(Session *s) {
 }
 
 static int session_open_vt(Session *s) {

-        char path[128];
+        char path[sizeof("/dev/tty") + DECIMAL_STR_MAX(s->vtnr)];

 
 

-        if (!s->vtnr)
-                return -1;
+        if (s->vtnr < 1)
+                return -ENODEV;

 
         if (s->vtfd >= 0)
                 return s->vtfd;
 
         sprintf(path, "/dev/tty%u", s->vtnr);
 
         if (s->vtfd >= 0)
                 return s->vtfd;
 
         sprintf(path, "/dev/tty%u", s->vtnr);

-        s->vtfd = open(path, O_RDWR | O_CLOEXEC | O_NONBLOCK | O_NOCTTY);
-        if (s->vtfd < 0) {
-                log_error("cannot open VT %s of session %s: %m", path, s->id);
-                return -1;
-        }
+        s->vtfd = open_terminal(path, O_RDWR | O_CLOEXEC | O_NONBLOCK | O_NOCTTY);
+        if (s->vtfd < 0)
+                return log_error_errno(errno, "cannot open VT %s of session %s: %m", path, s->id);

 
         return s->vtfd;
 }
 
 
         return s->vtfd;
 }
 

-static int session_vt_fn(sd_event_source *source, const struct signalfd_siginfo *si, void *data) {
-        Session *s = data;
-
-        if (s->vtfd >= 0)
-                ioctl(s->vtfd, VT_RELDISP, 1);
-
-        return 0;
-}
-
-void session_mute_vt(Session *s) {
+int session_prepare_vt(Session *s) {

         int vt, r;
         struct vt_mode mode = { 0 };
         int vt, r;
         struct vt_mode mode = { 0 };

-        sigset_t mask;
+
+        if (s->vtnr < 1)
+                return 0;

 
         vt = session_open_vt(s);
         if (vt < 0)
 
         vt = session_open_vt(s);
         if (vt < 0)

-                return;
+                return vt;

 
 

-        r = ioctl(vt, KDSKBMODE, K_OFF);
-        if (r < 0)
+        r = fchown(vt, s->user->uid, -1);
+        if (r < 0) {
+                r = -errno;
+                log_error_errno(errno, "Cannot change owner of /dev/tty%u: %m", s->vtnr);

                 goto error;
                 goto error;

+        }

 
 

-        r = ioctl(vt, KDSETMODE, KD_GRAPHICS);
-        if (r < 0)
+        r = ioctl(vt, KDSKBMODE, K_OFF);
+        if (r < 0) {
+                r = -errno;
+                log_error_errno(errno, "Cannot set K_OFF on /dev/tty%u: %m", s->vtnr);

                 goto error;
                 goto error;

+        }

 
 

-        sigemptyset(&mask);
-        sigaddset(&mask, SIGUSR1);
-        sigprocmask(SIG_BLOCK, &mask, NULL);
-
-        r = sd_event_add_signal(s->manager->event, SIGUSR1, session_vt_fn, s, &s->vt_source);
-        if (r < 0)
+        r = ioctl(vt, KDSETMODE, KD_GRAPHICS);
+        if (r < 0) {
+                r = -errno;
+                log_error_errno(errno, "Cannot set KD_GRAPHICS on /dev/tty%u: %m", s->vtnr);

                 goto error;
                 goto error;

+        }

 
         /* Oh, thanks to the VT layer, VT_AUTO does not work with KD_GRAPHICS.
          * So we need a dummy handler here which just acknowledges *all* VT
          * switch requests. */
         mode.mode = VT_PROCESS;
 
         /* Oh, thanks to the VT layer, VT_AUTO does not work with KD_GRAPHICS.
          * So we need a dummy handler here which just acknowledges *all* VT
          * switch requests. */
         mode.mode = VT_PROCESS;

-        mode.relsig = SIGUSR1;
-        mode.acqsig = SIGUSR1;
+        mode.relsig = SIGRTMIN;
+        mode.acqsig = SIGRTMIN + 1;

         r = ioctl(vt, VT_SETMODE, &mode);
         r = ioctl(vt, VT_SETMODE, &mode);

-        if (r < 0)
+        if (r < 0) {
+                r = -errno;
+                log_error_errno(errno, "Cannot set VT_PROCESS on /dev/tty%u: %m", s->vtnr);

                 goto error;
                 goto error;

+        }

 
 

-        return;
+        return 0;

 
 error:
 
 error:

-        log_error("cannot mute VT %u for session %s (%d/%d)", s->vtnr, s->id, r, errno);

         session_restore_vt(s);
         session_restore_vt(s);

+        return r;

 }
 
 void session_restore_vt(Session *s) {
 }
 
 void session_restore_vt(Session *s) {

-        _cleanup_free_ char *utf8;
+        _cleanup_free_ char *utf8 = NULL;

         int vt, kb = K_XLATE;
         struct vt_mode mode = { 0 };
 
         int vt, kb = K_XLATE;
         struct vt_mode mode = { 0 };
 

+        /* We need to get a fresh handle to the virtual terminal,
+         * since the old file-descriptor is potentially in a hung-up
+         * state after the controlling process exited; we do a
+         * little dance to avoid having the terminal be available
+         * for reuse before we've cleaned it up.
+         */
+        int old_fd = s->vtfd;
+        s->vtfd = -1;
+

         vt = session_open_vt(s);
         vt = session_open_vt(s);

+        safe_close(old_fd);
+

         if (vt < 0)
                 return;
 
         if (vt < 0)
                 return;
 

-        sd_event_source_unref(s->vt_source);
-        s->vt_source = NULL;
-
-        ioctl(vt, KDSETMODE, KD_TEXT);
+        (void) ioctl(vt, KDSETMODE, KD_TEXT);

 
         if (read_one_line_file("/sys/module/vt/parameters/default_utf8", &utf8) >= 0 && *utf8 == '1')
                 kb = K_UNICODE;
 
         if (read_one_line_file("/sys/module/vt/parameters/default_utf8", &utf8) >= 0 && *utf8 == '1')
                 kb = K_UNICODE;

-        ioctl(vt, KDSKBMODE, kb);
+
+        (void) ioctl(vt, KDSKBMODE, kb);

 
         mode.mode = VT_AUTO;
 
         mode.mode = VT_AUTO;

-        ioctl(vt, VT_SETMODE, &mode);
+        (void) ioctl(vt, VT_SETMODE, &mode);

 
 

-        close_nointr_nofail(vt);
-        s->vtfd = -1;
+        fchown(vt, 0, -1);
+
+        s->vtfd = safe_close(s->vtfd);
+}
+
+void session_leave_vt(Session *s) {
+        int r;
+
+        assert(s);
+
+        /* This is called whenever we get a VT-switch signal from the kernel.
+         * We acknowledge all of them unconditionally. Note that session are
+         * free to overwrite those handlers and we only register them for
+         * sessions with controllers. Legacy sessions are not affected.
+         * However, if we switch from a non-legacy to a legacy session, we must
+         * make sure to pause all device before acknowledging the switch. We
+         * process the real switch only after we are notified via sysfs, so the
+         * legacy session might have already started using the devices. If we
+         * don't pause the devices before the switch, we might confuse the
+         * session we switch to. */
+
+        if (s->vtfd < 0)
+                return;
+
+        session_device_pause_all(s);
+        r = ioctl(s->vtfd, VT_RELDISP, 1);
+        if (r < 0)
+                log_debug_errno(errno, "Cannot release VT of session %s: %m", s->id);

 }
 
 bool session_is_controller(Session *s, const char *sender) {
 }
 
 bool session_is_controller(Session *s, const char *sender) {


@@ -997,30 +1111,41 @@ bool session_is_controller(Session *s, const char *sender) {
         return streq_ptr(s->controller, sender);
 }
 
         return streq_ptr(s->controller, sender);
 }
 

-static void session_swap_controller(Session *s, char *name) {
+static void session_release_controller(Session *s, bool notify) {
+        _cleanup_free_ char *name = NULL;

         SessionDevice *sd;
 
         SessionDevice *sd;
 

-        if (s->controller) {
-                manager_drop_busname(s->manager, s->controller);
-                free(s->controller);
+        if (!s->controller)
+                return;
+
+        name = s->controller;
+
+        /* By resetting the controller before releasing the devices, we won't
+         * send notification signals. This avoids sending useless notifications
+         * if the controller is released on disconnects. */
+        if (!notify)

                 s->controller = NULL;
 
                 s->controller = NULL;
 

-                /* Drop all devices as they're now unused. Do that after the
-                 * controller is released to avoid sending out useles
-                 * dbus signals. */
-                while ((sd = hashmap_first(s->devices)))
-                        session_device_free(sd);
+        while ((sd = hashmap_first(s->devices)))
+                session_device_free(sd);

 
 

-                if (!name)
-                        session_restore_vt(s);
-        }
+        s->controller = NULL;
+        s->track = sd_bus_track_unref(s->track);
+}

 
 

-        s->controller = name;
-        session_save(s);
+static int on_bus_track(sd_bus_track *track, void *userdata) {
+        Session *s = userdata;
+
+        assert(track);
+        assert(s);
+
+        session_drop_controller(s);
+
+        return 0;

 }
 
 int session_set_controller(Session *s, const char *sender, bool force) {
 }
 
 int session_set_controller(Session *s, const char *sender, bool force) {

-        char *t;
+        _cleanup_free_ char *name = NULL;

         int r;
 
         assert(s);
         int r;
 
         assert(s);


@@ -1031,17 +1156,18 @@ int session_set_controller(Session *s, const char *sender, bool force) {
         if (s->controller && !force)
                 return -EBUSY;
 
         if (s->controller && !force)
                 return -EBUSY;
 

-        t = strdup(sender);
-        if (!t)
+        name = strdup(sender);
+        if (!name)

                 return -ENOMEM;
 
                 return -ENOMEM;
 

-        r = manager_watch_busname(s->manager, sender);
-        if (r) {
-                free(t);
+        s->track = sd_bus_track_unref(s->track);
+        r = sd_bus_track_new(s->manager->bus, &s->track, on_bus_track, s);
+        if (r < 0)

                 return r;
                 return r;

-        }

 
 

-        session_swap_controller(s, t);
+        r = sd_bus_track_add_name(s->track, name);
+        if (r < 0)
+                return r;

 
         /* When setting a session controller, we forcibly mute the VT and set
          * it into graphics-mode. Applications can override that by changing
 
         /* When setting a session controller, we forcibly mute the VT and set
          * it into graphics-mode. Applications can override that by changing


@@ -1051,7 +1177,16 @@ int session_set_controller(Session *s, const char *sender, bool force) {
          * exits.
          * If logind crashes/restarts, we restore the controller during restart
          * or reset the VT in case it crashed/exited, too. */
          * exits.
          * If logind crashes/restarts, we restore the controller during restart
          * or reset the VT in case it crashed/exited, too. */

-        session_mute_vt(s);
+        r = session_prepare_vt(s);
+        if (r < 0) {
+                s->track = sd_bus_track_unref(s->track);
+                return r;
+        }
+
+        session_release_controller(s, true);
+        s->controller = name;
+        name = NULL;
+        session_save(s);

 
         return 0;
 }
 
         return 0;
 }


@@ -1062,7 +1197,10 @@ void session_drop_controller(Session *s) {
         if (!s->controller)
                 return;
 
         if (!s->controller)
                 return;
 

-        session_swap_controller(s, NULL);
+        s->track = sd_bus_track_unref(s->track);
+        session_release_controller(s, false);
+        session_save(s);
+        session_restore_vt(s);

 }
 
 static const char* const session_state_table[_SESSION_STATE_MAX] = {
 }
 
 static const char* const session_state_table[_SESSION_STATE_MAX] = {


@@ -1075,10 +1213,12 @@ static const char* const session_state_table[_SESSION_STATE_MAX] = {
 DEFINE_STRING_TABLE_LOOKUP(session_state, SessionState);
 
 static const char* const session_type_table[_SESSION_TYPE_MAX] = {
 DEFINE_STRING_TABLE_LOOKUP(session_state, SessionState);
 
 static const char* const session_type_table[_SESSION_TYPE_MAX] = {

+        [SESSION_UNSPECIFIED] = "unspecified",

         [SESSION_TTY] = "tty",
         [SESSION_X11] = "x11",
         [SESSION_WAYLAND] = "wayland",
         [SESSION_TTY] = "tty",
         [SESSION_X11] = "x11",
         [SESSION_WAYLAND] = "wayland",

-        [SESSION_UNSPECIFIED] = "unspecified",
+        [SESSION_MIR] = "mir",
+        [SESSION_WEB] = "web",

 };
 
 DEFINE_STRING_TABLE_LOOKUP(session_type, SessionType);
 };
 
 DEFINE_STRING_TABLE_LOOKUP(session_type, SessionType);