bus: add support for serializing to gvariant

[elogind.git] / src / libsystemd-bus / bus-introspect.c

diff --git a/src/libsystemd-bus/bus-introspect.c b/src/libsystemd-bus/bus-introspect.c
index c04d9b51f774cf71908bcf6355329993757a8e86..115b3ceae875fbb0d32c2efc7a0cd0f8b30357db 100644 (file)
--- a/src/libsystemd-bus/bus-introspect.c
+++ b/src/libsystemd-bus/bus-introspect.c
@@ -24,6 +24,7 @@
 #include "bus-introspect.h"
 #include "bus-signature.h"
 #include "bus-internal.h"
 #include "bus-introspect.h"
 #include "bus-signature.h"
 #include "bus-internal.h"

+#include "bus-protocol.h"

 
 int introspect_begin(struct introspect *i) {
         assert(i);
 
 int introspect_begin(struct introspect *i) {
         assert(i);


@@ -34,7 +35,7 @@ int introspect_begin(struct introspect *i) {
         if (!i->f)
                 return -ENOMEM;
 
         if (!i->f)
                 return -ENOMEM;
 

-        fputs(SD_BUS_INTROSPECT_DOCTYPE
+        fputs(BUS_INTROSPECT_DOCTYPE

               "<node>\n", i->f);
 
         return 0;
               "<node>\n", i->f);
 
         return 0;


@@ -43,12 +44,12 @@ int introspect_begin(struct introspect *i) {
 int introspect_write_default_interfaces(struct introspect *i, bool object_manager) {
         assert(i);
 
 int introspect_write_default_interfaces(struct introspect *i, bool object_manager) {
         assert(i);
 

-        fputs(SD_BUS_INTROSPECT_INTERFACE_PEER
-              SD_BUS_INTROSPECT_INTERFACE_INTROSPECTABLE
-              SD_BUS_INTROSPECT_INTERFACE_PROPERTIES, i->f);
+        fputs(BUS_INTROSPECT_INTERFACE_PEER
+              BUS_INTROSPECT_INTERFACE_INTROSPECTABLE
+              BUS_INTROSPECT_INTERFACE_PROPERTIES, i->f);

 
         if (object_manager)
 
         if (object_manager)

-                fputs(SD_BUS_INTROSPECT_INTERFACE_OBJECT_MANAGER, i->f);
+                fputs(BUS_INTROSPECT_INTERFACE_OBJECT_MANAGER, i->f);

 
         return 0;
 }
 
         return 0;
 }


@@ -63,7 +64,7 @@ int introspect_write_child_nodes(struct introspect *i, Set *s, const char *prefi
                 const char *e;
 
                 e = object_path_startswith(node, prefix);
                 const char *e;
 
                 e = object_path_startswith(node, prefix);

-                if (e)
+                if (e && e[0])

                         fprintf(i->f, " <node name=\"%s\"/>\n", e);
 
                 free(node);
                         fprintf(i->f, " <node name=\"%s\"/>\n", e);
 
                 free(node);


@@ -103,21 +104,18 @@ static int introspect_write_arguments(struct introspect *i, const char *signatur
                 fprintf(i->f, "   <arg type=\"%.*s\"", (int) l, signature);
 
                 if (direction)
                 fprintf(i->f, "   <arg type=\"%.*s\"", (int) l, signature);
 
                 if (direction)

-                        fprintf(i->f, " direction=\"%s\">\n", direction);
+                        fprintf(i->f, " direction=\"%s\"/>\n", direction);

                 else
                 else

-                        fputs(">\n", i->f);
+                        fputs("/>\n", i->f);

 
                 signature += l;
         }
 }
 
 
                 signature += l;
         }
 }
 

-int introspect_write_interface(struct introspect *i, const char *interface, const sd_bus_vtable *v) {
+int introspect_write_interface(struct introspect *i, const sd_bus_vtable *v) {

         assert(i);
         assert(i);

-        assert(interface);

         assert(v);
 
         assert(v);
 

-        fprintf(i->f, " <interface name=\"%s\">\n", interface);
-

         for (; v->type != _SD_BUS_VTABLE_END; v++) {
 
                 switch (v->type) {
         for (; v->type != _SD_BUS_VTABLE_END; v++) {
 
                 switch (v->type) {


@@ -129,8 +127,8 @@ int introspect_write_interface(struct introspect *i, const char *interface, cons
 
                 case _SD_BUS_VTABLE_METHOD:
                         fprintf(i->f, "  <method name=\"%s\">\n", v->x.method.member);
 
                 case _SD_BUS_VTABLE_METHOD:
                         fprintf(i->f, "  <method name=\"%s\">\n", v->x.method.member);

-                        introspect_write_arguments(i, v->x.method.signature, "in");
-                        introspect_write_arguments(i, v->x.method.result, "out");
+                        introspect_write_arguments(i, strempty(v->x.method.signature), "in");
+                        introspect_write_arguments(i, strempty(v->x.method.result), "out");

                         introspect_write_flags(i, v->type, v->flags);
                         fputs("  </method>\n", i->f);
                         break;
                         introspect_write_flags(i, v->type, v->flags);
                         fputs("  </method>\n", i->f);
                         break;


@@ -147,7 +145,7 @@ int introspect_write_interface(struct introspect *i, const char *interface, cons
 
                 case _SD_BUS_VTABLE_SIGNAL:
                         fprintf(i->f, "  <signal name=\"%s\">\n", v->x.signal.member);
 
                 case _SD_BUS_VTABLE_SIGNAL:
                         fprintf(i->f, "  <signal name=\"%s\">\n", v->x.signal.member);

-                        introspect_write_arguments(i, v->x.signal.signature, NULL);
+                        introspect_write_arguments(i, strempty(v->x.signal.signature), NULL);

                         introspect_write_flags(i, v->type, v->flags);
                         fputs("  </signal>\n", i->f);
                         break;
                         introspect_write_flags(i, v->type, v->flags);
                         fputs("  </signal>\n", i->f);
                         break;


@@ -155,7 +153,6 @@ int introspect_write_interface(struct introspect *i, const char *interface, cons
 
         }
 
 
         }
 

-        fputs(" </interface>\n", i->f);

         return 0;
 }
 
         return 0;
 }
 


@@ -173,7 +170,7 @@ int introspect_finish(struct introspect *i, sd_bus *bus, sd_bus_message *m, sd_b
         if (ferror(i->f))
                 return -ENOMEM;
 
         if (ferror(i->f))
                 return -ENOMEM;
 

-        r = sd_bus_message_new_method_return(bus, m, &q);
+        r = sd_bus_message_new_method_return(m, &q);

         if (r < 0)
                 return r;
 
         if (r < 0)
                 return r;