chiark / gitweb /
~ianmdlvl / elogind.git / blobdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | inline | side by side
analyze: simplify things
[elogind.git] / src / analyze / analyze.c
diff --git a/src/analyze/analyze.c b/src/analyze/analyze.c
index 6bfe13d82db2d15c5611e0b08e5fe55c46a73f45..9becc72309a5eee283f94f60cbe6afde0269ce0f 100644 (file)
--- a/src/analyze/analyze.c
+++ b/src/analyze/analyze.c
@@ -102,10 +102,10 @@ struct unit_info {
 
 struct unit_times {
         char *name;
-        usec_t ixt;
-        usec_t iet;
-        usec_t axt;
-        usec_t aet;
+        usec_t activating;
+        usec_t activated;
+        usec_t deactivated;
+        usec_t deactivating;
         usec_t time;
 };
 
@@ -144,8 +144,8 @@ static int compare_unit_time(const void *a, const void *b) {
 }
 
 static int compare_unit_start(const void *a, const void *b) {
-        return compare(((struct unit_times *)a)->ixt,
-                       ((struct unit_times *)b)->ixt);
+        return compare(((struct unit_times *)a)->activating,
+                       ((struct unit_times *)b)->activating);
 }
 
 static int get_os_name(char **_n) {
@@ -218,7 +218,7 @@ static int bus_get_unit_property_strv(sd_bus *bus, const char *unit_path, const
 
         r = sd_bus_message_enter_container(reply, SD_BUS_TYPE_ARRAY, "s");
         if (r < 0)
-            return r;
+                return r;
 
         while ((r = sd_bus_message_read(reply, "s", &s)) > 0) {
                 r = strv_extend(strv, s);
@@ -248,19 +248,19 @@ static int acquire_time_data(sd_bus *bus, struct unit_times **out) {
                        &reply,
                        "");
         if (r < 0) {
-            log_error("Failed to parse reply: %s", bus_error_message(&error, -r));
-            goto fail;
+                log_error("Failed to parse reply: %s", bus_error_message(&error, -r));
+                goto fail;
         }
 
         r = sd_bus_message_enter_container(reply, SD_BUS_TYPE_ARRAY, "(ssssssouso)");
         if (r < 0)
-            goto fail;
+                goto fail;
 
         while ((r = bus_parse_unit_info(reply, &u)) > 0) {
                 struct unit_times *t;
 
                 if (r < 0)
-                    goto fail;
+                        goto fail;
 
                 if (c >= n_units) {
                         struct unit_times *w;
@@ -283,31 +283,31 @@ static int acquire_time_data(sd_bus *bus, struct unit_times **out) {
                 if (bus_get_uint64_property(bus, u.unit_path,
                                             "org.freedesktop.systemd1.Unit",
                                             "InactiveExitTimestampMonotonic",
-                                            &t->ixt) < 0 ||
+                                            &t->activating) < 0 ||
                     bus_get_uint64_property(bus, u.unit_path,
                                             "org.freedesktop.systemd1.Unit",
                                             "ActiveEnterTimestampMonotonic",
-                                            &t->aet) < 0 ||
+                                            &t->activated) < 0 ||
                     bus_get_uint64_property(bus, u.unit_path,
                                             "org.freedesktop.systemd1.Unit",
                                             "ActiveExitTimestampMonotonic",
-                                            &t->axt) < 0 ||
+                                            &t->deactivating) < 0 ||
                     bus_get_uint64_property(bus, u.unit_path,
                                             "org.freedesktop.systemd1.Unit",
                                             "InactiveEnterTimestampMonotonic",
-                                            &t->iet) < 0) {
+                                            &t->deactivated) < 0) {
                         r = -EIO;
                         goto fail;
                 }
 
-                if (t->aet >= t->ixt)
-                        t->time = t->aet - t->ixt;
-                else if (t->iet >= t->ixt)
-                        t->time = t->iet - t->ixt;
+                if (t->activated >= t->activating)
+                        t->time = t->activated - t->activating;
+                else if (t->deactivated >= t->activating)
+                        t->time = t->deactivated - t->activating;
                 else
                         t->time = 0;
 
-                if (t->ixt == 0)
+                if (t->activating == 0)
                         continue;
 
                 t->name = strdup(u.id);
@@ -509,28 +509,32 @@ static int analyze_plot(sd_bus *bus) {
                 m++;
 
         for (u = times; u < times + n; u++) {
-                double len;
+                double text_start, text_width;
 
-                if (u->ixt < boot->userspace_time ||
-                    u->ixt > boot->finish_time) {
+                if (u->activating < boot->userspace_time ||
+                    u->activating > boot->finish_time) {
                         free(u->name);
                         u->name = NULL;
                         continue;
                 }
-                len = ((boot->firmware_time + u->ixt) * SCALE_X)
-                        + (10.0 * strlen(u->name));
-                if (len > width)
-                        width = len;
-
-                if (u->iet > u->ixt && u->iet <= boot->finish_time
-                                && u->aet == 0 && u->axt == 0)
-                        u->aet = u->axt = u->iet;
-                if (u->aet < u->ixt || u->aet > boot->finish_time)
-                        u->aet = boot->finish_time;
-                if (u->axt < u->aet || u->aet > boot->finish_time)
-                        u->axt = boot->finish_time;
-                if (u->iet < u->axt || u->iet > boot->finish_time)
-                        u->iet = boot->finish_time;
+
+                /* If the text cannot fit on the left side then
+                 * increase the svg width so it fits on the right.
+                 * TODO: calculate the text width more accurately */
+                text_width = 8.0 * strlen(u->name);
+                text_start = (boot->firmware_time + u->activating) * SCALE_X;
+                if (text_width > text_start && text_width + text_start > width)
+                        width = text_width + text_start;
+
+                if (u->deactivated > u->activating && u->deactivated <= boot->finish_time
+                                && u->activated == 0 && u->deactivating == 0)
+                        u->activated = u->deactivating = u->deactivated;
+                if (u->activated < u->activating || u->activated > boot->finish_time)
+                        u->activated = boot->finish_time;
+                if (u->deactivating < u->activated || u->activated > boot->finish_time)
+                        u->deactivating = boot->finish_time;
+                if (u->deactivated < u->deactivating || u->deactivated > boot->finish_time)
+                        u->deactivated = boot->finish_time;
                 m++;
         }
 
@@ -608,7 +612,7 @@ static int analyze_plot(sd_bus *bus) {
         svg_bar("active", boot->userspace_time, boot->finish_time, y);
         svg_bar("generators", boot->generators_start_time, boot->generators_finish_time, y);
         svg_bar("unitsload", boot->unitsload_start_time, boot->unitsload_finish_time, y);
-        svg_text("left", boot->userspace_time, y, "systemd");
+        svg_text(true, boot->userspace_time, y, "systemd");
         y++;
 
         for (u = times; u < times + n; u++) {
@@ -618,35 +622,36 @@ static int analyze_plot(sd_bus *bus) {
                 if (!u->name)
                         continue;
 
-                svg_bar("activating",   u->ixt, u->aet, y);
-                svg_bar("active",       u->aet, u->axt, y);
-                svg_bar("deactivating", u->axt, u->iet, y);
+                svg_bar("activating",   u->activating, u->activated, y);
+                svg_bar("active",       u->activated, u->deactivating, y);
+                svg_bar("deactivating", u->deactivating, u->deactivated, y);
 
-                b = u->ixt * SCALE_X > width * 2 / 3;
+                /* place the text on the left if we have passed the half of the svg width */
+                b = u->activating * SCALE_X < width / 2;
                 if (u->time)
-                        svg_text(b, u->ixt, y, "%s (%s)",
+                        svg_text(b, u->activating, y, "%s (%s)",
                                  u->name, format_timespan(ts, sizeof(ts), u->time, USEC_PER_MSEC));
                 else
-                        svg_text(b, u->ixt, y, "%s", u->name);
+                        svg_text(b, u->activating, y, "%s", u->name);
                 y++;
         }
 
         /* Legend */
         y++;
         svg_bar("activating", 0, 300000, y);
-        svg_text("right", 400000, y, "Activating");
+        svg_text(true, 400000, y, "Activating");
         y++;
         svg_bar("active", 0, 300000, y);
-        svg_text("right", 400000, y, "Active");
+        svg_text(true, 400000, y, "Active");
         y++;
         svg_bar("deactivating", 0, 300000, y);
-        svg_text("right", 400000, y, "Deactivating");
+        svg_text(true, 400000, y, "Deactivating");
         y++;
         svg_bar("generators", 0, 300000, y);
-        svg_text("right", 400000, y, "Generators");
+        svg_text(true, 400000, y, "Generators");
         y++;
         svg_bar("unitsload", 0, 300000, y);
-        svg_text("right", 400000, y, "Loading unit files");
+        svg_text(true, 400000, y, "Loading unit files");
         y++;
 
         svg("</g>\n\n");
@@ -671,10 +676,10 @@ static int list_dependencies_print(const char *name, unsigned int level, unsigne
         if (times) {
                 if (times->time)
                         printf("%s%s @%s +%s%s", ANSI_HIGHLIGHT_RED_ON, name,
-                               format_timespan(ts, sizeof(ts), times->ixt - boot->userspace_time, USEC_PER_MSEC),
+                               format_timespan(ts, sizeof(ts), times->activating - boot->userspace_time, USEC_PER_MSEC),
                                format_timespan(ts2, sizeof(ts2), times->time, USEC_PER_MSEC), ANSI_HIGHLIGHT_OFF);
-                else if (times->aet > boot->userspace_time)
-                        printf("%s @%s", name, format_timespan(ts, sizeof(ts), times->aet - boot->userspace_time, USEC_PER_MSEC));
+                else if (times->activated > boot->userspace_time)
+                        printf("%s @%s", name, format_timespan(ts, sizeof(ts), times->activated - boot->userspace_time, USEC_PER_MSEC));
                 else
                         printf("%s", name);
         } else printf("%s", name);
@@ -715,10 +720,10 @@ static int list_dependencies_compare(const void *_a, const void *_b) {
 
         times = hashmap_get(unit_times_hashmap, *a);
         if (times)
-                usa = times->aet;
+                usa = times->activated;
         times = hashmap_get(unit_times_hashmap, *b);
         if (times)
-                usb = times->aet;
+                usb = times->activated;
 
         return usb - usa;
 }
@@ -749,11 +754,11 @@ static int list_dependencies_one(sd_bus *bus, const char *name, unsigned int lev
         STRV_FOREACH(c, deps) {
                 times = hashmap_get(unit_times_hashmap, *c);
                 if (times
-                    && times->aet
-                    && times->aet <= boot->finish_time
-                    && (times->aet >= service_longest
+                    && times->activated
+                    && times->activated <= boot->finish_time
+                    && (times->activated >= service_longest
                         || service_longest == 0)) {
-                        service_longest = times->aet;
+                        service_longest = times->activated;
                         break;
                 }
         }
@@ -763,9 +768,9 @@ static int list_dependencies_one(sd_bus *bus, const char *name, unsigned int lev
 
         STRV_FOREACH(c, deps) {
                 times = hashmap_get(unit_times_hashmap, *c);
-                if (times && times->aet
-                    && times->aet <= boot->finish_time
-                    && (service_longest - times->aet) <= arg_fuzz) {
+                if (times && times->activated
+                    && times->activated <= boot->finish_time
+                    && (service_longest - times->activated) <= arg_fuzz) {
                         to_print++;
                 }
         }
@@ -776,9 +781,9 @@ static int list_dependencies_one(sd_bus *bus, const char *name, unsigned int lev
         STRV_FOREACH(c, deps) {
                 times = hashmap_get(unit_times_hashmap, *c);
                 if (!times
-                    || !times->aet
-                    || times->aet > boot->finish_time
-                    || service_longest - times->aet > arg_fuzz)
+                    || !times->activated
+                    || times->activated > boot->finish_time
+                    || service_longest - times->activated > arg_fuzz)
                         continue;
 
                 to_print--;
@@ -852,8 +857,8 @@ static int list_dependencies(sd_bus *bus, const char *name) {
                 if (times->time)
                         printf("%s%s +%s%s\n", ANSI_HIGHLIGHT_RED_ON, id,
                                format_timespan(ts, sizeof(ts), times->time, USEC_PER_MSEC), ANSI_HIGHLIGHT_OFF);
-                else if (times->aet > boot->userspace_time)
-                        printf("%s @%s\n", id, format_timespan(ts, sizeof(ts), times->aet - boot->userspace_time, USEC_PER_MSEC));
+                else if (times->activated > boot->userspace_time)
+                        printf("%s @%s\n", id, format_timespan(ts, sizeof(ts), times->activated - boot->userspace_time, USEC_PER_MSEC));
                 else
                         printf("%s\n", id);
         }
@@ -945,9 +950,8 @@ static int graph_one_property(sd_bus *bus, const struct unit_info *u, const char
         assert(color);
 
         r = bus_get_unit_property_strv(bus, u->unit_path, prop, &units);
-        if (r < 0) {
-            return -r;
-        }
+        if (r < 0)
+                return -r;
 
         STRV_FOREACH(unit, units) {
                 char **p;
@@ -1102,14 +1106,14 @@ static int dump(sd_bus *bus, char **args) {
                        &reply,
                        "");
         if (r < 0) {
-            log_error("Failed to parse reply: %s", bus_error_message(&error, -r));
-            return r;
+                log_error("Failed to parse reply: %s", bus_error_message(&error, -r));
+                return r;
         }
 
         r = sd_bus_message_read(reply, "s", &text);
         if (r < 0) {
-            log_error("Failed to parse reply");
-            return r;
+                log_error("Failed to parse reply");
+                return r;
         }
 
         fputs(text, stdout);
@@ -1119,7 +1123,6 @@ static int dump(sd_bus *bus, char **args) {
 static int set_log_level(sd_bus *bus, char **args) {
         _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL;
         int r;
-        const char* value;
 
         assert(bus);
         assert(args);
@@ -1129,8 +1132,6 @@ static int set_log_level(sd_bus *bus, char **args) {
                 return -E2BIG;
         }
 
-        value = args[0];
-
         r = sd_bus_set_property(
                         bus,
                         "org.freedesktop.systemd1",
@@ -1139,7 +1140,7 @@ static int set_log_level(sd_bus *bus, char **args) {
                         "LogLevel",
                         &error,
                         "s",
-                        value);
+                        args[0]);
         if (r < 0) {
                 log_error("Failed to issue method call: %s", bus_error_message(&error, -r));
                 return -EIO;
Unnamed repository; edit this file 'description' to name the repository.