static char** arg_environ = NULL;
static int add_epoll(int epoll_fd, int fd) {
+ struct epoll_event ev = {
+ .events = EPOLLIN
+ };
int r;
- struct epoll_event ev = {EPOLLIN};
- ev.data.fd = fd;
assert(epoll_fd >= 0);
assert(fd >= 0);
+ ev.data.fd = fd;
r = epoll_ctl(epoll_fd, EPOLL_CTL_ADD, fd, &ev);
if (r < 0)
- log_error("Failed to add event on epoll fd:%d for fd:%d: %s",
- epoll_fd, fd, strerror(-r));
- return r;
-}
-
-static int set_nocloexec(int fd) {
- int flags;
-
- flags = fcntl(fd, F_GETFD);
- if (flags < 0) {
- log_error("Querying flags for fd:%d: %m", fd);
- return -errno;
- }
-
- if (!(flags & FD_CLOEXEC))
- return 0;
-
- if (fcntl(fd, F_SETFD, flags & ~FD_CLOEXEC) < 0) {
- log_error("Settings flags for fd:%d: %m", fd);
- return -errno;
- }
-
- return 0;
+ log_error("Failed to add event on epoll fd:%d for fd:%d: %m",
+ epoll_fd, fd);
+ return -errno;
}
-static int print_socket(const char* desc, int fd) {
- int r;
- SocketAddress addr = {
- .size = sizeof(union sockaddr_union),
- .type = SOCK_STREAM,
- };
- int family;
+static int make_socket_fd(const char* address, int flags) {
+ _cleanup_free_ char *p = NULL;
+ SocketAddress a;
+ int fd, r;
- r = getsockname(fd, &addr.sockaddr.sa, &addr.size);
+ r = socket_address_parse(&a, address);
if (r < 0) {
- log_warning("Failed to query socket on fd:%d: %m", fd);
- return 0;
+ log_error("Failed to parse socket: %s", strerror(-r));
+ return r;
}
- family = socket_address_family(&addr);
- switch(family) {
- case AF_INET:
- case AF_INET6: {
- char* _cleanup_free_ a = NULL;
- r = socket_address_print(&addr, &a);
- if (r < 0)
- log_warning("socket_address_print(): %s", strerror(-r));
- else
- log_info("%s %s address %s",
- desc,
- family == AF_INET ? "IP" : "IPv6",
- a);
- break;
- }
- default:
- log_warning("Connection with unknown family %d", family);
+ fd = socket_address_listen(&a, flags, SOMAXCONN, SOCKET_ADDRESS_DEFAULT, NULL, false, false, 0755, 0644, NULL);
+ if (fd < 0) {
+ log_error("Failed to listen: %s", strerror(-r));
+ return fd;
}
- return 0;
+ return fd;
}
static int open_sockets(int *epoll_fd, bool accept) {
- int n, fd;
- int count = 0;
char **address;
+ int n, fd, r;
+ int count = 0;
n = sd_listen_fds(true);
if (n < 0) {
strerror(-n));
return n;
}
- log_info("Received %d descriptors", n);
+ if (n > 0) {
+ log_info("Received %i descriptors via the environment.", n);
- for (fd = SD_LISTEN_FDS_START; fd < SD_LISTEN_FDS_START + n; fd++) {
- log_debug("Received descriptor fd:%d", fd);
- print_socket("Listening on", fd);
-
- if (!arg_accept) {
- int r = set_nocloexec(fd);
+ for (fd = SD_LISTEN_FDS_START; fd < SD_LISTEN_FDS_START + n; fd++) {
+ r = fd_cloexec(fd, arg_accept);
if (r < 0)
return r;
- }
- count ++;
+ count ++;
+ }
}
+ /** Note: we leak some fd's on error here. I doesn't matter
+ * much, since the program will exit immediately anyway, but
+ * would be a pain to fix.
+ */
+
STRV_FOREACH(address, arg_listen) {
- log_info("Opening address %s", *address);
fd = make_socket_fd(*address, SOCK_STREAM | (arg_accept*SOCK_CLOEXEC));
if (fd < 0) {
return fd;
}
+ assert(fd == SD_LISTEN_FDS_START + count);
count ++;
}
}
for (fd = SD_LISTEN_FDS_START; fd < SD_LISTEN_FDS_START + count; fd++) {
- int r = add_epoll(*epoll_fd, fd);
+ _cleanup_free_ char *name = NULL;
+
+ getsockname_pretty(fd, &name);
+ log_info("Listening on %s.", strna(name));
+
+ r = add_epoll(*epoll_fd, fd);
if (r < 0)
return r;
}
}
static int launch(char* name, char **argv, char **env, int fds) {
- unsigned n_env = 0, length;
- char **envp = NULL, **s;
+
static const char* tocopy[] = {"TERM=", "PATH=", "USER=", "HOME="};
- char _cleanup_free_ *tmp = NULL;
+ _cleanup_strv_free_ char **envp = NULL;
+ _cleanup_free_ char *tmp = NULL;
+ unsigned n_env = 0, length;
+ char **s;
unsigned i;
length = strv_length(arg_environ);
+
/* PATH, TERM, HOME, USER, LISTEN_FDS, LISTEN_PID, NULL */
- envp = new(char *, length + 7);
+ envp = new0(char *, length + 7);
+ if (!envp)
+ return log_oom();
STRV_FOREACH(s, arg_environ) {
if (strchr(*s, '='))
envp[n_env++] = *s;
else {
- char _cleanup_free_ *p = strappend(*s, "=");
+ _cleanup_free_ char *p = strappend(*s, "=");
if (!p)
return log_oom();
envp[n_env] = strv_find_prefix(env, p);
log_info("Execing %s (%s)", name, tmp);
execvpe(name, argv, envp);
log_error("Failed to execp %s (%s): %m", name, tmp);
+
return -errno;
}
static int launch1(const char* child, char** argv, char **env, int fd) {
+ _cleanup_free_ char *tmp = NULL;
pid_t parent_pid, child_pid;
int r;
- char _cleanup_free_ *tmp = NULL;
tmp = strv_join(argv, " ");
if (!tmp)
return log_oom();
}
static int do_accept(const char* name, char **argv, char **envp, int fd) {
- SocketAddress addr = {
- .size = sizeof(union sockaddr_union),
- .type = SOCK_STREAM,
- };
- int fd2, r;
+ _cleanup_free_ char *local = NULL, *peer = NULL;
+ int fd2;
- fd2 = accept(fd, &addr.sockaddr.sa, &addr.size);
+ fd2 = accept(fd, NULL, NULL);
if (fd2 < 0) {
log_error("Failed to accept connection on fd:%d: %m", fd);
return fd2;
}
- print_socket("Connection from", fd2);
+ getsockname_pretty(fd2, &local);
+ getpeername_pretty(fd2, &peer);
+ log_info("Connection from %s to %s", strna(peer), strna(local));
- r = launch1(name, argv, envp, fd2);
- return r;
+ return launch1(name, argv, envp, fd2);
}
/* SIGCHLD handler. */
-static void sigchld_hdl(int sig, siginfo_t *t, void *data)
-{
+static void sigchld_hdl(int sig, siginfo_t *t, void *data) {
log_info("Child %d died with code %d", t->si_pid, t->si_status);
- /* Wait for a dead child. */
- waitpid(t->si_pid, NULL, 0);
+ /* Wait for a dead child. */
+ waitpid(t->si_pid, NULL, 0);
}
static int install_chld_handler(void) {
int r;
- struct sigaction act;
+ struct sigaction act;
zero(act);
act.sa_flags = SA_SIGINFO;
act.sa_sigaction = sigchld_hdl;
{ "listen", required_argument, NULL, 'l' },
{ "accept", no_argument, NULL, 'a' },
{ "environment", required_argument, NULL, 'E' },
- { NULL, 0, NULL, 0 }
+ {}
};
int c;
while ((c = getopt_long(argc, argv, "+hl:saE:", options, NULL)) >= 0)
switch(c) {
case 'h':
- help();
- return 0 /* done */;
+ return help();
case ARG_VERSION:
puts(PACKAGE_STRING);
return -EINVAL;
default:
- log_error("Unknown option code %c", c);
- return -EINVAL;
+ assert_not_reached("Unhandled option");
}
if (optind == argc) {
int r, n;
int epoll_fd = -1;
- log_set_max_level(LOG_DEBUG);
- log_show_color(true);
log_parse_environment();
+ log_open();
r = parse_argv(argc, argv);
if (r <= 0)
if (n < 0)
return EXIT_FAILURE;
- while (true) {
+ for (;;) {
struct epoll_event event;
r = epoll_wait(epoll_fd, &event, 1, -1);
~ianmdlvl / elogind.git / blobdiff