chiark / gitweb /
yay, we can start socket units
[elogind.git] / socket.c
index 23e347d7f4a708a8311dd80302a7103c8ef4902c..cbddcaa77d880adc43acedbda9bd3fc999df05c0 100644 (file)
--- a/socket.c
+++ b/socket.c
@@ -8,27 +8,42 @@
 #include <sys/poll.h>
 #include <signal.h>
 
-#include "name.h"
+#include "unit.h"
 #include "socket.h"
 #include "log.h"
 
-static const NameActiveState state_table[_SOCKET_STATE_MAX] = {
-        [SOCKET_DEAD] = NAME_INACTIVE,
-        [SOCKET_START_PRE] = NAME_ACTIVATING,
-        [SOCKET_START_POST] = NAME_ACTIVATING,
-        [SOCKET_LISTENING] = NAME_ACTIVE,
-        [SOCKET_RUNNING] = NAME_ACTIVE,
-        [SOCKET_STOP_PRE] = NAME_DEACTIVATING,
-        [SOCKET_STOP_PRE_SIGTERM] = NAME_DEACTIVATING,
-        [SOCKET_STOP_PRE_SIGKILL] = NAME_DEACTIVATING,
-        [SOCKET_STOP_POST] = NAME_DEACTIVATING,
-        [SOCKET_STOP_POST_SIGTERM] = NAME_DEACTIVATING,
-        [SOCKET_STOP_POST_SIGKILL] = NAME_DEACTIVATING,
-        [SOCKET_MAINTAINANCE] = NAME_INACTIVE,
+static const UnitActiveState state_translation_table[_SOCKET_STATE_MAX] = {
+        [SOCKET_DEAD] = UNIT_INACTIVE,
+        [SOCKET_START_PRE] = UNIT_ACTIVATING,
+        [SOCKET_START_POST] = UNIT_ACTIVATING,
+        [SOCKET_LISTENING] = UNIT_ACTIVE,
+        [SOCKET_RUNNING] = UNIT_ACTIVE,
+        [SOCKET_STOP_PRE] = UNIT_DEACTIVATING,
+        [SOCKET_STOP_PRE_SIGTERM] = UNIT_DEACTIVATING,
+        [SOCKET_STOP_PRE_SIGKILL] = UNIT_DEACTIVATING,
+        [SOCKET_STOP_POST] = UNIT_DEACTIVATING,
+        [SOCKET_STOP_POST_SIGTERM] = UNIT_DEACTIVATING,
+        [SOCKET_STOP_POST_SIGKILL] = UNIT_DEACTIVATING,
+        [SOCKET_MAINTAINANCE] = UNIT_INACTIVE,
 };
 
-static void socket_done(Name *n) {
-        Socket *s = SOCKET(n);
+static const char* const state_string_table[_SOCKET_STATE_MAX] = {
+        [SOCKET_DEAD] = "dead",
+        [SOCKET_START_PRE] = "start-pre",
+        [SOCKET_START_POST] = "start-post",
+        [SOCKET_LISTENING] = "listening",
+        [SOCKET_RUNNING] = "running",
+        [SOCKET_STOP_PRE] = "stop-pre",
+        [SOCKET_STOP_PRE_SIGTERM] = "stop-pre-sigterm",
+        [SOCKET_STOP_PRE_SIGKILL] = "stop-pre-sigkill",
+        [SOCKET_STOP_POST] = "stop-post",
+        [SOCKET_STOP_POST_SIGTERM] = "stop-post-sigterm",
+        [SOCKET_STOP_POST_SIGKILL] = "stop-post-sigkill",
+        [SOCKET_MAINTAINANCE] = "maintainance"
+};
+
+static void socket_done(Unit *u) {
+        Socket *s = SOCKET(u);
         SocketPort *p;
 
         assert(s);
@@ -47,17 +62,19 @@ static void socket_done(Name *n) {
         s->control_command = NULL;
 
         if (s->control_pid > 0) {
-                name_unwatch_pid(n, s->control_pid);
+                unit_unwatch_pid(u, s->control_pid);
                 s->control_pid = 0;
         }
 
         s->service = NULL;
 
-        name_unwatch_timer(n, &s->timer_id);
+        free(s->bind_to_device);
+
+        unit_unwatch_timer(u, &s->timer_watch);
 }
 
-static int socket_init(Name *n) {
-        Socket *s = SOCKET(n);
+static int socket_init(Unit *u) {
+        Socket *s = SOCKET(u);
         char *t;
         int r;
 
@@ -65,33 +82,33 @@ static int socket_init(Name *n) {
          * reload */
 
         s->state = 0;
-        s->timer_id = -1;
+        s->timer_watch.type = WATCH_INVALID;
         s->bind_ipv6_only = false;
         s->backlog = SOMAXCONN;
         s->timeout_usec = DEFAULT_TIMEOUT_USEC;
         exec_context_init(&s->exec_context);
 
-        if ((r = name_load_fragment_and_dropin(n)) < 0)
+        if ((r = unit_load_fragment_and_dropin(u)) < 0)
                 goto fail;
 
-        if (!(t = name_change_suffix(name_id(n), ".service"))) {
+        if (!(t = unit_name_change_suffix(unit_id(u), ".service"))) {
                 r = -ENOMEM;
                 goto fail;
         }
 
-        r = manager_load_name(n->meta.manager, t, (Name**) &s->service);
+        r = manager_load_unit(u->meta.manager, t, (Unit**) &s->service);
         free(t);
 
         if (r < 0)
                 goto fail;
 
-        if ((r = name_add_dependency(n, NAME_BEFORE, NAME(s->service))) < 0)
+        if ((r = unit_add_dependency(u, UNIT_BEFORE, UNIT(s->service))) < 0)
                 goto fail;
 
         return 0;
 
 fail:
-        socket_done(n);
+        socket_done(u);
         return r;
 }
 
@@ -108,22 +125,7 @@ static const char* listen_lookup(int type) {
         return NULL;
 }
 
-static void socket_dump(Name *n, FILE *f, const char *prefix) {
-
-        static const char* const state_table[_SOCKET_STATE_MAX] = {
-                [SOCKET_DEAD] = "dead",
-                [SOCKET_START_PRE] = "start-pre",
-                [SOCKET_START_POST] = "start-post",
-                [SOCKET_LISTENING] = "listening",
-                [SOCKET_RUNNING] = "running",
-                [SOCKET_STOP_PRE] = "stop-pre",
-                [SOCKET_STOP_PRE_SIGTERM] = "stop-pre-sigterm",
-                [SOCKET_STOP_PRE_SIGKILL] = "stop-pre-sigkill",
-                [SOCKET_STOP_POST] = "stop-post",
-                [SOCKET_STOP_POST_SIGTERM] = "stop-post-sigterm",
-                [SOCKET_STOP_POST_SIGKILL] = "stop-post-sigkill",
-                [SOCKET_MAINTAINANCE] = "maintainance"
-        };
+static void socket_dump(Unit *u, FILE *f, const char *prefix) {
 
         static const char* const command_table[_SOCKET_EXEC_MAX] = {
                 [SOCKET_EXEC_START_PRE] = "StartPre",
@@ -133,19 +135,29 @@ static void socket_dump(Name *n, FILE *f, const char *prefix) {
         };
 
         SocketExecCommand c;
-        Socket *s = SOCKET(n);
+        Socket *s = SOCKET(u);
         SocketPort *p;
+        char *prefix2;
 
         assert(s);
 
+        prefix2 = strappend(prefix, "\t");
+        if (!prefix2)
+                prefix2 = "";
+
         fprintf(f,
                 "%sSocket State: %s\n"
                 "%sBindIPv6Only: %s\n"
                 "%sBacklog: %u\n",
-                prefix, state_table[s->state],
+                prefix, state_string_table[s->state],
                 prefix, yes_no(s->bind_ipv6_only),
                 prefix, s->backlog);
 
+        if (s->bind_to_device)
+                fprintf(f,
+                        "%sBindToDevice: %s\n",
+                        prefix, s->bind_to_device);
+
         LIST_FOREACH(port, p, s->ports) {
 
                 if (p->type == SOCKET_SOCKET) {
@@ -167,11 +179,16 @@ static void socket_dump(Name *n, FILE *f, const char *prefix) {
         exec_context_dump(&s->exec_context, f, prefix);
 
         for (c = 0; c < _SOCKET_EXEC_MAX; c++) {
-                ExecCommand *i;
+                if (!s->exec_command[c])
+                        continue;
+
+                fprintf(f, "%sā†’ %s:\n",
+                        prefix, command_table[c]);
 
-                LIST_FOREACH(command, i, s->exec_command[c])
-                        fprintf(f, "%s%s: %s\n", prefix, command_table[c], i->path);
+                exec_command_dump_list(s->exec_command[c], f, prefix2);
         }
+
+        free(prefix2);
 }
 
 static void socket_close_fds(Socket *s) {
@@ -183,7 +200,7 @@ static void socket_close_fds(Socket *s) {
                 if (p->fd < 0)
                         continue;
 
-                name_unwatch_fd(NAME(s), p->fd);
+                unit_unwatch_fd(UNIT(s), &p->fd_watch);
                 assert_se(close_nointr(p->fd) >= 0);
 
                 p->fd = -1;
@@ -203,7 +220,7 @@ static int socket_open_fds(Socket *s) {
 
                 if (p->type == SOCKET_SOCKET) {
 
-                        if ((r = socket_address_listen(&p->address, s->backlog, s->bind_ipv6_only, &p->fd)) < 0)
+                        if ((r = socket_address_listen(&p->address, s->backlog, s->bind_ipv6_only, s->bind_to_device, &p->fd)) < 0)
                                 goto rollback;
 
                 } else {
@@ -250,7 +267,7 @@ static void socket_unwatch_fds(Socket *s) {
                 if (p->fd < 0)
                         continue;
 
-                name_unwatch_fd(NAME(s), p->fd);
+                unit_unwatch_fd(UNIT(s), &p->fd_watch);
         }
 }
 
@@ -264,7 +281,7 @@ static int socket_watch_fds(Socket *s) {
                 if (p->fd < 0)
                         continue;
 
-                if ((r = name_watch_fd(NAME(s), p->fd, POLLIN)) < 0)
+                if ((r = unit_watch_fd(UNIT(s), p->fd, POLLIN, &p->fd_watch)) < 0)
                         goto fail;
         }
 
@@ -290,7 +307,7 @@ static void socket_set_state(Socket *s, SocketState state) {
             state != SOCKET_STOP_POST &&
             state != SOCKET_STOP_POST_SIGTERM &&
             state != SOCKET_STOP_POST_SIGKILL)
-                name_unwatch_timer(NAME(s), &s->timer_id);
+                unit_unwatch_timer(UNIT(s), &s->timer_watch);
 
         if (state != SOCKET_START_PRE &&
             state != SOCKET_START_POST &&
@@ -300,8 +317,8 @@ static void socket_set_state(Socket *s, SocketState state) {
             state != SOCKET_STOP_POST &&
             state != SOCKET_STOP_POST_SIGTERM &&
             state != SOCKET_STOP_POST_SIGKILL)
-                if (s->control_pid >= 0) {
-                        name_unwatch_pid(NAME(s), s->control_pid);
+                if (s->control_pid > 0) {
+                        unit_unwatch_pid(UNIT(s), s->control_pid);
                         s->control_pid = 0;
                 }
 
@@ -322,7 +339,9 @@ static void socket_set_state(Socket *s, SocketState state) {
         if (state != SOCKET_LISTENING)
                 socket_unwatch_fds(s);
 
-        name_notify(NAME(s), state_table[old_state], state_table[s->state]);
+        log_debug("%s changing %s ā†’ %s", unit_id(UNIT(s)), state_string_table[old_state], state_string_table[state]);
+
+        unit_notify(UNIT(s), state_translation_table[old_state], state_translation_table[state]);
 }
 
 static int socket_spawn(Socket *s, ExecCommand *c, bool timeout, pid_t *_pid) {
@@ -334,15 +353,15 @@ static int socket_spawn(Socket *s, ExecCommand *c, bool timeout, pid_t *_pid) {
         assert(_pid);
 
         if (timeout) {
-                if ((r = name_watch_timer(NAME(s), s->timeout_usec, &s->timer_id)) < 0)
+                if ((r = unit_watch_timer(UNIT(s), s->timeout_usec, &s->timer_watch)) < 0)
                         goto fail;
         } else
-                name_unwatch_timer(NAME(s), &s->timer_id);
+                unit_unwatch_timer(UNIT(s), &s->timer_watch);
 
         if ((r = exec_spawn(c, &s->exec_context, NULL, 0, &pid)) < 0)
                 goto fail;
 
-        if ((r = name_watch_pid(NAME(s), pid)) < 0)
+        if ((r = unit_watch_pid(UNIT(s), pid)) < 0)
                 /* FIXME: we need to do something here */
                 goto fail;
 
@@ -352,7 +371,7 @@ static int socket_spawn(Socket *s, ExecCommand *c, bool timeout, pid_t *_pid) {
 
 fail:
         if (timeout)
-                name_unwatch_timer(NAME(s), &s->timer_id);
+                unit_unwatch_timer(UNIT(s), &s->timer_watch);
 
         return r;
 }
@@ -385,7 +404,7 @@ static void socket_enter_stop_post(Socket *s, bool success) {
         return;
 
 fail:
-        log_warning("%s failed to run stop-post executable: %s", name_id(NAME(s)), strerror(-r));
+        log_warning("%s failed to run stop-post executable: %s", unit_id(UNIT(s)), strerror(-r));
         socket_enter_dead(s, false);
 }
 
@@ -414,7 +433,7 @@ static void socket_enter_signal(Socket *s, SocketState state, bool success) {
         return;
 
 fail:
-        log_warning("%s failed to kill processes: %s", name_id(NAME(s)), strerror(-r));
+        log_warning("%s failed to kill processes: %s", unit_id(UNIT(s)), strerror(-r));
 
         if (state == SOCKET_STOP_PRE_SIGTERM || state == SOCKET_STOP_PRE_SIGKILL)
                 socket_enter_stop_post(s, false);
@@ -441,7 +460,7 @@ static void socket_enter_stop_pre(Socket *s, bool success) {
         return;
 
 fail:
-        log_warning("%s failed to run stop-pre executable: %s", name_id(NAME(s)), strerror(-r));
+        log_warning("%s failed to run stop-pre executable: %s", unit_id(UNIT(s)), strerror(-r));
         socket_enter_stop_post(s, false);
 }
 
@@ -451,14 +470,14 @@ static void socket_enter_start_post(Socket *s) {
 
         if ((r = socket_open_fds(s)) < 0 ||
             (r = socket_watch_fds(s)) < 0) {
-                log_warning("%s failed to listen on sockets: %s", name_id(NAME(s)), strerror(-r));
+                log_warning("%s failed to listen on sockets: %s", unit_id(UNIT(s)), strerror(-r));
                 goto fail;
         }
 
         if ((s->control_command = s->exec_command[SOCKET_EXEC_START_POST])) {
 
                 if ((r = socket_spawn(s, s->control_command, true, &s->control_pid)) < 0) {
-                        log_warning("%s failed to run start-post executable: %s", name_id(NAME(s)), strerror(-r));
+                        log_warning("%s failed to run start-post executable: %s", unit_id(UNIT(s)), strerror(-r));
                         goto fail;
                 }
 
@@ -488,7 +507,7 @@ static void socket_enter_start_pre(Socket *s) {
         return;
 
 fail:
-        log_warning("%s failed to run start-pre exectuable: %s", name_id(NAME(s)), strerror(-r));
+        log_warning("%s failed to run start-pre exectuable: %s", unit_id(UNIT(s)), strerror(-r));
         socket_enter_dead(s, false);
 }
 
@@ -497,14 +516,14 @@ static void socket_enter_running(Socket *s) {
 
         assert(s);
 
-        if ((r = manager_add_job(NAME(s)->meta.manager, JOB_START, NAME(s->service), JOB_REPLACE, true, NULL)) < 0)
+        if ((r = manager_add_job(UNIT(s)->meta.manager, JOB_START, UNIT(s->service), JOB_REPLACE, true, NULL)) < 0)
                 goto fail;
 
         socket_set_state(s, SOCKET_RUNNING);
         return;
 
 fail:
-        log_warning("%s failed to queue socket startup job: %s", name_id(NAME(s)), strerror(-r));
+        log_warning("%s failed to queue socket startup job: %s", unit_id(UNIT(s)), strerror(-r));
         socket_enter_dead(s, false);
 }
 
@@ -534,8 +553,8 @@ fail:
                 socket_enter_stop_pre(s, false);
 }
 
-static int socket_start(Name *n) {
-        Socket *s = SOCKET(n);
+static int socket_start(Unit *u) {
+        Socket *s = SOCKET(u);
 
         assert(s);
 
@@ -554,7 +573,7 @@ static int socket_start(Name *n) {
                 return 0;
 
         /* Cannot run this without the service being around */
-        if (s->service->meta.load_state != NAME_LOADED)
+        if (s->service->meta.load_state != UNIT_LOADED)
                 return -ENOENT;
 
         assert(s->state == SOCKET_DEAD || s->state == SOCKET_MAINTAINANCE);
@@ -564,8 +583,8 @@ static int socket_start(Name *n) {
         return 0;
 }
 
-static int socket_stop(Name *n) {
-        Socket *s = SOCKET(n);
+static int socket_stop(Unit *u) {
+        Socket *s = SOCKET(u);
 
         assert(s);
 
@@ -581,18 +600,18 @@ static int socket_stop(Name *n) {
         return 0;
 }
 
-static NameActiveState socket_active_state(Name *n) {
-        assert(n);
+static UnitActiveState socket_active_state(Unit *u) {
+        assert(u);
 
-        return state_table[SOCKET(n)->state];
+        return state_translation_table[SOCKET(u)->state];
 }
 
-static void socket_fd_event(Name *n, int fd, uint32_t events) {
-        Socket *s = SOCKET(n);
+static void socket_fd_event(Unit *u, int fd, uint32_t events, Watch *w) {
+        Socket *s = SOCKET(u);
 
         assert(s);
 
-        log_info("Incoming traffic on %s", name_id(n));
+        log_info("Incoming traffic on %s", unit_id(u));
 
         if (events != POLLIN)
                 socket_enter_stop_pre(s, false);
@@ -600,8 +619,8 @@ static void socket_fd_event(Name *n, int fd, uint32_t events) {
         socket_enter_running(s);
 }
 
-static void socket_sigchld_event(Name *n, pid_t pid, int code, int status) {
-        Socket *s = SOCKET(n);
+static void socket_sigchld_event(Unit *u, pid_t pid, int code, int status) {
+        Socket *s = SOCKET(u);
         bool success;
 
         assert(s);
@@ -616,20 +635,23 @@ static void socket_sigchld_event(Name *n, pid_t pid, int code, int status) {
         exec_status_fill(&s->control_command->exec_status, pid, code, status);
         s->control_pid = 0;
 
-        log_debug("%s: control process exited, code=%s status=%i", name_id(n), sigchld_code(code), status);
+        log_debug("%s control process exited, code=%s status=%i", unit_id(u), sigchld_code(code), status);
 
         if (s->control_command->command_next &&
-            (success || (s->state == SOCKET_EXEC_STOP_PRE || s->state == SOCKET_EXEC_STOP_POST)))
+            (success || (s->state == SOCKET_EXEC_STOP_PRE || s->state == SOCKET_EXEC_STOP_POST))) {
+                log_debug("%s running next command for the state %s", unit_id(u), state_string_table[s->state]);
                 socket_run_next(s, success);
-        else {
+        else {
                 /* No further commands for this step, so let's figure
                  * out what to do next */
 
+                log_debug("%s finished with state %s", unit_id(u), state_string_table[s->state]);
+
                 switch (s->state) {
 
                 case SOCKET_START_PRE:
                         if (success)
-                                socket_enter_start_pre(s);
+                                socket_enter_start_post(s);
                         else
                                 socket_enter_stop_pre(s, false);
                         break;
@@ -659,49 +681,49 @@ static void socket_sigchld_event(Name *n, pid_t pid, int code, int status) {
         }
 }
 
-static void socket_timer_event(Name *n, int id, uint64_t elapsed) {
-        Socket *s = SOCKET(n);
+static void socket_timer_event(Unit *u, uint64_t elapsed, Watch *w) {
+        Socket *s = SOCKET(u);
 
         assert(s);
         assert(elapsed == 1);
 
-        assert(s->timer_id == id);
+        assert(w == &s->timer_watch);
 
         switch (s->state) {
 
         case SOCKET_START_PRE:
         case SOCKET_START_POST:
-                log_warning("%s operation timed out. Stopping.", name_id(n));
+                log_warning("%s operation timed out. Stopping.", unit_id(u));
                 socket_enter_stop_pre(s, false);
                 break;
 
         case SOCKET_STOP_PRE:
-                log_warning("%s stopping timed out. Terminating.", name_id(n));
+                log_warning("%s stopping timed out. Terminating.", unit_id(u));
                 socket_enter_signal(s, SOCKET_STOP_PRE_SIGTERM, false);
                 break;
 
         case SOCKET_STOP_PRE_SIGTERM:
-                log_warning("%s stopping timed out. Killing.", name_id(n));
+                log_warning("%s stopping timed out. Killing.", unit_id(u));
                 socket_enter_signal(s, SOCKET_STOP_PRE_SIGKILL, false);
                 break;
 
         case SOCKET_STOP_PRE_SIGKILL:
-                log_warning("%s still around after SIGKILL. Ignoring.", name_id(n));
+                log_warning("%s still around after SIGKILL. Ignoring.", unit_id(u));
                 socket_enter_stop_post(s, false);
                 break;
 
         case SOCKET_STOP_POST:
-                log_warning("%s stopping timed out (2). Terminating.", name_id(n));
+                log_warning("%s stopping timed out (2). Terminating.", unit_id(u));
                 socket_enter_signal(s, SOCKET_STOP_POST_SIGTERM, false);
                 break;
 
         case SOCKET_STOP_POST_SIGTERM:
-                log_warning("%s stopping timed out (2). Killing.", name_id(n));
+                log_warning("%s stopping timed out (2). Killing.", unit_id(u));
                 socket_enter_signal(s, SOCKET_STOP_POST_SIGKILL, false);
                 break;
 
         case SOCKET_STOP_POST_SIGKILL:
-                log_warning("%s still around after SIGKILL (2). Entering maintainance mode.", name_id(n));
+                log_warning("%s still around after SIGKILL (2). Entering maintainance mode.", unit_id(u));
                 socket_enter_dead(s, false);
                 break;
 
@@ -742,7 +764,7 @@ int socket_collect_fds(Socket *s, int **fds, unsigned *n_fds) {
         return 0;
 }
 
-const NameVTable socket_vtable = {
+const UnitVTable socket_vtable = {
         .suffix = ".socket",
 
         .init = socket_init,