chiark / gitweb /
[PATCH] make udevsend binary even smaller
[elogind.git] / namedev_parse.c
index 3578058a768c1fe0f66549d4dd72b071549fed11..e6575fa108431958e33d0a283b2c7bd20935f4ba 100644 (file)
@@ -3,7 +3,7 @@
  *
  * Userspace devfs
  *
- * Copyright (C) 2003 Greg Kroah-Hartman <greg@kroah.com>
+ * Copyright (C) 2003,2004 Greg Kroah-Hartman <greg@kroah.com>
  *
  *
  *     This program is free software; you can redistribute it and/or modify it
  *
  */
 
-/* define this to enable parsing debugging */
+#ifdef DEBUG
+/* define this to enable parsing debugging also */
 /* #define DEBUG_PARSER */
+#endif
 
 #include <stddef.h>
 #include <stdlib.h>
 #include <errno.h>
 
 #include "udev.h"
+#include "logging.h"
 #include "namedev.h"
 
-int get_pair(char **orig_string, char **left, char **right)
+static int add_config_dev(struct config_device *new_dev)
 {
-       char *temp;
-       char *string = *orig_string;
-
-       if (!string)
-               return -ENODEV;
-
-       /* eat any whitespace */
-       while (isspace(*string) || *string == ',')
-               ++string;
-
-       /* split based on '=' */
-       temp = strsep(&string, "=");
-       *left = temp;
-       if (!string)
-               return -ENODEV;
-
-       /* take the right side and strip off the '"' */
-       while (isspace(*string))
-               ++string;
-       if (*string == '"')
-               ++string;
-       else
-               return -ENODEV;
-
-       temp = strsep(&string, "\"");
-       if (!string || *temp == '\0')
-               return -ENODEV;
-       *right = temp;
-       *orig_string = string;
-       
+       struct config_device *tmp_dev;
+
+       tmp_dev = malloc(sizeof(*tmp_dev));
+       if (tmp_dev == NULL)
+               return -ENOMEM;
+       memcpy(tmp_dev, new_dev, sizeof(*tmp_dev));
+       list_add_tail(&tmp_dev->node, &config_device_list);
+       //dump_config_dev(tmp_dev);
        return 0;
 }
 
 void dump_config_dev(struct config_device *dev)
 {
-       switch (dev->type) {
-       case KERNEL_NAME:
-               dbg_parse("KERNEL name='%s'", dev->name);
-               break;
-       case LABEL:
-               dbg_parse("LABEL name='%s', bus='%s', sysfs_file='%s', sysfs_value='%s'",
-                         dev->name, dev->bus, dev->sysfs_file, dev->sysfs_value);
-               break;
-       case NUMBER:
-               dbg_parse("NUMBER name='%s', bus='%s', id='%s'",
-                         dev->name, dev->bus, dev->id);
-               break;
-       case TOPOLOGY:
-               dbg_parse("TOPOLOGY name='%s', bus='%s', place='%s'",
-                         dev->name, dev->bus, dev->place);
-               break;
-       case REPLACE:
-               dbg_parse("REPLACE name=%s, kernel_name=%s",
-                         dev->name, dev->kernel_name);
-               break;
-       case CALLOUT:
-               dbg_parse("CALLOUT name='%s', bus='%s', program='%s', id='%s'",
-                         dev->name, dev->bus, dev->exec_program, dev->id);
-               break;
-       default:
-               dbg_parse("unknown type of method");
-       }
+       /*FIXME dump all sysfs's */
+       dbg_parse("name='%s', symlink='%s', bus='%s', place='%s', id='%s', "
+                 "sysfs_file[0]='%s', sysfs_value[0]='%s', "
+                 "kernel='%s', program='%s', result='%s'",
+                 dev->name, dev->symlink, dev->bus, dev->place, dev->id,
+                 dev->sysfs_pair[0].file, dev->sysfs_pair[0].value,
+                 dev->kernel, dev->program, dev->result);
 }
 
 void dump_config_dev_list(void)
 {
-       struct list_head *tmp;
+       struct config_device *dev;
 
-       list_for_each(tmp, &config_device_list) {
-               struct config_device *dev = list_entry(tmp, struct config_device, node);
+       list_for_each_entry(dev, &config_device_list, node)
                dump_config_dev(dev);
-       }
 }
 
 void dump_perm_dev(struct perm_device *dev)
@@ -120,15 +79,12 @@ void dump_perm_dev(struct perm_device *dev)
 
 void dump_perm_dev_list(void)
 {
-       struct list_head *tmp;
+       struct perm_device *dev;
 
-       list_for_each(tmp, &perm_device_list) {
-               struct perm_device *dev = list_entry(tmp, struct perm_device, node);
+       list_for_each_entry(dev, &perm_device_list, node)
                dump_perm_dev(dev);
-       }
 }
 
-
 int namedev_init_rules(void)
 {
        char line[255];
@@ -137,6 +93,7 @@ int namedev_init_rules(void)
        char *temp2;
        char *temp3;
        FILE *fd;
+       int program_given = 0;
        int retval = 0;
        struct config_device dev;
 
@@ -158,54 +115,23 @@ int namedev_init_rules(void)
                lineno++;
                dbg_parse("read '%s'", temp);
 
+               /* eat the whitespace */
+               while (isspace(*temp))
+                       ++temp;
+
                /* empty line? */
-               if (*temp == 0x00)
+               if ((*temp == '\0') || (*temp == '\n'))
                        continue;
 
                /* see if this is a comment */
                if (*temp == COMMENT_CHARACTER)
                        continue;
 
-               /* eat the whitespace */
-               while (isspace(*temp))
-                       ++temp;
-
                memset(&dev, 0x00, sizeof(struct config_device));
 
-               /* get the method */
-               temp2 = strsep(&temp, ",");
-
-               if (strcasecmp(temp2, TYPE_LABEL) == 0) {
-                       dev.type = LABEL;
-                       goto keys;
-               }
-
-               if (strcasecmp(temp2, TYPE_NUMBER) == 0) {
-                       dev.type = NUMBER;
-                       goto keys;
-               }
-
-               if (strcasecmp(temp2, TYPE_TOPOLOGY) == 0) {
-                       dev.type = TOPOLOGY;
-                       goto keys;
-               }
-
-               if (strcasecmp(temp2, TYPE_REPLACE) == 0) {
-                       dev.type = REPLACE;
-                       goto keys;
-               }
-
-               if (strcasecmp(temp2, TYPE_CALLOUT) == 0) {
-                       dev.type = CALLOUT;
-                       goto keys;
-               }
-
-               dbg_parse("unknown type of method '%s'", temp2);
-               goto error;
-keys:
                /* get all known keys */
                while (1) {
-                       retval = get_pair(&temp, &temp2, &temp3);
+                       retval = parse_get_pair(&temp, &temp2, &temp3);
                        if (retval)
                                break;
 
@@ -225,19 +151,39 @@ keys:
                        }
 
                        if (strncasecmp(temp2, FIELD_SYSFS, sizeof(FIELD_SYSFS)-1) == 0) {
-                               /* remove prepended 'SYSFS_' */
-                               strfieldcpy(dev.sysfs_file, temp2 + sizeof(FIELD_SYSFS)-1);
-                               strfieldcpy(dev.sysfs_value, temp3);
+                               struct sysfs_pair *pair = &dev.sysfs_pair[0];
+                               int sysfs_pair_num = 0;
+
+                               /* find first unused pair */
+                               while (pair->file[0] != '\0') {
+                                       ++sysfs_pair_num;
+                                       if (sysfs_pair_num >= MAX_SYSFS_PAIRS) {
+                                               pair = NULL;
+                                               break;
+                                       }
+                                       ++pair;
+                               }
+                               if (pair) {
+                                       /* remove prepended 'SYSFS_' */
+                                       strfieldcpy(pair->file, temp2 + sizeof(FIELD_SYSFS)-1);
+                                       strfieldcpy(pair->value, temp3);
+                               }
                                continue;
                        }
 
                        if (strcasecmp(temp2, FIELD_KERNEL) == 0) {
-                               strfieldcpy(dev.kernel_name, temp3);
+                               strfieldcpy(dev.kernel, temp3);
                                continue;
                        }
 
                        if (strcasecmp(temp2, FIELD_PROGRAM) == 0) {
-                               strfieldcpy(dev.exec_program, temp3);
+                               program_given = 1;
+                               strfieldcpy(dev.program, temp3);
+                               continue;
+                       }
+
+                       if (strcasecmp(temp2, FIELD_RESULT) == 0) {
+                               strfieldcpy(dev.result, temp3);
                                continue;
                        }
 
@@ -251,71 +197,33 @@ keys:
                                continue;
                        }
 
-                       dbg_parse("unknown type of field '%s'", temp2);
+                       dbg("unknown type of field '%s'", temp2);
+                       dbg("You might be using a rules file in the old format, please fix.");
+                       goto error;
+               }
+
+               /* simple plausibility check for given keys */
+               if ((dev.sysfs_pair[0].file[0] == '\0') ^
+                   (dev.sysfs_pair[0].value[0] == '\0')) {
+                       dbg("inconsistency in SYSFS_ key");
+                       goto error;
                }
 
-               /* check presence of keys according to method type */
-               switch (dev.type) {
-               case LABEL:
-                       dbg_parse("LABEL name='%s', bus='%s', "
-                                 "sysfs_file='%s', sysfs_value='%s', symlink='%s'",
-                                 dev.name, dev.bus, dev.sysfs_file,
-                                 dev.sysfs_value, dev.symlink);
-                       if ((*dev.name == '\0') ||
-                           (*dev.bus == '\0') ||
-                           (*dev.sysfs_file == '\0') ||
-                           (*dev.sysfs_value == '\0'))
-                               goto error;
-                       break;
-               case NUMBER:
-                       dbg_parse("NUMBER name='%s', bus='%s', id='%s', symlink='%s'",
-                                 dev.name, dev.bus, dev.id, dev.symlink);
-                       if ((*dev.name == '\0') ||
-                           (*dev.bus == '\0') ||
-                           (*dev.id == '\0'))
-                               goto error;
-                       break;
-               case TOPOLOGY:
-                       dbg_parse("TOPOLOGY name='%s', bus='%s', "
-                                 "place='%s', symlink='%s'",
-                                 dev.name, dev.bus, dev.place, dev.symlink);
-                       if ((*dev.name == '\0') ||
-                           (*dev.bus == '\0') ||
-                           (*dev.place == '\0'))
-                               goto error;
-                       break;
-               case REPLACE:
-                       dbg_parse("REPLACE name='%s', kernel_name='%s', symlink='%s'",
-                                 dev.name, dev.kernel_name, dev.symlink);
-                       if ((*dev.name == '\0') ||
-                           (*dev.kernel_name == '\0'))
-                               goto error;
-                       break;
-               case CALLOUT:
-                       dbg_parse("CALLOUT name='%s', bus='%s', program='%s', "
-                                 "id='%s', symlink='%s'",
-                                 dev.name, dev.bus, dev.exec_program,
-                                 dev.id, dev.symlink);
-                       if ((*dev.name == '\0') ||
-                           (*dev.bus == '\0') ||
-                           (*dev.id == '\0') ||
-                           (*dev.exec_program == '\0'))
-                               goto error;
-                       break;
-               default:
-                       dbg_parse("xxx default method");
+               if ((dev.result[0] != '\0') && (program_given == 0)) {
+                       dbg("RESULT is only useful when PROGRAM called in any rule before");
                        goto error;
                }
 
+               dev.config_line = lineno;
                retval = add_config_dev(&dev);
                if (retval) {
                        dbg("add_config_dev returned with error %d", retval);
                        continue;
+error:
+                       dbg("%s:%d:%d: parse error, rule skipped",
+                                 udev_rules_filename, lineno, temp - line);
                }
        }
-error:
-       dbg_parse("%s:%d:%Zd: field missing or parse error", udev_rules_filename,
-                 lineno, temp - line);
 exit:
        fclose(fd);
        return retval;
@@ -351,7 +259,7 @@ int namedev_init_permissions(void)
                        ++temp;
 
                /* empty line? */
-               if (*temp == 0x00)
+               if ((*temp == '\0') || (*temp == '\n'))
                        continue;
 
                /* see if this is a comment */
@@ -380,7 +288,7 @@ int namedev_init_permissions(void)
                        dbg("cannot parse line '%s'", line);
                        continue;
                }
-               strncpy(dev.group, temp2, sizeof(dev.owner));
+               strncpy(dev.group, temp2, sizeof(dev.group));
 
                if (!temp) {
                        dbg("cannot parse line: %s", line);
@@ -401,6 +309,5 @@ int namedev_init_permissions(void)
 exit:
        fclose(fd);
        return retval;
-}      
-
+}