chiark / gitweb /
[PATCH] remove extra ; in namedev_parse.c
[elogind.git] / namedev_parse.c
index 5cb3a3eb1d3c04cedce3ac997361214534b487ec..8198f7e684c35d402af9e2f49b3fdf9edd34c234 100644 (file)
@@ -3,7 +3,7 @@
  *
  * Userspace devfs
  *
- * Copyright (C) 2003 Greg Kroah-Hartman <greg@kroah.com>
+ * Copyright (C) 2003,2004 Greg Kroah-Hartman <greg@kroah.com>
  *
  *
  *     This program is free software; you can redistribute it and/or modify it
  *
  */
 
-/* define this to enable parsing debugging */
+#ifdef DEBUG
+/* define this to enable parsing debugging also */
 /* #define DEBUG_PARSER */
+#endif
 
 #include <stddef.h>
 #include <stdlib.h>
 #include <fcntl.h>
 #include <ctype.h>
 #include <unistd.h>
+#include <sys/stat.h>
+#include <dirent.h>
 #include <errno.h>
 
 #include "udev.h"
+#include "logging.h"
 #include "namedev.h"
 
-int get_pair(char **orig_string, char **left, char **right)
-{
-       char *temp;
-       char *string = *orig_string;
-
-       if (!string)
-               return -ENODEV;
-
-       /* eat any whitespace */
-       while (isspace(*string))
-               ++string;
-
-       /* split based on '=' */
-       temp = strsep(&string, "=");
-       *left = temp;
-       if (!string)
-               return -ENODEV;
-
-       /* take the right side and strip off the '"' */
-       while (isspace(*string))
-               ++string;
-       if (*string == '"')
-               ++string;
-       else
-               return -ENODEV;
+LIST_HEAD(file_list);
 
-       temp = strsep(&string, "\"");
-       if (!string || *temp == '\0')
-               return -ENODEV;
-       *right = temp;
-       *orig_string = string;
-       
-       return 0;
-}
 
-static int get_value(const char *left, char **orig_string, char **ret_string)
+static int add_config_dev(struct config_device *new_dev)
 {
-       int retval;
-       char *left_string;
-
-       retval = get_pair(orig_string, &left_string, ret_string);
-       if (retval)
-               return retval;
-       if (strcasecmp(left_string, left) != 0)
-               return -ENODEV;
+       struct config_device *tmp_dev;
+
+       tmp_dev = malloc(sizeof(*tmp_dev));
+       if (tmp_dev == NULL)
+               return -ENOMEM;
+       memcpy(tmp_dev, new_dev, sizeof(*tmp_dev));
+       list_add_tail(&tmp_dev->node, &config_device_list);
+       //dump_config_dev(tmp_dev);
        return 0;
 }
 
 void dump_config_dev(struct config_device *dev)
 {
-       switch (dev->type) {
-       case KERNEL_NAME:
-               dbg_parse("KERNEL name='%s'", dev->name);
-               break;
-       case LABEL:
-               dbg_parse("LABEL name='%s', bus='%s', sysfs_file='%s', sysfs_value='%s'",
-                         dev->name, dev->bus, dev->sysfs_file, dev->sysfs_value);
-               break;
-       case NUMBER:
-               dbg_parse("NUMBER name='%s', bus='%s', id='%s'",
-                         dev->name, dev->bus, dev->id);
-               break;
-       case TOPOLOGY:
-               dbg_parse("TOPOLOGY name='%s', bus='%s', place='%s'",
-                         dev->name, dev->bus, dev->place);
-               break;
-       case REPLACE:
-               dbg_parse("REPLACE name=%s, kernel_name=%s",
-                         dev->name, dev->kernel_name);
-               break;
-       case CALLOUT:
-               dbg_parse("CALLOUT name='%s', bus='%s', program='%s', id='%s'",
-                         dev->name, dev->bus, dev->exec_program, dev->id);
-               break;
-       default:
-               dbg_parse("unknown type of method");
-       }
+       dbg_parse("name='%s', symlink='%s', bus='%s', place='%s', id='%s', "
+                 "sysfs_file[0]='%s', sysfs_value[0]='%s', "
+                 "kernel='%s', program='%s', result='%s'",
+                 "owner='%s', group='%s', mode=%#o",
+                 dev->name, dev->symlink, dev->bus, dev->place, dev->id,
+                 dev->sysfs_pair[0].file, dev->sysfs_pair[0].value,
+                 dev->kernel, dev->program, dev->result,
+                 dev->owner, dev->group, dev->mode);
 }
 
 void dump_config_dev_list(void)
 {
-       struct list_head *tmp;
+       struct config_device *dev;
 
-       list_for_each(tmp, &config_device_list) {
-               struct config_device *dev = list_entry(tmp, struct config_device, node);
+       list_for_each_entry(dev, &config_device_list, node)
                dump_config_dev(dev);
+}
+
+static int add_perm_dev(struct perm_device *new_dev)
+{
+       struct perm_device *dev;
+       struct perm_device *tmp_dev;
+
+       /* update the values if we already have the device */
+       list_for_each_entry(dev, &perm_device_list, node) {
+               if (strcmp(new_dev->name, dev->name) != 0)
+                       continue;
+
+               set_empty_perms(dev, new_dev->mode, new_dev->owner, new_dev->group);
+               return 0;
        }
+
+       /* not found, add new structure to the perm list */
+       tmp_dev = malloc(sizeof(*tmp_dev));
+       if (!tmp_dev)
+               return -ENOMEM;
+
+       memcpy(tmp_dev, new_dev, sizeof(*tmp_dev));
+       list_add_tail(&tmp_dev->node, &perm_device_list);
+       //dump_perm_dev(tmp_dev);
+       return 0;
 }
 
 void dump_perm_dev(struct perm_device *dev)
@@ -133,31 +110,59 @@ void dump_perm_dev(struct perm_device *dev)
 
 void dump_perm_dev_list(void)
 {
-       struct list_head *tmp;
+       struct perm_device *dev;
 
-       list_for_each(tmp, &perm_device_list) {
-               struct perm_device *dev = list_entry(tmp, struct perm_device, node);
+       list_for_each_entry(dev, &perm_device_list, node)
                dump_perm_dev(dev);
-       }
 }
 
+/* extract possible KEY{attr} or KEY_attr */
+static char *get_key_attribute(char *str)
+{
+       char *pos;
+       char *attr;
+
+       attr = strchr(str, '{');
+       if (attr != NULL) {
+               attr++;
+               pos = strchr(attr, '}');
+               if (pos == NULL) {
+                       dbg("missing closing brace for format");
+                       return NULL;
+               }
+               pos[0] = '\0';
+               dbg("attribute='%s'", attr);
+               return attr;
+       }
 
-int namedev_init_rules(void)
+       attr = strchr(str, '_');
+       if (attr != NULL) {
+               attr++;
+               dbg("attribute='%s'", attr);
+               return attr;
+       }
+
+       return NULL;
+}
+
+static int namedev_parse_rules(char *filename)
 {
        char line[255];
        int lineno;
        char *temp;
        char *temp2;
        char *temp3;
+       char *attr;
        FILE *fd;
+       int program_given = 0;
        int retval = 0;
        struct config_device dev;
 
-       fd = fopen(udev_rules_filename, "r");
+       fd = fopen(filename, "r");
        if (fd != NULL) {
-               dbg("reading '%s' as rules file", udev_rules_filename);
+               dbg("reading '%s' as rules file", filename);
        } else {
-               dbg("can't open '%s' as a rules file", udev_rules_filename);
+               dbg("can't open '%s' as a rules file", filename);
                return -ENODEV;
        }
 
@@ -169,15 +174,14 @@ int namedev_init_rules(void)
                if (temp == NULL)
                        goto exit;
                lineno++;
-
                dbg_parse("read '%s'", temp);
 
-               /* eat the whitespace at the beginning of the line */
+               /* eat the whitespace */
                while (isspace(*temp))
                        ++temp;
 
                /* empty line? */
-               if (*temp == 0x00)
+               if ((*temp == '\0') || (*temp == '\n'))
                        continue;
 
                /* see if this is a comment */
@@ -186,163 +190,133 @@ int namedev_init_rules(void)
 
                memset(&dev, 0x00, sizeof(struct config_device));
 
-               /* parse the line */
-               temp2 = strsep(&temp, ",");
-               if (strcasecmp(temp2, TYPE_LABEL) == 0) {
-                       /* label type */
-                       dev.type = LABEL;
-
-                       /* BUS="bus" */
-                       retval = get_value("BUS", &temp, &temp3);
-                       if (retval)
-                               break;
-                       strfieldcpy(dev.bus, temp3);
-
-                       /* file="value" */
-                       temp2 = strsep(&temp, ",");
-                       retval = get_pair(&temp, &temp2, &temp3);
+               /* get all known keys */
+               while (1) {
+                       retval = parse_get_pair(&temp, &temp2, &temp3);
                        if (retval)
                                break;
-                       strfieldcpy(dev.sysfs_file, temp2);
-                       strfieldcpy(dev.sysfs_value, temp3);
 
-                       /* NAME="new_name" */
-                       temp2 = strsep(&temp, ",");
-                       retval = get_value("NAME", &temp, &temp3);
-                       if (retval)
-                               break;
-                       strfieldcpy(dev.name, temp3);
-
-                       dbg_parse("LABEL name='%s', bus='%s', "
-                                 "sysfs_file='%s', sysfs_value='%s'",
-                                 dev.name, dev.bus, dev.sysfs_file,
-                                 dev.sysfs_value);
+                       if (strcasecmp(temp2, FIELD_BUS) == 0) {
+                               strfieldcpy(dev.bus, temp3);
+                               continue;
+                       }
+
+                       if (strcasecmp(temp2, FIELD_ID) == 0) {
+                               strfieldcpy(dev.id, temp3);
+                               continue;
+                       }
+
+                       if (strcasecmp(temp2, FIELD_PLACE) == 0) {
+                               strfieldcpy(dev.place, temp3);
+                               continue;
+                       }
+
+                       if (strncasecmp(temp2, FIELD_SYSFS, sizeof(FIELD_SYSFS)-1) == 0) {
+                               struct sysfs_pair *pair = &dev.sysfs_pair[0];
+                               int sysfs_pair_num = 0;
+
+                               /* find first unused pair */
+                               while (pair->file[0] != '\0') {
+                                       ++sysfs_pair_num;
+                                       if (sysfs_pair_num >= MAX_SYSFS_PAIRS) {
+                                               pair = NULL;
+                                               break;
+                                       }
+                                       ++pair;
+                               }
+                               if (pair) {
+                                       attr = get_key_attribute(temp2 + sizeof(FIELD_SYSFS)-1);
+                                       if (attr == NULL) {
+                                               dbg("error parsing " FIELD_SYSFS " attribute");
+                                               continue;
+                                       }
+                                       strfieldcpy(pair->file, attr);
+                                       strfieldcpy(pair->value, temp3);
+                               }
+                               continue;
+                       }
+
+                       if (strcasecmp(temp2, FIELD_KERNEL) == 0) {
+                               strfieldcpy(dev.kernel, temp3);
+                               continue;
+                       }
+
+                       if (strcasecmp(temp2, FIELD_PROGRAM) == 0) {
+                               program_given = 1;
+                               strfieldcpy(dev.program, temp3);
+                               continue;
+                       }
+
+                       if (strcasecmp(temp2, FIELD_RESULT) == 0) {
+                               strfieldcpy(dev.result, temp3);
+                               continue;
+                       }
+
+                       if (strncasecmp(temp2, FIELD_NAME, sizeof(FIELD_NAME)-1) == 0) {
+                               attr = get_key_attribute(temp2 + sizeof(FIELD_NAME)-1);
+                               if (attr != NULL)
+                                       if (strcasecmp(attr, ATTR_PARTITIONS) == 0) {
+                                               dbg_parse("creation of partition nodes requested");
+                                               dev.partitions = PARTITIONS_COUNT;
+                                       }
+                               strfieldcpy(dev.name, temp3);
+                               continue;
+                       }
+
+                       if (strcasecmp(temp2, FIELD_SYMLINK) == 0) {
+                               strfieldcpy(dev.symlink, temp3);
+                               continue;
+                       }
+
+                       if (strcasecmp(temp2, FIELD_OWNER) == 0) {
+                               strfieldcpy(dev.owner, temp3);
+                               continue;
+                       }
+
+                       if (strcasecmp(temp2, FIELD_GROUP) == 0) {
+                               strfieldcpy(dev.group, temp3);
+                               continue;
+                       }
+
+                       if (strcasecmp(temp2, FIELD_MODE) == 0) {
+                               dev.mode = strtol(temp3, NULL, 8);
+                               continue;
+                       }
+
+                       dbg("unknown type of field '%s'", temp2);
+                       goto error;
                }
 
-               if (strcasecmp(temp2, TYPE_NUMBER) == 0) {
-                       /* number type */
-                       dev.type = NUMBER;
-
-                       /* BUS="bus" */
-                       retval = get_value("BUS", &temp, &temp3);
-                       if (retval)
-                               break;
-                       strfieldcpy(dev.bus, temp3);
-
-                       /* ID="id" */
-                       temp2 = strsep(&temp, ",");
-                       retval = get_value("ID", &temp, &temp3);
-                       if (retval)
-                               break;
-                       strfieldcpy(dev.id, temp3);
-
-                       /* NAME="new_name" */
-                       temp2 = strsep(&temp, ",");
-                       retval = get_value("NAME", &temp, &temp3);
-                       if (retval)
-                               break;
-                       strfieldcpy(dev.name, temp3);
-
-                       dbg_parse("NUMBER name='%s', bus='%s', id='%s'",
-                                 dev.name, dev.bus, dev.id);
+               /* simple plausibility checks for given keys */
+               if ((dev.sysfs_pair[0].file[0] == '\0') ^
+                   (dev.sysfs_pair[0].value[0] == '\0')) {
+                       dbg("inconsistency in " FIELD_SYSFS " key");
+                       goto error;
                }
 
-               if (strcasecmp(temp2, TYPE_TOPOLOGY) == 0) {
-                       /* number type */
-                       dev.type = TOPOLOGY;
-
-                       /* BUS="bus" */
-                       retval = get_value("BUS", &temp, &temp3);
-                       if (retval)
-                               break;
-                       strfieldcpy(dev.bus, temp3);
-
-                       /* PLACE="place" */
-                       temp2 = strsep(&temp, ",");
-                       retval = get_value("PLACE", &temp, &temp3);
-                       if (retval)
-                               break;
-                       strfieldcpy(dev.place, temp3);
-
-                       /* NAME="new_name" */
-                       temp2 = strsep(&temp, ",");
-                       retval = get_value("NAME", &temp, &temp3);
-                       if (retval)
-                               break;
-                       strfieldcpy(dev.name, temp3);
-
-                       dbg_parse("TOPOLOGY name='%s', bus='%s', place='%s'",
-                                 dev.name, dev.bus, dev.place);
-               }
-
-               if (strcasecmp(temp2, TYPE_REPLACE) == 0) {
-                       /* number type */
-                       dev.type = REPLACE;
-
-                       /* KERNEL="kernel_name" */
-                       retval = get_value("KERNEL", &temp, &temp3);
-                       if (retval)
-                               break;
-                       strfieldcpy(dev.kernel_name, temp3);
-
-                       /* NAME="new_name" */
-                       temp2 = strsep(&temp, ",");
-                       retval = get_value("NAME", &temp, &temp3);
-                       if (retval)
-                               break;
-                       strfieldcpy(dev.name, temp3);
-                       dbg_parse("REPLACE name='%s', kernel_name='%s'",
-                                 dev.name, dev.kernel_name);
-               }
-               if (strcasecmp(temp2, TYPE_CALLOUT) == 0) {
-                       /* number type */
-                       dev.type = CALLOUT;
-
-                       /* BUS="bus" */
-                       retval = get_value("BUS", &temp, &temp3);
-                       if (retval)
-                               break;
-                       strfieldcpy(dev.bus, temp3);
-
-                       /* PROGRAM="executable" */
-                       temp2 = strsep(&temp, ",");
-                       retval = get_value("PROGRAM", &temp, &temp3);
-                       if (retval)
-                               break;
-                       strfieldcpy(dev.exec_program, temp3);
-
-                       /* ID="id" */
-                       temp2 = strsep(&temp, ",");
-                       retval = get_value("ID", &temp, &temp3);
-                       if (retval)
-                               break;
-                       strfieldcpy(dev.id, temp3);
-
-                       /* NAME="new_name" */
-                       temp2 = strsep(&temp, ",");
-                       retval = get_value("NAME", &temp, &temp3);
-                       if (retval)
-                               break;
-                       strfieldcpy(dev.name, temp3);
-                       dbg_parse("CALLOUT name='%s', program='%s'",
-                                 dev.name, dev.exec_program);
+               if ((dev.result[0] != '\0') && (program_given == 0)) {
+                       dbg(FIELD_RESULT " is only useful when "
+                           FIELD_PROGRAM " is called in any rule before");
+                       goto error;
                }
 
+               dev.config_line = lineno;
+               strfieldcpy(dev.config_file, filename);
                retval = add_config_dev(&dev);
                if (retval) {
                        dbg("add_config_dev returned with error %d", retval);
-                       goto exit;
+                       continue;
+error:
+                       dbg("%s:%d:%d: parse error, rule skipped",
+                           filename, lineno, temp - line);
                }
        }
-       dbg_parse("%s:%d:%Zd: error parsing '%s'", udev_rules_filename,
-                 lineno, temp - line, temp);
 exit:
        fclose(fd);
        return retval;
-}      
-
+}
 
-int namedev_init_permissions(void)
+static int namedev_parse_permissions(char *filename)
 {
        char line[255];
        char *temp;
@@ -351,11 +325,11 @@ int namedev_init_permissions(void)
        int retval = 0;
        struct perm_device dev;
 
-       fd = fopen(udev_permissions_filename, "r");
+       fd = fopen(filename, "r");
        if (fd != NULL) {
-               dbg("reading '%s' as permissions file", udev_permissions_filename);
+               dbg("reading '%s' as permissions file", filename);
        } else {
-               dbg("can't open '%s' as permissions file", udev_permissions_filename);
+               dbg("can't open '%s' as permissions file", filename);
                return -ENODEV;
        }
 
@@ -372,7 +346,7 @@ int namedev_init_permissions(void)
                        ++temp;
 
                /* empty line? */
-               if (*temp == 0x00)
+               if ((*temp == '\0') || (*temp == '\n'))
                        continue;
 
                /* see if this is a comment */
@@ -387,34 +361,34 @@ int namedev_init_permissions(void)
                        dbg("cannot parse line '%s'", line);
                        continue;
                }
-               strncpy(dev.name, temp2, sizeof(dev.name));
+               strfieldcpy(dev.name, temp2);
 
                temp2 = strsep(&temp, ":");
                if (!temp2) {
                        dbg("cannot parse line '%s'", line);
                        continue;
                }
-               strncpy(dev.owner, temp2, sizeof(dev.owner));
+               strfieldcpy(dev.owner, temp2);
 
                temp2 = strsep(&temp, ":");
                if (!temp2) {
                        dbg("cannot parse line '%s'", line);
                        continue;
                }
-               strncpy(dev.group, temp2, sizeof(dev.owner));
+               strfieldcpy(dev.group, temp2);
 
                if (!temp) {
-                       dbg("cannot parse line: %s", line);
+                       dbg("cannot parse line '%s'", line);
                        continue;
                }
                dev.mode = strtol(temp, NULL, 8);
 
                dbg_parse("name='%s', owner='%s', group='%s', mode=%#o",
-                         dev.name, dev.owner, dev.group,
-                         dev.mode);
+                         dev.name, dev.owner, dev.group, dev.mode);
+
                retval = add_perm_dev(&dev);
                if (retval) {
-                       dbg("add_config_dev returned with error %d", retval);
+                       dbg("add_perm_dev returned with error %d", retval);
                        goto exit;
                }
        }
@@ -422,6 +396,90 @@ int namedev_init_permissions(void)
 exit:
        fclose(fd);
        return retval;
-}      
+}
 
+struct files {
+       struct list_head list;
+       char name[NAME_SIZE];
+};
 
+/* sort files in lexical order */
+static int file_list_insert(char *filename)
+{
+       struct files *loop_file;
+       struct files *new_file;
+
+       list_for_each_entry(loop_file, &file_list, list) {
+               if (strcmp(loop_file->name, filename) > 0) {
+                       break;
+               }
+       }
+
+       new_file = malloc(sizeof(struct files));
+       if (new_file == NULL) {
+               dbg("error malloc");
+               return -ENOMEM;
+       }
+
+       strfieldcpy(new_file->name, filename);
+       list_add_tail(&new_file->list, &loop_file->list);
+       return 0;
+}
+
+/* calls function for file or every file found in directory */
+static int call_foreach_file(int parser (char *f) , char *filename, char *extension)
+{
+       struct dirent *ent;
+       DIR *dir;
+       char *ext;
+       char file[NAME_SIZE];
+       struct stat stats;
+       struct files *loop_file;
+       struct files *tmp_file;
+
+       /* look if we have a plain file or a directory to scan */
+       stat(filename, &stats);
+       if ((stats.st_mode & S_IFMT) != S_IFDIR)
+               return parser(filename);
+
+       /* sort matching filename into list */
+       dbg("open config as directory '%s'", filename);
+       dir = opendir(filename);
+       while (1) {
+               ent = readdir(dir);
+               if (ent == NULL || ent->d_name[0] == '\0')
+                       break;
+
+               dbg("found file '%s'", ent->d_name);
+               ext = strrchr(ent->d_name, '.');
+               if (ext == NULL)
+                       continue;
+
+               if (strcmp(ext, extension) == 0) {
+                       dbg("put file in list '%s'", ent->d_name);
+                       file_list_insert(ent->d_name);
+               }
+       }
+
+       /* parse every file in the list */
+       list_for_each_entry_safe(loop_file, tmp_file, &file_list, list) {
+               strfieldcpy(file, filename);
+               strfieldcat(file, loop_file->name);
+               parser(file);
+               list_del(&loop_file->list);
+               free(loop_file);
+       }
+
+       closedir(dir);
+       return 0;
+}
+
+int namedev_init_rules()
+{
+       return call_foreach_file(namedev_parse_rules, udev_rules_filename, RULEFILE_EXT);
+}
+
+int namedev_init_permissions()
+{
+       return call_foreach_file(namedev_parse_permissions, udev_permissions_filename, PERMFILE_EXT);
+}