chiark / gitweb /
[PATCH] udevd: serialization of the event sequence of a chain of devices
[elogind.git] / namedev.c
index 3ab45d4ec6a67c32788b5b35a621a6f43ccaa193..9cfc4283be12b8b4d57df85695ea308d1b1c2818 100644 (file)
--- a/namedev.c
+++ b/namedev.c
 #include <errno.h>
 #include <sys/wait.h>
 #include <sys/stat.h>
-#include <sys/sysinfo.h>
 
 #include "libsysfs/sysfs/libsysfs.h"
 #include "list.h"
 #include "udev.h"
-#include "udev_lib.h"
+#include "udev_utils.h"
 #include "udev_version.h"
 #include "logging.h"
 #include "namedev.h"
@@ -101,7 +100,7 @@ static int strcmp_pattern(const char *p, const char *s)
        return 1;
 }
 
-static struct perm_device *find_perm(char *name)
+static struct perm_device *find_perm_entry(const char *name)
 {
        struct perm_device *perm;
 
@@ -113,32 +112,6 @@ static struct perm_device *find_perm(char *name)
        return NULL;
 }
 
-static mode_t get_default_mode(void)
-{
-       mode_t mode = 0600;     /* default to owner rw only */
-
-       if (strlen(default_mode_str) != 0)
-               mode = strtol(default_mode_str, NULL, 8);
-
-       return mode;
-}
-
-static char *get_default_owner(void)
-{
-       if (strlen(default_owner_str) == 0)
-               strfieldcpy(default_owner_str, "root");
-
-       return default_owner_str;
-}
-
-static char *get_default_group(void)
-{
-       if (strlen(default_group_str) == 0)
-               strfieldcpy(default_group_str, "root");
-
-       return default_group_str;
-}
-
 /* extract possible {attr} and move str behind it */
 static char *get_format_attribute(char **str)
 {
@@ -586,7 +559,8 @@ static int match_place(struct config_device *dev, struct sysfs_class_device *cla
        return 0;
 }
 
-static int match_rule(struct config_device *dev, struct sysfs_class_device *class_dev, struct udevice *udev, struct sysfs_device *sysfs_device)
+static int match_rule(struct udevice *udev, struct config_device *dev,
+                     struct sysfs_class_device *class_dev, struct sysfs_device *sysfs_device)
 {
        while (1) {
                /* check for matching bus value */
@@ -595,7 +569,8 @@ static int match_rule(struct config_device *dev, struct sysfs_class_device *clas
                                dbg("device has no bus");
                                goto try_parent;
                        }
-                       dbg("check for " FIELD_BUS " dev->bus='%s' sysfs_device->bus='%s'", dev->bus, sysfs_device->bus);
+                       dbg("check for " FIELD_BUS " dev->bus='%s' sysfs_device->bus='%s'",
+                           dev->bus, sysfs_device->bus);
                        if (strcmp_pattern(dev->bus, sysfs_device->bus) != 0) {
                                dbg(FIELD_BUS " is not matching");
                                goto try_parent;
@@ -604,9 +579,10 @@ static int match_rule(struct config_device *dev, struct sysfs_class_device *clas
                        }
                }
 
-               /* check for matching kernel name*/
+               /* check for matching kernel name */
                if (dev->kernel[0] != '\0') {
-                       dbg("check for " FIELD_KERNEL " dev->kernel='%s' class_dev->name='%s'", dev->kernel, class_dev->name);
+                       dbg("check for " FIELD_KERNEL " dev->kernel='%s' class_dev->name='%s'",
+                           dev->kernel, class_dev->name);
                        if (strcmp_pattern(dev->kernel, class_dev->name) != 0) {
                                dbg(FIELD_KERNEL " is not matching");
                                goto try_parent;
@@ -615,6 +591,30 @@ static int match_rule(struct config_device *dev, struct sysfs_class_device *clas
                        }
                }
 
+               /* check for matching subsystem */
+               if (dev->subsystem[0] != '\0') {
+                       dbg("check for " FIELD_SUBSYSTEM " dev->subsystem='%s' class_dev->name='%s'",
+                           dev->subsystem, class_dev->name);
+                       if (strcmp_pattern(dev->subsystem, udev->subsystem) != 0) {
+                               dbg(FIELD_SUBSYSTEM " is not matching");
+                               goto try_parent;
+                       } else {
+                               dbg(FIELD_SUBSYSTEM " matches");
+                       }
+               }
+
+               /* check for matching driver */
+               if (dev->driver[0] != '\0') {
+                       dbg("check for " FIELD_DRIVER " dev->driver='%s' sysfs_device->driver_name='%s'",
+                           dev->driver, sysfs_device->driver_name);
+                       if (strcmp_pattern(dev->driver, sysfs_device->driver_name) != 0) {
+                               dbg(FIELD_DRIVER " is not matching");
+                               goto try_parent;
+                       } else {
+                               dbg(FIELD_DRIVER " matches");
+                       }
+               }
+
                /* check for matching bus id */
                if (dev->id[0] != '\0') {
                        dbg("check " FIELD_ID);
@@ -665,8 +665,7 @@ static int match_rule(struct config_device *dev, struct sysfs_class_device *clas
 
                /* check for matching result of external program */
                if (dev->result[0] != '\0') {
-                       dbg("check for " FIELD_RESULT
-                           " dev->result='%s', udev->program_result='%s'",
+                       dbg("check for " FIELD_RESULT " dev->result='%s', udev->program_result='%s'",
                            dev->result, udev->program_result);
                        if (strcmp_pattern(dev->result, udev->program_result) != 0) {
                                dbg(FIELD_RESULT " is not matching");
@@ -686,7 +685,6 @@ try_parent:
                        return -ENODEV;
                dbg("sysfs_device->path='%s'", sysfs_device->path);
                dbg("sysfs_device->bus_id='%s'", sysfs_device->bus_id);
-               dbg("sysfs_device->bus='%s'", sysfs_device->bus);
        }
 
 }
@@ -697,7 +695,6 @@ int namedev_name_device(struct udevice *udev, struct sysfs_class_device *class_d
        struct sysfs_device *sysfs_device = NULL;
        struct config_device *dev;
        struct perm_device *perm;
-       struct sysinfo info;
        char *pos;
 
        udev->mode = 0;
@@ -720,7 +717,6 @@ int namedev_name_device(struct udevice *udev, struct sysfs_class_device *class_d
                dbg("found devices device: path='%s', bus_id='%s', bus='%s'",
                    sysfs_device->path, sysfs_device->bus_id, sysfs_device->bus);
                strfieldcpy(udev->bus_id, sysfs_device->bus_id);
-               strfieldcpy(udev->bus, sysfs_device->bus);
        }
 
        strfieldcpy(udev->kernel_name, class_dev->name);
@@ -737,13 +733,15 @@ int namedev_name_device(struct udevice *udev, struct sysfs_class_device *class_d
        /* look for a matching rule to apply */
        list_for_each_entry(dev, &config_device_list, node) {
                dbg("process rule");
-               if (match_rule(dev, class_dev, udev, sysfs_device) == 0) {
+               if (match_rule(udev, dev, class_dev, sysfs_device) == 0) {
+                       /* empty name and symlink will not create any node */
                        if (dev->name[0] == '\0' && dev->symlink[0] == '\0') {
                                info("configured rule in '%s' at line %i applied, '%s' is ignored",
                                     dev->config_file, dev->config_line, udev->kernel_name);
                                return -1;
                        }
 
+                       /* collect symlinks for the final matching rule */
                        if (dev->symlink[0] != '\0') {
                                char temp[NAME_SIZE];
 
@@ -756,6 +754,7 @@ int namedev_name_device(struct udevice *udev, struct sysfs_class_device *class_d
                                strfieldcat(udev->symlink, temp);
                        }
 
+                       /* rule matches */
                        if (dev->name[0] != '\0') {
                                /* apply all_partitions flag only at a main block device */
                                if (dev->partitions > 0 &&
@@ -764,53 +763,58 @@ int namedev_name_device(struct udevice *udev, struct sysfs_class_device *class_d
 
                                info("configured rule in '%s' at line %i applied, '%s' becomes '%s'",
                                     dev->config_file, dev->config_line, udev->kernel_name, dev->name);
+
                                strfieldcpy(udev->name, dev->name);
-                               goto found;
+                               apply_format(udev, udev->name, sizeof(udev->name), class_dev, sysfs_device);
+                               strfieldcpy(udev->config_file, dev->config_file);
+                               udev->config_line = dev->config_line;
+                               udev->ignore_remove = dev->ignore_remove;
+
+                               if (udev->type == 'n')
+                                       goto exit;
+
+                               udev->partitions = dev->partitions;
+                               udev->mode = dev->mode;
+                               strfieldcpy(udev->owner, dev->owner);
+                               apply_format(udev, udev->owner, sizeof(udev->owner), class_dev, sysfs_device);
+                               strfieldcpy(udev->group, dev->group);
+                               apply_format(udev, udev->group, sizeof(udev->group), class_dev, sysfs_device);
+
+                               goto perms;
                        }
                }
        }
-       /* no rule was found so we use the kernel name */
-       strfieldcpy(udev->name, udev->kernel_name);
-       if (udev->type == 'n')
-               goto done;
-       else
-               goto perms;
 
-found:
-       apply_format(udev, udev->name, sizeof(udev->name), class_dev, sysfs_device);
-       strfieldcpy(udev->config_file, dev->config_file);
-       udev->config_line = dev->config_line;
+       /* no rule matched, so we use the kernel name */
+       strfieldcpy(udev->name, udev->kernel_name);
 
        if (udev->type == 'n')
-               goto done;
-
-       udev->partitions = dev->partitions;
-
-       /* get permissions given in rule */
-       set_empty_perms(udev, dev->mode,
-                             dev->owner,
-                             dev->group);
+               goto exit;
 
 perms:
-       /* get permissions given in config file or set defaults */
-       perm = find_perm(udev->name);
+       /* apply permissions from permissions file to empty fields */
+       perm = find_perm_entry(udev->name);
        if (perm != NULL) {
-               set_empty_perms(udev, perm->mode,
-                                     perm->owner,
-                                     perm->group);
+               if (udev->mode == 0000)
+                       udev->mode = perm->mode;
+               if (udev->owner[0] == '\0')
+                       strfieldcpy(udev->owner, perm->owner);
+               if (udev->group[0] == '\0')
+                       strfieldcpy(udev->group, perm->group);
        }
-       set_empty_perms(udev, get_default_mode(),
-                             get_default_owner(),
-                             get_default_group());
+
+       /* apply permissions from config to empty fields */
+       if (udev->mode == 0000)
+               udev->mode = default_mode;
+       if (udev->owner[0] == '\0')
+               strfieldcpy(udev->owner, default_owner);
+       if (udev->group[0] == '\0')
+               strfieldcpy(udev->group, default_group);
 
        dbg("name, '%s' is going to have owner='%s', group='%s', mode = %#o",
            udev->name, udev->owner, udev->group, udev->mode);
 
-done:
-       /* store time of action */
-       sysinfo(&info);
-       udev->config_uptime = info.uptime;
-
+exit:
        return 0;
 }