chiark / gitweb /
[PATCH] improve klibc fixup integration
[elogind.git] / namedev.c
index 8f781a66e26c60fd7e76cbf0d295b8eb72f91ed0..80d5f1a499be4c631c5bf6c9f80ce5d441bd70af 100644 (file)
--- a/namedev.c
+++ b/namedev.c
@@ -29,9 +29,9 @@
 #include <ctype.h>
 #include <unistd.h>
 #include <errno.h>
-#include <time.h>
 #include <sys/wait.h>
 #include <sys/stat.h>
+#include <sys/sysinfo.h>
 
 #include "libsysfs/sysfs/libsysfs.h"
 #include "list.h"
@@ -40,7 +40,7 @@
 #include "udev_version.h"
 #include "logging.h"
 #include "namedev.h"
-#include "klibc_fixups.h"
+#include "udevdb.h"
 
 static struct sysfs_attribute *find_sysfs_attribute(struct sysfs_class_device *class_dev, struct sysfs_device *sysfs_device, char *attr);
 
@@ -178,6 +178,37 @@ static int get_format_len(char **str)
        return -1;
 }
 
+/** Finds the lowest positive N such that <name>N isn't present in 
+ *  $(udevroot) either as a file or a symlink.
+ *
+ *  @param  name                Name to check for
+ *  @return                     0 if <name> didn't exist and N otherwise.
+ */
+static unsigned int find_free_number (struct udevice *udev, char *name)
+{
+       char temp[NAME_SIZE];
+       char path[NAME_SIZE];
+       struct udevice dev;
+       int result;
+
+       /* have to sweep the database for each lookup */
+       result = 0;
+       strncpy(temp, name, sizeof (temp));
+       while (1) {
+               if (udevdb_get_dev_byname(temp, path, &dev) != 0)
+                       goto found;
+               /* symlink might be stale if $(udevroot) isn't cleaned; check
+                * on major/minor to see if it's the same device
+                */
+               if (dev.major == udev->major && dev.minor == udev->minor)
+                       goto found;
+               snprintf (temp, sizeof(temp), "%s%d", name, ++result);
+       }
+
+found:
+       return result;
+}
+
 static void apply_format(struct udevice *udev, char *string, size_t maxsize,
                         struct sysfs_class_device *class_dev,
                         struct sysfs_device *sysfs_device)
@@ -194,25 +225,24 @@ static void apply_format(struct udevice *udev, char *string, size_t maxsize,
        char *rest;
        int slen;
        struct sysfs_attribute *tmpattr;
+       unsigned int next_free_number;
 
        pos = string;
-
        while (1) {
-               pos = strchr(string, '%');
-               if (pos != NULL) {
-                       pos[0] = '\0';
-                       tail = pos+1;
-                       len = get_format_len(&tail);
-                       c = tail[0];
-                       strfieldcpy(temp, tail+1);
-                       tail = temp;
-               } else {
+               pos = strchr(pos, '%');
+               if (pos == NULL)
                        break;
-               }
-               dbg("format=%c, string='%s', tail='%s'",c , string, tail);
 
+               pos[0] = '\0';
+               tail = pos+1;
+               len = get_format_len(&tail);
+               c = tail[0];
+               strfieldcpy(temp, tail+1);
+               tail = temp;
+               dbg("format=%c, string='%s', tail='%s'",c , string, tail);
                attr = get_format_attribute(&tail);
 
+
                switch (c) {
                case 'b':
                        if (strlen(udev->bus_id) == 0)
@@ -275,6 +305,17 @@ static void apply_format(struct udevice *udev, char *string, size_t maxsize,
                                        dbg("sysfa attribute '%s' not found", attr);
                                        break;
                                }
+                               /* strip trailing whitespace of matching value */
+                               if (isspace(tmpattr->value[strlen(tmpattr->value)-1])) {
+                                       i = len = strlen(tmpattr->value);
+                                       while (i > 0 &&  isspace(tmpattr->value[i-1]))
+                                               i--;
+                                       if (i < len) {
+                                               tmpattr->value[i] = '\0';
+                                               dbg("remove %i trailing whitespace chars from '%s'",
+                                                        len - i, tmpattr->value);
+                                       }
+                               }
                                strfieldcatmax(string, tmpattr->value, maxsize);
                                dbg("substitute sysfs value '%s'", tmpattr->value);
                        } else {
@@ -283,6 +324,14 @@ static void apply_format(struct udevice *udev, char *string, size_t maxsize,
                        break;
                case '%':
                        strfieldcatmax(string, "%", maxsize);
+                       pos++;
+                       break;
+               case 'e':
+                       next_free_number = find_free_number(udev, string);
+                       if (next_free_number > 0) {
+                               snprintf(temp2, sizeof(temp2), "%d", next_free_number);
+                               strfieldcatmax(string, temp2, maxsize);
+                       }
                        break;
                default:
                        dbg("unknown substitution type '%%%c'", c);
@@ -296,69 +345,6 @@ static void apply_format(struct udevice *udev, char *string, size_t maxsize,
        }
 }
 
-/* 
- * Note, we can have multiple files for different busses in here due
- * to the mess that USB has for its device tree...
- */
-static struct bus_file {
-       char *bus;
-       char *file;
-} bus_files[] = {
-       { .bus = "scsi",        .file = "vendor" },
-       { .bus = "usb",         .file = "idVendor" },
-       { .bus = "usb",         .file = "iInterface" },
-       { .bus = "usb-serial",  .file = "detach_state" },
-       { .bus = "ide",         .file = "detach_state" },
-       { .bus = "pci",         .file = "vendor" },
-       {}
-};
-
-#define SECONDS_TO_WAIT_FOR_FILE       10
-static void wait_for_device_to_initialize(struct sysfs_device *sysfs_device)
-{
-       /* sleep until we see the file for this specific bus type show up this
-        * is needed because we can easily out-run the kernel in looking for
-        * these files before the paticular subsystem has created them in the
-        * sysfs tree properly.
-        *
-        * And people thought that the /sbin/hotplug event system was going to
-        * be slow, poo on you for arguing that before even testing it...
-        */
-       struct bus_file *b = &bus_files[0];
-       struct sysfs_attribute *tmpattr;
-       int found = 0;
-       int loop = SECONDS_TO_WAIT_FOR_FILE;
-
-       while (1) {
-               if (b->bus == NULL) {
-                       if (!found)
-                               break;
-                       /* sleep to give the kernel a chance to create the file */
-                       sleep(1);
-                       --loop;
-                       if (loop == 0)
-                               break;
-                       b = &bus_files[0];
-               }
-               if (strcmp(sysfs_device->bus, b->bus) == 0) {
-                       found = 1;
-                       dbg("looking for file '%s' on bus '%s'", b->file, b->bus);
-                       tmpattr = sysfs_get_device_attr(sysfs_device, b->file);
-                       if (tmpattr) {
-                               /* found it! */
-                               goto exit;
-                       }
-                       dbg("can't find '%s' file", b->file);
-               }
-               ++b;
-       }
-       if (!found)
-               dbg("did not find bus type '%s' on list of bus_id_files, "
-                   "contact greg@kroah.com", sysfs_device->bus);
-exit:
-       return; /* here to prevent compiler warning... */
-}
-
 static void fix_kernel_name(struct udevice *udev)
 {
        char *temp = udev->kernel_name;
@@ -372,7 +358,7 @@ static void fix_kernel_name(struct udevice *udev)
        }
 }
 
-static int execute_program(char *path, char *value, int len)
+static int execute_program(const char *path, char *value, int len)
 {
        int retval;
        int count;
@@ -381,28 +367,34 @@ static int execute_program(char *path, char *value, int len)
        pid_t pid;
        char *pos;
        char arg[PROGRAM_SIZE];
-       char *argv[sizeof(arg) / 2];
+       char *argv[(PROGRAM_SIZE / 2) + 1];
        int i;
 
+       strfieldcpy(arg, path);
        i = 0;
        if (strchr(path, ' ')) {
-               strfieldcpy(arg, path);
                pos = arg;
                while (pos != NULL) {
                        if (pos[0] == '\'') {
                                /* don't separate if in apostrophes */
                                pos++;
                                argv[i] = strsep(&pos, "\'");
-                               while (pos[0] == ' ')
+                               while (pos && pos[0] == ' ')
                                        pos++;
-               } else {
+                       } else {
                                argv[i] = strsep(&pos, " ");
                        }
                        dbg("arg[%i] '%s'", i, argv[i]);
                        i++;
                }
+               argv[i] =  NULL;
+               dbg("execute '%s' with parsed arguments", arg);
+       } else {
+               argv[0] = arg;
+               argv[1] = main_argv[1];
+               argv[2] = NULL;
+               dbg("execute '%s' with subsystem '%s' argument", arg, argv[1]);
        }
-       argv[i] =  NULL;
 
        retval = pipe(fds);
        if (retval != 0) {
@@ -414,17 +406,9 @@ static int execute_program(char *path, char *value, int len)
        switch(pid) {
        case 0:
                /* child */
-               close(STDOUT_FILENO);
-
-               /* dup write side of pipe to STDOUT */
-               dup(fds[1]);
-               if (argv[0] !=  NULL) {
-                       dbg("execute '%s' with given arguments", argv[0]);
-                       retval = execv(argv[0], argv);
-               } else {
-                       dbg("execute '%s' with main argument", path);
-                       retval = execv(path, main_argv);
-               }
+               /* dup2 write side of pipe to STDOUT */
+               dup2(fds[1], STDOUT_FILENO);
+               retval = execv(arg, argv);
 
                info(FIELD_PROGRAM " execution of '%s' failed", path);
                exit(1);
@@ -454,7 +438,7 @@ static int execute_program(char *path, char *value, int len)
                        retval = -1;
                }
 
-               if (i > 0 && value[i] == '\n')
+               if (i > 0 && value[i-1] == '\n')
                        i--;
                value[i] = '\0';
                dbg("result is '%s'", value);
@@ -602,75 +586,6 @@ static int match_place(struct config_device *dev, struct sysfs_class_device *cla
        return 0;
 }
 
-static struct sysfs_device *get_sysfs_device(struct sysfs_class_device *class_dev)
-{
-       struct sysfs_device *sysfs_device;
-       struct sysfs_class_device *class_dev_parent;
-       struct timespec tspec;
-       int loop;
-
-       /* Figure out where the device symlink is at.  For char devices this will
-        * always be in the class_dev->path.  But for block devices, it's different.
-        * The main block device will have the device symlink in it's path, but
-        * all partitions have the symlink in its parent directory.
-        * But we need to watch out for block devices that do not have parents, yet
-        * look like a partition (fd0, loop0, etc.)  They all do not have a device
-        * symlink yet.  We do sit and spin on waiting for them right now, we should
-        * possibly have a whitelist for these devices here...
-        */
-       class_dev_parent = sysfs_get_classdev_parent(class_dev);
-       if (class_dev_parent) 
-               dbg("Really a partition");
-
-       tspec.tv_sec = 0;
-       tspec.tv_nsec = 10000000;  /* sleep 10 millisec */
-       loop = 10;
-       while (loop--) {
-               if (udev_sleep)
-                       nanosleep(&tspec, NULL);
-               if (class_dev_parent)
-                       sysfs_device = sysfs_get_classdev_device(class_dev_parent);
-               else
-                       sysfs_device = sysfs_get_classdev_device(class_dev);
-
-               if (sysfs_device != NULL)
-                       goto device_found;
-       }
-       dbg("timed out waiting for device symlink, continuing on anyway...");
-       
-device_found:
-        /* We have another issue with just the wait above - the sysfs part of
-        * the kernel may not be quick enough to have created the link to the
-        * device under the "bus" subsystem. Due to this, the sysfs_device->bus
-        * will not contain the actual bus name :(
-        *
-        * Libsysfs now provides a new API sysfs_get_device_bus(), so use it
-        * if needed
-        */
-        if (sysfs_device) {
-               if (sysfs_device->bus[0] != '\0')
-                       goto bus_found;
-
-               loop = 10;
-               tspec.tv_nsec = 10000000;
-               while (loop--) {
-                       if (udev_sleep)
-                               nanosleep(&tspec, NULL);
-                       sysfs_get_device_bus(sysfs_device);
-                       
-                       if (sysfs_device->bus[0] != '\0')
-                               goto bus_found;
-               }
-               dbg("timed out waiting to find the device bus, continuing on anyway");
-               goto exit;
-bus_found:
-               dbg("device %s is registered with bus '%s'",
-                               sysfs_device->name, sysfs_device->bus);
-       }
-exit:
-       return sysfs_device;
-}
-
 static int match_rule(struct config_device *dev, struct sysfs_class_device *class_dev, struct udevice *udev, struct sysfs_device *sysfs_device)
 {
        while (1) {
@@ -735,10 +650,12 @@ static int match_rule(struct config_device *dev, struct sysfs_class_device *clas
 
                /* execute external program */
                if (dev->program[0] != '\0') {
+                       char program[PROGRAM_SIZE];
+
                        dbg("check " FIELD_PROGRAM);
-                       apply_format(udev, dev->program, sizeof(dev->program),
-                                    class_dev, sysfs_device);
-                       if (execute_program(dev->program, udev->program_result, NAME_SIZE) != 0) {
+                       strfieldcpy(program, dev->program);
+                       apply_format(udev, program, sizeof(program), class_dev, sysfs_device);
+                       if (execute_program(program, udev->program_result, NAME_SIZE) != 0) {
                                dbg(FIELD_PROGRAM " returned nonzero");
                                goto try_parent;
                        } else {
@@ -774,25 +691,37 @@ try_parent:
 
 }
 
-int namedev_name_device(struct sysfs_class_device *class_dev, struct udevice *udev)
+int namedev_name_device(struct udevice *udev, struct sysfs_class_device *class_dev)
 {
+       struct sysfs_class_device *class_dev_parent;
        struct sysfs_device *sysfs_device = NULL;
        struct config_device *dev;
        struct perm_device *perm;
+       struct sysinfo info;
        char *pos;
 
        udev->mode = 0;
+       dbg("class_dev->name='%s'", class_dev->name);
+
+       /* Figure out where the "device"-symlink is at.  For char devices this will
+        * always be in the class_dev->path.  On block devices, only the main block
+        * device will have the device symlink in it's path. All partition devices
+        * need to look at the symlink in its parent directory.
+        */
+       class_dev_parent = sysfs_get_classdev_parent(class_dev);
+       if (class_dev_parent != NULL) {
+               dbg("given class device has a parent, use this instead");
+               sysfs_device = sysfs_get_classdev_device(class_dev_parent);
+       } else {
+               sysfs_device = sysfs_get_classdev_device(class_dev);
+       }
 
-       /* find the sysfs_device associated with this class device */
-       sysfs_device = get_sysfs_device(class_dev);
        if (sysfs_device) {
-               dbg("sysfs_device->path='%s'", sysfs_device->path);
-               dbg("sysfs_device->bus_id='%s'", sysfs_device->bus_id);
-               dbg("sysfs_device->bus='%s'", sysfs_device->bus);
+               dbg("found devices device: path='%s', bus_id='%s', bus='%s'",
+                   sysfs_device->path, sysfs_device->bus_id, sysfs_device->bus);
                strfieldcpy(udev->bus_id, sysfs_device->bus_id);
-               wait_for_device_to_initialize(sysfs_device);
+               strfieldcpy(udev->bus, sysfs_device->bus);
        }
-       dbg("class_dev->name = '%s'", class_dev->name);
 
        strfieldcpy(udev->kernel_name, class_dev->name);
        fix_kernel_name(udev);
@@ -816,14 +745,23 @@ int namedev_name_device(struct sysfs_class_device *class_dev, struct udevice *ud
                        }
 
                        if (dev->symlink[0] != '\0') {
+                               char temp[NAME_SIZE];
+
                                info("configured rule in '%s' at line %i applied, added symlink '%s'",
                                     dev->config_file, dev->config_line, dev->symlink);
+                               strfieldcpy(temp, dev->symlink);
+                               apply_format(udev, temp, sizeof(temp), class_dev, sysfs_device);
                                if (udev->symlink[0] != '\0')
                                        strfieldcat(udev->symlink, " ");
-                               strfieldcat(udev->symlink, dev->symlink);
+                               strfieldcat(udev->symlink, temp);
                        }
 
                        if (dev->name[0] != '\0') {
+                               /* apply all_partitions flag only at a main block device */
+                               if (dev->partitions > 0 &&
+                                   (udev->type != 'b' || udev->kernel_number[0] != '\0'))
+                                       continue;
+
                                info("configured rule in '%s' at line %i applied, '%s' becomes '%s'",
                                     dev->config_file, dev->config_line, udev->kernel_name, dev->name);
                                strfieldcpy(udev->name, dev->name);
@@ -831,22 +769,29 @@ int namedev_name_device(struct sysfs_class_device *class_dev, struct udevice *ud
                        }
                }
        }
-
        /* no rule was found so we use the kernel name */
        strfieldcpy(udev->name, udev->kernel_name);
-       goto done;
+       if (udev->type == 'n')
+               goto done;
+       else
+               goto perms;
 
 found:
        apply_format(udev, udev->name, sizeof(udev->name), class_dev, sysfs_device);
-       apply_format(udev, udev->symlink, sizeof(udev->symlink), class_dev, sysfs_device);
+       strfieldcpy(udev->config_file, dev->config_file);
+       udev->config_line = dev->config_line;
+
+       if (udev->type == 'n')
+               goto done;
+
        udev->partitions = dev->partitions;
 
-done:
        /* get permissions given in rule */
        set_empty_perms(udev, dev->mode,
                              dev->owner,
                              dev->group);
 
+perms:
        /* get permissions given in config file or set defaults */
        perm = find_perm(udev->name);
        if (perm != NULL) {
@@ -862,6 +807,11 @@ done:
        dbg("name, '%s' is going to have owner='%s', group='%s', mode = %#o",
            udev->name, udev->owner, udev->group, udev->mode);
 
+done:
+       /* store time of action */
+       sysinfo(&info);
+       udev->config_uptime = info.uptime;
+
        return 0;
 }