chiark / gitweb /
[PATCH] fix up segfaulting binaries with new klibc
[elogind.git] / namedev.c
index a5c711bdf65dd282d95ca56f74d5bca7f9856ab9..49f9e4b1f48e30f21068179162d7b1015944eaed 100644 (file)
--- a/namedev.c
+++ b/namedev.c
@@ -144,15 +144,14 @@ static int get_format_len(char **str)
  */
 static int find_free_number(struct udevice *udev, const char *name)
 {
+       char devpath[NAME_SIZE];
        char filename[NAME_SIZE];
        int num = 0;
-       struct udevice db_udev;
 
        strfieldcpy(filename, name);
        while (1) {
                dbg("look for existing node '%s'", filename);
-               memset(&db_udev, 0x00, sizeof(struct udevice));
-               if (udev_db_get_device_byname(&db_udev, filename) != 0) {
+               if (udev_db_search_name(devpath, DEVPATH_SIZE, filename) != 0) {
                        dbg("free num=%d", num);
                        return num;
                }
@@ -168,20 +167,14 @@ static int find_free_number(struct udevice *udev, const char *name)
 }
 
 static void apply_format(struct udevice *udev, char *string, size_t maxsize,
-                        struct sysfs_class_device *class_dev,
-                        struct sysfs_device *sysfs_device)
+                        struct sysfs_class_device *class_dev, struct sysfs_device *sysfs_device)
 {
        char temp[NAME_SIZE];
        char temp2[NAME_SIZE];
-       char *tail;
-       char *pos;
-       char *attr;
+       char *tail, *pos, *cpos, *attr, *rest;
        int len;
        int i;
        char c;
-       char *spos;
-       char *rest;
-       int slen;
        struct sysfs_attribute *tmpattr;
        unsigned int next_free_number;
        struct sysfs_class_device *class_dev_parent;
@@ -201,61 +194,60 @@ static void apply_format(struct udevice *udev, char *string, size_t maxsize,
                dbg("format=%c, string='%s', tail='%s'",c , string, tail);
                attr = get_format_attribute(&tail);
 
-
                switch (c) {
                case 'p':
-                       if (strlen(udev->devpath) == 0)
-                               break;
                        strfieldcatmax(string, udev->devpath, maxsize);
                        dbg("substitute kernel name '%s'", udev->kernel_name);
                        break;
                case 'b':
-                       if (strlen(udev->bus_id) == 0)
-                               break;
                        strfieldcatmax(string, udev->bus_id, maxsize);
                        dbg("substitute bus_id '%s'", udev->bus_id);
                        break;
                case 'k':
-                       if (strlen(udev->kernel_name) == 0)
-                               break;
                        strfieldcatmax(string, udev->kernel_name, maxsize);
                        dbg("substitute kernel name '%s'", udev->kernel_name);
                        break;
                case 'n':
-                       if (strlen(udev->kernel_number) == 0)
-                               break;
                        strfieldcatmax(string, udev->kernel_number, maxsize);
                        dbg("substitute kernel number '%s'", udev->kernel_number);
                                break;
                case 'm':
-                       strintcatmax(string, minor(udev->devt), maxsize);
-                       dbg("substitute minor number '%u'", minor(udev->devt));
+                       sprintf(temp2, "%d", minor(udev->devt));
+                       strfieldcatmax(string, temp2, maxsize);
+                       dbg("substitute minor number '%s'", temp2);
                        break;
                case 'M':
-                       strintcatmax(string, major(udev->devt), maxsize);
-                       dbg("substitute major number '%u'", major(udev->devt));
+                       sprintf(temp2, "%d", major(udev->devt));
+                       strfieldcatmax(string, temp2, maxsize);
+                       dbg("substitute major number '%s'", temp2);
                        break;
                case 'c':
-                       if (strlen(udev->program_result) == 0)
+                       if (udev->program_result[0] == '\0')
                                break;
                        /* get part part of the result string */
                        i = 0;
                        if (attr != NULL)
                                i = strtoul(attr, &rest, 10);
                        if (i > 0) {
-                               foreach_strpart(udev->program_result, " \n\r", spos, slen) {
-                                       i--;
-                                       if (i == 0)
-                                               break;
+                               dbg("request part #%d of result string", i);
+                               cpos = udev->program_result;
+                               while (--i) {
+                                       while (cpos[0] != '\0' && !isspace(cpos[0]))
+                                               cpos++;
+                                       while (isspace(cpos[0]))
+                                               cpos++;
                                }
                                if (i > 0) {
                                        dbg("requested part of result string not found");
                                        break;
                                }
-                               if (rest[0] == '+')
-                                       strfieldcpy(temp2, spos);
-                               else
-                                       strfieldcpymax(temp2, spos, slen+1);
+                               strfieldcpy(temp2, cpos);
+                               /* %{2+}c copies the whole string from the second part on */
+                               if (rest[0] != '+') {
+                                       cpos = strchr(temp2, ' ');
+                                       if (cpos)
+                                               cpos[0] = '\0';
+                               }
                                strfieldcatmax(string, temp2, maxsize);
                                dbg("substitute part of result string '%s'", temp2);
                        } else {
@@ -308,13 +300,14 @@ static void apply_format(struct udevice *udev, char *string, size_t maxsize,
                                struct udevice udev_parent;
 
                                dbg("found parent '%s', get the node name", class_dev_parent->path);
-                               memset(&udev_parent, 0x00, sizeof(struct udevice));
+                               udev_init_device(&udev_parent, NULL, NULL);
                                /* lookup the name in the udev_db with the DEVPATH of the parent */
-                               if (udev_db_get_device_by_devpath(&udev_parent, &class_dev_parent->path[strlen(sysfs_path)]) == 0) {
+                               if (udev_db_get_device(&udev_parent, &class_dev_parent->path[strlen(sysfs_path)]) == 0) {
                                        strfieldcatmax(string, udev_parent.name, maxsize);
                                        dbg("substitute parent node name'%s'", udev_parent.name);
                                } else
                                        dbg("parent not found in database");
+                               udev_cleanup_device(&udev_parent);
                        }
                        break;
                case 'N':
@@ -343,19 +336,6 @@ static void apply_format(struct udevice *udev, char *string, size_t maxsize,
        }
 }
 
-static void fix_kernel_name(struct udevice *udev)
-{
-       char *temp = udev->kernel_name;
-
-       while (*temp != 0x00) {
-               /* Some block devices have a ! in their name, 
-                * we need to change that to / */
-               if (*temp == '!')
-                       *temp = '/';
-               ++temp;
-       }
-}
-
 static int execute_program(struct udevice *udev, const char *path, char *value, int len)
 {
        int retval;
@@ -549,8 +529,8 @@ static int match_id(struct config_device *dev, struct sysfs_class_device *class_
        dbg("search '%s' in '%s', path='%s'", dev->id, temp, path);
        if (strcmp_pattern(dev->id, temp) != 0)
                return -ENODEV;
-       else
-               return 0;
+
+       return 0;
 }
 
 static int match_place(struct config_device *dev, struct sysfs_class_device *class_dev, struct sysfs_device *sysfs_device)
@@ -582,7 +562,6 @@ static int match_place(struct config_device *dev, struct sysfs_class_device *cla
 static int match_rule(struct udevice *udev, struct config_device *dev,
                      struct sysfs_class_device *class_dev, struct sysfs_device *sysfs_device)
 {
-       /* check for matching kernel name */
        if (dev->kernel[0] != '\0') {
                dbg("check for " FIELD_KERNEL " dev->kernel='%s' class_dev->name='%s'",
                    dev->kernel, class_dev->name);
@@ -593,7 +572,6 @@ static int match_rule(struct udevice *udev, struct config_device *dev,
                dbg(FIELD_KERNEL " matches");
        }
 
-       /* check for matching subsystem */
        if (dev->subsystem[0] != '\0') {
                dbg("check for " FIELD_SUBSYSTEM " dev->subsystem='%s' class_dev->name='%s'",
                    dev->subsystem, class_dev->name);
@@ -710,7 +688,6 @@ int namedev_name_device(struct udevice *udev, struct sysfs_class_device *class_d
        struct sysfs_class_device *class_dev_parent;
        struct sysfs_device *sysfs_device = NULL;
        struct config_device *dev;
-       char *pos;
 
        dbg("class_dev->name='%s'", class_dev->name);
 
@@ -733,16 +710,7 @@ int namedev_name_device(struct udevice *udev, struct sysfs_class_device *class_d
                strfieldcpy(udev->bus_id, sysfs_device->bus_id);
        }
 
-       strfieldcpy(udev->kernel_name, class_dev->name);
-       fix_kernel_name(udev);
-       dbg("udev->kernel_name = '%s'", udev->kernel_name);
-
-       /* get kernel number */
-       pos = class_dev->name + strlen(class_dev->name);
-       while (isdigit(*(pos-1)))
-               pos--;
-       strfieldcpy(udev->kernel_number, pos);
-       dbg("kernel_number='%s'", udev->kernel_number);
+       dbg("udev->kernel_name='%s'", udev->kernel_name);
 
        /* look for a matching rule to apply */
        list_for_each_entry(dev, &config_device_list, node) {
@@ -756,7 +724,7 @@ int namedev_name_device(struct udevice *udev, struct sysfs_class_device *class_d
                                return -1;
                        }
                        if (dev->ignore_remove) {
-                               udev->ignore_remove = dev->ignore_remove;
+                               udev->ignore_remove = 1;
                                dbg_parse("remove event should be ignored");
                        }
                        /* apply all_partitions option only at a main block device */
@@ -781,17 +749,28 @@ int namedev_name_device(struct udevice *udev, struct sysfs_class_device *class_d
                                dbg("applied group='%s' to '%s'", udev->group, udev->kernel_name);
                        }
 
-                       /* collect symlinks for this or the final matching rule */
+                       /* collect symlinks */
                        if (dev->symlink[0] != '\0') {
                                char temp[NAME_SIZE];
+                               char *pos, *next;
 
                                info("configured rule in '%s[%i]' applied, added symlink '%s'",
                                     dev->config_file, dev->config_line, dev->symlink);
                                strfieldcpy(temp, dev->symlink);
                                apply_format(udev, temp, sizeof(temp), class_dev, sysfs_device);
-                               if (udev->symlink[0] != '\0')
-                                       strfieldcat(udev->symlink, " ");
-                               strfieldcat(udev->symlink, temp);
+
+                               /* add multiple symlinks separated by spaces */
+                               pos = temp;
+                               next = strchr(temp, ' ');
+                               while (next) {
+                                       next[0] = '\0';
+                                       dbg("add symlink '%s'", pos);
+                                       name_list_add(&udev->symlink_list, pos, 0);
+                                       pos = &next[1];
+                                       next = strchr(pos, ' ');
+                               }
+                               dbg("add symlink '%s'", pos);
+                               name_list_add(&udev->symlink_list, pos, 0);
                        }
 
                        /* rule matches */
@@ -808,16 +787,17 @@ int namedev_name_device(struct udevice *udev, struct sysfs_class_device *class_d
                                        dbg("name, '%s' is going to have owner='%s', group='%s', mode=%#o partitions=%i",
                                            udev->name, udev->owner, udev->group, udev->mode, udev->partitions);
 
-                               goto exit;
+                               break;
                        }
                }
        }
 
-       /* no rule matched, so we use the kernel name */
-       strfieldcpy(udev->name, udev->kernel_name);
-       dbg("no rule found, use kernel name '%s'", udev->name);
+       if (udev->name[0] == '\0') {
+               /* no rule matched, so we use the kernel name */
+               strfieldcpy(udev->name, udev->kernel_name);
+               dbg("no rule found, use kernel name '%s'", udev->name);
+       }
 
-exit:
        if (udev->tmp_node[0] != '\0') {
                dbg("removing temporary device node");
                unlink_secure(udev->tmp_node);