networkd: Add todo patch kernel for tunnel module alias

[elogind.git] / TODO

diff --git a/TODO b/TODO
index efaded7623396a5aec5957586e9e839bc13ffc57..50d3f796a2d61673bf042c3ad35388b6b1018e12 100644 (file)
--- a/TODO
+++ b/TODO
@@ -1,4 +1,6 @@
 Bugfixes:
 Bugfixes:

+* Should systemctl status \* work on all unit types, not just .service?
+

 * enabling an instance unit creates a pointless link, and
   the unit will be started with getty@getty.service:
     $ systemctl enable getty@.service
 * enabling an instance unit creates a pointless link, and
   the unit will be started with getty@getty.service:
     $ systemctl enable getty@.service


@@ -16,6 +18,9 @@ Bugfixes:
 
 * systemctl --root=container/ set-default ... is totally borked.
 
 
 * systemctl --root=container/ set-default ... is totally borked.
 

+* sd_bus_unref() is broken regarding self-references and "pseudo thread-safety".
+  See the comment in sd_bus_unref() for more..
+

 External:
 
 * Fedora: when installing fedora with yum --installroot /var/run is a directory, not a symlink
 External:
 
 * Fedora: when installing fedora with yum --installroot /var/run is a directory, not a symlink


@@ -27,16 +32,52 @@ External:
 
 Features:
 
 
 Features:
 

+* timesyncd:
+  - hookup with networkd: NTP servers from dhcp
+  - hookup with networkd: listen to online/offline state
+
+* a way for container managers to turn off getty starting via $container_headless= or so...
+
+* figure out a nice way how we can let the admin know what child/sibling unit causes cgroup membership for a specific unit
+
+* add a kernel command line option to enable the debug shell
+
+* journalctl: add the ability to look for the most recent process of a binary. journalctl /usr/bin/X11 --pid=-1 or so...
+
+* set NOTIFY_SOCKET also for control processes
+
+* drop parsing of chkconfig header lines from service.c
+
+* mount_cgroup_controllers(): symlinks need to get the label applied
+
+* For timer units: add some mechanisms so that timer units that trigger immediately on boot do not have the services they run added to the initial transaction and thus confuse Type=idle. Alternatively, split up the boot-up state into two, and make Type=idle only be affected by jobs for the default target, but ignore any further jobs
+
+* Add RPM macros for registering/unregistering binfmt drop-ins
+
+* Add timeout to early-boot, and shut down the system if it is hit. Solves the laptop-in-bag problem and is useful for embedded cases
+
+* sd-resolve: add callback api
+
+* ImmutableSystem=yes/no or so to mount /usr, /boot read-only/invisible, and leave /var and /etc writable
+
+* InaccessibleHome=yes/no or so to hide /home and /run/user from a service
+
+* Run most system services with cgroupfs read-only and procfs with a more secure mode
+
+* sd-event: generate a failure of a default event loop is executed out-of-thread
+
+* add "M" as recursive version of "m" to tmpfiles, then use it for
+  chowning /run/log/journal (but not /var/log/journal), so that we
+  adjust the perms of journal files created before tmpfiles ran.
+
+* expose "Locked" property on logind sesison objects
+

 * add bus api to query unit file's X fields.
 
 * consider adding RuntimeDirectoryUser= + RuntimeDirectoryGroup=
 
 * sd-event: define more intervals where we will shift wakeup intervals around in, 1h, 6h, 24h, ...
 
 * add bus api to query unit file's X fields.
 
 * consider adding RuntimeDirectoryUser= + RuntimeDirectoryGroup=
 
 * sd-event: define more intervals where we will shift wakeup intervals around in, 1h, 6h, 24h, ...
 

-* maybe add DefaultTimerAccuracySec= as global config option to set AccuracySec='s default value in .timer units
-
-* mount /sys/fs/cgroup read-only (but leave the subdirs writable)
-

 * gpt-auto-generator:
   - Support LUKS for root devices
   - Define new partition type for encrypted swap? Support probed LUKS for encrypted swap?
 * gpt-auto-generator:
   - Support LUKS for root devices
   - Define new partition type for encrypted swap? Support probed LUKS for encrypted swap?


@@ -44,17 +85,13 @@ Features:
 
 * improve journalctl performance by loading journal files
   lazily. Encode just enough information in the file name, so that we
 
 * improve journalctl performance by loading journal files
   lazily. Encode just enough information in the file name, so that we

-  don't have to open it to know that it is not interesting for us, for
+  do not have to open it to know that it is not interesting for us, for

   the most common operations.
 
 * support transient mount units
 
   the most common operations.
 
 * support transient mount units
 

-* Imply DevicePolicy=closed when PrivateDevices= is used
-

 * add an "input" group to udev logic and add all input devices to it
 
 * add an "input" group to udev logic and add all input devices to it
 

-* libsystemd-login: implement getpeer_unit(), get_peer_slice(), ...
-

 * machined: provide calls GetMachineByAddress() on the manager
   interface to get the machine for a local IP address, and
   GetAddress() on the Machine interface to get the Address for a
 * machined: provide calls GetMachineByAddress() on the manager
   interface to get the machine for a local IP address, and
   GetAddress() on the Machine interface to get the Address for a


@@ -72,12 +109,6 @@ Features:
 * "busctl status" works only as root on dbus1, since we cannot read
   /proc/$PID/exe
 
 * "busctl status" works only as root on dbus1, since we cannot read
   /proc/$PID/exe
 

-* systemctl (and possibly related tools): support a new switch that
-  allows enumerating units in local containers recursively. "systemctl
-  list-units -R" or so should not only lists on the host, but also the
-  services in all containers in a pretty way, to give an overview of
-  the entire system.
-

 * implement Distribute= in socket units to allow running multiple
   service instances processing the listening socket, and open this up
   for ReusePort=
 * implement Distribute= in socket units to allow running multiple
   service instances processing the listening socket, and open this up
   for ReusePort=


@@ -98,8 +129,6 @@ Features:
   on screen, not unlike how job control works on the shell
 
 * completions:
   on screen, not unlike how job control works on the shell
 
 * completions:

- - busctl zsh completion is outdated
- - systemd-nspawn -Z/-L/-q is missing for zsh

  - manager property enumeration was broken when systemd moved to /usr/lib/
 
 * cgroups:
  - manager property enumeration was broken when systemd moved to /usr/lib/
 
 * cgroups:


@@ -148,7 +177,7 @@ Features:
 
 * btrfs raid assembly: some .device jobs stay stuck in the queue
 
 
 * btrfs raid assembly: some .device jobs stay stuck in the queue
 

-* make sure gdm doesn't use multi-user-x but the new default X configuration file, and then remove multi-user-x from systemd
+* make sure gdm does not use multi-user-x but the new default X configuration file, and then remove multi-user-x from systemd

 
 * man: the documentation of Restart= currently is very misleading and suggests the tools from ExecStartPre= might get restarted.
 
 
 * man: the documentation of Restart= currently is very misleading and suggests the tools from ExecStartPre= might get restarted.
 


@@ -164,30 +193,28 @@ Features:
   ReadOnlyDirectories=... for whitelisting files for a service.
 
 * sd-bus:
   ReadOnlyDirectories=... for whitelisting files for a service.
 
 * sd-bus:

-  - when kdbus doesn't take our message without memfds, try again with memfds
-  - implement monitor logic
+  - make AddMatch calls on dbus1 transports async
+  - when kdbus does not take our message without memfds, try again with memfds
+  - systemd-bus-proxyd needs to enforce good old XML policy
+  - port exit-on-idle logic to byebye ioctl
+  - allow updating attach flags during runtime
+  - pid1: peek into activating message when activating a service
+  - introduce sd_bus_emit_object_added()/sd_bus_emit_object_removed() that automatically includes the build-in interfaces in the list
+  - constructors for bus messages should probably not be OK with a NULL bus pointer
+  - .busname units should not use get_user_creds()/get_cgroup_creds() but instead do NSS only in temporarily forked off child

   - see if we can drop more message validation on the sending side
   - add API to clone sd_bus_message objects
   - see if we can drop more message validation on the sending side
   - add API to clone sd_bus_message objects

-  - systemd-bus-proxyd needs to enforce good old XML policy
-  - upload minimal kdbus policy into the kernel at boot

   - kdbus: matches against source or destination pids for an "strace -p"-like feel. Problem: The PID info needs to be available in userspace too...
   - longer term: priority inheritance
   - kdbus: matches against source or destination pids for an "strace -p"-like feel. Problem: The PID info needs to be available in userspace too...
   - longer term: priority inheritance

-  - check sender of response messages

   - dbus spec updates:
        - kdbus mapping
        - NameLost/NameAcquired obsolete
        - GVariant
        - "const" properties (posted)
        - path escaping
   - dbus spec updates:
        - kdbus mapping
        - NameLost/NameAcquired obsolete
        - GVariant
        - "const" properties (posted)
        - path escaping

-  - port exit-on-idle logic to byebye ioctl

   - update systemd.special(7) to mention that dbus.socket is only about the compatibility socket now
   - update systemd.special(7) to mention that dbus.socket is only about the compatibility socket now

-  - allow updating attach flags during runtime
-  - pid1: peek into activating message when activating a service

   - test bloom filter generation indexes
   - test bloom filter generation indexes

-  - introduce sd_bus_emit_object_added()/sd_bus_emit_object_removed() that automatically includes the build-in interfaces in the list

   - port to sd-resolve for connecting to TCP dbus servers
   - port to sd-resolve for connecting to TCP dbus servers

-  - constructors for bus messages should probably not be OK with a NULL bus pointer
-  - .busname units should not use get_user_creds()/get_cgroup_creds() but instead do NSS only in temporarily forked off child

 
 * sd-event
   - allow multiple signal handlers per signal?
 
 * sd-event
   - allow multiple signal handlers per signal?


@@ -224,7 +251,7 @@ Features:
   file.
 
 * seems that when we follow symlinks to units we prefer the symlink
   file.
 
 * seems that when we follow symlinks to units we prefer the symlink

-  destination path over /etc and /usr. We shouldn't do that. Instead
+  destination path over /etc and /usr. We should not do that. Instead

   /etc should always override /run+/usr and also any symlink
   destination.
 
   /etc should always override /run+/usr and also any symlink
   destination.
 


@@ -236,10 +263,10 @@ Features:
 * after all byte-wise realloc() is slow, even on glibc, so i guess we
   need manual exponential loops after all
 
 * after all byte-wise realloc() is slow, even on glibc, so i guess we
   need manual exponential loops after all
 

-* BootLoaderSpec: drop allowing ext234 for $BOOT. Clarify that the
-  kernel has to be in $BOOT. Clarify that the boot loader should be
-  installed to the ESP. Define a way how an installer can figure out
-  whether a BLS compliant boot loader is installed.
+* BootLoaderSpec: Clarify that the kernel has to be in $BOOT. Clarify
+  that the boot loader should be installed to the ESP. Define a way
+  how an installer can figure out whether a BLS compliant boot loader
+  is installed.

 
 * think about requeuing jobs when daemon-reload is issued? usecase:
   the initrd issues a reload after fstab from the host is accessible
 
 * think about requeuing jobs when daemon-reload is issued? usecase:
   the initrd issues a reload after fstab from the host is accessible


@@ -250,7 +277,7 @@ Features:
 
 * journal-or-kmsg is currently broken? See reverted commit 4a01181e460686d8b4a543b1dfa7f77c9e3c5ab8.
 
 
 * journal-or-kmsg is currently broken? See reverted commit 4a01181e460686d8b4a543b1dfa7f77c9e3c5ab8.
 

-* remove any syslog support from log.c -- we probably can't do this before split-off udev is gone for good
+* remove any syslog support from log.c -- we probably cannot do this before split-off udev is gone for good

 
 * shutdown logging: store to EFI var, and store to USB stick?
 
 
 * shutdown logging: store to EFI var, and store to USB stick?
 


@@ -289,7 +316,6 @@ Features:
   - logind: wakelock/opportunistic suspend support
   - Add pretty name for seats in logind
   - logind: allow showing logout dialog from system?
   - logind: wakelock/opportunistic suspend support
   - Add pretty name for seats in logind
   - logind: allow showing logout dialog from system?

-  - logind: add equivalent to sd_pid_get_owner_uid() to the D-Bus API

   - we should probably handle SIGTERM/SIGINT to not leave dot files around, just in case
   - session scopes/user unit: add RequiresMountsFor for the home directory of the user
   - add Suspend() bus calls which take timestamps to fix double suspend issues when somebody hits suspend and closes laptop quickly.
   - we should probably handle SIGTERM/SIGINT to not leave dot files around, just in case
   - session scopes/user unit: add RequiresMountsFor for the home directory of the user
   - add Suspend() bus calls which take timestamps to fix double suspend issues when somebody hits suspend and closes laptop quickly.


@@ -307,7 +333,7 @@ Features:
   - journald: also get thread ID from client, plus thread name
   - journal: when waiting for journal additions in the client always sleep at least 1s or so, in order to minimize wakeups
   - add API to close/reopen/get fd for journal client fd in libsystemd-journal.
   - journald: also get thread ID from client, plus thread name
   - journal: when waiting for journal additions in the client always sleep at least 1s or so, in order to minimize wakeups
   - add API to close/reopen/get fd for journal client fd in libsystemd-journal.

-  - fallback to /dev/log based logging in libsystemd-journal, if we can't log natively?
+  - fallback to /dev/log based logging in libsystemd-journal, if we cannot log natively?

   - declare the local journal protocol stable in the wiki interface chart
   - journal: reuse XZ context
   - sd-journal: speed up sd_journal_get_data() with transparent hash table in bg
   - declare the local journal protocol stable in the wiki interface chart
   - journal: reuse XZ context
   - sd-journal: speed up sd_journal_get_data() with transparent hash table in bg


@@ -343,7 +369,7 @@ Features:
   - journald: make sure ratelimit is actually really per-service with the new cgroup changes
   - change systemd-journal-flush into a service that stays around during
     boot, and causes the journal to be moved back to /run on shutdown,
   - journald: make sure ratelimit is actually really per-service with the new cgroup changes
   - change systemd-journal-flush into a service that stays around during
     boot, and causes the journal to be moved back to /run on shutdown,

-    so that we don't keep /var busy. This needs to happen synchronously,
+    so that we do not keep /var busy. This needs to happen synchronously,

     hence doing this via signals is not going to work.
 
 * document:
     hence doing this via signals is not going to work.
 
 * document:


@@ -371,14 +397,13 @@ Features:
   - print nice message from systemctl --failed if there are no entries shown, and hook that into ExecStartPre of rescue.service/emergency.service
   - add new command to systemctl: "systemctl system-reexec" which reexecs as many daemons as virtually possible
   - systemctl enable: improve the success messages (i.e. more human readable, less shell-like)
   - print nice message from systemctl --failed if there are no entries shown, and hook that into ExecStartPre of rescue.service/emergency.service
   - add new command to systemctl: "systemctl system-reexec" which reexecs as many daemons as virtually possible
   - systemctl enable: improve the success messages (i.e. more human readable, less shell-like)

-  - systemctl enable: fail if target to alias into doesn't exist? maybe show how many units are enabled afterwards?
+  - systemctl enable: fail if target to alias into does not exist? maybe show how many units are enabled afterwards?

   - systemctl: "Journal has been rotated since unit was started." message is misleading
   - support "systemctl stop foobar@.service" to stop all units matching a certain template
   - Something is wrong with symlink handling of "autovt@.service" in "systemctl list-unit-files"
   - rework wait filter to not require match callback
   - better error message if you run systemctl without systemd running
   - systemctl status output should should include list of triggering units and their status
   - systemctl: "Journal has been rotated since unit was started." message is misleading
   - support "systemctl stop foobar@.service" to stop all units matching a certain template
   - Something is wrong with symlink handling of "autovt@.service" in "systemctl list-unit-files"
   - rework wait filter to not require match callback
   - better error message if you run systemctl without systemd running
   - systemctl status output should should include list of triggering units and their status

-  - in systemctl list-timers show time triggering units ran last

 
 * unit install:
   - "systemctl mask" should find all names by which a unit is accessible
 
 * unit install:
   - "systemctl mask" should find all names by which a unit is accessible


@@ -394,15 +419,13 @@ Features:
 * deal with sendmail/postfix exclusivity
 
 * timer units:
 * deal with sendmail/postfix exclusivity
 
 * timer units:

-  - timer events with system resume

   - timer units should get the ability to trigger when:
     o CLOCK_REALTIME makes jumps (TFD_TIMER_CANCEL_ON_SET)
     o DST changes
   - Support 2012-02~4 as syntax for specifying the fourth to last day of the month.
   - calendarspec: support value ranges with ".." notation. Example: 2013-4..8-1
   - timer units should get the ability to trigger when:
     o CLOCK_REALTIME makes jumps (TFD_TIMER_CANCEL_ON_SET)
     o DST changes
   - Support 2012-02~4 as syntax for specifying the fourth to last day of the month.
   - calendarspec: support value ranges with ".." notation. Example: 2013-4..8-1

-  - when parsing calendar timestamps support the UTC timezone (even if we won't support arbitrary timezone specs, support UTC itself certainly makes sense), also support syntaxes such as +0200
+  - when parsing calendar timestamps support the UTC timezone (even if we will not support arbitrary timezone specs, support UTC itself certainly makes sense), also support syntaxes such as +0200

   - Modulate timer frequency based on battery state
   - Modulate timer frequency based on battery state

-  - anacron-like feature

 
 * update the kernel's TZ (sys_tz) when DST changes
 
 
 * update the kernel's TZ (sys_tz) when DST changes
 


@@ -425,7 +448,7 @@ Features:
 * If we show an error about a unit (such as not showing up) and it has no Description string, then show a description string generated form the reverse of unit_name_mangle().
 
 * fedup: add --unit to systemctl switch-root somehow
 * If we show an error about a unit (such as not showing up) and it has no Description string, then show a description string generated form the reverse of unit_name_mangle().
 
 * fedup: add --unit to systemctl switch-root somehow

-* fedup: don't delete initrd on switch-root
+* fedup: do not delete initrd on switch-root

 * fedup: generator
 
 * timedated: refuse time changes when NTP is on
 * fedup: generator
 
 * timedated: refuse time changes when NTP is on


@@ -446,7 +469,7 @@ Features:
 
 * hostnamed: before returning information from /etc/machine-info.conf check the modification data and reread. Similar for localed, ...
 
 
 * hostnamed: before returning information from /etc/machine-info.conf check the modification data and reread. Similar for localed, ...
 

-* currently x-systemd.timeout is lost in the initrd, since crypttab is copied into dracut, but fstab isn't
+* currently x-systemd.timeout is lost in the initrd, since crypttab is copied into dracut, but fstab is not

 
 * nspawn:
   - nspawn: --read-only is not applied recursively to submounts
 
 * nspawn:
   - nspawn: --read-only is not applied recursively to submounts


@@ -492,9 +515,9 @@ Features:
 
 * drop PID 1 reloading, only do reexecing (difficult: Reload()
   currently is properly synchronous, Reexec() is weird, because we
 
 * drop PID 1 reloading, only do reexecing (difficult: Reload()
   currently is properly synchronous, Reexec() is weird, because we

-  can't delay the response properly until we are back, so instead of
+  cannot delay the response properly until we are back, so instead of

   being properly synchronous we just keep open the fd and close it
   being properly synchronous we just keep open the fd and close it

-  when done. That means clients don't get a successful method reply,
+  when done. That means clients do not get a successful method reply,

   but much rather a disconnect on success.
 
 * properly handle loop back mounts via fstab, especially regards to fsck/passno
   but much rather a disconnect on success.
 
 * properly handle loop back mounts via fstab, especially regards to fsck/passno


@@ -508,7 +531,7 @@ Features:
 * rename "userspace" to "core-os"
 
 * load-fragment: when loading a unit file via a chain of symlinks
 * rename "userspace" to "core-os"
 
 * load-fragment: when loading a unit file via a chain of symlinks

-  verify that it isn't masked via any of the names traversed.
+  verify that it is not masked via any of the names traversed.

 
 * introduce Type=pid-file
 
 
 * introduce Type=pid-file
 


@@ -552,7 +575,7 @@ Features:
 
 * support crash reporting operation modes (https://live.gnome.org/GnomeOS/Design/Whiteboards/ProblemReporting)
 
 
 * support crash reporting operation modes (https://live.gnome.org/GnomeOS/Design/Whiteboards/ProblemReporting)
 

-* default to actual 32bit PIDs, via /proc/sys/kernel/pid_max
+* default to actual 32-bit PIDs, via /proc/sys/kernel/pid_max

 
 * be able to specify a forced restart of service A where service B depends on, in case B
   needs to be auto-respawned?
 
 * be able to specify a forced restart of service A where service B depends on, in case B
   needs to be auto-respawned?


@@ -563,9 +586,9 @@ Features:
   - check systemd-tmpfiles for selinux context hookup for mknod(), symlink() and similar
   - apply "x" on "D" too (see patch from William Douglas)
 
   - check systemd-tmpfiles for selinux context hookup for mknod(), symlink() and similar
   - apply "x" on "D" too (see patch from William Douglas)
 

-* for services: don't set $HOME in services unless requested
+* for services: do not set $HOME in services unless requested

 
 

-* hide PAM/TCPWrap options in fragment parser when compile time disabled
+* hide PAM options in fragment parser when compile time disabled

 
 * when we automatically restart a service, ensure we restart its rdeps, too.
 
 
 * when we automatically restart a service, ensure we restart its rdeps, too.
 


@@ -661,24 +684,31 @@ Features:
    - Make sure ID_PATH is always exported and complete for
      network devices where possible, so we can safely rely
      on Path= matching
    - Make sure ID_PATH is always exported and complete for
      network devices where possible, so we can safely rely
      on Path= matching

+   - check MTUBytes parsing (expecting size_t but we are using unsigned)

 
 * sd-rtnl:
 
 * sd-rtnl:

-   - add support for exiting containers without reading them fully first

    - add support for more attribute types
    - add support for more attribute types

+   - inbuilt piping support (essentially degenerate async)? see loopback-setup.c and other places

 
 * networkd:
 
 * networkd:

-   - make sure RTM_NEWLINK messages match both the ifname and kind when setting the ifindex of a netdev

    - add more keys to [Route] and [Address] sections
    - add support for more DHCPv4 options (and, longer term, other kinds of dynamic config)
    - add more keys to [Route] and [Address] sections
    - add support for more DHCPv4 options (and, longer term, other kinds of dynamic config)

+   - send hostname to DHCP server

    - add proper initrd support (in particular generate .network/.link files based on /proc/cmdline)
    - add reduced [Link] support to .network files
    - add proper initrd support (in particular generate .network/.link files based on /proc/cmdline)
    - add reduced [Link] support to .network files

-   - add IPv4LL tests (inspire by DHCP)

    - add Scope= parsing option for [Network]
    - add Scope= parsing option for [Network]

-   - change LL address generation and make it predictable like get_mac() (link-config.c)
-   - have smooth transition from LL to routable address, without disconnecting clients.
+   - properly handle routerless dhcp leases
+   - set lifetime on the address acquired from dhcp
+   - patch kernel to support module alias for tunnel device (ipip/sit/gre),
+     then remove remove libkmod dependency and CAP_SYS_MODULE
+   - add veth netdev support (c.f. http://shorewall.net/bridge-Shorewall-perl.html#veth)

 
 External:
 
 
 External:
 

+* NM: figure out what to do about network-online.target.
+   - maybe pull in the target as dependency for LSB initscripts ordered now after network.target
+   - https://bugzilla.gnome.org/show_bug.cgi?id=728965
+

 * dbus:
    - natively watch for dbus-*.service symlinks (PENDING)
    - teach dbus to activate all services it finds in /etc/systemd/services/org-*.service
 * dbus:
    - natively watch for dbus-*.service symlinks (PENDING)
    - teach dbus to activate all services it finds in /etc/systemd/services/org-*.service


@@ -699,7 +729,7 @@ External:
 
 * drop accountsservice's StandardOutput=syslog and Type=dbus fields
 
 
 * drop accountsservice's StandardOutput=syslog and Type=dbus fields
 

-* dbus upstream still refers to dbus.target and shouldn't
+* dbus upstream still refers to dbus.target and should not

 
 * dbus: in fedora, make /var/lib/dbus/machine-id a symlink to /etc/machine-id
 
 
 * dbus: in fedora, make /var/lib/dbus/machine-id a symlink to /etc/machine-id
 


@@ -715,6 +745,8 @@ External:
 
 * fedora: update policy to declare access mode and ownership of unit files to root:root 0644, and add an rpmlint check for it
 
 
 * fedora: update policy to declare access mode and ownership of unit files to root:root 0644, and add an rpmlint check for it
 

+* register catalog database signature as file magic
+

 Regularly:
 
 * look for close() vs. close_nointr() vs. close_nointr_nofail()
 Regularly:
 
 * look for close() vs. close_nointr() vs. close_nointr_nofail()


@@ -725,7 +757,7 @@ Regularly:
 
 * pahole
 
 
 * pahole
 

-* set_put(), hashmap_put() return values check. i.e. == 0 doesn't free()!
+* set_put(), hashmap_put() return values check. i.e. == 0 does not free()!

 
 * use secure_getenv() instead of getenv() where appropriate
 
 
 * use secure_getenv() instead of getenv() where appropriate